rogfer01 added inline comments.
================ Comment at: lib/Parse/ParseTemplate.cpp:702 + ReportStorageClass(DS.getStorageClassSpecLoc()); + if (DS.getThreadStorageClassSpec() != DeclSpec::TSCS_unspecified) + ReportStorageClass(DS.getThreadStorageClassSpecLoc()); ---------------- You added tests for `SCS_*` but not for `TSCS_*`. Is it worth adding at least one for the latter as well? ```lang=cpp template <thread_local int X> struct Z2; // expected-error {{storage class specified for template parameter 'X'}} ``` https://reviews.llvm.org/D40705 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits