Author: rogfer01
Date: Thu Dec 7 01:23:50 2017
New Revision: 320017
URL: http://llvm.org/viewvc/llvm-project?rev=320017&view=rev
Log:
Ignore pointers to incomplete types when diagnosing misaligned addresses
This is a fix for PR35509 in which we crash because we attempt to compute the
alignment o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320017: Ignore pointers to incomplete types when diagnosing
misaligned addresses (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D40895?vs=125718&id=125901#toc
Repository:
r
ioeric added inline comments.
Comment at: clangd/Symbol.h:23
+ // The path of the source file where a symbol occurs.
+ std::string FilePath;
+ // The offset to the first character of the symbol from the beginning of the
Is this relative or absolute?
sammccall added inline comments.
Comment at: clangd/JSONRPCDispatcher.cpp:23
+namespace {
+static Key> TracerKey;
+static Key IDKey;
sammccall wrote:
> RequestTracer?
actually, RequestSpan I think - "tracer" is pretty confusing at global scope
sammccall added inline comments.
Comment at: clangd/Trace.cpp:138
return;
- if (!Args)
-Args = llvm::make_unique();
- T->event(Ctx, "E",
- Args ? json::obj{{"args", std::move(*Args)}} : json::obj{});
+ assert(Args && "Args can't be null at this point");
+ T
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320019: [ARM] ACLE parallel arithmetic and DSP style
multiplications (authored by SjoerdMeijer).
Repository:
rC Clang
https://reviews.llvm.org/D40888
Files:
include/clang/Basic/BuiltinsARM.def
lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320019: [ARM] ACLE parallel arithmetic and DSP style
multiplications (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D40888?vs=125705&id=125909#toc
Repository:
rL LLVM
Author: sjoerdmeijer
Date: Thu Dec 7 01:54:39 2017
New Revision: 320019
URL: http://llvm.org/viewvc/llvm-project?rev=320019&view=rev
Log:
[ARM] ACLE parallel arithmetic and DSP style multiplications
This is a follow up of r302131, in which we forgot to add SemaChecking
tests. Adding these tests
ioeric updated this revision to Diff 125913.
ioeric marked an inline comment as done.
ioeric added a comment.
- Removed a redundant #include
Repository:
rC Clang
https://reviews.llvm.org/D40884
Files:
include/clang/Index/IndexDataConsumer.h
lib/Index/IndexingAction.cpp
tools/libclang/C
sammccall added a comment.
Thanks for putting this together! Have a bit of a braindump here, happy to
discuss further either here or offline.
Comment at: clangd/Symbol.h:1
+//===--- Symbol.h ---*- C++-*-===//
+//
I t
krasimir updated this revision to Diff 125915.
krasimir added a comment.
- Added unsafe canonical delimiter update handling
Repository:
rC Clang
https://reviews.llvm.org/D40909
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
Author: ioeric
Date: Thu Dec 7 03:04:24 2017
New Revision: 320030
URL: http://llvm.org/viewvc/llvm-project?rev=320030&view=rev
Log:
[Index] Add setPreprocessor member to IndexDataConsumer.
Summary:
This enables us to use information in Preprocessor when handling symbol
occurrences.
Reviewers: a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320030: [Index] Add setPreprocessor member to
IndexDataConsumer. (authored by ioeric).
Repository:
rL LLVM
https://reviews.llvm.org/D40884
Files:
cfe/trunk/include/clang/Index/IndexDataConsumer.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320030: [Index] Add setPreprocessor member to
IndexDataConsumer. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D40884?vs=125913&id=125920#toc
Repository:
rC Clang
https://r
krasimir updated this revision to Diff 125921.
krasimir added a comment.
- Added support for enclosing function names
Repository:
rC Clang
https://reviews.llvm.org/D40909
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Fo
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
Hi all,
So, I've finally managed to run all the tests I wanted and get this out for
review. Sorry it's taken so long. This patch switches Clang's default C++
target to C++14 across all platforms and updates the test-suite
Here's the test-suite diff. It's really just a few ancient code-bases
that don't compile with C++14, no runtime issues I noticed.
Tim.
commit a52b065052bfefaac17e7096fd2c911aac62e9da
Author: Tim Northover
Date: Thu Dec 7 09:16:34 2017 +
Support C++14 as a default in Clang
diff --git a
krasimir updated this revision to Diff 125927.
krasimir added a comment.
- Updated documentation
Repository:
rC Clang
https://reviews.llvm.org/D40909
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationInden
ioeric updated this revision to Diff 125928.
ioeric added a comment.
- More cleanups and merged with https://reviews.llvm.org/D40897
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/ClangdIndex.cpp
clangd/ClangdIndex.h
clangd/Clan
martong added inline comments.
Comment at: clang-tidy/misc/InfiniteLoopCheck.cpp:105
+ return llvm::make_unique(
+ *(new ExprSequence(TheCFG.get(), &ASTCtx)));
+}
`make_unique` is a forwarding function, therefore there is no need to create an
object and th
djasper added inline comments.
Comment at: include/clang/Format/Format.h:1216
+LK_TextProto,
+/// Do not use. Keep at last position.
+LK_End,
Lets find a way to implement without this in the public header file.
Comment at: include/c
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:1375
+std::vector EnclosingFunctionNames;
+/// \brief The canonical delimiter for this language.
+std::string CanonicalDelimiter;
djasper wrote:
> Can you pull apart this patch?
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:242
std::shared_ptr PCHContainerOps, bool
StoreInMemory,
-PreambleCallbacks &Callbacks)
krasimir added inline comments.
Comment at: lib/Format/Format.cpp:920
+ if (LanguageFound) {
+for (int i = Styles.size() - 1; i >= 0; --i) {
+ if (Styles[i].Language == FormatStyle::LK_None) {
djasper wrote:
> I think this is getting a bit convoluted an
krasimir updated this revision to Diff 125939.
krasimir edited the summary of this revision.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D40909
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Continu
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:25
+
+class ContextData {
+public:
sammccall wrote:
> IIUC, the only reason we expose separate `Context` and `ContextData` types is
> to give things like Span a stable reference to hold onto (`Con
sammccall created this revision.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
This improves readability of tests and error messages.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40952
Files:
test/clangd/completion-items-kinds.test
test/clangd/completion-p
Hahnfeld added a reviewer: ABataev.
Hahnfeld added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1732
case InputKind::ObjCXX:
// The PS4 uses C++11 as the default C++ standard.
+ LangStd = LangStandard::lang_gnucxx14;
Thi
schroedersi added a comment.
Ping
https://reviews.llvm.org/D30946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Sorry for the delay. I missed this revision somehow. Please add cfe-commits to
the subscribers list so that others can chime in.
https://reviews.llvm.org/D39363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
alexfh added a comment.
One nit. Otherwise seems fine.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:502
-if (!Type.isNull() && Type.isLocalConstQualified() &&
+if (!Type.isNull() && Type.isConstQualified() &&
Decl->isStaticDataMember() && Nami
yaxunl created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl.
Will clean up the old addr space mapping in separate patch.
https://reviews.llvm.org/D40956
Files:
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
test/CodeGen/address-space.c
ioeric updated this revision to Diff 125960.
ioeric added a comment.
- Use IncludeNamespaceLevelDecls option; fix some broken tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/ClangdIndex.cpp
clangd/ClangdIndex.h
clangd/Clan
xazax.hun added a comment.
I like the idea of adding those assertions but a bit worried about the other
changes. Basically (if I get this right), we are masking the issues here and I
am a bit afraid that they will get forgotten. I think it would be nice to at
least add a FIXME that this path sh
ioeric updated this revision to Diff 125962.
ioeric added a comment.
Diff on https://reviews.llvm.org/D40897 instead origin/master!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/ClangdIndex.cpp
clangd/ClangdIndex.h
clangd/Clang
szepet updated this revision to Diff 125965.
szepet marked 9 inline comments as done.
szepet added a comment.
Updates based on comments.
https://reviews.llvm.org/D40937
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/InfiniteLoopCheck.cpp
clang-tidy/misc/InfiniteLoopCheck.h
clang-
george.karpenkov added inline comments.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:44
+CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt'
+CTU_TEMP_FNMAP_FOLDER = 'tmpExternalFnMaps'
gerazo wrote:
> george.karpenkov wrote:
> > What would happen when m
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/misc-infinite-loop.rst:6
+
+The check finds loops where none of the condition variables are updated in the
+body. This performs a very conservative check in order to avoid false positives
Pl
szepet added a comment.
In https://reviews.llvm.org/D40937#947760, @JVApen wrote:
> How does this check deal with atomic members?
> ...
This patch only works on integer types. So, since the atomic is a non-supported
type the check will skip that `while` loop.
https://reviews.llvm.org/D40937
xazax.hun added a comment.
This does not support memberExprs as condition variables right now.
What happens if you have something like this:
struct X {
void f(int a) {
while(a < i) {
--i;
}
}
int i;
};
I think you could extend the test cases with some classes.
==
xazax.hun added inline comments.
Comment at: clang-tidy/misc/InfiniteLoopCheck.cpp:121
+
+ Stmt *FunctionBody = nullptr;
+ if (ContainingLambda)
This could be pointer to const, right?
https://reviews.llvm.org/D40937
NoQ added a comment.
I think the new behavior is correct in the sense that in our region hierarchy
byte offsets (such as arithmetic on void pointers) are normally represented as
`char`-type element regions. For instance, we have a similar mechanism is
implemented in pointer casts case, when the
xazax.hun added a comment.
In https://reviews.llvm.org/D40939#948252, @NoQ wrote:
> Like, it's not the situation when we couldn't figure out the type - it would
> have been null in that case. Here we know exactly that the type is void.
Oh, thank you for the clarification!
Repository:
rC Cl
ioeric added a comment.
Ping.
(fyi, you could find use of the new option in https://reviews.llvm.org/D40548)
Repository:
rC Clang
https://reviews.llvm.org/D40562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
ioeric added a comment.
Fyi, you could find use of the new API in https://reviews.llvm.org/D40548
I'd like to land this patch if there is no objection.
https://reviews.llvm.org/D40563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
NoQ updated this revision to Diff 125972.
NoQ added a comment.
Rebase on top of https://reviews.llvm.org/D40584.
Stronger assertion for `CXXThisRegion` type. Uhm, forgot to mention that i also
added a similar assertion to `CXXThisRegion` (which didn't find any bugs yet).
Other typed value regio
malaperle added a comment.
In https://reviews.llvm.org/D40897#946911, @hokein wrote:
> Our rough plan would be
>
> 1. Define the Symbol structure.
> 2. Design the interfaces of SymbolIndex, ASTIndex.
> 3. Combine 1) and 2) together to make global code completion work (we'd use
> YAML dataset for
> + LangStd = LangStandard::lang_gnucxx14;
>
> This comment should be removed.
Opps, yep. Fixed on my local branch. I won't upload a new diff just yet though.
Thanks.
Tim.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
sammccall added inline comments.
Comment at: clangd/ClangdIndex.h:24
+/// (re-)scoring symbols from different indexes.
+class CombinedSymbolIndex : public SymbolIndex {
+public:
This seems a little premature to me - it's hard to know if this idea makes
sense wit
jdenny added a comment.
Alexey: I see that you committed the error message change, so I think this
issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new
here.
https://reviews.llvm.org/D40752
___
cfe-commits mailing list
cfe
ABataev added a comment.
In https://reviews.llvm.org/D40752#948399, @jdenny wrote:
> Alexey: I see that you committed the error message change, so I think this
> issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new
> here.
Yes, it is correct
https://reviews.llvm.org
malaperle added inline comments.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using USR.
sammccall wrote:
> hokein wrote:
> > malaperle wrote:
> > > I think it would be nic
kkwli0 created this revision.
This patch is to add diagnose when a function name is specified on the link
clause. According to the OpenMP spec, only the list items that exclude the
function name are allowed on the link clause.
void foo() {}
#pragma omp declare target link(foo)
d2.c:2:
malaperle added inline comments.
Comment at: include/indexstore/IndexStoreCXX.h:84
+
+ std::pair getLineCol() {
+unsigned line, col;
ioeric wrote:
> nathawes wrote:
> > malaperle wrote:
> > > From what I understand, this returns the beginning of the occurren
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:12576
+if (MT == OMPDeclareTargetDeclAttr::MT_Link && isa(ND)) {
+ Diag(Id.getLoc(), diag::err_omp_function_in_link_clause);
I would like to see this some in `check` functions, like
`c
akyrtzi added a comment.
@malaperle, to clarify we are not suggesting that you write your own parser,
the suggestion is to use clang in 'fast-scan' mode to get the structure of the
declarations of a single file, see `CXTranslationUnit_SingleFileParse` (along
with enabling skipping of bodies). W
Author: arphaman
Date: Thu Dec 7 11:04:10 2017
New Revision: 320073
URL: http://llvm.org/viewvc/llvm-project?rev=320073&view=rev
Log:
[driver] Set the 'simulator' environment for Darwin when compiling for
iOS/tvOS/watchOS simulator
rdar://35135215
Differential Revision: https://reviews.llvm.org
Author: morehouse
Date: Thu Dec 7 11:04:27 2017
New Revision: 320074
URL: http://llvm.org/viewvc/llvm-project?rev=320074&view=rev
Log:
[clangd-fuzzer] Update contruction of LSPServer.
The constructor for ClangdLSPServer changed in r318412 and r318925,
breaking the clangd-fuzzer build.
Modified:
kcc updated this revision to Diff 126001.
kcc added a comment.
mention https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt
Repository:
rC Clang
https://reviews.llvm.org/D40938
Files:
docs/HardwareAssistedAddressSanitizerDesign.rst
Index: docs/HardwareAssistedAddressSanitiz
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320073: [driver] Set the 'simulator' environment for Darwin
when compiling for (authored by arphaman).
Repository:
rC Clang
https://reviews.llvm.org/D40682
Files:
include/clang/Driver/ToolChain.h
alekseyshl accepted this revision.
alekseyshl added inline comments.
Comment at: clang/include/clang/Basic/Sanitizers.def:47
+SANITIZER("hwaddress", HWAddress)
+
Why didn't we follow KASan style and name it "hw-address"?
Comment at: clang/lib
Author: kcc
Date: Thu Dec 7 11:21:30 2017
New Revision: 320075
URL: http://llvm.org/viewvc/llvm-project?rev=320075&view=rev
Log:
update hwasan docs
Summary:
* use more readable name
* document the hwasan attribute
Reviewers: eugenis
Reviewed By: eugenis
Subscribers: llvm-commits, cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320075: update hwasan docs (authored by kcc).
Changed prior to commit:
https://reviews.llvm.org/D40938?vs=126001&id=126005#toc
Repository:
rC Clang
https://reviews.llvm.org/D40938
Files:
docs/Hard
Nebiroth added inline comments.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:242
std::shared_ptr PCHContainerOps, bool
StoreInMemory,
-PreambleCallbacks &Callbacks) {
+PreambleCallbacks &Callbacks, std::unique_ptr PPCallbacks) {
assert(VFS && "VFS is null");
eugenis added inline comments.
Comment at: clang/include/clang/Basic/Sanitizers.def:47
+SANITIZER("hwaddress", HWAddress)
+
alekseyshl wrote:
> Why didn't we follow KASan style and name it "hw-address"?
A matter of taste, I guess.
I don't want the attribute to
grokos created this revision.
grokos added a project: OpenMP.
Herald added a subscriber: mgorny.
The current implementation of the nvptx runtime (to be upstreamed shortly) uses
the `atomicMax` operation on 64-bit integers. This is only supported in compute
capabilities 3.5 and later. I've change
probinson added a reviewer: rjmccall.
probinson added a comment.
+rjmccall for the codegen bits.
Comment at: clang/test/SemaCXX/new-array-size-conv.cpp:1
-// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s
+// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=gnu++98 %s
Author: abataev
Date: Thu Dec 7 11:49:28 2017
New Revision: 320078
URL: http://llvm.org/viewvc/llvm-project?rev=320078&view=rev
Log:
[OPENMP] Do not capture private variables in the target regions.
Private variables are completely redefined in the outlined regions, so
we don't need to capture th
george.burgess.iv added a comment.
Thanks for this!
It's interesting to me that these array-bound checks don't seem to use
`@llvm.objectsize` in some form already. I can't find any notes about it
grepping through git/source, so I'm happy with it.
Comment at: lib/CodeGen/CGEx
aaron.ballman marked 4 inline comments as done.
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1218-1228
def NeonPolyVectorType : TypeAttr {
- let Spellings = [GNU<"neon_polyvector_type">];
+ let Spellings = [Clang<"neon_polyvector_type">];
let
aaron.ballman updated this revision to Diff 126015.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Updated based on review feedback. This patch leaves off attributes with custom
parsing, as well as `analyzer_noreturn`, so that we can handle them as special
cases.
aaron.ballman added a comment.
In https://reviews.llvm.org/D40225#944113, @aaron.ballman wrote:
> Rebased on ToT and given more context.
Ping. I'd like to get this in before the 6.0 branch.
https://reviews.llvm.org/D40225
___
cfe-commits mailing
aaron.ballman updated this revision to Diff 126016.
aaron.ballman added a comment.
Ping. Added more context to the patch.
https://reviews.llvm.org/D40448
Files:
include/clang/AST/Type.h
lib/AST/ASTDumper.cpp
lib/AST/TypePrinter.cpp
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/C
berenm updated this revision to Diff 126017.
berenm added a comment.
Herald added a subscriber: klimek.
Factor !Type.isNull() && Type.isConstQualified() condition
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39363
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
te
guansong added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D40977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm added a comment.
In https://reviews.llvm.org/D39363#948134, @alexfh wrote:
> Sorry for the delay. I missed this revision somehow. Please add cfe-commits
> to the subscribers list so that others can chime in.
No worries, I'll add it in the future.
Thanks!
Repository:
rCTE Clang Tool
xazax.hun updated this revision to Diff 125986.
xazax.hun added a comment.
Herald added a subscriber: rnkovacs.
- @gerazo addressed some review comments in scan-build-py.
https://reviews.llvm.org/D30691
Files:
include/clang/AST/ASTContext.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320082: [OpenMP] NVPTX: Set default/minimum compute
capability to sm_35 (authored by grokos).
Repository:
rC Clang
https://reviews.llvm.org/D40977
Files:
CMakeLists.txt
Index: CMakeLists.txt
=
Author: arphaman
Date: Thu Dec 7 12:37:50 2017
New Revision: 320085
URL: http://llvm.org/viewvc/llvm-project?rev=320085&view=rev
Log:
[libclang] Record code-completion invocations to a temporary file when
requested by client
This is a follow up to r319702 which records parsing invocations.
Thes
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please update the documentation and the release notes.
https://reviews.llvm.org/D39665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, makes sense to add this for GCC compatibility even if the standard ends
up being called C18.
https://reviews.llvm.org/D40225
___
cfe-commi
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
I think the `LateParsed` attributes are not going to work properly (because
they'd be written in places where the function parameters are not in scope), so
I wonder if we should avoid a
t.p.northover added inline comments.
Comment at: clang/test/SemaCXX/new-array-size-conv.cpp:1
-// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s
+// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=gnu++98 %s
// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=c++98
kkwli0 marked an inline comment as done.
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:12576
+if (MT == OMPDeclareTargetDeclAttr::MT_Link && isa(ND)) {
+ Diag(Id.getLoc(), diag::err_omp_function_in_link_clause);
ABataev wrote:
> I w
kkwli0 updated this revision to Diff 126025.
kkwli0 marked an inline comment as done.
https://reviews.llvm.org/D40968
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaOpenMP.cpp
test/OpenMP/declare_target_ast_print.cpp
test/OpenMP/declare_target_m
rsmith added inline comments.
Comment at: clang/test/CodeGenCXX/new-overflow.cpp:88
// CHECK: [[N:%.*]] = sext i16 {{%.*}} to i32
- // CHECK-NEXT: [[T0:%.*]] = icmp slt i32 [[N]], 0
- // CHECK-NEXT: [[T1:%.*]] = select i1 [[T0]], i32 -1, i32 [[N]]
- // CHECK-NEXT: call
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r320088.
https://reviews.llvm.org/D39665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch is a follow up to the previous work that recorded Libclang
invocations into temporary files: https://reviews.llvm.org/D40527.
It adds a new -cc1 mode to clang: `-cc1gen-reproducer`. The goal of this mode
is to generat
Author: aaronballman
Date: Thu Dec 7 13:46:26 2017
New Revision: 320089
URL: http://llvm.org/viewvc/llvm-project?rev=320089&view=rev
Log:
Add new language mode flags for C17.
This adds -std=c17, -std=gnu17, and -std=iso9899:2017 as language mode flags
for C17 and updates the value of __STDC_VER
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r320089.
https://reviews.llvm.org/D40225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: grokos
Date: Thu Dec 7 12:27:31 2017
New Revision: 320082
URL: http://llvm.org/viewvc/llvm-project?rev=320082&view=rev
Log:
[OpenMP] NVPTX: Set default/minimum compute capability to sm_35
The current implementation of the nvptx runtime (to be upstreamed shortly) uses
the atomicMax opera
Author: eugenezelenko
Date: Thu Dec 7 13:55:09 2017
New Revision: 320091
URL: http://llvm.org/viewvc/llvm-project?rev=320091&view=rev
Log:
[Analysis] Fix some Clang-tidy modernize and Include What You Use warnings;
other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Analysis/CFG.h
vsk updated this revision to Diff 126037.
vsk added a comment.
Thanks for your feedback.
- Give up on 0-sized types.
- Give up on pass_object_size(2 | 3).
https://reviews.llvm.org/D40940
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/ubsan-pass-object-size.c
In
jklaehn added a comment.
Ping, can you take another look?
https://reviews.llvm.org/D35181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D40671#947762, @xgsa wrote:
> So can this patch be submitted? Should I do something to make it happen?
There are still some outstanding con
Author: tstellar
Date: Thu Dec 7 14:10:39 2017
New Revision: 320096
URL: http://llvm.org/viewvc/llvm-project?rev=320096&view=rev
Log:
Creating release candidate rc3 from release_501 branch
Added:
libcxx/tags/RELEASE_501/rc3/ (props changed)
- copied from r320095, libcxx/branches/rele
Author: tstellar
Date: Thu Dec 7 14:10:43 2017
New Revision: 320097
URL: http://llvm.org/viewvc/llvm-project?rev=320097&view=rev
Log:
Creating release candidate rc3 from release_501 branch
Added:
libcxxabi/tags/RELEASE_501/rc3/
- copied from r320096, libcxxabi/branches/release_50/
___
Author: tstellar
Date: Thu Dec 7 14:11:09 2017
New Revision: 320103
URL: http://llvm.org/viewvc/llvm-project?rev=320103&view=rev
Log:
Creating release candidate rc3 from release_501 branch
Added:
libunwind/tags/RELEASE_501/rc3/ (props changed)
- copied from r320102, libunwind/branche
aaron.ballman added a reviewer: dcoughlin.
aaron.ballman added a subscriber: dcoughlin.
aaron.ballman added a comment.
I share the concerns that @Eugene.Zelenko brought up regarding this not being
in the analyzer. This is a path sensitive problem that I'm not certain
clang-tidy is the best home
t.p.northover added a comment.
Thanks Richard. I'll file the bugs tomorrow for the issues you suggest. Do you
see either of them blocking the change to C++14 as a default? On a scale of
"no", "no but I want a commitment to fix them" and "yes" sort of thing.
Tonight I've just got one comment tha
1 - 100 of 152 matches
Mail list logo
