sammccall added a comment.
In https://reviews.llvm.org/D40439#935678, @bkramer wrote:
> There are a few users of the C++ API out there, do we have migration path for
> them?
Do we have any idea what these look like?
One option would be to keep the functionality on the JSONCompilationDatabase
nik added a comment.
Could you elaborate on "the client will be able to use it to generate a
reproducer for the crash"? Having the json file, what would I need to do in
order to reproduce the crash?
Repository:
rC Clang
https://reviews.llvm.org/D40527
Quolyk created this revision.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D40543
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
Index: include/clang/Tooling/Refactoring/Rename/RenamingAction.h
==
hokein added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79
QualifiedRenameRule(const NamedDecl *ND,
- std::string NewQualifiedName)
+ const std::string &NewQualifiedName)
: ND(ND), New
nik added a comment.
Ping
https://reviews.llvm.org/D40072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
In https://reviews.llvm.org/D40275#937010, @tra wrote:
> In https://reviews.llvm.org/D40275#933253, @tra wrote:
>
> > @rjmccall : are you OK with this approach? If VLA is not supported by the
> > target, CUDA is handled as a special case
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
tra wrote:
> tra wrote:
nik added a comment.
Ping III - is there anything I can do to get this reviewed faster? 3 weeks
passed.
https://reviews.llvm.org/D39903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm
Thanks for the rename!
https://reviews.llvm.org/D40399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
sammccall added a comment.
Thanks for doing this!
Most of my comments are of the form "can we make this conceptually simpler, and
somewhat less awesome".
This is because it's a somewhat unusual/scary pattern, so I'd like the
implementation to be as small and transparent as possible.
=
Author: sammccall
Date: Tue Nov 28 01:25:09 2017
New Revision: 319157
URL: http://llvm.org/viewvc/llvm-project?rev=319157&view=rev
Log:
[clangd] Add missing (but documented!) JSONExpr typed accessors
Summary:
Noticed this when I tried to port the Protocol.h parsers.
And tests for the inspect API,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE319157: [clangd] Add missing (but documented!) JSONExpr
typed accessors (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40399?vs=124204&id=124528#toc
Repository:
rCTE Cl
hokein added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE319159: [clangd] Switch from YAMLParser to JSONExpr
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40406?vs=124163&id=124529#toc
Repository:
rCTE Clang Tools Extra
htt
Author: sammccall
Date: Tue Nov 28 01:37:43 2017
New Revision: 319159
URL: http://llvm.org/viewvc/llvm-project?rev=319159&view=rev
Log:
[clangd] Switch from YAMLParser to JSONExpr
Summary:
- Converted Protocol.h parse() functions to take JSON::Expr.
These no longer detect and log unknown fiel
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
Comment at: include/clang-c/Index.h:2622
+ *
+ * A declaration is invalid if it could not be parsed successfully.
+ */
Perhaps add that we need to have id
dberris added a comment.
In https://reviews.llvm.org/D39114#930461, @kubamracek wrote:
> Hi, can you split the patch and send individual changes as separate patches?
> It's getting hard to follow. And I think we should land the parts that are
> "safe to land", e.g. the ASM changes or some of th
ilya-biryukov added inline comments.
Comment at: clangd/Context.cpp:16
+
+static Context *GlobalCtx = nullptr;
+static Context EmptyContext(nullptr, {});
sammccall wrote:
> Seems like it would simplify things if:
> - GlobalCtx was always set (static local trick)
Wizard added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
erikjv added a comment.
Maybe something like this works:
--- a/tools/libclang/CIndex.cpp
+++ b/tools/libclang/CIndex.cpp
@@ -8090,6 +8090,7 @@ CXSourceRangeList
*clang_getSkippedRanges(CXTranslationUnit TU, CXFile file) {
SourceManager &sm = Ctx.getSourceManager();
FileEntry *fil
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1525
+ if (!DryRun)
+Token->adaptStartOfLine(0, Whitespaces);
+
If we indent here, shouldn't that also change ContentStartColumn?
Comment at: lib/Format/Contin
erikjv closed this revision.
erikjv added a comment.
Submitted as r317308.
https://reviews.llvm.org/D38578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dberris updated this revision to Diff 124538.
dberris retitled this revision from "[XRay][darwin] Initial XRay in Darwin
Support" to "[XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin".
dberris edited the summary of this revision.
dberris added a comment.
This revision is now accept
dberris updated this revision to Diff 124539.
dberris edited the summary of this revision.
dberris added a comment.
Update description to not use tabs.
https://reviews.llvm.org/D39114
Files:
compiler-rt/cmake/config-ix.cmake
compiler-rt/lib/xray/CMakeLists.txt
compiler-rt/lib/xray/weak_sy
dberris added a comment.
Landing this now and seeing whether there's fallout from the build bots.
https://reviews.llvm.org/D39114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
I found some nit, otherwise LG!
I think you should includ the context in the patches, that makes them reviewing
much easier. See:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Com
Quolyk added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79
QualifiedRenameRule(const NamedDecl *ND,
- std::string NewQualifiedName)
+ const std::string &NewQualifiedName)
: ND(ND), New
ioeric created this revision.
Herald added subscribers: ilya-biryukov, mgorny.
o Experimental interfaces to support use multiple index sources (e.g. AST index,
global index) for code completion, cross-reference finding etc.
o Replace sema code completion for qualified-id with index-based completio
xazax.hun added a comment.
In https://reviews.llvm.org/D38171#927046, @alexfh wrote:
> And, btw, sorry for the long delay. I've been on travelling / on vacation for
> the last few weeks.
No problem. Will you have some time to think about the overall concept?
Implementation and test wise it lo
xazax.hun added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:262
+std::vector ClangTidyContext::getEnabledClangDiagnostics() {
+ llvm::SmallVector Diags;
+ DiagnosticIDs::getAllDiagnostics(diag::Flavor::WarningOrError, Diags);
I am wo
nik updated this revision to Diff 124550.
nik marked an inline comment as done.
nik added a comment.
Rebaed and clarified the documentation only.
Please submit as I don't have the permissions.
https://reviews.llvm.org/D40072
Files:
include/clang-c/Index.h
test/Index/print-type-size.cpp
t
MTC updated this revision to Diff 124549.
MTC added a comment.
Update the llvm_unreachable's description of the BlockEntrance-branch from
"Unexpected ProgramPoint" to "Unexpected CFG element at front of block".
https://reviews.llvm.org/D37187
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
MTC marked an inline comment as done.
MTC added a comment.
Hi dcoughlin,
Thank you very much for your help. I have no commit access and hope someone can
commit it on my behalf. Thanks a lot!
https://reviews.llvm.org/D37187
___
cfe-commits mailing
alexfh updated this revision to Diff 124553.
alexfh added a comment.
Herald added a subscriber: klimek.
- clang-format -style=llvm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40507
Files:
clang-tidy/hicpp/HICPPTidyModule.cpp
clang-tidy/misc/CMakeLists.txt
clang-tidy/mi
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Found one possible problem. Once fixed, LG!
Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33
+#include "../performance/MoveConstArgCheck.h"
+#include "../performance
alexfh updated this revision to Diff 124554.
alexfh added a comment.
- Reverted formatting in tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40507
Files:
clang-tidy/hicpp/HICPPTidyModule.cpp
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-
Author: xazax
Date: Tue Nov 28 05:54:52 2017
New Revision: 319170
URL: http://llvm.org/viewvc/llvm-project?rev=319170&view=rev
Log:
[clang-tidy] Fix tests for ReplaceRandomShuffleCheck
Patch by: Daniel Kolozsvari!
Differential Revision: https://reviews.llvm.org/D40516
Modified:
clang-tools-
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from one small nit with the test file missing a trailing newline.
Comment at: test/clang-tidy/fuchsia-default-arguments.cpp:82
+}
\ No newline at end
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor formatting nit.
Comment at: test/clang-tidy/readability-else-after-return.cpp:7
+ ~string();
+};
+}
Indentation is incor
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:44
+CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt'
+CTU_TEMP_FNMAP_FOLDER = 'tmpE
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
I'm fine if @rjmccall is fine - but looks like I need to accept this revision
because I requested changes in the past?
https://reviews.llvm.org/D40275
_
malaperle added a comment.
Hi Eric! As you might know I'm working on persisted indexing. I was wondering
which cases needed the index for code completion? Could you give a small
example? I thought the AST alone would be sufficient for that. I'll look at
this patch more closely a bit later but I
malcolm.parsons updated this revision to Diff 124566.
malcolm.parsons added a comment.
clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40505
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
test/clang-tidy/readability-else-after-return.cpp
Index: test/cl
Author: malcolm.parsons
Date: Tue Nov 28 06:57:47 2017
New Revision: 319174
URL: http://llvm.org/viewvc/llvm-project?rev=319174&view=rev
Log:
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Summary:
The readability-else-after-return check was not warning about
an else after
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE319174: [clang-tidy] Ignore ExprWithCleanups when looking
for else-after-throw (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D40505?vs=124566&id=124567#toc
Reposito
ilya-biryukov added a comment.
In https://reviews.llvm.org/D40548#937626, @malaperle wrote:
> Hi Eric! As you might know I'm working on persisted indexing. I was wondering
> which cases needed the index for code completion? Could you give a small
> example? I thought the AST alone would be suff
ioeric added a comment.
In https://reviews.llvm.org/D40548#937626, @malaperle wrote:
> Hi Eric! As you might know I'm working on persisted indexing. I was wondering
> which cases needed the index for code completion? Could you give a small
> example? I thought the AST alone would be sufficient
Another bump on this - again, this is my first time trying to submit a
patch, so please let me know if there's a better way to go about this.
On Mon, Nov 20, 2017 at 10:22 AM, Russell McClellan
wrote:
> Hi -
>
> Just pinging this after a week; let me know if there's a better way to
> submit patch
NoQ created this revision.
Herald added subscribers: rnkovacs, eraman.
Under the assumption of `-analyzer-config c++-allocator-inlining=true`, which
enables evaluation of `operator new` as a regular function call, this patch
shows what it takes to actually inline the constructor into the return
nik created this revision.
For the function declaration
auto foo5(Foo) -> Foo;
the parameter tokens were mapped to cursors representing the
FunctionDecl:
Keyword: "auto" [1:1 - 1:5] FunctionDecl=test5:1:6
Identifier: "test5" [1:6 - 1:11] FunctionDecl=test5:1:6
Punctuation: "(" [1:11 - 1:12]
NoQ added a comment.
> for the sake of this proof-of-concept, i've crudely disabled garbage
> collection on the respective moments of time
Forgot to mention that this breaks tests in `NewDeleteLeaks-PR19102.cpp`, which
are still failing in the present revision. Leak warnings get delayed to much
Author: sepavloff
Date: Tue Nov 28 08:14:14 2017
New Revision: 319178
URL: http://llvm.org/viewvc/llvm-project?rev=319178&view=rev
Log:
Refactor functions PrintTemplateArgumentList
These functions were defined as static members of TemplateSpecializationType.
Now they are moved to namespace level.
alexfh updated this revision to Diff 124580.
alexfh added a comment.
Herald added a subscriber: rnkovacs.
- Add dependencies to prevent a link error
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40507
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyModule.
jkorous-apple added a comment.
No luck. If I understand it correctly all the information that would be needed
to distinguish between:
foo::
and
int i = foo::
in ResultBuilder::AddResult() is missing since the context is represented only
by DeclContext. Something like a DirectASTParentNod
alexfh marked 2 inline comments as done.
alexfh added inline comments.
Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33
+#include "../performance/MoveConstArgCheck.h"
+#include "../performance/NoexceptMoveConstructorCheck.h"
#include "../readability/BracesAroundStatementsChec
keith.walker.arm updated this revision to Diff 124579.
keith.walker.arm added a comment.
> What are these disabled "R-UN" lines?
Oops! They shouldn't have been disabled in the patch.
> Do we really need to check every combination like this? I don't think the
> underlying logic actually varies
klimek updated this revision to Diff 124581.
klimek marked 3 inline comments as done.
klimek added a comment.
Address review comments.
https://reviews.llvm.org/D40310
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/Fo
ioeric created this revision.
... in qualified code completion and decl lookup.
https://reviews.llvm.org/D40562
Files:
lib/Sema/SemaCodeComplete.cpp
lib/Sema/SemaLookup.cpp
test/CodeCompletion/ignore-global-decls.cpp
Index: test/CodeCompletion/ignore-global-decls.cpp
===
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1525
+ if (!DryRun)
+Token->adaptStartOfLine(0, Whitespaces);
+
krasimir wrote:
> If we indent here, shouldn't that also change ContentStartColumn?
Nope, this will exactly adapt th
Author: alexfh
Date: Tue Nov 28 08:41:03 2017
New Revision: 319183
URL: http://llvm.org/viewvc/llvm-project?rev=319183&view=rev
Log:
[clang-tidy] Move more checks from misc- to performance-
Summary:
rename_check.py misc-move-const-arg performance-move-const-arg
rename_check.py misc-noexcept-move-
This revision was automatically updated to reflect the committed changes.
alexfh marked 2 inline comments as done.
Closed by commit rCTE319183: [clang-tidy] Move more checks from misc- to
performance- (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D40507?vs=124580&id=12
ioeric created this revision.
https://reviews.llvm.org/D40563
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaCodeComplete.cpp
===
--- lib/Sema/SemaCodeComplete.cpp
+++ lib/Sem
sammccall created this revision.
Herald added subscribers: cfe-commits, klimek.
This makes the parse() functions about as short as they can be given the
current signature, and moves all array-traversal etc code to a
central location.
We keep the ability to distinguish between optional and require
juliehockett updated this revision to Diff 124586.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Added missing newline
https://reviews.llvm.org/D40108
Files:
clang-tidy/CMakeLists.txt
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/DefaultArgumentsCheck
sepavloff updated this revision to Diff 124587.
sepavloff added a comment.
Updated patch as part of it was committed in https://reviews.llvm.org/rL319178
https://reviews.llvm.org/D40508
Files:
include/clang/AST/PrettyPrinter.h
lib/AST/TypePrinter.cpp
lib/CodeGen/CodeGenTypes.cpp
test/Co
NoQ added a comment.
The reason why i don't want to commit the MAX/4 approach now (for `>`/`<` case)
is that it has too little useful effects until the iterator checker is enabled
by default. However, it is a core change that immediately affects all users
with all its negative effects (such as
NoQ added a comment.
Hey wb! Get well :)
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:282
+}
+// We might want to handle the case when the mutex lock function was
inlined
+// and returned an Unknown or Undefined value.
a.sidorin w
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:271
}
-assert(lockFail && lockSucc);
-C.addTransition(lockFail);
-
+//
sepavloff marked 3 inline comments as done.
sepavloff added a comment.
In https://reviews.llvm.org/D40508#936617, @rnk wrote:
> It's not clear to me that this abbreviation functionality should live in
> Support. Clang probably wants enough control over this (assuming we're doing
> it) that the
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2238-2240
+ // All other pointers are unique.
+ if (Ty->isPointerType() || Ty->isMemberPointerType())
+return true;
rsmith wrote:
> erichkeane wrote:
> > rsmith wrote:
> > > This is not co
mattd created this revision.
Fixes: PR28290
When checking an argument list, arguments from the templated class instance,
were
returning 'is dependent' based on the 'this' pointer. In that case, arguments
were
being marked dependent, and name lookup was delayed until template
instantiation. Thi
sepavloff added a comment.
In https://reviews.llvm.org/D40508#937212, @rjmccall wrote:
> In Swift's IRGen, we have an option controlling whether to emit meaningful
> value names. That option can be set directly from the command line, but it
> defaults to whether we're emitting IR assembly (i.e
Author: ctopper
Date: Tue Nov 28 10:00:32 2017
New Revision: 319195
URL: http://llvm.org/viewvc/llvm-project?rev=319195&view=rev
Log:
[Target] Make a copy of TargetOptions feature list before sorting during CodeGen
Currently CodeGen is calling std::sort on the features vector in TargetOptions
fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319195: [Target] Make a copy of TargetOptions feature list
before sorting during CodeGen (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D40228?vs=123862&id=124599#toc
Reposito
aaron.ballman added a comment.
Thanks for the nit fix. If you'd like me to commit this on your behalf, just
let me know.
https://reviews.llvm.org/D40108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
sepavloff created this revision.
Herald added subscribers: JDevlieghere, eraman.
If a module contains opaque type and another one contains definition
of equivalent type in sense of C++, `llvm-link` merges these types.
In this procedure it can rely only on type name. An issue arises if
the type is
kcc created this revision.
Herald added subscribers: cfe-commits, fedor.sergeev.
preliminary design document for a hardware-assisted memory safety (HWAMS) tool,
similar to AddressSanitizer
The name TaggedAddressSanitizer and the rest of the document, are early draft,
suggestions are welcome.
Th
sepavloff added a comment.
https://reviews.llvm.org/D40567 presents a patch that adds template argument
names to class template specializations. It also describes the use case in
which type names are used to identify type across different TUs.
Adding template parameters obviously increase memory
kcc updated this revision to Diff 124604.
kcc added a comment.
minor edit (explained shadow)
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/TaggedAddressSanitizerDesign.rst
Index: docs/TaggedAddressSanitizerDesign.rst
=
tra added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
rjmccall wrote:
> tra wrote:
spatel added a comment.
Ping * 2.
https://reviews.llvm.org/D40044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
I'll take a look, but my guess is that you might have to use scoping information
https://reviews.llvm.org/D39730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: tra
Date: Tue Nov 28 10:51:42 2017
New Revision: 319201
URL: http://llvm.org/viewvc/llvm-project?rev=319201&view=rev
Log:
[CUDA] Report "unsupported VLA" errors only on device side.
This fixes erroneously reported CUDA compilation errors
in host-side code during device-side compilation.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319201: [CUDA] Report "unsupported VLA" errors only on
device side. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40275?vs=123831&id=124607#toc
Repository:
rL LLVM
https://re
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:178
Split Split) const {
// Example: consider the content
// lala lala
Offtopic: Should add a FIXME that this doesn't really work in th
erichkeane updated this revision to Diff 124609.
erichkeane added a comment.
Add has padding to CXXABI getMemberPointerWidthAndAlign to correct padding
behavior here.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
l
krasimir added a comment.
Re: "I tried to write a test for this, and convinced myself that while +1 is
correct, it is currently impossible to change behavior based on the missing
+1.":
In order to have different outcome based on the start column, you could use
tabs. Consider the content `"aaa\t
bsdjhb added a comment.
Ping @compnerd, @sdardis
https://reviews.llvm.org/D38110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jacobly created this revision.
Forcing the 4 byte alignment caused an issue in my out of tree backend that
doesn't even have a 4 byte aligned stack. Using the default target-specific
alignment for i32 seems more reasonable.
Repository:
rC Clang
https://reviews.llvm.org/D40569
Files:
lib
jtony added inline comments.
Comment at: test/Driver/ppc-features.cpp:140
+
// RUN: %clang -target powerpc64-unknown-linux-gnu %s -mno-htm -### -o %t.o
2>&1 | FileCheck -check-prefix=CHECK-NOHTM %s
// CHECK-NOHTM: "-target-feature" "-htm"
We probably need to a
dcoughlin added a comment.
Thanks for tackling this! There is one major comment inline (you are generating
an extra node that you shouldn't, which is causing the analyzer to explore code
it shouldn't) and a suggestion for simpler diagnostic text.
Comment at: lib/StaticAnalyze
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, seems reasonable enough.
Repository:
rC Clang
https://reviews.llvm.org/D40569
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
tra wrote:
> rjmccall w
rnk requested changes to this revision.
rnk added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Driver/ToolChain.cpp:450-458
+ const llvm::Target *TT = llvm::TargetRegistry::lookupTarget(TS, Error);
+ if (!TT)
+return llvm::ExceptionHandlin
rjmccall added a comment.
My skepticism about the raw_ostream is not about the design of having a custom
raw_ostream subclass, it's that that subclass could conceivably be re-used by
some other client. It feels like it belongs as an internal hack in Clang
absent some real evidence that someone
Hahnfeld created this revision.
This is needed to not break with an upcoming change in LLVM to use
dollar signs (which need to be quoted) instead of dots for
generating unique names.
https://reviews.llvm.org/D40572
Files:
test/OpenMP/nvptx_parallel_codegen.cpp
Index: test/OpenMP/nvptx_parall
fhahn added reviewers: arphaman, GorNishanov, hfinkel, fhahn.
fhahn added a comment.
Looks good to me, with some nits. However it seems that we do not use the fast
math flags anywhere else in Clang codegen, so it would be good to clarify if it
is OK to use it here.
Comment at
Author: mgrang
Date: Tue Nov 28 12:41:13 2017
New Revision: 319222
URL: http://llvm.org/viewvc/llvm-project?rev=319222&view=rev
Log:
[OpenMP] Stable sort Privates to remove non-deterministic ordering
Summary:
This fixes the following failures uncovered by D39245:
Clang :: OpenMP/task_firstpri
1 - 100 of 178 matches
Mail list logo
