xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land.
Found one possible problem. Once fixed, LG! ================ Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33 +#include "../performance/MoveConstArgCheck.h" +#include "../performance/NoexceptMoveConstructorCheck.h" #include "../readability/BracesAroundStatementsCheck.h" ---------------- Don't you need to add performance module to link to the HICPP module to avoid link errors? ================ Comment at: clang-tidy/performance/MoveConstArgCheck.h:19 -class MoveConstantArgumentCheck : public ClangTidyCheck { +class MoveConstArgCheck : public ClangTidyCheck { public: ---------------- Is there any specific reason to rename this class? I am ok with the change, just wondering. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits