xazax.hun added inline comments.

================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:262
+std::vector<std::string> ClangTidyContext::getEnabledClangDiagnostics() {
+  llvm::SmallVector<unsigned, 5000> Diags;
+  DiagnosticIDs::getAllDiagnostics(diag::Flavor::WarningOrError, Diags);
----------------
I am wondering if this is still a good candidate to be a small vector with this 
size. Maybe a regular vector with a reserve might be better?


https://reviews.llvm.org/D38171



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to