JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:261
+- Static Analyzer can now properly detect and diagnose unary pre-/post-
+ increment/decrement on an uninitialized values.
+
The end of the sentence should be either 'on uninitialized values'
lebedev.ri added inline comments.
Comment at: docs/ReleaseNotes.rst:261
+- Static Analyzer can now properly detect and diagnose unary pre-/post-
+ increment/decrement on an uninitialized values.
+
JonasToth wrote:
> The end of the sentence should be either 'on u
a.sidorin added a comment.
LGTM, thank you!
Comment at: unittests/AST/ASTImporterTest.cpp:566
+ typeTraitExpr(
+ hasType(asString("_Bool"))
+ )));
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Hello Peter,
This looks good to me. But could you please check if test works if we add
`-fms-compatibility` and `-fdelayed-template-parsing` to `Args`?
Comment at: un
JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:261
+- Static Analyzer can now properly detect and diagnose unary pre-/post-
+ increment/decrement on an uninitialized values.
+
lebedev.ri wrote:
> JonasToth wrote:
> > The end of the sentence s
xazax.hun added a subscriber: NoQ.
xazax.hun added inline comments.
Comment at: docs/ReleaseNotes.rst:261
+- Static Analyzer can now properly detect and diagnose unary pre-/post-
+ increment/decrement on an uninitialized values.
+
lebedev.ri wrote:
> JonasToth w
tk1012 updated this revision to Diff 124286.
tk1012 added a comment.
Hello there,
I update the diff to follow your comments.
https://reviews.llvm.org/D39722
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
=
a.sidorin accepted this revision.
a.sidorin added a comment.
Thank you!
https://reviews.llvm.org/D39722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: orenb
Date: Sun Nov 26 04:34:54 2017
New Revision: 318995
URL: http://llvm.org/viewvc/llvm-project?rev=318995&view=rev
Log:
Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking
support (Clang side)
Shadow stack solution introduces a new stack for return address
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318995: Control-Flow Enforcement Technology - Shadow Stack
and Indirect Branch Tracking… (authored by orenb).
Changed prior to commit:
https://reviews.llvm.org/D40224?vs=123937&id=124287#toc
Repository
Rakete added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7693
+Decl *Sema::ActOnConceptDefinition(Scope *S,
+ MultiTemplateParamsArg TemplateParameterLists,
+ IdentifierInfo *Name, SourceLocation L,
---
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
https://reviews.llvm.org/D38843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D40225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D39665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rwols updated this revision to Diff 124307.
rwols added a comment.
- Rebase to latest upstream revision.
- Go all-in with TextEdit, even down to ClangdUnit.cpp.
- Move FixItsMap to ClangdServer. ClangdLSPServer is much cleaner now.
- Remove the cached FixIts when the client closes the document.
-
rwols added inline comments.
Comment at: clangd/ClangdUnit.cpp:168
- P.line = Location.getSpellingLineNumber() - 1;
- P.character = Location.getSpellingColumnNumber();
Range R = {P, P};
Why subtract 1 from the line here, but not from the column? When subtrac
aaron.ballman updated this revision to Diff 124308.
aaron.ballman added a comment.
Ping. Rebased on ToT.
https://reviews.llvm.org/D15935
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Analysis/casts.c
test/CXX/d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318998: [ASTImporter] Support TypeTraitExpr (authored by
a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D39722?vs=124286&id=124309#toc
Repository:
rL LLVM
https://reviews.llvm.org/D39
Author: a.sidorin
Date: Sun Nov 26 09:04:06 2017
New Revision: 318998
URL: http://llvm.org/viewvc/llvm-project?rev=318998&view=rev
Log:
[ASTImporter] Support TypeTraitExpr
Patch by Takafumi Kubota!
Differential Revision: https://reviews.llvm.org/D39722
Modified:
cfe/trunk/lib/AST/ASTImport
lebedev.ri added a comment.
Ping?
Repository:
rL LLVM
https://reviews.llvm.org/D33826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
saar.raz requested changes to this revision.
saar.raz added a comment.
This revision now requires changes to proceed.
Do the requested clang-formatting as shown by hubert, other than that looks
good to me :)
https://reviews.llvm.org/D40381
___
cfe-
aaron.ballman added a comment.
I had the chance to finalize this long-standing review by fixing up the
remaining test cases and removing the unused enumerators from AttributeList.h.
I've commit in r319002 (but cannot close the review because the "Accept" didn't
happen).
https://reviews.llvm.o
malcolm.parsons added a comment.
In https://reviews.llvm.org/D38171#927045, @alexfh wrote:
> The only place I can think of, where -checks=* is useful is in combination
> with -list-checks, where the presence of clang-diagnostic- entries would be
> desired anyway.
Can we replace -list-checks w
pirama updated this revision to Diff 124313.
pirama added a comment.
- Switch kryo to use -mcpu=cortex-a57 when invoking the assembler
https://reviews.llvm.org/D37302
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Headers/float.h
test/Driver/as-mcpu.c
test/Headers/float.c
Index: test/Headers
pirama updated this revision to Diff 124315.
pirama added a comment.
Actually revert
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
test/Headers/float.c
Index: test/Headers/float.c
===
--- test/Headers/float.c
+++
pirama updated this revision to Diff 124314.
pirama added a comment.
Revert to previous patch after accidental update
https://reviews.llvm.org/D37302
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Headers/float.h
test/Driver/as-mcpu.c
test/Headers/float.c
Index: test/Headers/float.c
pirama created this revision.
Using -no-integrated-as causes -mcpu=kryo to fail since GNU assembler
doesn't recognize kryo. Cortex-a57 is the closest CPU to kryo that the
assembler does recognize. So we should switch the assembler to use
that instead.
https://reviews.llvm.org/D40476
Files:
Author: kamil
Date: Sun Nov 26 14:24:22 2017
New Revision: 319007
URL: http://llvm.org/viewvc/llvm-project?rev=319007&view=rev
Log:
Enable additonal features in NetBSD
Summary:
Enable for x86_64:
- ESan,
- KASan,
- MSan.
Enable for x86_64 and i386:
- Scudo.
These features are under active
pirama updated this revision to Diff 124318.
pirama added a comment.
Few refactorings.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
--- /dev/null
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Alright, I guess this all makes sense. We do have some extensions that are
playing around with v-table pointers, so it's probably fair to require the
v-table pointer type to be passed dow
aaron.ballman updated this revision to Diff 124320.
aaron.ballman added a comment.
Rebased against ToT, ping.
https://reviews.llvm.org/D33563
Files:
include/clang/AST/Expr.h
lib/AST/ASTDumper.cpp
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeG
changyu updated this revision to Diff 124319.
changyu added a comment.
- Fixed indent issues.
- Moved TODO on boolean atomic constraints to ActOnConceptDefinition where we
are currently checking for boolean constraint expression
https://reviews.llvm.org/D40381
Files:
include/clang/AST/DeclTe
KrzysztofKapusta added a comment.
@krasimir thanks for the review! I don't have commit rights. Would you push
this for me?
Repository:
rL LLVM
https://reviews.llvm.org/D40288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
33 matches
Mail list logo
