rwols added inline comments.
================
Comment at: clangd/ClangdUnit.cpp:168
- P.line = Location.getSpellingLineNumber() - 1;
- P.character = Location.getSpellingColumnNumber();
Range R = {P, P};
----------------
Why subtract 1 from the line here, but not from the column? When subtracting 1
from both, diagnostics appear correct in my client. I have moved this logic
into `SourceLocToPosition`.
https://reviews.llvm.org/D39430
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
