JonasToth added a comment.
@aaron.ballman and @alexfh ping.
https://reviews.llvm.org/D37808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm created this revision.
Herald added subscribers: yaxunl, wdng.
Already done for CUDA.
https://reviews.llvm.org/D39784
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGenOpenCL/convergent.cl
Index: test/CodeGenOpenCL/convergent.cl
=
hokein updated this revision to Diff 122038.
hokein marked 3 inline comments as done.
hokein added a comment.
Fix remaining nits.
https://reviews.llvm.org/D39332
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
lib/Tooling/Refactoring/RefactoringActions.cpp
lib/Tooling/Ref
Author: hokein
Date: Wed Nov 8 00:56:56 2017
New Revision: 317672
URL: http://llvm.org/viewvc/llvm-project?rev=317672&view=rev
Log:
[clang-refactor] Introduce a new rename rule for qualified symbols
Summary: Prototype of a new rename rule for renaming qualified symbol.
Reviewers: arphaman, ioer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317672: [clang-refactor] Introduce a new rename rule for
qualified symbols (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39332
Files:
cfe/trunk/include/clang/Tooling/Refactorin
ilya-biryukov added a comment.
Sorry for late response, was on vacation.
+1 to all @malaperle 's comments.
Here are some extra quick comments, will take a closer look later.
Comment at: clangd/ClangdServer.cpp:11
#include "ClangdServer.h"
+#include "Protocol.h"
#include "cla
Author: sammccall
Date: Wed Nov 8 01:15:01 2017
New Revision: 317673
URL: http://llvm.org/viewvc/llvm-project?rev=317673&view=rev
Log:
[clangd] loosen tests for flag-dependence revealed by r317670
Modified:
clang-tools-extra/trunk/test/clangd/completion-snippet.test
clang-tools-extra/tru
ilya-biryukov added a comment.
Just a few minor code style comments.
Comment at: clangd/ClangdServer.cpp:367
+Context.setASTContext(AST->getASTContext());
+auto rename = clang::tooling::RenameOccurrences::initiate(
+Context, SourceRange(SourceLocationBeg), NewNa
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
I don't think we should pass the very general configuration map to
`ClangdServer`. Especially given that we can easily update
`DirectoryBaseCompilationDatabase` instance in `ClangdLSPServer` itself.
What are your th
Author: ibiryukov
Date: Wed Nov 8 02:39:03 2017
New Revision: 317676
URL: http://llvm.org/viewvc/llvm-project?rev=317676&view=rev
Log:
Moved QualTypeNames.h from Tooling to AST.
Summary:
For code reuse in SemaCodeComplete.
Note that the tests for QualTypeNames are still in Tooling as they use
To
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317676: Moved QualTypeNames.h from Tooling to AST. (authored
by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D39224?vs=120014&id=122044#toc
Repository:
rL LLVM
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317677: Avoid printing some redundant name qualifiers in
completion (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38538
Files:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/
Author: ibiryukov
Date: Wed Nov 8 02:39:09 2017
New Revision: 317677
URL: http://llvm.org/viewvc/llvm-project?rev=317677&view=rev
Log:
Avoid printing some redundant name qualifiers in completion
Summary:
Adjusted PrintingPolicy inside code completion to avoid printing some
redundant name qualifi
lebedev.ri updated this revision to Diff 122053.
lebedev.ri added a comment.
Ping.
In https://reviews.llvm.org/D36836#889375, @aaron.ballman wrote:
> Adding @dberlin for licensing discussion questions.
@dberlin ping? I'm wondering if you had the chance to look at this? :)
Repository:
rL LL
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein updated this revision to Diff 122060.
hokein marked 10 inline comments as done.
hokein added a comment.
- address review comments.
- add error handling.
https://reviews.llvm.org/D39676
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdS
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:338
+std::vector
+ClangdServer::Rename(PathRef File, Position Pos, llvm::StringRef NewName) {
sammccall wrote:
> I think you can split out a private method:
>
> Expected>
> ClangdServer::ap
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Could you please take a different approach and add the callbacks you need into
`PreambleCallbacks` class?
It already has this one:
virtual void HandleMacroDefined(con
Author: sammccall
Date: Wed Nov 8 04:25:00 2017
New Revision: 317686
URL: http://llvm.org/viewvc/llvm-project?rev=317686&view=rev
Log:
[clangd] tolerate windows filepaths in tests
Modified:
clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test
Modified: clang-tools-extra/trunk/test/
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:338
+std::vector
+ClangdServer::Rename(PathRef File, Position Pos, llvm::StringRef NewName) {
hokein wrote:
> sammccall wrote:
> > I think you can split out a private method:
> >
> > Expe
vries created this revision.
Herald added a subscriber: kubamracek.
this removes a semicolon after "do {} while (0)" in CHECK_SMALL_REGION. This
allows the macro to be used in if-then-elses without curly braces.
[ https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00298.html ]
https://reviews.llvm.
Author: ibiryukov
Date: Wed Nov 8 05:05:52 2017
New Revision: 317687
URL: http://llvm.org/viewvc/llvm-project?rev=317687&view=rev
Log:
Workaround reverse-iteration buildbot breakages. Filed PR35244.
Clang's completion output is non-deterministic, causing test failures
with turned on LLVM_REVERSE
Author: krasimir
Date: Wed Nov 8 05:28:53 2017
New Revision: 317689
URL: http://llvm.org/viewvc/llvm-project?rev=317689&view=rev
Log:
[clang-tidy] Add a note about modernize-replace-random-shuffle
Summary:
This adds a note warning the users that the way the suggested fix seeds the
random number
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317689: [clang-tidy] Add a note about
modernize-replace-random-shuffle (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D39787
Files:
clang-tools-extra/trunk/docs/clang-tidy/che
krasimir updated this revision to Diff 122069.
krasimir added a comment.
- Remove dead code
https://reviews.llvm.org/D39786
Files:
docs/ClangFormatStyleOptions.rst
docs/tools/dump_format_style.py
include/clang/Format/Format.h
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/Usi
hokein created this revision.
Herald added a subscriber: klimek.
The OccurrencesFinder is only used in RenameOccurrences to find symbol
occurrences, there is no need to inherit RefactoringRule.
Replace it with a single utility function to avoid code misleading.
https://reviews.llvm.org/D39796
sammccall created this revision.
https://reviews.llvm.org/D39797
Files:
test/clangd/definitions.test
Index: test/clangd/definitions.test
===
--- test/clangd/definitions.test
+++ test/clangd/definitions.test
@@ -27,7 +27,7 @@
# CH
hokein updated this revision to Diff 122074.
hokein marked 2 inline comments as done.
hokein added a comment.
Simplify the code.
https://reviews.llvm.org/D39676
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:347
+
+void handle(tooling::SymbolOccurrences) override {}
+
sammccall wrote:
> hokein wrote:
> > sammccall wrote:
> > > I don't think you need to override this, assuming you don't expect any o
Author: sammccall
Date: Wed Nov 8 05:52:21 2017
New Revision: 317692
URL: http://llvm.org/viewvc/llvm-project?rev=317692&view=rev
Log:
Relax definitions.test to accept windows file paths.
Reviewers: ilya-biryukov
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D39797
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317692: Relax definitions.test to accept windows file paths.
(authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D39797
Files:
clang-tools-extra/trunk/test/clangd/definitions.test
sylvestre.ledru updated this revision to Diff 122077.
sylvestre.ledru edited the summary of this revision.
https://reviews.llvm.org/D38124
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
test/profile/instrprof-dlopen-dlclose-gcov.test
Index: test/prof
belleyb added a comment.
@sylvestre.ledru Thanks for the test!
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru added a comment.
please thank Marco :)
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
Herald added a subscriber: ilya-biryukov.
This is an alternative to JSONCompilationDatabase for simple projects that
don't use a build system such as CMake.
(You can also drop one in ~, to make your tools use e.g. C++11 by default)
There's no facility for varying
klimek added inline comments.
Comment at: include/clang/Tooling/CompilationDatabase.h:188
+ static std::unique_ptr
+ loadFromFile(StringRef Path, std::string &ErrorMsg);
+
Perhaps loadFromTextFile?
Comment at: lib/Tooling/CompilationDatabase.
uriel.k updated this revision to Diff 122082.
uriel.k marked 2 inline comments as done.
https://reviews.llvm.org/D38737
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
test/
uriel.k added inline comments.
Comment at: lib/Headers/avx512vlbwintrin.h:2425
+ return _mm_mask_cmpneq_epi8_mask (__U, _mm_and_si128 (__A, __B),
+ _mm_setzero_hi());
}
For strange reason this line moved and is not aligned with t
uriel.k added inline comments.
Comment at: lib/Headers/avx512vlbwintrin.h:2425
+ return _mm_mask_cmpneq_epi8_mask (__U, _mm_and_si128 (__A, __B),
+ _mm_setzero_hi());
}
uriel.k wrote:
> For strange reason this line moved and is n
sammccall added inline comments.
Comment at: include/clang/Tooling/CompilationDatabase.h:188
+ static std::unique_ptr
+ loadFromFile(StringRef Path, std::string &ErrorMsg);
+
klimek wrote:
> Perhaps loadFromTextFile?
This mirrors JSONCompilationDatabase for con
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdServer.cpp:67
+
+ // Using the handle(SymbolOccurrences) from parent class.
+ using tooling::RefactoringResultConsumer::handle;
-
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(This seems trivial enough to submit without review FWIW)
https://reviews.llvm.org/D39796
___
cfe-commits mailing list
cfe-commits@lists.ll
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/ClangdServer.cpp:67
+
+ // Using the handle(SymbolOccurrences) from parent class.
+ using tooling::RefactoringResultConsumer::handle;
sammccall wrote:
> why is this needed
Author: hokein
Date: Wed Nov 8 06:53:08 2017
New Revision: 317696
URL: http://llvm.org/viewvc/llvm-project?rev=317696&view=rev
Log:
[clang-refactor] Get rid of OccurrencesFinder in RenamingAction, NFC
Summary:
The OccurrencesFinder is only used in RenameOccurrences to find symbol
occurrences, th
NoQ created this revision.
pr34404 points out that given
class C {
struct {
int x;
};
};
, taking pointer-to-member `&C::x` would crash the analyzer. We were not ready
to stumble upon an `IndirectFieldDecl`, which is used for representing a field
within an anonymous structure
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317696: [clang-refactor] Get rid of OccurrencesFinder in
RenamingAction, NFC (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39796
Files:
cfe/trunk/lib/Tooling/Refactoring/Rename
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
cameron314 added inline comments.
Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365
cast(FD)->getParent(), ObjectType,
- ObjectClassification, Args.slice(1), CandidateSet,
+ ObjectClassification, F
ioeric added a comment.
Implementation looks good. Just some nits.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.cpp:36
+ return true;
+// FIXME: Capture 'self'.
+if (!VD->isLocalVarDeclOrParm())
and `this`?
Commen
NoQ created this revision.
`std::initializer_list` objects can be constructed sort of explicitly, eg.
`(std::initializer_list){12}`. This produces an AST that looks like
CompoundLiteralExpr 0x11987f1a0 'std::initializer_list':'class
std::initializer_list'
`-CXXStdInitializerListExpr 0x11987
ilya-biryukov added a comment.
I can see that `FixedCompilationDatabase` does not set a working directory. Is
this something we may want to have for `compile_flags.txt` or one would need to
resort to `compile_commands.json` to get this?
E.g., I'd find it useful to add includes with paths relativ
mgorny created this revision.
The bump of default _MSC_VER which occurred in r315107 has caused
the '__declspec(thread)' TLSKind to change from STATIC to DYNAMIC.
Update the clang python binding tests accordingly. Test both for
behavior with old and new -fms-compatibility-version.
Repository:
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D39799#919388, @ilya-biryukov wrote:
> I can see that `FixedCompilationDatabase` does not set a working directory.
> Is this something we may want to have for `compile_flags.txt` or one would
> ne
malaperle added inline comments.
Comment at: lib/Index/IndexRecordWriter.cpp:155
+if (!IsNew) {
+ llvm::errs() << "Index: Duplicate USR! " << SymInfo.USR << "\n";
+ // FIXME: print more information so it's easier to find the declaration.
I'm getting
sammccall updated this revision to Diff 122100.
sammccall added a comment.
llvm::make_unique
https://reviews.llvm.org/D39799
Files:
docs/JSONCompilationDatabase.rst
include/clang/Tooling/CompilationDatabase.h
lib/Tooling/CompilationDatabase.cpp
test/Tooling/fixed-database.cpp
Index: te
frutiger added a comment.
Thanks for posting this on Phabricator, I had sent it to the mailing list last
month.
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ilya-biryukov added a comment.
In https://reviews.llvm.org/D39799#919415, @sammccall wrote:
> Currently the working directory is always the parent of `compile_flags.txt`
> as you suggest.
> Maybe this isn't great though - sometimes it might be important that the WD
> is the parent of the sourc
sammccall added a comment.
In https://reviews.llvm.org/D39799#919468, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D39799#919415, @sammccall wrote:
>
> > Currently the working directory is always the parent of `compile_flags.txt`
> > as you suggest.
> > Maybe this isn't great though - so
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: dergachev
Date: Wed Nov 8 09:27:58 2017
New Revision: 317700
URL: http://llvm.org/viewvc/llvm-project?rev=317700&view=rev
Log:
[analyzer] Fix a crash on logical operators with vectors.
Do not crash when trying to compute x && y or x || y where x and y are
of a vector type.
For now we do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317700: [analyzer] Fix a crash on logical operators with
vectors. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39682?vs=121856&id=122108#toc
Repository:
rL LLVM
https:
ilya-biryukov added a comment.
In https://reviews.llvm.org/D39799#919494, @sammccall wrote:
> e.g. IIUC, things like `#include "sibling.h"` won't look for the h file next
> to the cc file?
Actually, this should work as quoted includes are always searched relative to
the current file before lo
bsdjhb added a comment.
Ping
https://reviews.llvm.org/D38110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
@frutiger, do you maybe happen to have fixes for the two other test failures?
Maybe I'm tracking them down unnecessarily ;-).
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@li
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D38221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added a comment.
For clarification: what is the "symbols table" you are referring to in the
description?
Repository:
rL LLVM
https://reviews.llvm.org/D39622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
dcoughlin added a comment.
I believe your motivating examples used errno_t, which is a signed type.
I'm fine with assuming a two's complement value representation for signed
integers, which would make Artem's suggestion work. That assumption definitely
deserves a comment, though.
https://revi
mgorny created this revision.
Starting with https://reviews.llvm.org/rL314037, anonymous namespaces no longer
give
unique-external linkage to variables. As a result, the relevant test no
longer works correctly. Comment it out until a replacement expression is
found.
Repository:
rL LLVM
https
frutiger added a comment.
I will commit this shortly.
@mgorny I have a fix for the `unique_external` issue here:
https://reviews.llvm.org/D39161
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.
mgorny abandoned this revision.
mgorny added a comment.
Duplicate of https://reviews.llvm.org/D39161.
Repository:
rL LLVM
https://reviews.llvm.org/D39810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
mgorny added a comment.
I see that you haven't more luck than I did finding a better solution. How
about the code completion failure? I suppose I still have to figure that one
out on my own ;-).
I can commit this one myself, I have it ready for commit already.
Repository:
rL LLVM
https://r
spatel created this revision.
Herald added a subscriber: mcrosier.
There are 2 parts to getting the -fassociative-math command-line flag
translated to LLVM FMF:
1. In the driver/frontend, we accept the flag and its 'no' inverse and deal
with the interactions with other flags like -ffast-math. T
Author: frutiger
Date: Wed Nov 8 11:17:27 2017
New Revision: 317706
URL: http://llvm.org/viewvc/llvm-project?rev=317706&view=rev
Log:
[bindings] fix TLS test failure
Since cfe commit r237337, '__declspec(thread)' and 'thread_local' have
been the same since MSVC 2015. i.e. they are both consider
frutiger closed this revision.
frutiger added a comment.
Ah missed your last note. Committed as `r317706`.
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
spatel added a comment.
I just reviewed the gcc docs:
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
"[-fassociative-math] requires that both -fno-signed-zeros and
-fno-trapping-math be in effect."
If we want to match that behavior, I need to change this patch to light up
'nsz' and t
wristow added a comment.
In https://reviews.llvm.org/D39812#919687, @spatel wrote:
> I just reviewed the gcc docs:
> https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
>
> "[-fassociative-math] requires that both -fno-signed-zeros and
> -fno-trapping-math be in effect."
>
> If we want to
frutiger added a comment.
Friendly poke @rsmith @compnerd
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dlj
Date: Wed Nov 8 12:03:11 2017
New Revision: 317716
URL: http://llvm.org/viewvc/llvm-project?rev=317716&view=rev
Log:
Add a missing "REQUIRES: system-windows" to a Windows-only test.
This un-breaks builds on other platforms. Otherwise, they fail due to warnings
like:
warning: unable
frutiger added a comment.
@jklaehn do you know why the referenced cursor would point to line 2?
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cameron314 added inline comments.
Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6396
} else {
AddTemplateOverloadCandidate(FunTmpl, F.getPair(),
ExplicitTemplateArgs, Args,
The same slice that was added abov
Author: abataev
Date: Wed Nov 8 12:16:14 2017
New Revision: 317719
URL: http://llvm.org/viewvc/llvm-project?rev=317719&view=rev
Log:
[OPENMP] Codegen for `#pragma omp target parallel for`.
Added:
cfe/trunk/test/OpenMP/target_parallel_for_codegen_registration.cpp
cfe/trunk/test/OpenMP/tar
Author: marshall
Date: Wed Nov 8 12:25:47 2017
New Revision: 317722
URL: http://llvm.org/viewvc/llvm-project?rev=317722&view=rev
Log:
Added include for
Modified:
libcxx/trunk/fuzzing/fuzzing.cpp
Modified: libcxx/trunk/fuzzing/fuzzing.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxx/tru
Author: marco
Date: Wed Nov 8 11:21:54 2017
New Revision: 317709
URL: http://llvm.org/viewvc/llvm-project?rev=317709&view=rev
Log:
Add CoreOption flag to "-coverage" option to make it available for clang-cl
Summary:
The -coverage option is not a CoreOption, so it is not available to clang-cl.
Th
Thanks for the patch, Reimar. Can you please add tests to ensure this
functionality doesn’t regress? As null character is required by the standard
(27.7.2.3p21), a good starting point seems to be
test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size.pass.cpp
spatel added a comment.
In https://reviews.llvm.org/D39812#919699, @wristow wrote:
> Yes, I think we want to match that behavior. But by "light up" 'nsz' and the
> no-trapping-math attribute, do you mean automatically turn them on when
> '-fassociative-math' is specified? I'd think it should
Author: arphaman
Date: Wed Nov 8 13:33:15 2017
New Revision: 317727
URL: http://llvm.org/viewvc/llvm-project?rev=317727&view=rev
Log:
[ObjC] Boxed strings should use the nullability from stringWithUTF8String's
return type
Objective-C NSString has a class method stringWithUTF8String that creates
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317727: [ObjC] Boxed strings should use the nullability from
stringWithUTF8String's… (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D39762?vs=121982&id=122148#toc
Repository:
malaperle added inline comments.
Comment at: include/indexstore/IndexStoreCXX.h:75
+ bool foreachRelation(llvm::function_ref receiver)
{
+#if INDEXSTORE_HAS_BLOCKS
+return indexstore_occurrence_relations_apply(obj,
^bool(indexstore_symbol_relation_t sym_rel) {
jlebar created this revision.
Herald added a subscriber: sanjoy.
How embarrassing.
This is tested in the test-suite -- fix to come there in a separate
patch.
https://reviews.llvm.org/D39817
Files:
clang/lib/Headers/cuda_wrappers/algorithm
Index: clang/lib/Headers/cuda_wrappers/algorithm
==
jlebar created this revision.
Herald added a subscriber: sanjoy.
Previously we only tested on C++14 and newer, which let slip a bug where
std::min returned the max. :(
https://reviews.llvm.org/D39818
Files:
External/CUDA/algorithm.cu
Index: External/CUDA/algorithm.cu
==
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Ouch. LGTM.
https://reviews.llvm.org/D39817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Nebiroth added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:51
+ "definitionProvider": true,
+ "configurationChangeProvider": true
}})");
malaperle wrote:
> Are you sure the existing tests don't fail? usually when we change t
spatel updated this revision to Diff 122155.
spatel added a comment.
Patch updated:
Match gcc's handling of -fassociative-math with -fno-signed-zeros and
-fno-trapping-math. I've created a new codegen option (-mreassociate) that maps
directly to LLVM's 'reassoc' flag, so we limit the mix-and-mat
Author: vsapsai
Date: Wed Nov 8 14:30:29 2017
New Revision: 317734
URL: http://llvm.org/viewvc/llvm-project?rev=317734&view=rev
Log:
[libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx
versions.
r313500 added a fix for undefined "___cxa_deleted_virtual" symbol.
Previo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317734: [libcxx] Mark test cxa_deleted_virtual.pass.cpp as
failing for previous libcxx… (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D39776?vs=122024&id=122157#toc
Repositor
spatel updated this revision to Diff 122158.
spatel added a comment.
Updated again - the last upload was missing the driver's test file.
https://reviews.llvm.org/D39812
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
li
Author: arphaman
Date: Wed Nov 8 14:44:34 2017
New Revision: 317736
URL: http://llvm.org/viewvc/llvm-project?rev=317736&view=rev
Log:
[ObjC] Fix function signature handling for blocks literals with attributes
Block literals can have a type with attributes in its signature, e.g.
ns_returns_retain
Author: arphaman
Date: Wed Nov 8 14:47:15 2017
New Revision: 317737
URL: http://llvm.org/viewvc/llvm-project?rev=317737&view=rev
Log:
Remove redundant copy-pasted comment in test file from r317736
Modified:
cfe/trunk/test/SemaObjC/block-literal-with-attribute.m
Modified: cfe/trunk/test/Sema
1 - 100 of 122 matches
Mail list logo
