[PATCH] D39810: [clang] [python] [tests] Disable the broken unique-external linkage test

[Michał Górny via Phabricator via cfe-commits]

mgorny created this revision.

Starting with https://reviews.llvm.org/rL314037, anonymous namespaces no longer 
give
unique-external linkage to variables. As a result, the relevant test no
longer works correctly. Comment it out until a replacement expression is
found.


Repository:
  rL LLVM

https://reviews.llvm.org/D39810

Files:
  bindings/python/tests/cindex/test_linkage.py


Index: bindings/python/tests/cindex/test_linkage.py
===================================================================
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -12,7 +12,6 @@
     tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
 extern int external;
 """, lang = 'cpp')
 
@@ -22,8 +21,9 @@
     internal = get_cursor(tu.cursor, 'internal')
     assert internal.linkage == LinkageKind.INTERNAL
 
-    unique_external = get_cursor(tu.cursor, 'unique_external')
-    assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
+    # TODO: find an expression producing unique-external linkage
+    #unique_external = get_cursor(tu.cursor, 'unique_external')
+    #assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
 
     external = get_cursor(tu.cursor, 'external')
     assert external.linkage == LinkageKind.EXTERNAL



Index: bindings/python/tests/cindex/test_linkage.py
===================================================================
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -12,7 +12,6 @@
     tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
 extern int external;
 """, lang = 'cpp')
 
@@ -22,8 +21,9 @@
     internal = get_cursor(tu.cursor, 'internal')
     assert internal.linkage == LinkageKind.INTERNAL
 
-    unique_external = get_cursor(tu.cursor, 'unique_external')
-    assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
+    # TODO: find an expression producing unique-external linkage
+    #unique_external = get_cursor(tu.cursor, 'unique_external')
+    #assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
 
     external = get_cursor(tu.cursor, 'external')
     assert external.linkage == LinkageKind.EXTERNAL

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits