hokein marked an inline comment as done. hokein added inline comments.
================ Comment at: clangd/ClangdServer.cpp:67 + + // Using the handle(SymbolOccurrences) from parent class. + using tooling::RefactoringResultConsumer::handle; ---------------- sammccall wrote: > why is this needed? shouldn't inheriting the base method be enough if it's > only ever called through the base? We need this to make compiler happy, otherwise the compiler will emit "overloaded-virtual" error (the `handle(SymbolOccurrences)` will be hidden in this class). https://reviews.llvm.org/D39676 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
