mstorsjo added a comment.
In https://reviews.llvm.org/D39673#917524, @martell wrote:
> I mostly expect this to be useful where environment has builds all 3 versions
> of the libunwind. where the library is named differently based on the eh
> model.
> e.g. `libunwind-sjlj.a` `libunwind-seh.a` a
MTC added a comment.
ping?
https://reviews.llvm.org/D37187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Tue Nov 7 00:53:37 2017
New Revision: 317552
URL: http://llvm.org/viewvc/llvm-project?rev=317552&view=rev
Log:
Add new check in google module for Objective-C code to ensure global variables
follow the naming convention of Google Objective-C Style Guide
Summary:
This is a ne
Author: sammccall
Date: Tue Nov 7 00:57:54 2017
New Revision: 317553
URL: http://llvm.org/viewvc/llvm-project?rev=317553&view=rev
Log:
[clangd] fix MSVC build errors
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
clang-tools-extra/trunk/clangd/JSONExpr.h
Modified: clang-tools-ext
glandium created this revision.
Herald added a subscriber: kubamracek.
Sufficiently old Linux kernel headers don't provide the PR_SET_PTRACER, but we
can still call prctl with it if the runtime kernel is newer. Even if it's not,
prctl will only return EINVAL.
https://reviews.llvm.org/D39717
F
klimek added a comment.
Weekly ping. This week is C++ committee, so it's again going to be hard to get
Richards attention :( It's an unfortunate time of year to land major
API-touching changes.
https://reviews.llvm.org/D5767
___
cfe-commits mailin
hokein created this revision.
Herald added a subscriber: ilya-biryukov.
Avoid using magic number in the code everywhere.
https://reviews.llvm.org/D39718
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
clangd/Protocol.h
Index: clangd/Protocol.h
jina.nahias created this revision.
https://reviews.llvm.org/D39719
Files:
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
test/CodeGen/avx512bw-builtins.c
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/ClangdUnit.cpp:970
+SourceMgr.getFileEntryForID(SourceMgr.getFileID(LocStart))) {
+ StringRef FilePath = F->tryGetRealPathName(
klimek added a comment.
Sorry for jumping in late, but I'm somewhat questioning whether an extra
function in the API is worth the cost here:
If you already have a printing policy, getting the type name will be 1 line
instead of 2; having an extra function in a large API seems not worth it at a
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Protocol.h:35
+enum class ErrorCodes {
+ // Defined by JSON RPC.
nit: could you call this ErrorCode? The plural doesn't make
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317558: [docs] Add section 'Half-Precision Floating Point'
(authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D35295?vs=121265&id=121854#toc
Repository:
rL LLVM
https://re
Author: sjoerdmeijer
Date: Tue Nov 7 02:09:45 2017
New Revision: 317558
URL: http://llvm.org/viewvc/llvm-project?rev=317558&view=rev
Log:
[docs] Add section 'Half-Precision Floating Point'
This documents the differences/interactions between _Float16 and __fp16
and is a companion change for the _
NoQ updated this revision to Diff 121856.
NoQ added a comment.
A better name for the test function.
https://reviews.llvm.org/D39682
Files:
lib/StaticAnalyzer/Core/ExprEngineC.cpp
test/Analysis/vector.c
Index: test/Analysis/vector.c
=
hokein updated this revision to Diff 121858.
hokein added a comment.
Address review comments:
- ErrorCodes => ErrorCode
- Remove serverErrorStart/serverErrorEnd
https://reviews.llvm.org/D39718
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
cla
tk1012 created this revision.
Herald added a subscriber: klimek.
This fixes unsupporting of importing TypeTraitExpr in ASTImporter.
TypeTraitExpr is caused by "__builtin_types_compatible_p()" that is usually
used in the assertion in C code.
For example, PostgreSQL uses the builtin function in its
djasper accepted this revision.
djasper added a comment.
Looks good. Do you have submit access?
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317559: [clangd] Add ErrorCode enum class. (authored by
hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39718
Files:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/tru
Author: hokein
Date: Tue Nov 7 02:21:02 2017
New Revision: 317559
URL: http://llvm.org/viewvc/llvm-project?rev=317559&view=rev
Log:
[clangd] Add ErrorCode enum class.
Summary: Avoid using magic number in the code everywhere.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryuk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317565: [analyzer] pr34779: CStringChecker: Accept
non-standard headers. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39422?vs=120834&id=121866#toc
Repository:
rL LLVM
Author: dergachev
Date: Tue Nov 7 02:51:15 2017
New Revision: 317565
URL: http://llvm.org/viewvc/llvm-project?rev=317565&view=rev
Log:
[analyzer] pr34779: CStringChecker: Accept non-standard headers.
Do not crash when trying to define and call a non-standard
strcpy(unsigned char *, unsigned char
spetrovic added a comment.
ping
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
This looks like a great addition! Apart from some nits, LGTM.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:487
+
+// result >= constant
+
xazax.hun added a comment.
In https://reviews.llvm.org/D39711#917433, @dcoughlin wrote:
> @xazax.hun Would you be willing to take a look?
Sure, I basically agree with George.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587
if (TrackedType &&
+
RKSimon added inline comments.
Comment at: lib/Headers/avx512bwintrin.h:2045
{
- return (__mmask64) __builtin_ia32_kunpckdi ((__mmask64) __A,
-(__mmask64) __B);
+ return (__mmask64) (( __B & 0x) | ((__mmask64) __A << 32));
}
Is this
Author: xazax
Date: Tue Nov 7 05:17:58 2017
New Revision: 317570
URL: http://llvm.org/viewvc/llvm-project?rev=317570&view=rev
Log:
[clang-tidy] Misc redundant expressions checker updated for macros
Redundant Expression Checker is updated to be able to detect expressions that
contain macros. Also
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317570: [clang-tidy] Misc redundant expressions checker
updated for macros (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D38688?vs=121740&id=121875#toc
Repository:
rL LLVM
h
arichardson added inline comments.
Comment at: test/support/nasty_macros.hpp:55
+#define __output NASTY_MACRO
+#define __input NASTY_MACRO
EricWF wrote:
> Shouldn't these not be defined when running the tests with a CHER compiler?
> Otherwise the macro will co
jkorous-apple created this revision.
Herald added a subscriber: eraman.
It seems like constructor code completion was intentionally disabled ages ago
in this commit (and refactored later):
commit 33224e61bfca370850abae89bbd415a4dabe07fa
Author: Douglas Gregor
Date: Fri Sep 18 17:42:29 2009 +0
mikhail.ramalho added a comment.
Should we keep just the version with the custom printing policy then?
https://reviews.llvm.org/D36610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
Yep, nice and clean~
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:520
+ Result = applyBitwiseConstraints(BV, F, T, Result, Sym);
return Result;
That's more and more "special case"s, i gues
Author: sammccall
Date: Tue Nov 7 06:14:58 2017
New Revision: 317575
URL: http://llvm.org/viewvc/llvm-project?rev=317575&view=rev
Log:
[clangd] another try at fixing MSVC
Modified:
clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/
ioeric updated this revision to Diff 121883.
ioeric added a comment.
- Fix typos.
https://reviews.llvm.org/D39675
Files:
tools/clang-refactor/ClangRefactor.cpp
Index: tools/clang-refactor/ClangRefactor.cpp
===
--- tools/clang-re
xazax.hun updated this revision to Diff 121885.
xazax.hun marked 3 inline comments as done.
xazax.hun added a comment.
- Fix review comments
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/CopyConstructorInitCheck.cpp
clang-tidy/misc/CopyConstructorIn
xazax.hun updated this revision to Diff 121886.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
- Fix doc comments that I overlooked earlier
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/CopyConstructorInitCheck.cpp
clang-tidy
xazax.hun added a comment.
In https://reviews.llvm.org/D33722#916990, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33722#916540, @xazax.hun wrote:
>
> > Also, bugprone might be a better module to put this?
>
>
> I don't have strong opinions on misc vs bugprone (they're both effectively
>
Author: ioeric
Date: Tue Nov 7 06:35:03 2017
New Revision: 317577
URL: http://llvm.org/viewvc/llvm-project?rev=317577&view=rev
Log:
[clang-refactor] Use ClangTool more explicitly by making refaroing actions AST
frontend actions.
Summary: This is a refactoring change. NFC
Reviewers: arphaman, h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317577: [clang-refactor] Use ClangTool more explicitly by
making refaroing actions AST… (authored by ioeric).
Repository:
rL LLVM
https://reviews.llvm.org/D39675
Files:
cfe/trunk/tools/clang-refacto
Author: sammccall
Date: Tue Nov 7 06:45:31 2017
New Revision: 317580
URL: http://llvm.org/viewvc/llvm-project?rev=317580&view=rev
Log:
[clangd] don't crash on invalid JSON-RPC ID
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified: clang-tools-extra/trunk/clangd/JSONRPCD
Author: sammccall
Date: Tue Nov 7 06:59:21 2017
New Revision: 317581
URL: http://llvm.org/viewvc/llvm-project?rev=317581&view=rev
Log:
[clangd] MSVC - third time's the charm
Modified:
clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp
Modified: clang-tools-extra/trunk/unittests/clan
spatel updated this revision to Diff 121898.
spatel added a comment.
Patch updated - no code or functional changes from the last rev.
I split the and test files up, so I can update those
independently and not incur svn conflicts.
https://reviews.llvm.org/D39641
Files:
include/clang/Basic/
jina.nahias updated this revision to Diff 121899.
https://reviews.llvm.org/D39719
Files:
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
test/CodeGen/avx512bw-builtins.c
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
=
jina.nahias added inline comments.
Comment at: lib/Headers/avx512bwintrin.h:2045
{
- return (__mmask64) __builtin_ia32_kunpckdi ((__mmask64) __A,
-(__mmask64) __B);
+ return (__mmask64) (( __B & 0x) | ((__mmask64) __A << 32));
}
RKSi
lsaba added inline comments.
Comment at: lib/Headers/avx512fintrin.h:7207
+ 3 + imm) >> 2) & 0x3) * 4), \
+ 8 + imm) >> 4) & 0x3) * 4), \
+ 9 + imm) >> 4) & 0x3) * 4), \
Author: sammccall
Date: Tue Nov 7 07:49:35 2017
New Revision: 317584
URL: http://llvm.org/viewvc/llvm-project?rev=317584&view=rev
Log:
[clangd] Fix initialize capabilities response
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/test/clangd/initialize
malaperle abandoned this revision.
malaperle added a comment.
Already committed.
Repository:
rL LLVM
https://reviews.llvm.org/D39735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
jina.nahias updated this revision to Diff 121908.
https://reviews.llvm.org/D38672
Files:
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlintrin.h
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512vl-builtins.c
Index: test/CodeGen/avx512vl-builtins.c
=
Author: malaperle
Date: Tue Nov 7 08:16:45 2017
New Revision: 317585
URL: http://llvm.org/viewvc/llvm-project?rev=317585&view=rev
Log:
[clangd] Fix opening declarations located in non-preamble inclusion
Summary:
When an inclusion is not processed as part of the preamble, its path is
not made int
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317585: [clangd] Fix opening declarations located in
non-preamble inclusion (authored by malaperle).
Repository:
rL LLVM
https://reviews.llvm.org/D39705
Files:
clang-tools-extra/trunk/clangd/ClangdU
Author: arnolds
Date: Tue Nov 7 08:40:51 2017
New Revision: 317589
URL: http://llvm.org/viewvc/llvm-project?rev=317589&view=rev
Log:
SystemZ Swift TargetInfo: swifterror support in the backend is broken
Return false for swifterror support until the backend is fixed.
Modified:
cfe/trunk/lib/
erichkeane added a comment.
Also, I should probably validate bitfields. The following SHOULD?! be unique?
struct S {
unsigned a : 1;
unsigned b : 2;
unsigned c : 3;
unsigned d : 2;
};
static_assert(__has_unique_object_representations(S), "error");
But without 'd', it should not be (tail paddin
erichkeane added a comment.
Corrected version of the previous example:
struct S {
char a : 1;
char b : 2;
char c : 3;
char d : 2;
};
static_assert(sizeof(S) == 1, "size");
static_assert(__has_unique_object_representations(S), "error");
I haven't tested this patch agaainst this repro, but it shoul
sammccall created this revision.
Herald added a subscriber: ilya-biryukov.
This is (probably) not required by LSP, but at least one buggy client wants it.
It also simplifies some tests - changed a few completion tests to use -pretty.
https://reviews.llvm.org/D39738
Files:
clangd/ClangdUnit.cp
Author: arphaman
Date: Tue Nov 7 09:29:11 2017
New Revision: 317593
URL: http://llvm.org/viewvc/llvm-project?rev=317593&view=rev
Log:
[index] index field references in __builtin_offset
rdar://35109556
Modified:
cfe/trunk/lib/Index/IndexBody.cpp
cfe/trunk/test/Index/Core/index-source.cpp
kosarev added a comment.
Colleagues, please let me know if there are any concerns about this patch. It
was specifically designed to not cause any substantial changes, but I may be
missing something important. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D39455
___
arphaman added a comment.
This approach doesn't look right. We don't want to code-complete constructors
after the `.`. Instead we want to complete the constructors/destructors in
bodies of classes and in out-of-line declarations after `~`, right?
https://reviews.llvm.org/D39730
grokos created this revision.
grokos added projects: OpenMP, clang.
This patch renames some of the flag names of the clang/libomptarget map
interface. The old names are slightly misleading, whereas the new ones describe
in a better way what each flag is about.
Only the macros within the enumera
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D39745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
sugak added a comment.
@djasper: no, I do not.
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous-apple added a comment.
I agree and it seems to be the case but I will upgrade my ad-hoc testing code
snippet to a proper test as I should have done it in the first place. I also
agree that this change looks really suspicious and I was basically surprised
that it works.
https://reviews
Author: arphaman
Date: Tue Nov 7 10:25:36 2017
New Revision: 317596
URL: http://llvm.org/viewvc/llvm-project?rev=317596&view=rev
Log:
[index] __builtin_offset's field reference is located at the end location
The starting location is the location of the '.'
Modified:
cfe/trunk/lib/Index/Inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317598: Clang/libomptarget map interface flag renaming - NFC
patch (authored by grokos).
Changed prior to commit:
https://reviews.llvm.org/D39745?vs=121928&id=121931#toc
Repository:
rL LLVM
https://
Author: arphaman
Date: Tue Nov 7 10:30:23 2017
New Revision: 317599
URL: http://llvm.org/viewvc/llvm-project?rev=317599&view=rev
Log:
[refactor] rename field references in __builtin_offsetof
rdar://33875453
Added:
cfe/trunk/test/Refactor/LocalRename/BuiltinOffsetof.cpp
Modified:
cfe/tru
Author: grokos
Date: Tue Nov 7 10:27:04 2017
New Revision: 317598
URL: http://llvm.org/viewvc/llvm-project?rev=317598&view=rev
Log:
Clang/libomptarget map interface flag renaming - NFC patch
This patch renames some of the flag names of the clang/libomptarget map
interface. The old names are sli
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
BTW I'm still trying to get caught up, so if there's some review or something
you have in flight that you want me to get to first, just let me know.
https://reviews.llvm.org/D39748
_
dschuff added a comment.
Also btw I still think I want to back out the "long-double-is-f128" ABI from
wasm. But either way it probably doesn't hurt to have these in compiler-rt.
https://reviews.llvm.org/D39748
___
cfe-commits mailing list
cfe-commi
sbc100 added a comment.
I guess if we make that change we can revert this one?
https://reviews.llvm.org/D39748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff added a comment.
Yeah. Or not; I think you can still use `__float128` types in clang, so if you
did that then it would use these methods too. And as long as `long double` is
f64 then none of these functions would get pulled into every program that uses
printf (which is the case now), s
sbc100 added a comment.
My guess was that it was "long-double-is-f128" that was causing clang to
generate references to these symbols, but I wasn't totally sure.. its only
aarch64 and mips64 that seem to require these thus far.
https://reviews.llvm.org/D39748
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317601: [WebAssembly] Include GENERIC_TF_SOURCES in wasm
builds (authored by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D39748
Files:
compiler-rt/trunk/lib/builtins/CMakeLists.txt
Index: c
dschuff added a comment.
Yes; in particular, musl's implementation of printf has some code where it
promotes everything to long double, so if long double is f128, that causes
several of these functions to get linked in to every binary, for no real
benefit to the user.
Repository:
rL LLVM
h
arphaman created this revision.
The commit r300140 changed the implementation of __compressed_pair, but didn't
add _LIBCPP_INLINE_VISIBILITY to the constructors and `get` members of the
__compressed_pair_elem class. This patch adds the visibility annotation.
I'm not sure how to test this (and i
hokein updated this revision to Diff 121941.
hokein added a comment.
- remove USRRenameRule
- rebase to master
https://reviews.llvm.org/D39332
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
lib/Tooling/Refactoring/RefactoringActions.cpp
lib/Tooling/Refactoring/Rename/Ren
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101
+ std::string NewQualifiedName) {
+ return QualifiedRenameRule(std::move(OldQualifiedName),
+
Author: tmsriram
Date: Tue Nov 7 11:37:51 2017
New Revision: 317605
URL: http://llvm.org/viewvc/llvm-project?rev=317605&view=rev
Log:
New clang option -fno-plt which avoids the PLT and lazy binding while making
external calls.
Differential Revision: https://reviews.llvm.org/D39079
Added:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317605: New clang option -fno-plt which avoids the PLT and
lazy binding while making… (authored by tmsriram).
Changed prior to commit:
https://reviews.llvm.org/D39079?vs=119950&id=121947#toc
Repository
spatel updated this revision to Diff 121949.
spatel retitled this revision from "[CodeGen] make cbrt and fma constant (never
set errno); document complex calls as always constant" to "[CodeGen] change
const-ness of complex calls".
spatel edited the summary of this revision.
spatel added a comment
Hello Sam,
It looks like this commit broke the builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13313
. . .
FAILED:
tools/clang/tools/extra/unittests/clangd/CMakeFiles/ClangdTests.dir/JSONExprTests.cpp.obj
Please have a look?
Thanks
Galina
On
Author: ericwf
Date: Tue Nov 7 12:20:58 2017
New Revision: 317610
URL: http://llvm.org/viewvc/llvm-project?rev=317610&view=rev
Log:
Change test suite to support c++17 dialect flag instead of c++1z.
This patch changes the test suite to attempt and prefer -std=c++17 over
-std=c++1z. It also fixes
Author: ericwf
Date: Tue Nov 7 12:26:23 2017
New Revision: 317611
URL: http://llvm.org/viewvc/llvm-project?rev=317611&view=rev
Log:
Teach test suite about C++2a dialect flag.
This patch teaches the test suite configuration about the -std=c++2a
flag. And, since it's the newest dialect, change the
Author: arphaman
Date: Tue Nov 7 13:40:11 2017
New Revision: 317620
URL: http://llvm.org/viewvc/llvm-project?rev=317620&view=rev
Log:
[ObjC++] Don't warn about pessimizing move for __block variables
rdar://33316951
Added:
cfe/trunk/test/SemaObjCXX/block-variable-move.mm
Modified:
cfe/tr
tmsriram created this revision.
https://reviews.llvm.org/D39079 breaks noplt.c for non-x86 targets. Remove x86
specific code from noplt.c
https://reviews.llvm.org/D39759
Files:
test/CodeGen/noplt.c
Index: test/CodeGen/noplt.c
===
glandium updated this revision to Diff 121983.
glandium added a comment.
Updated wording.
https://reviews.llvm.org/D39717
Files:
lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc
Index: lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc
=
Author: jlebar
Date: Tue Nov 7 14:10:54 2017
New Revision: 317623
URL: http://llvm.org/viewvc/llvm-project?rev=317623&view=rev
Log:
[NVPTX] Implement __nvvm_atom_add_gen_d builtin.
Summary:
This just seems to have been an oversight. We already supported the f64
atomic add with an explicit scope
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317623: [NVPTX] Implement __nvvm_atom_add_gen_d builtin.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D39638?vs=121620&id=121984#toc
Repository:
rL LLVM
https://reviews.ll
arphaman created this revision.
Objective-C NSString has a class method `stringWithUTF8String` that creates a
new NSString from a C string. Objective-C box expression `@(...)` can be used
to create an NSString instead of invoking the `stringWithUTF8String` method
directly (The compiler lowers i
cameron314 added a comment.
I'll rebase the patch and add a test. Thanks for looking at this!
Repository:
rL LLVM
https://reviews.llvm.org/D20124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tmsriram added a comment.
More information here. This breaks non-x86 builds like PPC because:
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/CodeGen/noplt.c:4:22:
error: expected string not found in input
// CHECK-NOPLT-NEXT: declare i32 @foo
^
:14:1: note: scanning
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587
if (TrackedType &&
+ !isa(CE) &&
!ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) &&
xazax.hun wrote:
> george.karpenkov wrote:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Please search for `declare {{.*}}i32 @foo`, and then commit. Otherwise this
could match `call i32 @foo` or something like that.
https://reviews.llvm.org/D39759
__
Author: tmsriram
Date: Tue Nov 7 14:34:55 2017
New Revision: 317627
URL: http://llvm.org/viewvc/llvm-project?rev=317627&view=rev
Log:
Change noplt.c to work for non-x86 targets.
Differential Revision: https://reviews.llvm.org/D39759
Modified:
cfe/trunk/test/CodeGen/noplt.c
Modified: cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317627: Change noplt.c to work for non-x86 targets.
(authored by tmsriram).
Changed prior to commit:
https://reviews.llvm.org/D39759?vs=121977&id=121987#toc
Repository:
rL LLVM
https://reviews.llvm.
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:205
+
+ if (!(H.contents[0].codeBlockLanguage == "" &&
+H.contents[0].markdownString == "" &&
Author: hctim
Date: Tue Nov 7 13:16:37 2017
New Revision: 317616
URL: http://llvm.org/viewvc/llvm-project?rev=317616&view=rev
Log:
Update SanitizerSpecialCaseList to use renamed functions in base class.
Note: This change has a cyclical dependency on D39485. Both these changes must
be submitted
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
dcoughlin accepted this revision.
dcoughlin added a comment.
Interesting bug! The workaround looks good to me.
https://reviews.llvm.org/D39682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
mgorny added a comment.
The diffs aren't very useful since I had to add a class for each test unit and
so everything needed reindenting. You can take my word that changes boil down
to:
- adding `unittest` import,
- adding class for each test unit and converting the functions into methods
(exce
mgorny added a comment.
Before:
==
FAIL: tests.cindex.test_code_completion.test_code_complete_availability
--
Traceback (most recent call last):
File
hfinkel added a comment.
In https://reviews.llvm.org/D39611#918275, @spatel wrote:
> Patch updated:
> I don't know if we have agreement on the behavior that we want yet,
I just sent a note to the Austin group mailing list to see if the POSIX folks
agree with my reading. I'll follow up.
> but
1 - 100 of 113 matches
Mail list logo
