xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land.
This looks like a great addition! Apart from some nits, LGTM. ================ Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:487 + + // result >= constant + return Result.Intersect(BV, F, SIE->getRHS(), BV.getMaxValue(T)); ---------------- Comments should be sentences (start with capital letter and have a period). ================ Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:498 + return Result; + +} ---------------- This new line is redundant. Also, there are way more new lines in this method than there usually are in LLVM. https://reviews.llvm.org/D39707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
