sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clangd/ClangdUnit.cpp:970
+ SourceMgr.getFileEntryForID(SourceMgr.getFileID(LocStart))) {
+ StringRef FilePath = F->tryGetRealPathName();
+ if (FilePath.empty())
----------------
Can you add a comment about when this is needed?
like // Non-preamble included files may have relative paths.
Repository:
rL LLVM
https://reviews.llvm.org/D39705
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
