[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling

2017-11-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: src/Registers.hpp:1481 + mutable uint32_t _iwmmx_control[4]; #endif }; compnerd wrote: > Why the change to mark these as mutable? These are touched from within `getRegister`, but we need to make `getRegister` const

[libunwind] r317192 - Fix building for ARM with dwarf exception handling

2017-11-02 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Thu Nov 2 01:16:16 2017 New Revision: 317192 URL: http://llvm.org/viewvc/llvm-project?rev=317192&view=rev Log: Fix building for ARM with dwarf exception handling The previous definition of _LIBUNWIND_HIGHEST_DWARF_REGISTER seems to be a copy of the ARM64 value (introduced

[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling

2017-11-02 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317192: Fix building for ARM with dwarf exception handling (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D39251?vs=120863&id=121242#toc Repository: rL LLVM https://review

[PATCH] D39441: [refactor][extract] insert semicolons into extracted/inserted code when needed

2017-11-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Code looks good with some nits. Comment at: lib/Tooling/Refactoring/CMakeLists.txt:7 AtomicChange.cpp Extract.cpp + SourceExtraction.cpp Shall we move function extraction sources into a sub-directory? Like what you did for header

[PATCH] D39533: [MinGW] Define __ARM_DWARF_EH__ on MinGW/ARM

2017-11-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. This should go together with https://reviews.llvm.org/D39532 in LLVM. https://reviews.llvm.org/D39533 Files: lib/Basic/Targets/ARM.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c =

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

2017-11-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. Herald added subscribers: kristof.beyls, aprantl, aemerson. This allows using dwarf exceptions on MinGW/ARM. This goes together with https://reviews.llvm.org/D39532 in LLVM and https://reviews.llvm.org/D39533 in clang. https://reviews.llvm.org/D39534 Files: d

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 121247. sammccall added a comment. Provide RAII-like interface to trace functionality. Note that we may want to provide a backend API here. https://reviews.llvm.org/D39086 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUnit.cpp

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. still lgtm Comment at: clangd/Trace.h:38 + // Starts a sessions capturing trace events and writing Trace Event JSON. + static std::unique_ptr createJSON(llvm::raw_ostream &OS); + ~Session(); `createJSON`

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 121252. sammccall marked an inline comment as done. sammccall added a comment. createJSON -> create https://reviews.llvm.org/D39086 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/JSONRPCDispatcher.cpp clangd/Pr

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/Trace.h:38 + // Starts a sessions capturing trace events and writing Trace Event JSON. + static std::unique_ptr createJSON(llvm::raw_ostream &OS); + ~Session(); ioeric wrote: > `createJSON` is a bit confusing

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 121253. sammccall added a comment. clang-format https://reviews.llvm.org/D39086 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/JSONRPCDispatcher.cpp clangd/ProtocolHandlers.cpp clangd/Trace.cpp clangd/Trace

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

2017-11-02 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added a comment. I spotted two typos. :) Also, the commit message needs to be updated. Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:61 + StringRef getDescription() const override { +return "The new qualified to chagne the symbol to"; + }

[PATCH] D39537: Rename identifiers named `__output`

2017-11-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. In the CHERI clang compiler __output and __input are keywords and therefore we can't compile libc++ with our compiler. Repository: rL LLVM https://reviews.llvm.org/D39537 Files: include/algorithm include/experimental/algorithm include/experimental/ite

[clang-tools-extra] r317193 - Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 2 02:21:51 2017 New Revision: 317193 URL: http://llvm.org/viewvc/llvm-project?rev=317193&view=rev Log: Performance tracing facility for clangd. Summary: This lets you visualize clangd's activity on different threads over time, and understand critical paths of requ

[PATCH] D39086: Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317193: Performance tracing facility for clangd. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D39086?vs=121253&id=121257#toc Repository: rL LLVM https://reviews.llvm.or

[clang-tools-extra] r317194 - Fix clangd test on platforms where get_thread_name does nothing.

2017-11-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 2 02:48:55 2017 New Revision: 317194 URL: http://llvm.org/viewvc/llvm-project?rev=317194&view=rev Log: Fix clangd test on platforms where get_thread_name does nothing. Modified: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp Modified: clang-tools-ext

[PATCH] D35295: [docs] Add section 'Half-Precision Floating Point'

2017-11-02 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham added inline comments. Comment at: docs/LanguageExtensions.rst:462 +``__fp16`` is a ARM C-Language Extension (ACLE) and ``_Float16`` is defined by +the C standards committee, which should help portability between entire +architectures. Also, ``_Float16`` arithmetic a

[PATCH] D35295: [docs] Add section 'Half-Precision Floating Point'

2017-11-02 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer updated this revision to Diff 121265. SjoerdMeijer added a comment. Many thanks for the reviews and suggestions! Comments addressed. https://reviews.llvm.org/D35295 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst ===

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

2017-11-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 121266. hokein marked 3 inline comments as done. hokein added a comment. - add USRRenameRule interface. - fix typos. https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h lib/Tooling/Refactoring/RefactoringActio

[PATCH] D35295: [docs] Add section 'Half-Precision Floating Point'

2017-11-02 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM now, thanks! (But other reviewers may still want to comment.) https://reviews.llvm.org/D35295 ___ cfe-commits mailing list cfe-c

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

2017-11-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: lib/Analysis/BodyFarm.cpp:415 CallbackRecordDecl, CallArgs); - } else { + } else if (Callback->getType()->isRValueReferenceType() + || Callback->getType()->isLValueReferenceType()

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

2017-11-02 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + rjmccall wrote: > The way you've written this makes it sound l

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. Herald added subscribers: szepet, baloghadamsoftware, whisperity. Add documentation to the recently added issue hash dumping function. Repository: rL LLVM https://reviews.llvm.org/D39543 Files: docs/analyzer/DebugChecks.rst Index: docs/analyzer/DebugCheck

[PATCH] D38844: [analyzer] Make issue hash related tests more concise

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D38844#911735, @NoQ wrote: > Hey, i just recalled that we have documentation for `ExprInspection` > functions in `docs/analyzer/DebugChecks.rst`, you may want to add your > function there as well :) Indeed, thanks for pointing this out! T

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

2017-11-02 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added inline comments. Comment at: docs/analyzer/DebugChecks.rst:247 + + The analyzer can generate a hash to identify repots. To debug what information + is used to calculate this hash it is possible to dump the hashed string to typo `reports`? Repos

r317200 - Fix typo in class annotation

2017-11-02 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Nov 2 05:15:51 2017 New Revision: 317200 URL: http://llvm.org/viewvc/llvm-project?rev=317200&view=rev Log: Fix typo in class annotation Modified: cfe/trunk/include/clang/AST/NestedNameSpecifier.h Modified: cfe/trunk/include/clang/AST/NestedNameSpecifier.h URL: htt

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

2017-11-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yup, thanks! Comment at: docs/analyzer/DebugChecks.rst:255 + int x = 1; + clang_analyzer_hashDump(x); // Hashed string of x on stderr. +} Unlike `printState` and like all other functions, your function doesn't dump to plain s

r317205 - Fix clang-format CLion integration bug.

2017-11-02 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Nov 2 05:48:48 2017 New Revision: 317205 URL: http://llvm.org/viewvc/llvm-project?rev=317205&view=rev Log: Fix clang-format CLion integration bug. CLion's Sax parser threw this error: Failed to parse clang-format XML replacements. Input: [...] [org.xml.sax.SAXParseExc

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 121290. xazax.hun marked 2 inline comments as done. https://reviews.llvm.org/D39543 Files: docs/analyzer/DebugChecks.rst Index: docs/analyzer/DebugChecks.rst === --- docs/analyzer/DebugChec

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: docs/analyzer/DebugChecks.rst:255 + int x = 1; + clang_analyzer_hashDump(x); // Hashed string of x on stderr. +} NoQ wrote: > Unlike `printState` and like all other functions, your function doesn't dump

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

2017-11-02 Thread Tamas Berghammer via Phabricator via cfe-commits
tberghammer added a comment. In https://reviews.llvm.org/D39239#911696, @CarlosAlbertoEnciso wrote: > Hi Tamas, > > Thanks very much for your message. > > In https://reviews.llvm.org/D39239#910797, @tberghammer wrote: > > > - Can you do a diff of the debug_info dump before and after your change?

r317207 - [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base

2017-11-02 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Thu Nov 2 06:30:42 2017 New Revision: 317207 URL: http://llvm.org/viewvc/llvm-project?rev=317207&view=rev Log: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base We can generate constant sized arrays whenever the array section has constant length, even

[PATCH] D39504: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base

2017-11-02 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317207: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D39504?vs=121169&id=121297#toc Repository: rL

Patch to fix Format's FixNamespaceComments for Objective-C++ files

2017-11-02 Thread Vasyl Smyrnov via cfe-commits
Hi, I’ve noticed that clang-format does not respect the "FixNamespaceComments: true” option if an Objective-C++ file is formatted by feeding a .mm file to clang-format, however the option is respected with the same source code supplied via stdin. The attached patch fixes the problem (based on

(Take 2) Patch to fix Format's FixNamespaceComments for Objective-C++ files

2017-11-02 Thread Vasyl Smyrnov via cfe-commits
(Take 2, with the correct patch.diff - originally used "svn st" instead of “svn diff") Hi, I’ve noticed that clang-format does not respect the "FixNamespaceComments: true” option if an Objective-C++ file is formatted by feeding a .mm file to clang-format, however the option is respected with t

r317208 - [OPENMP] Fix PR35156: Get correct thread id with windows exceptions.

2017-11-02 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Nov 2 07:25:34 2017 New Revision: 317208 URL: http://llvm.org/viewvc/llvm-project?rev=317208&view=rev Log: [OPENMP] Fix PR35156: Get correct thread id with windows exceptions. If the thread id is requested in windows mode within funclets, we may generate incorrect funct

[PATCH] D39551: [analyzer] Make __builtin_debugtrap() a sink

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. Herald added subscribers: szepet, baloghadamsoftware, whisperity. For some reason, `__builtin_debugtrap` is not a sink for the analyzer. I also added some test cases to demonstrate that `__builtin_trap` and `__builtin_unreachable` are handled properly. The former

[libcxx] r317209 - Mark Endian as 'in progress'

2017-11-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Nov 2 07:53:08 2017 New Revision: 317209 URL: http://llvm.org/viewvc/llvm-project?rev=317209&view=rev Log: Mark Endian as 'in progress' Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D38362: Mark tests as unsupported in C++98 as well

2017-11-02 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D39551: [analyzer] Make __builtin_debugtrap() a sink

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In the meantime, I found this discussion: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20121015/153735.html It looks like the reasoning behind this intrinsic not being noreturn is that the user might continue the execution in the debugger. I think the main

[PATCH] D38362: Mark tests as unsupported in C++98 as well

2017-11-02 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317210: Mark tests as unsupported in C++98 as well (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38362?vs=118005&id=121310#toc Repository: rL LLVM https://reviews.llvm.o

[libcxx] r317210 - Mark tests as unsupported in C++98 as well

2017-11-02 Thread Roger Ferrer Ibanez via cfe-commits
Author: rogfer01 Date: Thu Nov 2 08:01:43 2017 New Revision: 317210 URL: http://llvm.org/viewvc/llvm-project?rev=317210&view=rev Log: Mark tests as unsupported in C++98 as well Differential Revision: https://reviews.llvm.org/D38362 Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/exp

[PATCH] D38362: Mark tests as unsupported in C++98 as well

2017-11-02 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Thank you @mclow.lists ! Repository: rL LLVM https://reviews.llvm.org/D38362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r317212 - Change a bunch of comments from C++1z to C++17. NFC

2017-11-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Nov 2 08:03:25 2017 New Revision: 317212 URL: http://llvm.org/viewvc/llvm-project?rev=317212&view=rev Log: Change a bunch of comments from C++1z to C++17. NFC Modified: libcxx/trunk/test/libcxx/selftest/test_macros.pass.cpp libcxx/trunk/test/std/depr/depr.func

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:382 +DescFile<"CheckSecuritySyntaxOnly.cpp">; + def DeprecatedBufferHandling : Checker<"DeprecatedBufferHandling">, +HelpText<"Warn on uses of deprecated buffer manipulating fu

[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

2017-11-02 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:41 +static const llvm::StringSet<> KnownBannedMacroNames = {"EAGAIN", "EWOULDBLOCK", + "SIGCLD", "SIGCHLD"}; Is this

[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

2017-11-02 Thread Barancsuk Lilla via Phabricator via cfe-commits
barancsuk updated this revision to Diff 121323. barancsuk added a comment. Fix shifted line https://reviews.llvm.org/D38688 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h docs/clang-tidy/checks/misc-redundant-expression.rst test/clang-tidy

[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

2017-11-02 Thread Barancsuk Lilla via Phabricator via cfe-commits
barancsuk added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:41 +static const llvm::StringSet<> KnownBannedMacroNames = {"EAGAIN", "EWOULDBLOCK", + "SIGCLD", "SIGCHLD"}; xazax.hu

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

2017-11-02 Thread Kuba (Brecka) Mracek via Phabricator via cfe-commits
kubamracek accepted this revision. kubamracek added a comment. This revision is now accepted and ready to land. Hi and sorry for replying so late! All of the changes LGTM with a few nits. > Assembly for Darwin x86_64 and how we avoid the ELF'isms (do we need to > implement darwin-specific assemb

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

2017-11-02 Thread Kuba (Brecka) Mracek via Phabricator via cfe-commits
kubamracek added a comment. Also, please make sure this builds and tests pass before actually landing this patch. FYI, there are bots that run on older macOS versions (10.11 for sure, probably even older). https://reviews.llvm.org/D39114 ___ cfe-c

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

2017-11-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --

r317216 - Fix comment typo

2017-11-02 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Nov 2 09:37:00 2017 New Revision: 317216 URL: http://llvm.org/viewvc/llvm-project?rev=317216&view=rev Log: Fix comment typo Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

r317220 - [CodeGen] add builtin attr tests to show errno-related diffs; NFC

2017-11-02 Thread Sanjay Patel via cfe-commits
Author: spatel Date: Thu Nov 2 10:06:05 2017 New Revision: 317220 URL: http://llvm.org/viewvc/llvm-project?rev=317220&view=rev Log: [CodeGen] add builtin attr tests to show errno-related diffs; NFC Added: cfe/trunk/test/CodeGen/builtin-errno.c Added: cfe/trunk/test/CodeGen/builtin-errno.c U

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. There's an oddity with fma. The version without __builtin has 'e' already LIBBUILTIN(fma, "", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(fmaf, "", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(fmal, "LdLdLdLd", "fne", "math.h", ALL_LANGUAGES) But we don't

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

2017-11-02 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state. https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@

[PATCH] D39430: [clangd] formatting: don't ignore style

2017-11-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks for this! Comment at: clangd/ClangdLSPServer.cpp:93 +void ClangdLSPServer::replyWithTextEditsOrError( +Ctx C, std::string Code, This function is pretty hard to understand from a high level - it's a bit of an odd split.

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-02 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > But we don't check the const attribute in CGBuiltin.cpp before converting it > to an intrinsic In practice, fma() implementations don't set errno (at least, glibc and msvcrt don't). And people would be really annoyed if we forced them to use fast-math flags to gene

r317224 - [refactor][selection] canonicalize selected string literal to objc

2017-11-02 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Nov 2 11:05:48 2017 New Revision: 317224 URL: http://llvm.org/viewvc/llvm-project?rev=317224&view=rev Log: [refactor][selection] canonicalize selected string literal to objc string literal when possible Modified: cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cpp

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-02 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D39481#914174, @craig.topper wrote: > There's an oddity with fma. The version without __builtin has 'e' already Something that is potentially relevant: POSIX says that fma() can set errno (http://pubs.opengroup.org/onlinepubs/9699919799/func

[PATCH] D39441: [refactor][extract] insert semicolons into extracted/inserted code when needed

2017-11-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 121339. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D39441 Files: include/clang/Lex/Lexer.h lib/Lex/Lexer.cpp lib/Tooling/Refactoring/CMakeLists.txt li

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

2017-11-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName));

r317227 - [OPENMP] Fix PR35152: Do not use getInvokeDest() function for EH checks.

2017-11-02 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Nov 2 11:55:05 2017 New Revision: 317227 URL: http://llvm.org/viewvc/llvm-project?rev=317227&view=rev Log: [OPENMP] Fix PR35152: Do not use getInvokeDest() function for EH checks. The compiler may crash under some conditions if the getInvokeDest() is used, but later it

r317228 - remove unused function from ObjCRuntime.h, NFC

2017-11-02 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Nov 2 12:01:34 2017 New Revision: 317228 URL: http://llvm.org/viewvc/llvm-project?rev=317228&view=rev Log: remove unused function from ObjCRuntime.h, NFC Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h UR

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-02 Thread Sanjay Patel via Phabricator via cfe-commits
spatel updated this revision to Diff 121344. spatel added a comment. Patch updated: Make const-ness of the builtins match const-ness of their lib function siblings. We're deferring fixing some of these that are obviously wrong to follow-up patches. Hopefully, the bugs are visible in the new test

r317231 - revert r317228: remove unused function from ObjCRuntime.h, NFC

2017-11-02 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Nov 2 12:42:40 2017 New Revision: 317231 URL: http://llvm.org/viewvc/llvm-project?rev=317231&view=rev Log: revert r317228: remove unused function from ObjCRuntime.h, NFC This function is actually used in LLDB Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2017-11-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. Herald added subscribers: kristof.beyls, aemerson. The assertion failure occurs when a setter is called using the dot syntax to set a property of a class type that doesn't have trivial copy/move constructors or assignment operators. It happens only when clang is c

[PATCH] D39210: Add default calling convention support for regcall.

2017-11-02 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews added a comment. *ping* https://reviews.llvm.org/D39210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r317232 - acos: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:06 2017 New Revision: 317232 URL: http://llvm.org/viewvc/llvm-project?rev=317232&view=rev Log: acos: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acos.inc M

[libclc] r317233 - acosh: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:11 2017 New Revision: 317233 URL: http://llvm.org/viewvc/llvm-project?rev=317233&view=rev Log: acosh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acosh.inc

[libclc] r317239 - atanh: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:22 2017 New Revision: 317239 URL: http://llvm.org/viewvc/llvm-project?rev=317239&view=rev Log: atanh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atanh.inc

[libclc] r317236 - asinh: Use unary_dec instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:16 2017 New Revision: 317236 URL: http://llvm.org/viewvc/llvm-project?rev=317236&view=rev Log: asinh: Use unary_dec instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asinh.inc

[libclc] r317238 - atan: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:20 2017 New Revision: 317238 URL: http://llvm.org/viewvc/llvm-project?rev=317238&view=rev Log: atan: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atan.inc M

[libclc] r317235 - asin: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:15 2017 New Revision: 317235 URL: http://llvm.org/viewvc/llvm-project?rev=317235&view=rev Log: asin: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asin.inc M

[libclc] r317237 - asinpi: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:18 2017 New Revision: 317237 URL: http://llvm.org/viewvc/llvm-project?rev=317237&view=rev Log: asinpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asinpi.i

[libclc] r317241 - cbrt: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:25 2017 New Revision: 317241 URL: http://llvm.org/viewvc/llvm-project?rev=317241&view=rev Log: cbrt: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cbrt.inc M

[libclc] r317234 - acospi: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:13 2017 New Revision: 317234 URL: http://llvm.org/viewvc/llvm-project?rev=317234&view=rev Log: acospi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acospi.i

[libclc] r317240 - atanpi: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:23 2017 New Revision: 317240 URL: http://llvm.org/viewvc/llvm-project?rev=317240&view=rev Log: atanpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atanpi.i

[libclc] r317244 - cospi: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:31 2017 New Revision: 317244 URL: http://llvm.org/viewvc/llvm-project?rev=317244&view=rev Log: cospi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cospi.inc

[libclc] r317243 - cosh: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:30 2017 New Revision: 317243 URL: http://llvm.org/viewvc/llvm-project?rev=317243&view=rev Log: cosh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cosh.inc M

[libclc] r317245 - exp2: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:33 2017 New Revision: 317245 URL: http://llvm.org/viewvc/llvm-project?rev=317245&view=rev Log: exp2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/exp2.inc M

[libclc] r317242 - cos: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:27 2017 New Revision: 317242 URL: http://llvm.org/viewvc/llvm-project?rev=317242&view=rev Log: cos: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cos.inc Mod

[libclc] r317247 - log1p: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:37 2017 New Revision: 317247 URL: http://llvm.org/viewvc/llvm-project?rev=317247&view=rev Log: log1p: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log1p.inc

[libclc] r317248 - log2: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:39 2017 New Revision: 317248 URL: http://llvm.org/viewvc/llvm-project?rev=317248&view=rev Log: log2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log2.inc M

[libclc] r317246 - lgamma: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:35 2017 New Revision: 317246 URL: http://llvm.org/viewvc/llvm-project?rev=317246&view=rev Log: lgamma: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/lgamma.i

[libclc] r317250 - log: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:43 2017 New Revision: 317250 URL: http://llvm.org/viewvc/llvm-project?rev=317250&view=rev Log: log: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log.inc Mod

[libclc] r317249 - logb: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:41 2017 New Revision: 317249 URL: http://llvm.org/viewvc/llvm-project?rev=317249&view=rev Log: logb: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/logb.inc M

[libclc] r317251 - native_log10: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:44 2017 New Revision: 317251 URL: http://llvm.org/viewvc/llvm-project?rev=317251&view=rev Log: native_log10: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/na

[libclc] r317253 - native_log: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:48 2017 New Revision: 317253 URL: http://llvm.org/viewvc/llvm-project?rev=317253&view=rev Log: native_log: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/nati

[libclc] r317254 - sin: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:50 2017 New Revision: 317254 URL: http://llvm.org/viewvc/llvm-project?rev=317254&view=rev Log: sin: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sin.inc Mod

[libclc] r317255 - sinh: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:51 2017 New Revision: 317255 URL: http://llvm.org/viewvc/llvm-project?rev=317255&view=rev Log: sinh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sinh.inc M

[libclc] r317252 - native_log2: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:46 2017 New Revision: 317252 URL: http://llvm.org/viewvc/llvm-project?rev=317252&view=rev Log: native_log2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/nat

[libclc] r317258 - tan: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:57 2017 New Revision: 317258 URL: http://llvm.org/viewvc/llvm-project?rev=317258&view=rev Log: tan: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tan.inc Mod

[libclc] r317256 - sinpi: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:53 2017 New Revision: 317256 URL: http://llvm.org/viewvc/llvm-project?rev=317256&view=rev Log: sinpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sinpi.inc

[libclc] r317257 - sqrt: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:55 2017 New Revision: 317257 URL: http://llvm.org/viewvc/llvm-project?rev=317257&view=rev Log: sqrt: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sqrt.inc M

[libclc] r317260 - tgamma: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:49:00 2017 New Revision: 317260 URL: http://llvm.org/viewvc/llvm-project?rev=317260&view=rev Log: tgamma: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tgamma.i

[libclc] r317259 - tanh: Use unary_decl instead of custom inc file

2017-11-02 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Thu Nov 2 12:48:58 2017 New Revision: 317259 URL: http://llvm.org/viewvc/llvm-project?rev=317259&view=rev Log: tanh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tanh.inc M

[clang-tools-extra] r317261 - Update release notes (check SVN commit-after-approval access)

2017-11-02 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Thu Nov 2 13:00:17 2017 New Revision: 317261 URL: http://llvm.org/viewvc/llvm-project?rev=317261&view=rev Log: Update release notes (check SVN commit-after-approval access) Summary: I was just granted commit-after-approval access to SVN, and @clattner recommended I try

[PATCH] D39210: Add default calling convention support for regcall.

2017-11-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay. https://reviews.llvm.org/D39210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D39551: [analyzer] Make __builtin_debugtrap() a sink

2017-11-02 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. I believe that the intent of `__builtin_debugtrap()` is to provide an in-source mechanism so that the developer can trap into the debugger and then continue execution. For example, in the Swift codebase this is used in combination with a debug flag to break into the d

  1   2   >