simon_tatham added inline comments.

================
Comment at: docs/LanguageExtensions.rst:462
+``__fp16`` is a ARM C-Language Extension (ACLE) and ``_Float16`` is defined by
+the C standards committee, which should help portability between entire
+architectures. Also, ``_Float16`` arithmetic and operations will directly map
----------------
Sorry to nitpick a second time, but I think the phrase "entire architectures" 
is a bit strange here. I know it's the same phrase I actually *wrote* in my 
last review comment, but I was being a bit informal, and also explicitly 
contrasting with "versions of the Arm architecture" in the same sentence, to 
distinguish (say) "port between Arm and x86" from "port between ArmThis and 
ArmThat". Out of context it doesn't seem quite idiomatic or quite clear to me, 
so sorry to have accidentally suggested it!

How about something like this as alternative wording:

  ``__fp16`` is an ARM C-Language Extension (ACLE), whereas ``_Float16`` is 
defined by the C standards committee, so using ``_Float16`` will not prevent 
code from being ported to architectures other than Arm.


https://reviews.llvm.org/D35295



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to