ioeric accepted this revision. ioeric added a comment. still lgtm
================ Comment at: clangd/Trace.h:38 + // Starts a sessions capturing trace events and writing Trace Event JSON. + static std::unique_ptr<Session> createJSON(llvm::raw_ostream &OS); + ~Session(); ---------------- `createJSON` is a bit confusing... maybe just `create` since json is just the underlying representation which users don't have to know about? https://reviews.llvm.org/D39086 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
