arphaman added a comment.
That would be nice. Temporary checkouts are a way to solve the problem. But
they might not work for all projects, like when some translation unit includes
a file that's not in git using a relative path.
Another solution is to use virtual file systems. A custom vfs coul
teemperor added a comment.
Very well done, I really like this patch! I added a few remarks mostly about
the comments that need some small adjusting.
I'm wondering what would be a nice way of creating a StmtDataCollector that is
faster but only works for single translation units (e.g. it only ha
Author: svenvh
Date: Tue Aug 15 02:38:18 2017
New Revision: 310911
URL: http://llvm.org/viewvc/llvm-project?rev=310911&view=rev
Log:
[OpenCL] Allow targets to select address space per type
Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such
that targets can select the address spa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310911: [OpenCL] Allow targets to select address space per
type (authored by svenvh).
Changed prior to commit:
https://reviews.llvm.org/D33989?vs=110947&id=37#toc
Repository:
rL LLVM
https://rev
arphaman added a subscriber: rsmith.
arphaman added a comment.
In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about
> the comments that need some small adjusting.
>
> I'm wondering what would be a nice way of
SjoerdMeijer added a comment.
Ping
https://reviews.llvm.org/D33719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samparker created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.
This patch introduces support for Cortex-A75 and Cortex-A55, Arm's latest
big.LITTLE A-class cores. They implement the ARMv8.2-A architecture, including
the cryptography and RAS extensions,
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D36670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
xazax.hun added inline comments.
Comment at: test/clang-tidy/misc-misplaced-widening-cast-explicit-only.cpp:63
+ enum Type {};
+ static char *m_fn1() { char p = (Type)(&p - m_fn1()); }
+};
Isn't this testcase a bit overcomplicated to demonstrate the issue?
Re
mzeren-vmw added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2281
TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) {
verifyFormat("#define A \\\n"
mzeren-vmw wrote:
> Experimenting with the patch locally I found that comme
edward-jones added a comment.
No, this doesn't seem to have been committed yet.
https://reviews.llvm.org/D24461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue Aug 15 05:40:01 2017
New Revision: 310916
URL: http://llvm.org/viewvc/llvm-project?rev=310916&view=rev
Log:
[Sema] Silence -Wobjc-missing-property-synthesis for unavailable properties
rdar://30296911
Modified:
cfe/trunk/lib/Sema/SemaObjCProperty.cpp
cfe/trunk/t
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D36715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
NoQ marked an inline comment as done.
NoQ added a comment.
We've discussed it in person with Devin, and he provided more points to think
about:
- If the initializer list consists of non-POD data, constructors of list's
objects need to take the sub-region of the list's region as `this`-region In
NoQ updated this revision to Diff 56.
NoQ added a comment.
Actually update the diff.
https://reviews.llvm.org/D35216
Files:
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/initializer.cpp
Index: test/Analysis/initializer.cpp
NoQ created this revision.
Because i tend to raise important design questions in weird places like tiny
phabricator patches, we had a thought that it's better to archive them in
`docs/analyzer` for future reference. We should be able to pick them up
whenever time comes to solve these problems.
xazax.hun added a comment.
Good idea!
I think some of your extremely helpful responses from the mailing list would
worth archiving in a form of documentation as well.
Also, as far as I can recall, you are also maintaining a pdf which is a very
good reference. In some form, I would love to see t
sdardis requested changes to this revision.
sdardis added a reviewer: kparzysz.
sdardis added a comment.
This revision now requires changes to proceed.
+kparzysz as Hexagon also makes use of the small data section.
Comment at: docs/LangRef.rst:629
+corresponding to the LLVM mod
bcraig added a comment.
The test headers should not be in the production include folder. They should
probably be in the benchmark folder.
If possible, follow the style and conventions of the existing tests. When you
can't follow the style and convention of the existing tests, try to make it
yaxunl updated this revision to Diff 60.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D36580
Files:
include/clang/AST/Expr.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/SyncScope.h
lib/AST/Ex
kparzysz added inline comments.
Comment at: docs/LangRef.rst:629
+corresponding to the LLVM module, section information specified in the
+declaration is retained in LLVM IR to enable OpenCL processes.
+
sdardis wrote:
> efriedma wrote:
> > This doesn't really ex
Author: abataev
Date: Tue Aug 15 07:34:04 2017
New Revision: 310920
URL: http://llvm.org/viewvc/llvm-project?rev=310920&view=rev
Log:
[OPENMP] Fix compiler crash on argument translate for NVPTX.
When translating arguments for NVPTX target it is not taken into account
that function may have variab
mikhail.ramalho updated this revision to Diff 63.
mikhail.ramalho added a comment.
Updated QualTypeNamesTest.cpp to use multiline string in all tests.
Also ran clang-format -style=LLVM for code style.
https://reviews.llvm.org/D36610
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib
Author: arphaman
Date: Tue Aug 15 07:42:01 2017
New Revision: 310921
URL: http://llvm.org/viewvc/llvm-project?rev=310921&view=rev
Log:
Allow pretty platform names in availability attributes
rdar://32076651
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/test/Sema/attr-availability-
rjmccall accepted this revision.
rjmccall added a comment.
Thanks, that looks great.
https://reviews.llvm.org/D36580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 15 August 2017 at 01:25, Richard Smith wrote:
> On 14 August 2017 at 03:27, Diana Picus via cfe-commits
> wrote:
>>
>> Hi,
>>
>> Strangely enough, it turns out that if I run
>> Asan-armhf-with-calls-Noinst-Test on the command line it fails,
>> although it doesn't fail when run with lit.
>
>
>
erichkeane added a comment.
Of course, overnight I realized I am probably better off having the
'CpuSupports' validate MULTIPLE features at a time! I'll update this patch
with an improvement when I get one that I think is really useful. Sorry for
the thrash.
https://reviews.llvm.org/D36707
NoQ created this revision.
Herald added a subscriber: xazax.hun.
RetainCountChecker's warning message "`Incorrect decrement of the reference
count of an object that is not owned at this point by the caller`" does not
explicitly mention the caller, which may be confusing when there is a nested
b
Ugh, I'm not sure that last email made it through.
Here's the IR with -Xclang -disable-llvm-passes, at r310400 and r310401:
https://goo.gl/4n84SR
https://goo.gl/gxhxp9
The diff between them is small enough so I don't think there's much
point in reducing it further.
Hope that helps.
On 15 August
Author: yaxunl
Date: Tue Aug 15 09:02:49 2017
New Revision: 310924
URL: http://llvm.org/viewvc/llvm-project?rev=310924&view=rev
Log:
[OpenCL] Support variable memory scope in atomic builtins
Differential Revision: https://reviews.llvm.org/D36580
Modified:
cfe/trunk/include/clang/AST/Expr.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310924: [OpenCL] Support variable memory scope in atomic
builtins (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D36580?vs=60&id=85#toc
Repository:
rL LLVM
https://r
Do we want to merge this to 5.0?
On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: epilk
> Date: Tue Aug 8 10:09:09 2017
> New Revision: 310382
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310382&view=rev
> Log:
> [Availability] Do
Author: yaxunl
Date: Tue Aug 15 09:30:31 2017
New Revision: 310927
URL: http://llvm.org/viewvc/llvm-project?rev=310927&view=rev
Log:
Remove -finclude-default-header in OpenCL atomic tests
Differential Revision: https://reviews.llvm.org/D36676
Modified:
cfe/trunk/test/CodeGenOpenCL/atomic-ops
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310927: Remove -finclude-default-header in OpenCL atomic
tests (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D36676?vs=110953&id=91#toc
Repository:
rL LLVM
https://revi
modocache updated this revision to Diff 95.
modocache retitled this revision from "[RFC][time-report] Add preprocessor
timer" to "[time-report] Add preprocessor timer".
modocache edited the summary of this revision.
modocache removed subscribers: vsk, mzolotukhin.
modocache added a comment.
A
modocache added subscribers: vsk, mzolotukhin.
modocache added a comment.
Oops, sorry, didn't mean to remove the subscribers. `arc diff --verbatim`
strikes again.
https://reviews.llvm.org/D36492
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: yaxunl
Date: Tue Aug 15 10:16:44 2017
New Revision: 310932
URL: http://llvm.org/viewvc/llvm-project?rev=310932&view=rev
Log:
Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl
Modified:
cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl
Modified: cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl
Author: akirtzidis
Date: Tue Aug 15 10:20:37 2017
New Revision: 310933
URL: http://llvm.org/viewvc/llvm-project?rev=310933&view=rev
Log:
[index] Update indexing to handle CXXDeductionGuideDecls properly
CXXDeductionGuideDecls can't be referenced so there's no need to output a
symbol occurrence f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310933: [index] Update indexing to handle
CXXDeductionGuideDecls properly (authored by akirtzidis).
Changed prior to commit:
https://reviews.llvm.org/D36641?vs=110829&id=99#toc
Repository:
rL LLV
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:64
+ // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]],
i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}}, i8 addrspace(4)*
addrspacecast (i8 addrspace(1)
chh created this revision.
Simplify registerMatchers and check functions in CloexecCreatCheck.
https://reviews.llvm.org/D36755
Files:
clang-tidy/android/CloexecCreatCheck.cpp
clang-tidy/android/CloexecCreatCheck.h
Index: clang-tidy/android/CloexecCreatCheck.h
=
chh created this revision.
Simplify registerMatchers and check functions in CloexecSocketCheck.
https://reviews.llvm.org/D36756
Files:
clang-tidy/android/CloexecSocketCheck.cpp
clang-tidy/android/CloexecSocketCheck.h
Index: clang-tidy/android/CloexecSocketCheck.h
=
Author: yaxunl
Date: Tue Aug 15 10:59:26 2017
New Revision: 310937
URL: http://llvm.org/viewvc/llvm-project?rev=310937&view=rev
Log:
Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl again
Modified:
cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl
Modified: cfe/trunk/test/CodeGenOpenCL/atomic-
chh created this revision.
Simplify registerMatchers and check functions in CloexecFopenCheck.
https://reviews.llvm.org/D36759
Files:
clang-tidy/android/CloexecFopenCheck.cpp
clang-tidy/android/CloexecFopenCheck.h
Index: clang-tidy/android/CloexecFopenCheck.h
=
Eugene.Zelenko added a comment.
I think you could combine this refactoring into single change.
https://reviews.llvm.org/D36759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh added a comment.
Eugene, do you mean combining this one, https://reviews.llvm.org/D36756, and
https://reviews.llvm.org/D36755 into one?
I don't mind either way.
https://reviews.llvm.org/D36759
___
cfe-commits mailing list
cfe-commits@lists.llv
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D36759#842367, @chh wrote:
> Eugene, do you mean combining this one, https://reviews.llvm.org/D36756, and
> https://reviews.llvm.org/D36755 into one?
> I don't mind either way.
Sure. All three diffs are of same kind.
https://revie
chh created this revision.
Simplify registerMatchers and check functions in CloexecCreatCheck,
CloexecSocketCheck, and CloexecFopenCheck.
https://reviews.llvm.org/D36761
Files:
clang-tidy/android/CloexecCreatCheck.cpp
clang-tidy/android/CloexecCreatCheck.h
clang-tidy/android/CloexecFopenC
chh added a comment.
Okay, 3 changes are combined into https://reviews.llvm.org/D36761.
https://reviews.llvm.org/D36759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hans, is it okay to merge this to 5.0?
> On Aug 10, 2017, at 5:06 PM, Akira Hatanaka via cfe-commits
> wrote:
>
> Author: ahatanak
> Date: Thu Aug 10 17:06:49 2017
> New Revision: 310672
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310672&view=rev
> Log:
> [Sema][ObjC] Fix spurious -Wcast-
efriedma added a comment.
> The other side of the problem is, what if the declarations don't have any
> section information, but the definition does? Is that also an undefined
> behavior?
I can't see how "undefined behavior" could possibly be the right answer in that
case. Every definition ha
Author: rsmith
Date: Tue Aug 15 12:11:21 2017
New Revision: 310946
URL: http://llvm.org/viewvc/llvm-project?rev=310946&view=rev
Log:
PR33082: Improve tracking of unexpanded parameter packs within variadic generic
lambdas.
Modified:
cfe/trunk/include/clang/Sema/ScopeInfo.h
cfe/trunk/lib/S
efriedma added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:570
+ // We'll warn about reaching the end of file later.
+ if (C == '\0' || C == '\r' || C == '\n')
+break;
This doesn't really handle backslash-escaped newlines correctly. (
Author: alexshap
Date: Tue Aug 15 12:23:54 2017
New Revision: 310948
URL: http://llvm.org/viewvc/llvm-project?rev=310948&view=rev
Log:
[clang] Code cleanup in clang/tooling
1. Add missing explicit for SymbolName constructor.
2. Add missing std::move in createRenameReplacements.
Differential revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310948: [clang] Code cleanup in clang/tooling (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D36715?vs=111078&id=111229#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
eandrews updated this revision to Diff 111227.
eandrews added a comment.
I updated the documentation to include Simon's comments. I wasn't sure whether
to include the line about section information being retained in LLVM IR, since
Eli mentioned it could vary for different front-ends. I have incl
Author: kuba.brecka
Date: Tue Aug 15 12:47:06 2017
New Revision: 310950
URL: http://llvm.org/viewvc/llvm-project?rev=310950&view=rev
Log:
[clang] Get rid of "%T" expansions
The %T lit expansion expands to a common directory shared between all the tests
in the same directory, which is unexpected
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310950: [clang] Get rid of "%T" expansions (authored by
kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D36437?vs=110113&id=111232#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: kuba.brecka
Date: Tue Aug 15 12:54:04 2017
New Revision: 310952
URL: http://llvm.org/viewvc/llvm-project?rev=310952&view=rev
Log:
Fixup for r310950: Also remove the new instance of %T from html-diags.c
Modified:
cfe/trunk/test/Analysis/html-diags.c
Modified: cfe/trunk/test/Analysis/
kparzysz added a comment.
In https://reviews.llvm.org/D36712#842433, @efriedma wrote:
> I can't see how "undefined behavior" could possibly be the right answer in
> that case. Every definition has to end up in some section eventually, and in
> many cases we don't know what section that will be
saugustine created this revision.
These functions were disabled for powerpc in the initial
checkin all the way back in 2009. The reasons why are lost to history,
but they work fine with modern clang and powerpc64. I have no way
to test them on 32-bit systems, but will clean this up if the someone
eandrews added inline comments.
Comment at: docs/LangRef.rst:629
+corresponding to the LLVM module, section information specified in the
+declaration is retained in LLVM IR to enable OpenCL processes.
+
kparzysz wrote:
> sdardis wrote:
> > efriedma wrote:
> > >
Eugene.Zelenko added a comment.
Please abandon this and other similar revisions as obsoleted by
https://reviews.llvm.org/D36761.
https://reviews.llvm.org/D36759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
chh abandoned this revision.
chh added a comment.
Included in https://reviews.llvm.org/D36761.
https://reviews.llvm.org/D36759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh abandoned this revision.
chh added a comment.
Included in https://reviews.llvm.org/D36761.
https://reviews.llvm.org/D36756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh abandoned this revision.
chh added a comment.
Included in https://reviews.llvm.org/D36761.
https://reviews.llvm.org/D36755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh updated this revision to Diff 111243.
chh edited the summary of this revision.
https://reviews.llvm.org/D36761
Files:
clang-tidy/android/CloexecCheck.cpp
clang-tidy/android/CloexecCheck.h
clang-tidy/android/CloexecCreatCheck.cpp
clang-tidy/android/CloexecCreatCheck.h
clang-tidy/andr
tomcherry created this revision.
The C++ standard calls for wait_for() to use steady clock and
wait_until() to use the clock that is provided as an argument. This
is not currently done in libc++ and is not possible with the pthreads
API, however it is possible with the underlying futex system
tomcherry added a comment.
This is mostly an RFC. The underlying issue is that we cannot use timed waits
based on CLOCK_REALTIME on Android. In trying to fix that, I figured I might
as well try implementing the standard as described, though I understand that
there'd be resistance to such a re
Author: srhines
Date: Tue Aug 15 14:20:41 2017
New Revision: 310958
URL: http://llvm.org/viewvc/llvm-project?rev=310958&view=rev
Log:
Switch to consumeError(), since this can crash otherwise.
Summary:
If assertions are disabled, but LLVM_ABI_BREAKING_CHANGES is enabled,
this will cause an issue w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310958: Switch to consumeError(), since this can crash
otherwise. (authored by srhines).
Repository:
rL LLVM
https://reviews.llvm.org/D36728
Files:
cfe/trunk/lib/Tooling/Core/Replacement.cpp
Index
danalbert created this revision.
Herald added subscribers: eraman, mehdi_amini, emaste.
Relanding https://reviews.llvm.org/D35739 which was reverted because
it broke the tests on non-Linux. The tests have been fixed to be
platform agnostic, and additional tests have been added to make sure
that th
lhames added a comment.
The preferred solution to this is actually to wrap the call with cantFail (See
http://llvm.org/docs/ProgrammersManual.html#using-cantfail-to-simplify-safe-callsites)
-- it will handle both the assertion and consumption of the value for you, and
will simplify calls that r
Author: danalbert
Date: Tue Aug 15 14:31:17 2017
New Revision: 310960
URL: http://llvm.org/viewvc/llvm-project?rev=310960&view=rev
Log:
Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""
Summary:
Relanding https://reviews.llvm.org/D35739 which was reverted because
it broke the tests o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310960: Revert "Revert "Fix LLVMgold plugin name/path for
non-Linux."" (authored by danalbert).
Repository:
rL LLVM
https://reviews.llvm.org/D36769
Files:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.
euhlmann added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2405-2408
+ // Defect: We currently do not deal with cases where legitimate lines may be
+ // outside an include guard. Examples are #pragma once and
+ // #pragma GCC diagnostic, or anything else that
srhines added a comment.
In https://reviews.llvm.org/D36728#842644, @lhames wrote:
> The preferred solution to this is actually to wrap the call with cantFail
> (See
> http://llvm.org/docs/ProgrammersManual.html#using-cantfail-to-simplify-safe-callsites)
> -- it will handle both the assertion
Author: rjmccall
Date: Tue Aug 15 14:42:52 2017
New Revision: 310964
URL: http://llvm.org/viewvc/llvm-project?rev=310964&view=rev
Log:
Extract IRGen's constant-emitter into its own helper class and clean up
the interface.
The ultimate goal here is to make it easier to do some more interesting
thi
Author: rjmccall
Date: Tue Aug 15 14:42:47 2017
New Revision: 310963
URL: http://llvm.org/viewvc/llvm-project?rev=310963&view=rev
Log:
Allow the target field of a CK_ToUnion to be more easily recovered.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/Expr.cpp
cfe/trunk/
Author: rjmccall
Date: Tue Aug 15 14:42:42 2017
New Revision: 310962
URL: http://llvm.org/viewvc/llvm-project?rev=310962&view=rev
Log:
Allow StmtVisitor visitation to be parameterized. NFC.
Modified:
cfe/trunk/include/clang/AST/StmtVisitor.h
Modified: cfe/trunk/include/clang/AST/StmtVisitor
Author: danalbert
Date: Tue Aug 15 15:10:44 2017
New Revision: 310966
URL: http://llvm.org/viewvc/llvm-project?rev=310966&view=rev
Log:
Add a target for new LTO plugin name tests.
Not all targets will use -plugin with -flto. Pick a fixed target so
this works regardless of the default target (rega
Author: jvesely
Date: Tue Aug 15 15:24:05 2017
New Revision: 310968
URL: http://llvm.org/viewvc/llvm-project?rev=310968&view=rev
Log:
configure.py: Drop explicit import of int builtin
I can't reproduce the error that made me add this.
Reported-by: Kim Gräsman
Signed-off-by: Jan Vesely
Reviewed
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
- gfx600
- gfx601
- gfx703
- gfx902
- gfx903
https://reviews.llvm.org/D36771
Files:
lib/Basic/Targets/AMDGPU.cpp
test/Driver/r600-mcpu.cl
Index: test/Driver/r600-mcpu.cl
==
Author: rsmith
Date: Tue Aug 15 15:58:45 2017
New Revision: 310972
URL: http://llvm.org/viewvc/llvm-project?rev=310972&view=rev
Log:
Do not look through pack expansions when looking for unexpanded parameter packs.
Fixes a selection of rejects-valids when pack-expanding a lambda that itself
contai
jseba created this revision.
jseba added a project: clang.
Clang has had a regression since version 3.8 where calls to __builtin_signbit
(and friends signbitf & signbitl) without passing any arguments would cause it
to segfault because it didn't abort compilation, even though it would properly
efriedma added inline comments.
Comment at: docs/LangRef.rst:628
+information. Attaching section information to an external declaration is an
+assertion that it's definition is located in the specified section. If the
+definition is located in a different section, the behavior
t-tye added inline comments.
Comment at: cfe/trunk/lib/Frontend/InitPreprocessor.cpp:581
// Define macros for the OpenCL memory scope.
// The values should match clang SyncScope enum.
+ static_assert(
// The values should match clang AtomicScopeOpenCLModel
arsenm added a comment.
We should also be defining __devicename__ macros. I opened a bug for this last
week
https://reviews.llvm.org/D36771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
smeenai added a comment.
@mclow.lists does this seem reasonable to you?
https://reviews.llvm.org/D36713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Dan,
I don't know if you are aware, but the tests you added/changed in this commit
are causing failures on the PS4 Windows bot. The root cause seems to be that
you are looking for a forward slash, but Windows generates double backslashes,
so the match fails:
http://lab.llvm.org:8011/builder
Author: danalbert
Date: Tue Aug 15 16:57:32 2017
New Revision: 310976
URL: http://llvm.org/viewvc/llvm-project?rev=310976&view=rev
Log:
Revert "Add a target for new LTO plugin name tests."
Modified:
cfe/trunk/test/Driver/lto-plugin-darwin.c
cfe/trunk/test/Driver/lto-plugin-linux.c
cfe
Author: danalbert
Date: Tue Aug 15 16:57:34 2017
New Revision: 310977
URL: http://llvm.org/viewvc/llvm-project?rev=310977&view=rev
Log:
Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux."""
Removed:
cfe/trunk/test/Driver/lto-plugin-darwin.c
cfe/trunk/test/Driver/lto-plug
Author: rsmith
Date: Tue Aug 15 17:06:07 2017
New Revision: 310978
URL: http://llvm.org/viewvc/llvm-project?rev=310978&view=rev
Log:
Add missing test for warning added in r310803.
Added:
cfe/trunk/test/Lexer/cxx2a_keyword_as_cxx17.cpp
Added: cfe/trunk/test/Lexer/cxx2a_keyword_as_cxx17.cpp
UR
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D35678#840092, @boris wrote:
> My understanding of your comment is that the rest is ok for now (since there
> will probably be a redesign in this area). If, however
erik.pilkington created this revision.
Currently, this has pretty terrible ergonomics for the fairly common case of
switching over an enum which has some entries that are partial. Thanks to Nico
Weber for pointing this out!
Thanks,
Erik
https://reviews.llvm.org/D36777
Files:
lib/Sema/SemaD
Probably not, this might be a risky change.
- Erik
On 8/15/17 9:15 AM, Nico Weber wrote:
Do we want to merge this to 5.0?
On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: epilk
Date: Tue Aug 8 10:09:09 2017
New Re
lhames added a comment.
> Is it ok to drop the assertion in that case (and convert it to a comment)? I
> didn't want to alter too much of this check, since perhaps the original
> author(s) were more skeptical about this breaking (hence the assertion).
> Something like:
>
> // Replacements must
rsmith added inline comments.
Comment at: docs/ClangCommandLineReference.rst:3-4
---
NOTE: This file is automatically generated by running clang-tblgen
-gen-opt-docs. Do not edit this file by hand!!
-
Author: rsmith
Date: Tue Aug 15 18:46:46 2017
New Revision: 310982
URL: http://llvm.org/viewvc/llvm-project?rev=310982&view=rev
Log:
Add test that we get the correct calling convention and mangling for va_list.
Added:
cfe/trunk/test/Headers/stdarg.cpp
Added: cfe/trunk/test/Headers/stdarg.cpp
Author: rsmith
Date: Tue Aug 15 18:49:53 2017
New Revision: 310983
URL: http://llvm.org/viewvc/llvm-project?rev=310983&view=rev
Log:
PR19668, PR23034: Fix handling of move constructors and deleted copy
constructors when deciding whether classes should be passed indirectly.
This fixes ABI differen
1 - 100 of 107 matches
Mail list logo
