arphaman added a subscriber: rsmith. arphaman added a comment. In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about > the comments that need some small adjusting. > > I'm wondering what would be a nice way of creating a StmtDataCollector that > is faster but only works for single translation units (e.g. it only hashes > the pointer values of decls instead of their qualified name)? The use case > here would be Stmt::Profile and the CloneDetector which could be set to a > single-TU-mode in the CloneChecker. For Stmt::Profile it would ensure we > don't degrade performance from the current version, for the CloneChecker we > probably get a reasonable performance boost (as the hashing is currently the > last remaining bottle neck). > > @arphaman Any suggestions who could review/approve the additions to `AST/`? I guess @rsmith, but he's usually busy. I don't think this patch requires some special approval though. This patch adds support for things like literals and DeclRefExpr and MemberExpr, but they're untested. They should either be added in a follow-up patch or tested with an appropriate unittest in unittests/AST or unittests/Tooling. https://reviews.llvm.org/D36664 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
