ogoffart created this revision.
The code in the test caused a crash with this backtrace:
RecordLayoutBuilder.cpp:2934: const clang::ASTRecordLayout
&clang::ASTContext::getASTRecordLayout(const clang::RecordDecl *) const:
Assertion `!D->isInvalidDecl() && "Cannot get layout of invalid decl!"' fa
rogfer01 added a comment.
Hi @ogoffart thanks for fixing this.
I suggest some minor change for the check, other than that this looks good to
me.
Comment at: lib/Sema/SemaChecking.cpp:12099
BaseType = BaseType->getPointeeType();
RecordDecl *RD = BaseType->getAs()->
baloghadamsoftware created this revision.
Since the range-based constraint manager (default) is weak in handling
comparisons where symbols are on both sides it is wise to rearrange them to
have symbols only on the left side. Thus e.g. `A + n >= B + m` becomes `A - B
>= m - n` which enables the
mfherbst updated this revision to Diff 105592.
mfherbst added a comment.
Herald added a subscriber: JDevlieghere.
- Adapted patch to changes suggested by alexfh
- Added comment why setting MainSourceFile to an empty string if fixes are
exported
https://reviews.llvm.org/D31326
Files:
run-clan
baloghadamsoftware created this revision.
If range `[m .. n]` is stored for symbolic expression `A - B`, then we can
deduce the range for `B - A` which is [-n .. -m]. This is only true for signed
types, unless the range is `[0 .. 0]`.
https://reviews.llvm.org/D35110
Files:
lib/StaticAnalyze
baloghadamsoftware updated this revision to Diff 105593.
baloghadamsoftware added a comment.
Wrong patch files was uploaded first.
https://reviews.llvm.org/D35110
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
test/Analysis/ptr-arith.c
Index: test/Analysis/ptr-arith.c
==
mfherbst added inline comments.
Comment at: run-clang-tidy.py:105
+ elif merged['MainSourceFile'] != content['MainSourceFile']:
+# The values given for MainSourceFile are inconsistent.
+# Just empty MainSourceFile blank:
alexfh wrote:
> This
baloghadamsoftware updated this revision to Diff 105594.
baloghadamsoftware added a comment.
Simplified for enhanced SValBuilder and ConstraintManager.
https://reviews.llvm.org/D32642
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx.h
SjoerdMeijer added a comment.
Thanks Richard. I've opened an cxx abi issue, see comments inline. I will start
working now on the doc update, and will do that in a companion change. Cheers.
Comment at: lib/AST/ItaniumMangle.cpp:2457-2460
+ case BuiltinType::Float16:
case Bu
mteodor added a comment.
In https://reviews.llvm.org/D12407#314671, @klimek wrote:
> I think we'll want somebody to find out whether there are simpler ways to
> implement this.
**Format on save** was implemented by https://reviews.llvm.org/D29221.
What's the new functionality in the **reforma
alexshap updated this revision to Diff 105597.
Repository:
rL LLVM
https://reviews.llvm.org/D35041
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/enum.cpp
Index: test/Analysis/enum.cpp
=
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote:
> The check in https://reviews.llvm.org/D3 is using a CFG, not just
> checking direct throws.
I tested the latest revision (the fronted patch already included) on my test
file. Disregardin
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D34404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rL307368: [ObjC] Avoid the -Wunguarded-availability warnings
for protocol (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D35061?vs=105
Author: arphaman
Date: Fri Jul 7 02:15:29 2017
New Revision: 307368
URL: http://llvm.org/viewvc/llvm-project?rev=307368&view=rev
Log:
[ObjC] Avoid the -Wunguarded-availability warnings for protocol
requirements in protocol/class/category declarations
The unguarded availability warnings in the pr
Author: ogoffart
Date: Fri Jul 7 02:38:59 2017
New Revision: 307371
URL: http://llvm.org/viewvc/llvm-project?rev=307371&view=rev
Log:
Fix crash parsing invalid code
The code in the test caused a crash with this backtrace:
RecordLayoutBuilder.cpp:2934: const clang::ASTRecordLayout
&clang::ASTC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307371: Fix crash parsing invalid code (authored by
ogoffart).
Changed prior to commit:
https://reviews.llvm.org/D35108?vs=105590&id=105604#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35108
F
NoQ added a comment.
Thanks, this looks great!
Because integer promotion rules are tricky, could we, for now, avoid dealing
with the situation when left-hand side and right-hand side and the result (all
three) are not all of the same type? Or maybe we'd like to support substraction
of unsigned
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307379: [clang-tidy] Fix modernize-use-override incorrect
replacement (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D35078?vs=105554&id=105610#toc
Repository:
rL LLVM
https
Author: alexfh
Date: Fri Jul 7 03:15:24 2017
New Revision: 307379
URL: http://llvm.org/viewvc/llvm-project?rev=307379&view=rev
Log:
[clang-tidy] Fix modernize-use-override incorrect replacement
Summary:
For the following code: `modernize-use-override` generates a replacement with
incorrect loca
Author: arphaman
Date: Fri Jul 7 03:25:12 2017
New Revision: 307384
URL: http://llvm.org/viewvc/llvm-project?rev=307384&view=rev
Log:
[Frontend] Verify that the bitstream is not empty before reading
the serialised diagnostics
Clang should avoid calling report_fatal_error when the file with the s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307384: [Frontend] Verify that the bitstream is not empty
before reading (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D35069?vs=105462&id=105612#toc
Repository:
rL LLVM
Author: atanasyan
Date: Fri Jul 7 03:35:33 2017
New Revision: 307386
URL: http://llvm.org/viewvc/llvm-project?rev=307386&view=rev
Log:
[driver][mips] Pass long-calls feature flag to the MIPS backend
Check the `-mlong-calls` command line option and pass the `long-calls`
feature flag to the backen
Author: arphaman
Date: Fri Jul 7 03:41:19 2017
New Revision: 307388
URL: http://llvm.org/viewvc/llvm-project?rev=307388&view=rev
Log:
Recommit [driver][macOS] Pick the system version for the
deployment target if the SDK is newer than the system
This commit reverts the revert commit r305891. Now
aemerson created this revision.
aemerson added a project: clang.
Herald added subscribers: kristof.beyls, tschuett, javed.absar.
[AArch64] Add support for handling the +sve target feature.
This also adds the appropriate predefine for SVE if enabled.
Depends on https://reviews.llvm.org/D35076
R
rengolin added a reviewer: t.p.northover.
rengolin added a subscriber: t.p.northover.
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:6245
enum FPUModeEnum {
-FPUMode,
-NeonMode
+NeonMode = (1 << 0),
+SveMode = (1 << 1)
Is the
aemerson added inline comments.
Comment at: lib/Basic/Targets.cpp:6245
enum FPUModeEnum {
-FPUMode,
-NeonMode
+NeonMode = (1 << 0),
+SveMode = (1 << 1)
rengolin wrote:
> Is there any AArch64 arch without SIMD?
>
> Anyway, that seems deliberate
baloghadamsoftware updated this revision to Diff 105628.
baloghadamsoftware added a comment.
Type check added and restricted to additive operators.
https://reviews.llvm.org/D35109
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/std-c-library-functions.c
test/Analysis/sv
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:583
+newRhs = BasicVals.evalAPSInt(BO_Add, *lInt, *rInt);
+reverse = (lop == BO_Add);
+ } else
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D35109#801921, @NoQ wrote:
> Because integer promotion rules are tricky, could we, for now, avoid dealing
> with the situation when left-hand side and right-hand side and the resu
Author: mprobst
Date: Fri Jul 7 06:17:10 2017
New Revision: 307394
URL: http://llvm.org/viewvc/llvm-project?rev=307394&view=rev
Log:
clang-format: [JS] do not wrap after "readonly".
Summary:
Breaks after "readonly" trigger automatic semicolon insertion in field
declarations.
Reviewers: krasimir
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A few more nits.
Comment at: run-clang-tidy.py:93
+def merge_replacement_files(tmpdir, fixfile):
+ """Merge all replacement files in a directory into a single fixf
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1144
+ ? CGM.getNSConcreteGlobalBlock()
+ : CGM.getNullPointer(CGM.VoidPtrPtrTy,
+ QualType(CGM.getCont
yaxunl updated this revision to Diff 105644.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D33842
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGDecl.cpp
lib/C
karies added a comment.
In https://reviews.llvm.org/D34985#801498, @bruno wrote:
> @v.g.vassilev will this also benefit from `ContentCache::getBuffer`
> improvements from https://reviews.llvm.org/D33275? I guess if `getBuffer`
> transparently handles pointing to right buffer we won't need this
chill added a comment.
Ping.
https://reviews.llvm.org/D33676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
I discussed this with @rsmith and we think the correct fix is to update the
DefinitionData bits computed when adding special members. I haven't reviewed
this patch in detail, but we came to the conclusion that Clang's optimization
to avoid implicit special member declaratio
Author: ctopper
Date: Fri Jul 7 11:41:09 2017
New Revision: 307420
URL: http://llvm.org/viewvc/llvm-project?rev=307420&view=rev
Log:
[X86] Replace 'fallthrough' comments with LLVM_FALLTHROUGH.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://l
Author: rsmith
Date: Fri Jul 7 13:04:28 2017
New Revision: 307434
URL: http://llvm.org/viewvc/llvm-project?rev=307434&view=rev
Log:
[modules ts] Basic for module linkage.
In addition to the formal linkage rules, the Modules TS includes cases where
internal-linkage symbols within a module interfa
On 7 July 2017 at 13:04, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri Jul 7 13:04:28 2017
> New Revision: 307434
>
> URL: http://llvm.org/viewvc/llvm-project?rev=307434&view=rev
> Log:
> [modules ts] Basic for module linkage.
>
Sorry, that shoul
Author: dehao
Date: Fri Jul 7 13:53:17 2017
New Revision: 307438
URL: http://llvm.org/viewvc/llvm-project?rev=307438&view=rev
Log:
Enable the new PM + SamlePGO + ThinLTO testing.
Summary: This patch should be enabled after https://reviews.llvm.org/D34895
Reviewers: chandlerc, tejohnson, davidxl
Author: lhames
Date: Fri Jul 7 14:51:11 2017
New Revision: 307444
URL: http://llvm.org/viewvc/llvm-project?rev=307444&view=rev
Log:
Add testcase for r305850.
Accidentally left this out of the original commit.
Added:
cfe/trunk/test/Import/import-overrides/
cfe/trunk/test/Import/import-ov
Author: dehao
Date: Fri Jul 7 15:01:47 2017
New Revision: 307445
URL: http://llvm.org/viewvc/llvm-project?rev=307445&view=rev
Log:
Add sample PGO integration test to cover profile annotation and inlining.
Summary: The patch makes the integration test cover major sample PGO components.
Reviewers
Author: rnk
Date: Fri Jul 7 15:04:29 2017
New Revision: 307446
URL: http://llvm.org/viewvc/llvm-project?rev=307446&view=rev
Log:
[MS] Don't statically initialize dllimport member function pointers
Summary:
r306137 made dllimport pointers to member functions non-constant. This
is correct because
Author: dehao
Date: Fri Jul 7 15:40:37 2017
New Revision: 307449
URL: http://llvm.org/viewvc/llvm-project?rev=307449&view=rev
Log:
Revert r307445 as it breaks on certain platforms.
Modified:
cfe/trunk/test/CodeGen/Inputs/pgo-sample.prof
cfe/trunk/test/CodeGen/pgo-sample.c
Modified: cfe/
Author: ericwf
Date: Fri Jul 7 16:02:30 2017
New Revision: 307450
URL: http://llvm.org/viewvc/llvm-project?rev=307450&view=rev
Log:
Fix diagnostic in verify test to match new Clang output
Modified:
libcxx/trunk/test/std/thread/futures/futures.task/futures.task.members/ctor2.fail.cpp
Modifi
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Jul 7 17:37:59 2017
New Revision: 307455
URL: http://llvm.org/viewvc/llvm-project?rev=307455&view=rev
Log:
Fix warnings introduced by r307434.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
cfe/trunk/tools/libclang/CXIndexDataConsumer.cpp
Modified: cfe/trunk/tool
Author: ctopper
Date: Fri Jul 7 17:47:44 2017
New Revision: 307456
URL: http://llvm.org/viewvc/llvm-project?rev=307456&view=rev
Log:
[X86] Move AVX512VPOPCNTDQ in __builtin_cpu_support's enum to match trunk gcc.
There are two other features before it that we don't currently support in the
the f
Author: rtrieu
Date: Fri Jul 7 19:04:42 2017
New Revision: 307458
URL: http://llvm.org/viewvc/llvm-project?rev=307458&view=rev
Log:
[ODRHash] Support FriendDecl
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/lib/Seriali
Author: ericwf
Date: Fri Jul 7 21:18:41 2017
New Revision: 307461
URL: http://llvm.org/viewvc/llvm-project?rev=307461&view=rev
Log:
Fix filesystem build on platforms with weird time_t types.
32-bit powerpc provides a 64 bit time_t type and older ppc64 systems
provide time_t as a floating point t
51 matches
Mail list logo
