[PATCH] D35108: Fix crash parsing invalid code

[Roger Ferrer Ibanez via Phabricator via cfe-commits]

rogfer01 added a comment.

Hi @ogoffart thanks for fixing this.

I suggest some minor change for the check, other than that this looks good to 
me.



================
Comment at: lib/Sema/SemaChecking.cpp:12099
       BaseType = BaseType->getPointeeType();
     RecordDecl *RD = BaseType->getAs<RecordType>()->getDecl();
 
----------------
Can you make the check for `RD->isInvalidDecl()` here instead?

```
if (RD->isInvalidDecl())
  return;
```


https://reviews.llvm.org/D35108



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits