mfherbst added inline comments.

================
Comment at: run-clang-tidy.py:105
+      elif merged['MainSourceFile'] != content['MainSourceFile']:
+        # The values given for MainSourceFile are inconsistent.
+        # Just empty MainSourceFile blank:
----------------
alexfh wrote:
> This is going to be the case for each non-trivial invocation of this script. 
> Do we need to keep `MainSourceFile` at all?
Good point. As it turns out clang-apply-replacement never uses the value afaik. 
The field needs to be around, however, since the definition of the replacements 
``yaml`` format ( see ``clang/include/clang/Tooling/ReplacementsYaml.h``) makes 
it mandatory.


https://reviews.llvm.org/D31326



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to