[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Now that you found the root cause, this looks like a proper fix ;) Thank you! LG https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cf

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 101862. EricWF added a comment. - Fix value category of `co_await`/`co_yield` expression. ie use the return type of the resume expression to determine the value category. @rsmith Should the `CoroutineSuspendExpr` constructor be using `getCallReturnType()` to

[libcxx] r304966 - Revert r304955 - Fix class template deduction for scoped_lock.

Author: ericwf Date: Thu Jun 8 02:18:15 2017 New Revision: 304966 URL: http://llvm.org/viewvc/llvm-project?rev=304966&view=rev Log: Revert r304955 - Fix class template deduction for scoped_lock. Richard decided to fix these cases in Clang, even though they are representative of a larger problem

[libcxx] r304967 - Add tests for class template deduction on std::tuple.

Author: ericwf Date: Thu Jun 8 02:18:17 2017 New Revision: 304967 URL: http://llvm.org/viewvc/llvm-project?rev=304967&view=rev Log: Add tests for class template deduction on std::tuple. Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/implicit_deduction_guides.pass.cpp M

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. IIUC, when `vector` (for a class `T` that has both move and copy constructors) resizes, it will prefer move constructors, but only if they're declared `noexcept`. This is true even if `-fno-exceptions` is on. So I don't think this check should depend on `-fno-exceptions

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. Here's a small test: https://godbolt.org/g/nNZgUb (look for `T::T(` and `S::S(` calls, adding `-fno-exceptions` doesn't change which constructors are called). https://reviews.llvm.org/D34002 ___ cfe-commits mailing list cfe-

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101865. yvvan added a comment. Improve commentary. Use StringMap https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ===

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

alexfh added a comment. I would be interested in seeing the results of this check's run on LLVM+Clang code. https://reviews.llvm.org/D33722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[libcxx] r304969 - XFAIL tuple deduction guide test on GCC

Author: ericwf Date: Thu Jun 8 03:03:35 2017 New Revision: 304969 URL: http://llvm.org/viewvc/llvm-project?rev=304969&view=rev Log: XFAIL tuple deduction guide test on GCC Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/implicit_deduction_guides.pass.cpp Modified:

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. Given that we are already considering extensions, maybe you want to add a test for compound statements in expressions. void foo(void) { ({ bar(); }); int (*p)() = bar; /* expected-error {{use of undeclared identifier 'bar'}} */ } This already works with

[PATCH] D34022: Repair 2010-05-31-palignr.c test

teemperor created this revision. This test was silently failing since a long time because it failed to include stdlib.h (as it's running in a freestanding environment). However, because we used just `not clang_cc1` instead of the verify mode, this regression was never noticed and the test was j

[PATCH] D33365: [clang-tidy] misc-assertion-count: A New Check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. I guess, this check should go to `readability` or elsewhere, but definitely not to `misc`. Another big question is whether it's reasonable to set up specific ratio limits on the den

[PATCH] D33365: [clang-tidy] misc-assertion-count: A New Check

lebedev.ri added a comment. In https://reviews.llvm.org/D33365#775860, @alexfh wrote: > I guess, this check should go to `readability` or elsewhere, but definitely > not to `misc`. Hmm, `misc` may be a bad place for this, but i think `readability` is even worse fit. The best guess would be so

[PATCH] D34024: [OpenCL] Diagnose scoped address-space qualified variables

svenvh created this revision. Variables qualified with the local or const address space may only be declared in the outermost scope of a kernel. Patch by Simon Perretta. https://reviews.llvm.org/D34024 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenC

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor updated this revision to Diff 101877. teemperor added a comment. - Just unconditionally calling `setHidden` now. IIRC I had to put the conditions for the module builds because setLocalOwningModule did trigger some tests/asserts, otherwise but the setHidden works fine like this. htt

[PATCH] D33365: [clang-tidy] misc-assertion-count: A New Check

alexfh added a comment. In https://reviews.llvm.org/D33365#775880, @lebedev.ri wrote: > In https://reviews.llvm.org/D33365#775860, @alexfh wrote: > > > I guess, this check should go to `readability` or elsewhere, but definitely > > not to `misc`. > > > Hmm, `misc` may be a bad place for this, bu

[PATCH] D33976: [clang] Fix format specifiers fixits

alexshap added a comment. @mehdi_amini , thanks, i see, regarding the "opposite issue" - probably an example / test case would be helpful, that looks like a separate issue. Thanks for adding @ahatanak and @arphaman, that would be wonderful if smb could look at this diff (which, besides the fix,

[clang-tools-extra] r304949 - [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

Author: yawanng Date: Wed Jun 7 17:39:20 2017 New Revision: 304949 URL: http://llvm.org/viewvc/llvm-project?rev=304949&view=rev Log: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed. Summary: "misc-noexcept-move-constructor" is better not to be issued when

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

joerg added a comment. At the very least, missing test case. I'm mostly ambivalent about this -- I don't really see the point and without matching soft float support it won't fully work either. Repository: rL LLVM https://reviews.llvm.org/D34018 __

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski added a comment. Softfloat on the NetBSD of Clang/LLVM part? Repository: rL LLVM https://reviews.llvm.org/D34018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

FlameTop added inline comments. Comment at: test/clang-tidy/misc-noexcept-move-constructor.cpp:2 +// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ +// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ +// RUN: -implicit-check-not="{{warnin

[PATCH] D34031: [OpenCL] Diagnose some reserved types

svenvh created this revision. Catch uses of the 'long long', 'unsigned long long', and 'long double' reserved types. Remove use of 'long long' in test/Misc/languageOptsOpenCL.cl; it shouldn't have been added there in the first place as the OpenCL specification explicitly forbids it in s6.1.4. In

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

joerg added a comment. Soft-float on the runtime environment part. I.e. non-trivial operations are lowered to library calls. Repository: rL LLVM https://reviews.llvm.org/D34018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Great, thanks for you help. Could you commit this for me? https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh added a comment. In https://reviews.llvm.org/D20693#776030, @hintonda wrote: > Great, thanks for you help. > > Could you commit this for me? Sure, running tests... https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev updated this revision to Diff 101908. ABataev added a comment. Removed FIXMEs and corrected comment https://reviews.llvm.org/D33735 Files: include/clang/AST/Decl.h lib/AST/ASTImporter.cpp lib/AST/Decl.cpp lib/AST/DeclObjC.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGCXXABI.cpp

[clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Author: alexfh Date: Thu Jun 8 09:04:16 2017 New Revision: 304977 URL: http://llvm.org/viewvc/llvm-project?rev=304977&view=rev Log: [clang-tidy] New checker to replace dynamic exception specifications Summary: New checker to replace dynamic exception specifications This is an alternative to D18

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rL304977: [clang-tidy] New checker to replace dynamic exception specifications (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D20693?vs=101860&id=101910#toc Repository: rL LLVM

r304978 - [libclang] Expose typedef and address space functions

Author: svenvh Date: Thu Jun 8 09:22:04 2017 New Revision: 304978 URL: http://llvm.org/viewvc/llvm-project?rev=304978&view=rev Log: [libclang] Expose typedef and address space functions Expose the following functions: - clang_getTypedefName - clang_getAddressSpace Patch by Simon Perretta. Di

[PATCH] D33598: [libclang] [OpenCL] Expose CIndex functions for typedef and address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL304978: [libclang] Expose typedef and address space functions (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D33598?vs=100404&id=101918#toc Repository: rL LLVM https://revie

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:153 Item.kind = getKind(Result.CursorKind); +Item.insertText = CCS->getTypedText(); if (CCS->getBriefComment()) Should we also update sortText and filterText, which u

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir updated this revision to Diff 101919. krasimir added a comment. - Remove optional chunks. They might contain control characters https://reviews.llvm.org/D34033 Files: clangd/ClangdUnit.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clangd/ClangdUnit.cpp:153 Item.kind = getKind(Result.CursorKind); +Item.insertText = CCS->getTypedText(); if (CCS->getBriefComment()) ilya-biryukov wr

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir updated this revision to Diff 101921. krasimir marked an inline comment as done. krasimir added a comment. - Add sortText and filterText https://reviews.llvm.org/D34033 Files: clangd/ClangdUnit.cpp test/clangd/completion.test Index: test/clangd/completion.test ===

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: test/clangd/completion.test:32 # CHECK: {"jsonrpc":"2.0","id":1,"result":[ -# CHECK-DAG: {"label":"a","kind":5} -# CHECK-DAG: {"label":"bb","ki

[clang-tools-extra] r304980 - [clangd] Add parameter and return type information to completion results

Author: krasimir Date: Thu Jun 8 10:11:51 2017 New Revision: 304980 URL: http://llvm.org/viewvc/llvm-project?rev=304980&view=rev Log: [clangd] Add parameter and return type information to completion results Summary: This patch adds information about the parameters and return types of completion

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

This revision was automatically updated to reflect the committed changes. Closed by commit rL304980: [clangd] Add parameter and return type information to completion results (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D34033?vs=101921&id=101925#toc Repository: r

[clang-tools-extra] r304981 - [clangd] Separate authority less uris from completion tests

Author: krasimir Date: Thu Jun 8 10:21:55 2017 New Revision: 304981 URL: http://llvm.org/viewvc/llvm-project?rev=304981&view=rev Log: [clangd] Separate authority less uris from completion tests Added: clang-tools-extra/trunk/test/clangd/authority-less-uri.test - copied, changed from r3

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi updated this revision to Diff 101929. MontyKutyi added a comment. Just added the whole file instead of a small surrounding to be able to check the `DEF_TRAVERSE_DECL` macro too. https://reviews.llvm.org/D34030 Files: include/clang/AST/RecursiveASTVisitor.h Index: include/clang/A

[clang-tools-extra] r304983 - [clangd] extend completion test

Author: krasimir Date: Thu Jun 8 11:02:27 2017 New Revision: 304983 URL: http://llvm.org/viewvc/llvm-project?rev=304983&view=rev Log: [clangd] extend completion test Modified: clang-tools-extra/trunk/test/clangd/completion.test Modified: clang-tools-extra/trunk/test/clangd/completion.test U

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof commandeered this revision. christof added a reviewer: sanwou01. christof added a comment. This refactoring was ready to land some time ago, except for a few small details. It's a shame if we don't commit this refactoring, so with @sanwou01 his agreement, I'm taking over this patch.

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists created this revision. These are part of C++17. Later, we'll get the parallel versions. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_iter_iter_iter.pass.cpp test/std/numerics/numeric.ops/exclusive.scan/exc

r304984 - [sanitizer-coverage] Allow using KASAN instrumentation with sancov

Author: glider Date: Thu Jun 8 11:24:21 2017 New Revision: 304984 URL: http://llvm.org/viewvc/llvm-project?rev=304984&view=rev Log: [sanitizer-coverage] Allow using KASAN instrumentation with sancov Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof updated this revision to Diff 101933. christof marked 6 inline comments as done. christof added a comment. Rebased onto current HEAD and addressed the comments from Reid. https://reviews.llvm.org/D31709 Files: include/clang/Basic/SourceLocation.h include/clang/Frontend/DiagnosticRe

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof added a comment. @rnk can you let me know if you are happy with the changes? @rovka I assume the rebase did not change your mind about the patch. But please let me know if you have new reservations. Thanks Comment at: lib/Frontend/DiagnosticRenderer.cpp:512 // Pro

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

chh added a comment. In https://reviews.llvm.org/D34002#775830, @alexfh wrote: > IIUC, when `vector` (for a class `T` that has both move and copy > constructors) resizes, it will prefer move constructors, but only if they're > declared `noexcept`. This is true even if `-fno-exceptions` is on.

[clang-tools-extra] r304988 - Wdocumentation fix.

Author: rksimon Date: Thu Jun 8 12:01:01 2017 New Revision: 304988 URL: http://llvm.org/viewvc/llvm-project?rev=304988&view=rev Log: Wdocumentation fix. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNoexceptCheck.h Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNoexce

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

How did it break it? Any logs? On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rengolin > Date: Mon Jun 5 02:35:45 2017 > New Revision: 304697 > > URL: http://llvm.org/viewvc/llvm-project?rev=304697&view=rev > Log: > Revert "[sanitizer

[PATCH] D33493: Speed up preamble loading

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one inline request below. I also have a question: what kind of performance benefits do you get for the preamble load times? Comment at: lib/Frontend/ASTUnit.c

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

arphaman added inline comments. Comment at: test/Index/availability.c:20 // CHECK-2: (macos, introduced=10.4, deprecated=10.5, obsoleted=10.7) // CHECK-2: EnumConstantDecl=old_enum:6:3 (Definition) (deprecated) rdwampler wrote: > Can we run `FileCheck` once n

RE: r284060 - Implement MS _BitScan intrinsics

Yes, we definitely do not want to introduce pointer-type incompatibility warnings. Predicating the behavior change on LP64 vs LLP64 seems better. What’s the best way to do that? Brian and I can hack on clang a bit, but we’re certainly not experts. Schwieb From: Saleem Abdulrasool [mailto:comp

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

This revision was automatically updated to reflect the committed changes. Closed by commit rL304994: Frontend support for Nios2 target. (authored by n.bozhenov). Changed prior to commit: https://reviews.llvm.org/D33356?vs=100674&id=101941#toc Repository: rL LLVM https://reviews.llvm.org/D33

r304994 - Frontend support for Nios2 target.

Author: n.bozhenov Date: Thu Jun 8 12:40:30 2017 New Revision: 304994 URL: http://llvm.org/viewvc/llvm-project?rev=304994&view=rev Log: Frontend support for Nios2 target. Summary: - Implements TargetInfo class for Nios2 target. - Enables handling of -march and -mcpu options for Nios2 target. - D

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

Ah, I see https://bugs.llvm.org/show_bug.cgi?id=33308, moving the discussion there. On Thu, Jun 8, 2017 at 10:05 AM, Kostya Serebryany wrote: > How did it break it? > Any logs? > > On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: r

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33976: [clang] Fix format specifiers fixits

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with a couple of fixes: Comment at: test/FixIt/fixit-format-darwin.m:3 +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only -f

r304996 - [Sema] Remove unused field from OverloadCandidate.

Author: gbiv Date: Thu Jun 8 13:19:25 2017 New Revision: 304996 URL: http://llvm.org/viewvc/llvm-project?rev=304996&view=rev Log: [Sema] Remove unused field from OverloadCandidate. The only use in-tree I can find for BuiltinTypes.ResultTy is a single store to it. We otherwise just recompute what

r304997 - Added llvm_unreachable to make sure the switch is always exhaustive.

Author: gkistanova Date: Thu Jun 8 13:20:32 2017 New Revision: 304997 URL: http://llvm.org/viewvc/llvm-project?rev=304997&view=rev Log: Added llvm_unreachable to make sure the switch is always exhaustive. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplat

[libcxx] r305000 - [libcxx] [test] Update locale names for Windows.

Author: stl_msft Date: Thu Jun 8 13:22:03 2017 New Revision: 305000 URL: http://llvm.org/viewvc/llvm-project?rev=305000&view=rev Log: [libcxx] [test] Update locale names for Windows. locale.codecvt.byname/ctor_char.pass.cpp: This test used to use "en_US" as a plain string instead of using platf

[libcxx] r304999 - [libcxx] [test] Remove a Clang/C2 workaround.

Author: stl_msft Date: Thu Jun 8 13:21:59 2017 New Revision: 304999 URL: http://llvm.org/viewvc/llvm-project?rev=304999&view=rev Log: [libcxx] [test] Remove a Clang/C2 workaround. Clang/LLVM doesn't need this workaround. Fixes D33955. Modified: libcxx/trunk/test/std/utilities/optional/opt

r305002 - Revert "Frontend support for Nios2 target"

Author: n.bozhenov Date: Thu Jun 8 13:36:35 2017 New Revision: 305002 URL: http://llvm.org/viewvc/llvm-project?rev=305002&view=rev Log: Revert "Frontend support for Nios2 target" As it breaks many buildbots. Removed: cfe/trunk/include/clang/Basic/BuiltinsNios2.def cfe/trunk/test/Driver/

RE: r284060 - Implement MS _BitScan intrinsics

It’s probably also better to not try to infer our weird desired behavior. It should probably be controlled by a specific driver directive, like “-fms-extensions-lp64-intrinsics” or something like that. Using a new directive means that nobody can accidentally get this behavior if they for some re

[PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

vsk added a comment. I've encountered some new diagnostics when running tests on a stage2 instrumented clang, and will need more time to investigate them. Sorry for the delayed communication, I am a bit swamped this week owing to wwdc and being a build cop. https://reviews.llvm.org/D33910

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. Suppose you have: struct A {}; struct B {}; A operator+(A, B); std::vector v; std::reduce(v.begin(), v.end(), A{}); The implementation in this patch works fine for the above case - as would `accumulate`, which it is equivalent to. However, `reduce` requires

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. I think the test `reduce_iter_iter_T.pass.cpp` can be improved a little bit. Right now, it: - Tests that the three argument overload (iterators + init) work correctly when the iterator value type is the same as the init type. - Tests that the return type of the three argum

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 101955. yaxunl retitled this revision from "Support synchronisation scope in Clang atomic builtin functions" to "Add OpenCL 2.0 atomic builtin functions as Clang builtin". yaxunl edited the summary of this revision. yaxunl added a comment. Add __opencl_atomic

[PATCH] D34022: Repair 2010-05-31-palignr.c test

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you need someone to commit it? https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator < revi...@reviews.llvm.org> wrote: > joerg added a comment. > > In https://reviews.llvm.org/D33726#774105, @ruiu wrote: > > > I'm totally against adding per-OS path knowledge to our linker. > Compilers already know include paths an

r305013 - [Sema] Refactor OverloadCandidate::BuiltinTypes. NFC.

Author: gbiv Date: Thu Jun 8 15:55:21 2017 New Revision: 305013 URL: http://llvm.org/viewvc/llvm-project?rev=305013&view=rev Log: [Sema] Refactor OverloadCandidate::BuiltinTypes. NFC. As promised in r304996. Modified: cfe/trunk/include/clang/Sema/Overload.h cfe/trunk/lib/Sema/SemaExprCX

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from one minor nit, LGTM! Comment at: include/clang/AST/Decl.h:901 +/// member functions. +unsigned ImplicitParamKind : 3; };

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:335 unsigned Unsigned; +double Double; bool Boolean; Lekenstey

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [clang-tools-extra] r304949 - [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

Hello Yan, This commit broke few of our builders: Failing Tests (1): Clang Tools :: clang-tidy/misc-noexcept-move-constructor.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12411 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows

[PATCH] D34022: Repair 2010-05-31-palignr.c test

v.g.vassilev added a comment. Raphael and I work together I can take care of it... https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34022: Repair 2010-05-31-palignr.c test

echristo added a comment. Thanks! https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

rsmith added inline comments. Comment at: include/numeric:145 +{ +return reduce(__first, __last, __init, _VSTD::plus<>()); +} Missing _VSTD:: Comment at: include/numeric:153 +{ +return reduce(__first, __last, + typename iterator_

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Hello Alexander, Couple of our builders do not like this commit: Failing Tests: Clang Tools :: clang-tidy/modernize-use-noexcept-opt.cpp Clang Tools :: clang-tidy/modernize-use-noexcept.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12431 http://

[PATCH] D33976: [clang] Fix format specifiers fixits

alexshap updated this revision to Diff 101962. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D33976 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index: test/FixIt/fixit-format-darwin.m ===

r305018 - [clang] Fix format specifiers fixits

Author: alexshap Date: Thu Jun 8 16:44:45 2017 New Revision: 305018 URL: http://llvm.org/viewvc/llvm-project?rev=305018&view=rev Log: [clang] Fix format specifiers fixits This diff fixes printf "fixits" in the case when there is a wrapping macro and the format string needs multiple replacements

[PATCH] D33976: [clang] Fix format specifiers fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rL305018: [clang] Fix format specifiers fixits (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D33976?vs=101962&id=101964#toc Repository: rL LLVM https://reviews.llvm.org/D33

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

This revision was automatically updated to reflect the committed changes. Closed by commit rL305021: [ASTMatchers] Add support for floatLiterals (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33135?vs=101816&id=101968#toc Repository: rL LLVM https://reviews.llv

[PATCH] D33093: [ASTMatchers] Add support for boolean literals

This revision was automatically updated to reflect the committed changes. Closed by commit rL305020: [ASTMatchers] Add support for boolean literals (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33093?vs=98781&id=101966#toc Repository: rL LLVM https://reviews.l

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL305022: [ASTMatchers] Add clang-query support for equals matcher (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33094?vs=101817&id=101967#toc Repository: rL LLVM https:

r305021 - [ASTMatchers] Add support for floatLiterals

Author: lekensteyn Date: Thu Jun 8 17:00:50 2017 New Revision: 305021 URL: http://llvm.org/viewvc/llvm-project?rev=305021&view=rev Log: [ASTMatchers] Add support for floatLiterals Summary: Needed to support something like "floatLiteral(equals(1.0))". The parser for floating point numbers is kept

r305020 - [ASTMatchers] Add support for boolean literals

Author: lekensteyn Date: Thu Jun 8 17:00:38 2017 New Revision: 305020 URL: http://llvm.org/viewvc/llvm-project?rev=305020&view=rev Log: [ASTMatchers] Add support for boolean literals Summary: Recognize boolean literals for future extensions ("equals(true)"). Note that a specific VariantValue con

r305022 - [ASTMatchers] Add clang-query support for equals matcher

Author: lekensteyn Date: Thu Jun 8 17:00:58 2017 New Revision: 305022 URL: http://llvm.org/viewvc/llvm-project?rev=305022&view=rev Log: [ASTMatchers] Add clang-query support for equals matcher Summary: This allows the clang-query tool to use matchers like "integerLiteral(equals(32))". For this t

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

On 08.06.2017 22:39, Rui Ueyama wrote: > On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > > joerg added a comment. > > In https://reviews.llvm.org/D33726#774105 > , @ruiu wrote: > >

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. For all the `transform_` variants, the spec allows the "inner" operation (the transformation)'s return type is not constrained. We should have a test for this. For example, consider the binary-unary `transform_reduce` implementation: template inline _LIBCPP_INLINE_VI

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

It looks like the buildbots have exceptions turned off by default, so the tests need to use `-fexceptions` explicitly. Testing a fix... On Thu, Jun 8, 2017 at 11:26 PM, Galina Kistanova wrote: > Hello Alexander, > > Couple of our builders do not like this commit: > > Failing Tests: > > Clang

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

I don't remember the details, but I believe LLD-generated executables are fine with either Linux or on NetBSD On Thu, Jun 8, 2017 at 3:08 PM, Kamil Rytarowski wrote: > On 08.06.2017 22:39, Rui Ueyama wrote: > > On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator > > mailto:revi...

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. In https://reviews.llvm.org/D34002#776193, @chh wrote: > In https://reviews.llvm.org/D34002#775830, @alexfh wrote: > > > IIUC, when `vector` (for a class `T` that has both move and copy > > constructors) resizes, it will prefer move constructors, but only if > > they're

Re: [PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

On Thu, Jun 8, 2017 at 6:24 PM, Alexander Kornienko via Phabricator wrote: > alexfh added a comment. > > In https://reviews.llvm.org/D34002#776193, @chh wrote: > >> In https://reviews.llvm.org/D34002#775830, @alexfh wrote: >> >> > IIUC, when `vector` (for a class `T` that has both move and copy >

[clang-tools-extra] r305024 - [clang-tidy] Use -fexceptions explicitly in the tests that need exceptions.

Author: alexfh Date: Thu Jun 8 17:25:23 2017 New Revision: 305024 URL: http://llvm.org/viewvc/llvm-project?rev=305024&view=rev Log: [clang-tidy] Use -fexceptions explicitly in the tests that need exceptions. This should fix relevant buildbot breakages. Modified: clang-tools-extra/trunk/test

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added inline comments. Comment at: test/clang-tidy/misc-noexcept-move-constructor.cpp:2 +// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ +// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ +// RUN: -implicit-check-not="{{warning|

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

I managed to link a hello world application, however the NetBSD-specific nits stand for production programs. RPATH is the first difference that matters. Unfortunately I'm swamped by other LLVM projects to join LLD.. research other differences and prepare patches myself. On 09.06.2017 00:11, Rui U

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. Minor note: there's a mix of tabs and spaces in this diff. https://reviews.llvm.org/D34007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33976: [clang] Fix format specifiers fixits

mehdi_amini added a comment. In https://reviews.llvm.org/D33976#775918, @alexshap wrote: > @mehdi_amini , thanks, i see, regarding the "opposite issue" - probably an > example / test case would be helpful, that looks like a separate issue. > Thanks for adding @ahatanak and @arphaman, that would

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. So, `inclusive_scan` should be equivalent to `partial_sum` for the non-parallel version. https://reviews.llvm.org/D34007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. Here's `partial_sum`: template inline _LIBCPP_INLINE_VISIBILITY _OutputIterator partial_sum(_InputIterator __first, _InputIterator __last, _OutputIterator __result, _BinaryOperation __binary_op) { if (__first != __last) { typen

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. I think we need a test case like this for all of the `transform_*`s struct A {}; struct B {}; struct C {}; B unary_op(C); B unary_op(A) { assert(false); /* unary op applied to init value! */ } A binary_op(A, A); A binary_op(A, B); A binary_op(B, A); A bi

  1   2   >