arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land.
Thanks for working on this! LGTM with a couple of fixes: ================ Comment at: test/FixIt/fixit-format-darwin.m:3 +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only -fblocks -Wformat -fixit %t +// RUN: grep -v CHECK %t > %t2 +// RUN: FileCheck -input-file=%t2 %s ---------------- You can just pipe the result of `grep` into `FileCheck` without using another temporary file. ================ Comment at: test/FixIt/fixit-format-darwin.m:54 + + // Aritificial test to check that X (in Log3(X, Y, Z)) + // is modified only according to the diagnostics ---------------- Typo: `Artificial`. Repository: rL LLVM https://reviews.llvm.org/D33976 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
