GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/SemaCXX/coroutines.cpp:842
+struct bad_await_suspend_return {
+ bool await_ready();
+ // expected-error@+1 {{the return type of 'await_suspe
GorNishanov added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:324
struct ReadySuspendResumeResult {
+ enum AwaitCallType { ACT_Ready, ACT_Suspend, ACT_Resume };
Expr *Results[3];
enum class?
https://reviews.llvm.org/D33625
__
GorNishanov created this revision.
Herald added a subscriber: EricWF.
https://reviews.llvm.org/D33632
Files:
www/cxx_status.html
Index: www/cxx_status.html
===
--- www/cxx_status.html
+++ www/cxx_status.html
@@ -832,7 +832,7 @@
Author: gornishanov
Date: Sun May 28 11:25:31 2017
New Revision: 304091
URL: http://llvm.org/viewvc/llvm-project?rev=304091&view=rev
Log:
[coroutines] www/cxx_status.html: add non-breaking hyphen
Reviewers: GorNishanov
Reviewed By: GorNishanov
Subscribers: EricWF, rsmith, cfe-commits
Different
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304091: [coroutines] www/cxx_status.html: add non-breaking
hyphen (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33632?vs=100552&id=100553#toc
Repository:
rL LLVM
http
GorNishanov updated this revision to Diff 100555.
GorNishanov added a comment.
one more non-breaking hyphen to make it pretty in chrome. In edge it is perfect
already, naturally
https://reviews.llvm.org/D33632
Files:
www/cxx_status.html
Index: www/cxx_status.html
==
Author: gornishanov
Date: Sun May 28 12:35:23 2017
New Revision: 304092
URL: http://llvm.org/viewvc/llvm-project?rev=304092&view=rev
Log:
[coroutines] www/cxx_status.html: add non-breaking hyphen
Reviewers: GorNishanov
Reviewed By: GorNishanov
Subscribers: EricWF, rsmith, cfe-commits
Different
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304092: [coroutines] www/cxx_status.html: add non-breaking
hyphen (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33632?vs=100555&id=100556#toc
Repository:
rL LLVM
http
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:324
struct ReadySuspendResumeResult {
+ enum AwaitCallType { ACT_Ready, ACT_Suspend, ACT_Resume };
Expr *Results[3];
GorNishanov wrote:
> enum class
EricWF updated this revision to Diff 100557.
EricWF added a comment.
- Add requested test case.
https://reviews.llvm.org/D33625
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cpp
Author: ericwf
Date: Sun May 28 13:21:12 2017
New Revision: 304094
URL: http://llvm.org/viewvc/llvm-project?rev=304094&view=rev
Log:
[coroutines] Diagnose invalid result types for `await_resume` and
`await_suspend` and add missing conversions.
Summary:
The expression `await_ready` is required t
Author: ericwf
Date: Sun May 28 14:38:21 2017
New Revision: 304101
URL: http://llvm.org/viewvc/llvm-project?rev=304101&view=rev
Log:
[coroutines] Add end-to-end tests within libc++
This patch adds end-to-end/breathing tests for coroutines
into libc++. The tests aren't specifically to test libc++
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8977-8980
+ "the return type of 'await_suspend' is required to be 'void' or 'bool' (have
%0)"
+>;
+def note_await_ready_no_bool_conversion : Note<
+ "the return type of 'await_ready' is requir
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:393
+// - await-suspend is the expression e.await_suspend(h), which shall be
+// a prvalue of type void or bool.
+QualType RetType = AwaitSuspend->getTy
EricWF created this revision.
@rsmith Does this correctly address the issues mentioned in
https://reviews.llvm.org/D33625#inline-292971 ?
https://reviews.llvm.org/D33636
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test
Author: ericwf
Date: Sun May 28 15:25:41 2017
New Revision: 304102
URL: http://llvm.org/viewvc/llvm-project?rev=304102&view=rev
Log:
Remove XFAIL's for recently fixed bug
Modified:
libcxx/trunk/test/libcxx/experimental/language.support/support.coroutines/dialect_support.sh.cpp
Modified:
li
Author: ericwf
Date: Sun May 28 15:30:18 2017
New Revision: 304103
URL: http://llvm.org/viewvc/llvm-project?rev=304103&view=rev
Log:
Add hack to allow test to run w/o C++17 copy elision
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.
On 28 May 2017 at 12:53, Eric Fiselier via Phabricator <
revi...@reviews.llvm.org> wrote:
> EricWF marked an inline comment as done.
> EricWF added inline comments.
>
>
>
> Comment at: lib/Sema/SemaCoroutine.cpp:393
> +// - await-suspend is the expression e.await_suspend(h),
Author: ericwf
Date: Sun May 28 15:49:13 2017
New Revision: 304105
URL: http://llvm.org/viewvc/llvm-project?rev=304105&view=rev
Log:
Fix use of uninitialized memory
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/expected.sh.cpp
Modified:
libcxx/
Author: ericwf
Date: Sun May 28 15:49:11 2017
New Revision: 304104
URL: http://llvm.org/viewvc/llvm-project?rev=304104&view=rev
Log:
XFAIL tests which trigger coroutine debug info crash in Clang
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_
Author: ericwf
Date: Sun May 28 15:56:16 2017
New Revision: 304106
URL: http://llvm.org/viewvc/llvm-project?rev=304106&view=rev
Log:
Correct XFAIL's in coroutine tests to only list ubsan
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_su
EricWF updated this revision to Diff 100567.
EricWF added a comment.
This patch was initially reverted due to a failing test it caused elsewhere;
which has been address in this version.
https://reviews.llvm.org/D33538
Files:
docs/Modules.rst
lib/Basic/Module.cpp
test/Index/index-module.m
Author: ericwf
Date: Sun May 28 16:07:22 2017
New Revision: 304107
URL: http://llvm.org/viewvc/llvm-project?rev=304107&view=rev
Log:
[coroutines] Support "coroutines" feature in module map requires clause
Summary: In order for libc++ to add `` to its module
map, there has to be a feature that ca
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Thanks for looking into this, its been on my list for a while now.
Comment at: src/cxa_demangle.cpp:2918
}
+if (!isalpha(*p0) && !isdigit(*p0) && *p0 !=
szepet added a comment.
Some nits added, other than these it looks good to me. Thank you!
Just more one question, I can see 3 different cases how the import returns are
handled:
- if(!ToDecl) return nullptr;
- if(!ToDecl && FromDecl) return nullptr;
- no handling: ObjectXY::Create(...Import(Fro
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks. One request for additional tests, but feel free to commit
when that's ready.
Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:258
+ take(u.h
Author: martell
Date: Sun May 28 17:46:50 2017
New Revision: 304110
URL: http://llvm.org/viewvc/llvm-project?rev=304110&view=rev
Log:
[libcxxabi] Disable DLL annotations on static
rL288692 renames
_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT to
_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
Modified:
lib
rjmccall added inline comments.
Comment at: include/clang/AST/VTableBuilder.h:160
+ "GlobalDecl can be created only from virtual function");
+if (getKind() == CK_FunctionPointer)
+ return GlobalDecl(getFunctionDecl());
Prazek wrote:
> rjmccall
Author: epilk
Date: Sun May 28 18:15:50 2017
New Revision: 304113
URL: http://llvm.org/viewvc/llvm-project?rev=304113&view=rev
Log:
[demangler] Fix a exponential string copying bug
The problem was that if base_name() was called from a context without
an actual base name, it could gulp up the enti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304113: [demangler] Fix a exponential string copying bug
(authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33637?vs=100568&id=100574#toc
Repository:
rL LLVM
https://reviews.llv
Author: ericwf
Date: Mon May 29 00:00:24 2017
New Revision: 304124
URL: http://llvm.org/viewvc/llvm-project?rev=304124&view=rev
Log:
Fix multiple bugs in coroutine tests.
Modified:
libcxx/trunk/include/experimental/coroutine
libcxx/trunk/test/libcxx/experimental/language.support/support.
Author: mehdi_amini
Date: Mon May 29 00:38:20 2017
New Revision: 304127
URL: http://llvm.org/viewvc/llvm-project?rev=304127&view=rev
Log:
IRGen: Add optnone attribute on function during O0
Amongst other, this will help LTO to correctly handle/honor files
compiled with O0, helping debugging failur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304127: IRGen: Add optnone attribute on function during O0
(authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D28404?vs=83480&id=100580#toc
Repository:
rL LLVM
https://revi
Author: ericwf
Date: Mon May 29 01:42:01 2017
New Revision: 304131
URL: http://llvm.org/viewvc/llvm-project?rev=304131&view=rev
Log:
Fix coroutine test failures caused by API misusages.
More tests to come. I think that from_address overload should be deleted
or ill-formed, except for the 'void*'
34 matches
Mail list logo
