compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Thanks for looking into this, its been on my list for a while now.
================
Comment at: src/cxa_demangle.cpp:2918
}
+ if (!isalpha(*p0) && !isdigit(*p0) && *p0 != '_')
+ {
----------------
Hmm, I wonder if we should negate and hoist this into the condition rather than
the explicit check here. It makes it slightly more obvious what we are trying
to do here. However, it does make failing more challenging (since we cannot as
easily identify if the extraction failed.
https://reviews.llvm.org/D33637
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
