rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land.
Looks great, thanks. One request for additional tests, but feel free to commit when that's ready. ================ Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:258 + take(u.h); +} ---------------- Please include test cases involving classes that only have a virtual pointer in a field of a base class — e.g. something that inherits from HoldingVirtuals. And be sure to cover both normal and virtual inheritance. https://reviews.llvm.org/D31830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
