r302003 - Silences gcc's -Wnarrowing.

Author: djasper Date: Wed May 3 02:48:27 2017 New Revision: 302003 URL: http://llvm.org/viewvc/llvm-project?rev=302003&view=rev Log: Silences gcc's -Wnarrowing. I think this is a false positive in GCC's warning, but nonetheless, we should try to be warning-free. Smaller reproducer (reproduces wi

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie created this revision. This change fixes std::inplace_merge to be stable for all inputs and adds corresponding tests. Fixes Bug 31166: https://bugs.llvm.org//show_bug.cgi?id=31166 https://reviews.llvm.org/D32788 Files: include/algorithm test/std/algorithms/alg.sorting/alg.merge/i

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie added inline comments. Comment at: include/algorithm:4471 _RBi(__middle), _RBi(__first), _RBi(__last), __negate<_Compare>(__comp)); } As marshall pointed out in https://bugs.llvm.org//show_

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

NoQ updated this revision to Diff 97574. NoQ added a comment. Added a reusable bug category. https://reviews.llvm.org/D32702 Files: include/clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h lib/StaticAnalyzer/Checkers/MallocChecker.cpp lib/StaticAnalyzer/Checkers/NullabilityChec

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

a.sidorin accepted this revision. a.sidorin added a comment. Thank you! https://reviews.llvm.org/D32702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

out-of-tree code that uses WeakVH will continue to compile OK but may not perform OK with WeakVH not tracking anymore. May be better not to reuse WeakVH yet so such code will fail compilation. ‫בתאריך יום ב׳, 1 במאי 2017 ב-20:21 מאת ‪Sanjoy Das via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

xazax.hun accepted this revision. xazax.hun added a comment. Even better :) https://reviews.llvm.org/D32702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

dim added a comment. Ping :) https://reviews.llvm.org/D32670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

zizhar added inline comments. Comment at: lib/Basic/TargetInfo.cpp:506 case '!': // Disparage severely. case '*': // Ignore for choosing register preferences. +case 'i': // Ignore i as output constraint (match from the other chars) ahatanak wrote: >

r301998 - Fix a bug that -isysroot is completely ignored on Unix

Author: yamaguchi Date: Tue May 2 23:58:39 2017 New Revision: 301998 URL: http://llvm.org/viewvc/llvm-project?rev=301998&view=rev Log: Fix a bug that -isysroot is completely ignored on Unix -isysroot is the flag which set the system root directory. This bug report https://bugs.llvm.org//show_bug

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. Uhm, i need to do something about this duplicate account. Sorry, I have completely forgotten that the review is already up... Repository: rL LLVM https://reviews.llvm.org/D32449 __

[PATCH] D32796: [Driver] Add a "-mmacos_version_min" option that's an alias for "-mmacosx_version_min"

arphaman created this revision. The option `-mmacosx_version_min` will still be the canonical option for now, but in the future we will switch over to `-mmacos_version_min` and make `-mmacosx_version_min` an alias instead. Repository: rL LLVM https://reviews.llvm.org/D32796 Files: includ

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

zizhar updated this revision to Diff 97602. https://reviews.llvm.org/D31383 Files: lib/Basic/TargetInfo.cpp test/Sema/asm.c Index: test/Sema/asm.c === --- test/Sema/asm.c +++ test/Sema/asm.c @@ -160,6 +160,41 @@ return ret;

r302012 - Undo turning ExtBehavior into a bitfield.

Author: djasper Date: Wed May 3 06:27:34 2017 New Revision: 302012 URL: http://llvm.org/viewvc/llvm-project?rev=302012&view=rev Log: Undo turning ExtBehavior into a bitfield. This produces warnings that I can't explain in a GCC build: In file included from ../tools/clang/include/clang/Lex/LexDi

r302016 - [analyzer] Fix memory error bug category capitalization.

Author: dergachev Date: Wed May 3 06:47:13 2017 New Revision: 302016 URL: http://llvm.org/viewvc/llvm-project?rev=302016&view=rev Log: [analyzer] Fix memory error bug category capitalization. It was written as "Memory Error" in most places and as "Memory error" in a few other places, however it

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302016: [analyzer] Fix memory error bug category capitalization. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D32702?vs=97574&id=97609#toc Repository: rL LLVM https://r

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

NoQ added a comment. Thanks for uploading this to phabricator and sorry again that i was lost for a while. As we already discussed in the mailing lists, i agree with your point that the locked-and-possibly-destroyed state should be removed, and we also had a thought of making it explicit that

[PATCH] D32332: Add support for transparent overloadable functions in clang

aaron.ballman added a comment. In https://reviews.llvm.org/D32332#742796, @george.burgess.iv wrote: > thanks for the feedback! > > fwiw, at a high level, the main problem i'm trying to solve with this is that > you can't really make a `__overloadable_without_mangling` macro without > handing it

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

chenwj added a comment. > Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m (line > 11). I ran the lit tests initially with a breakpoint on this line and it > never hit, though I must have set up the debugger wrong. Once I replaced it > with an assert, method-bad-param fa

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

aaron.ballman added a comment. Thank you for working on this check! Comment at: clang-tidy/cert/CERTTidyModule.cpp:22 #include "FloatLoopCounter.h" +#include "PostfixOperatorCheck.h" #include "LimitedRandomnessCheck.h" Please keep the list of includes alphabe

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

alexfh added a comment. Thank you! One comment inline. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; This should be a node matcher rather than a narrowing matcher,

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

kuhar added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; alexfh wrote: > This should be a node matcher rather than a narrowing matcher, and it shoul

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev added a comment. I think the second sentence is important. https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Sorry, ignore my previous comment. LGTM! https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

Hi Richard, This commit has caused an infinite loop in one of our internal libclang based tooling tests. It keeps repeating the following frames: frame #33528: 0x000109db2edf libclang.dylib`clang::DiagnosticsEngine::ReportDelayed(this=0x00011c002c00) at Diagnostic.cpp:149 frame #3

r302024 - Reusing an existing attribute diagnostic

Author: orenb Date: Wed May 3 09:05:00 2017 New Revision: 302024 URL: http://llvm.org/viewvc/llvm-project?rev=302024&view=rev Log: Reusing an existing attribute diagnostic In a previous patch, a new generic error diagnostic for inconsistent attributes was added. In this commit I reuse this diag

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk added a comment. In https://reviews.llvm.org/D32745#744292, @frej wrote: > In https://reviews.llvm.org/D32745#744280, @rnk wrote: > > > The REQUIRES tag is unnecessary. Clang can emit IR for any target without a > > registered backed. > > > So should I drop it? It doesn't hurt does it? Som

[PATCH] D32700: [clang-tidy] Add misc-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 97646. rnkovacs edited the summary of this revision. rnkovacs added a comment. - Fixed function call format in docs. - Added check to release notes. https://reviews.llvm.org/D32700 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cp

[PATCH] D32700: [clang-tidy] Add misc-suspicious-memset-usage check.

rnkovacs added a comment. In https://reviews.llvm.org/D32700#743178, @malcolm.parsons wrote: > Can you change this to match any pointer to a class with a virtual function? Well, I have just found a clang flag `-Wdynamic-class-memaccess`

[PATCH] D32796: [Driver] Add a "-mmacos_version_min" option that's an alias for "-mmacosx_version_min"

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D32796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

carlo.bertolli created this revision. This patch allows the map modifier 'always' to be separated by the map type (to, from, tofrom) only by a whitespace, rather than strictly by a comma as in current trunk. Repository: rL LLVM https://reviews.llvm.org/D32807 Files: lib/Parse/ParseOpenMP

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

erichkeane added a comment. In https://reviews.llvm.org/D32759#744613, @chenwj wrote: > > Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m > > (line 11). I ran the lit tests initially with a breakpoint on this line > > and it never hit, though I must have set up the debug

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D31887: [clangd] Add documentation page

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thank you! https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r302031 - [OpenMP] Extended parse for 'always' map modifier

Author: cbertol Date: Wed May 3 10:28:48 2017 New Revision: 302031 URL: http://llvm.org/viewvc/llvm-project?rev=302031&view=rev Log: [OpenMP] Extended parse for 'always' map modifier https://reviews.llvm.org/D32807 This patch allows the map modifier 'always' to be separated by the map type (to

[PATCH] D32378: Insert invariant.group.barrier for pointers comparisons

Prazek added a comment. In https://reviews.llvm.org/D32378#741989, @hubert.reinterpretcast wrote: > Has it been discussed whether this is something to be addressed in the > optimizer as opposed to the front-end? The example that you showed is excellent. I didn't know that LLVM does the transf

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 302031. Repository: rL LLVM https://reviews.llvm.org/D32807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r302037 - DiagnosticsEngine should clear DelayedDiagID before reporting the

Author: arphaman Date: Wed May 3 10:41:16 2017 New Revision: 302037 URL: http://llvm.org/viewvc/llvm-project?rev=302037&view=rev Log: DiagnosticsEngine should clear DelayedDiagID before reporting the delayed diagnostic This avoids an infinite loop that was uncovered in one of our internal tests

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl added a comment. Ah. Thanks for clarifying! We should remove it, then. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; kuhar wrote: > alexfh wrote: > > This should be a node matcher rather than a narrowing mat

Re: r301994 - [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations

This broke a WinASan test that builds with -Werror: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/10647 I tried to fix it in r302043, but I haven't finished testing it yet. On Tue, May 2, 2017 at 6:27 PM, Kostya Serebryany via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Autho

[PATCH] D32810: Add cxxStdInitializerListExpr AST matcher

kuhar created this revision. Herald added a subscriber: klimek. This adds a new ASTMatcher for CXXStdInitializerListExprs that matches C++ initializer list expressions. The primary motivation is to use it to fix PR32896 (review here D32767

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek updated this revision to Diff 97665. phosek added a comment. Done Repository: rL LLVM https://reviews.llvm.org/D32613 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

kuhar added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; Prazek wrote: > kuhar wrote: > > alexfh wrote: > > > This should be a node matcher rather t

r302046 - Revert r302037

Author: arphaman Date: Wed May 3 11:22:16 2017 New Revision: 302046 URL: http://llvm.org/viewvc/llvm-project?rev=302046&view=rev Log: Revert r302037 The commit caused the following two buildbot failures: Clang :: Misc/error-limit-multiple-notes.cpp Clang :: Misc/error-limit.c Removed:

Re: r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

Hi Yaron, On Wed, May 3, 2017 at 2:11 AM, Yaron Keren wrote: > out-of-tree code that uses WeakVH will continue to compile OK but may not > perform OK with WeakVH not tracking anymore. > May be better not to reuse WeakVH yet so such code will fail compilation. Typically we tend to focus on simpli

[PATCH] D32810: Add cxxStdInitializerListExpr AST matcher

alexfh added a comment. Please add a test. Repository: rL LLVM https://reviews.llvm.org/D32810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32810: Add cxxStdInitializerListExpr AST matcher

malcolm.parsons added a comment. Please run `docs/tools/dump_ast_matchers.py` to update the docs. Repository: rL LLVM https://reviews.llvm.org/D32810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk accepted this revision. rnk added a comment. Looks good without the REQUIRES line, thanks for the fix! It's unfortunate that this logic is here and in CodeGen/AsmPrinter/DwarfUnit.cpp, but such is life. https://reviews.llvm.org/D32745 ___ cfe-

Fix two-stage build on windows using DistributionExample cmake cache

I've added a correct compiler name for bootstrap builds on windows. Also added an opportunity to override stage2 cache file to make distribution example more flexible. fix_win_example_distribution.patch Description: Binary data ___ cfe-commits mailing l

[PATCH] D32815: [clang-tidy][CMake] Make clang-tidy usable as distribution component

phosek created this revision. phosek added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Use add_clang_tool rather than add_clang_executable to support clang-tidy as a distribution component. Repository: rL LLVM https://reviews.llvm.org/D32815 Files: clang-tid

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek created this revision. Herald added a subscriber: mgorny. This relies on the multi-target runtimes build support. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake ===

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23 +AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) { + return true; kuhar wrote: > Prazek wrote: > > kuhar wrote: > > > alexfh wrote: > > > > This shou

r302060 - [IR] Abstract away ArgNo+1 attribute indexing as much as possible

Author: rnk Date: Wed May 3 13:17:31 2017 New Revision: 302060 URL: http://llvm.org/viewvc/llvm-project?rev=302060&view=rev Log: [IR] Abstract away ArgNo+1 attribute indexing as much as possible Summary: Do three things to help with that: - Add AttributeList::FirstArgIndex, which is an enumerato

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D32613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: r301994 - [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations

Thanks! On Wed, May 3, 2017 at 9:15 AM, Reid Kleckner wrote: > This broke a WinASan test that builds with -Werror: > http://lab.llvm.org:8011/builders/sanitizer-windows/builds/10647 > > I tried to fix it in r302043, but I haven't finished testing it yet. > > On Tue, May 2, 2017 at 6:27 PM, Kosty

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:60 + + sys_fn_decay_str(SYS_STRING); // Not Ok - should it be ok? + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: do not implicitly decay an array

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv added a comment. > I'd like to understand this use case a little bit better. If you don't > perform the mangling, then choosing which overload gets called is already > based on the source order, isn't it? See https://godbolt.org/g/8b10Ns I think I might have miscommunicated: `

[PATCH] D32810: Add cxxStdInitializerListExpr AST matcher

kuhar updated this revision to Diff 97700. kuhar added a comment. I regenerated docs and added unit tests. Thanks for help. Repository: rL LLVM https://reviews.llvm.org/D32810 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Regi

[PATCH] D32810: Add cxxStdInitializerListExpr AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D32810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

kuhar updated this revision to Diff 97704. kuhar added a comment. I switched from a narrowing matcher to a "normal" node matcher. Repository: rL LLVM https://reviews.llvm.org/D32767 Files: clang-tidy/modernize/UseEmplaceCheck.cpp test/clang-tidy/modernize-use-emplace.cpp Index: test/cl

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D32767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv updated this revision to Diff 97698. george.burgess.iv added a comment. We now require `transparently_overloadable` on all redeclarations. Allowing mixed `transparently_overloadable` and `overloadable` coming soon. https://reviews.llvm.org/D32332 Files: include/clang/Basic/

r302066 - Tests: strengthen CHECK line to avoid picking up stray path.

Author: tnorthover Date: Wed May 3 14:20:45 2017 New Revision: 302066 URL: http://llvm.org/viewvc/llvm-project?rev=302066&view=rev Log: Tests: strengthen CHECK line to avoid picking up stray path. A bot had "-LTO" in its working directory, which matched the regex used in this test. Since the arg

[PATCH] D32824: [libc++] Use placeholder return types to avoid hard errors during overload resolution

Arcoth created this revision. Herald added a reviewer: EricWF. See https://bugs.llvm.org/show_bug.cgi?id=32856. Basically, as this code was written before placeholder return types for functions were a thing, the function call operators of __bind apply decltype on the call expression to infer the

[PATCH] D32825: [clang-format] Improve understanding of combined typedef+record declarations

jtbandes created this revision. Herald added a subscriber: klimek. Fixes an issue where `struct A { int X; };` would be broken onto multiple lines, but `typedef struct A { int X; } A2;` was collapsed onto a single line. https://reviews.llvm.org/D32825 Files: lib/Format/UnwrappedLineFormatter

[libcxx] r302070 - Merge r300397 - Fix PR32642 - string::insert and string::append don't work with move_iterator.

Author: ericwf Date: Wed May 3 14:48:55 2017 New Revision: 302070 URL: http://llvm.org/viewvc/llvm-project?rev=302070&view=rev Log: Merge r300397 - Fix PR32642 - string::insert and string::append don't work with move_iterator. Modified: libcxx/branches/release_40/include/string libcxx/

[libcxx] r302071 - Merge r296561 - Fix PR32097 - is_abstract doesn't work on class templates.

Author: ericwf Date: Wed May 3 14:50:39 2017 New Revision: 302071 URL: http://llvm.org/viewvc/llvm-project?rev=302071&view=rev Log: Merge r296561 - Fix PR32097 - is_abstract doesn't work on class templates. Modified: libcxx/branches/release_40/include/type_traits libcxx/branches/release

[PATCH] D32824: [libc++] Use placeholder return types to avoid hard errors during overload resolution

EricWF added a comment. Please add a test for this. https://reviews.llvm.org/D32824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302079 - [Driver] Update AArch64 testcase to match llvm r302078.

Author: ab Date: Wed May 3 15:34:32 2017 New Revision: 302079 URL: http://llvm.org/viewvc/llvm-project?rev=302079&view=rev Log: [Driver] Update AArch64 testcase to match llvm r302078. Modified: cfe/trunk/test/Preprocessor/aarch64-target-features.c Modified: cfe/trunk/test/Preprocessor/aarch

[PATCH] D32828: [Modules] Fix conservative assertion for import diagnostics

bruno created this revision. We currenltly assert when want to diagnose a missing import and the decl in question is already visible. It turns out that the decl in question might be visible because another decl from the same module actually made the module visible in a previous error diagnostic

[libcxx] r302082 - Qualify calls to __invoke, __apply_fuctor, and __mu

Author: ericwf Date: Wed May 3 16:02:19 2017 New Revision: 302082 URL: http://llvm.org/viewvc/llvm-project?rev=302082&view=rev Log: Qualify calls to __invoke, __apply_fuctor, and __mu Modified: libcxx/trunk/include/functional Modified: libcxx/trunk/include/functional URL: http://llvm.org/v

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Comment at: test/support/msvc_stdlib_force_include.hpp:76 +#include + Is the `stdlib.h` include above not enough?

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

EricWF added a comment. Also you're free to commit to MSVC specific files without pre-commit review :-) https://reviews.llvm.org/D32726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

On 3 May 2017 at 07:29, Alex L wrote: > Hi Richard, > > This commit has caused an infinite loop in one of our internal libclang > based tooling tests. It keeps repeating the following frames: > > frame #33528: 0x000109db2edf libclang.dylib`clang:: > DiagnosticsEngine::ReportDelayed(this=0

[libcxx] r302084 - Attempt to fix appveyor build

Author: ericwf Date: Wed May 3 16:14:26 2017 New Revision: 302084 URL: http://llvm.org/viewvc/llvm-project?rev=302084&view=rev Log: Attempt to fix appveyor build Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/ap

Re: r302037 - DiagnosticsEngine should clear DelayedDiagID before reporting the

On 3 May 2017 at 08:41, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Wed May 3 10:41:16 2017 > New Revision: 302037 > > URL: http://llvm.org/viewvc/llvm-project?rev=302037&view=rev > Log: > DiagnosticsEngine should clear DelayedDiagID before reportin

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. Ping. @arphaman I'd like to remove them, absent a concrete plan to fix this from folks with a vested interest in them (i.e. you). https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D32824: [libc++] Use placeholder return types to avoid hard errors during overload resolution

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This change regresses other code. By changing `__bind_return<...>::type` into `decltype(auto)` you prevent the member functions from SFINAE'ing. For example: #include struct

[PATCH] D32824: [libc++] Use placeholder return types to avoid hard errors during overload resolution

Arcoth added a comment. In https://reviews.llvm.org/D32824#745392, @EricWF wrote: > This change regresses other code. By changing `__bind_return<...>::type` into > `decltype(auto)` you prevent the member functions from SFINAE'ing. For > example: > > #include > > struct Func { > templ

[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

dexonsmith created this revision. Herald added a subscriber: mgorny. CMake: Only add test/ subdirectory when it exists r296685 started adding the test/ subdirectory even when LIBCXX_INCLUDE_TESTS=OFF. This is great for testing libcxx standalone, but it also breaks the build when the test/ subdir

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

EricWF created this revision. This patch ensures that `__shared_weak_count` provides a consistent vtable regardless of if RTTI is enabled or if we are targeting a static or shared libc++ build. This patch is technically ABI breaking, but only for a very specific configuration that neither Appl

[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm OK with this patch because it's minimally invasive. However it seems strange to support arbitrary configurations that delete random parts of the source tree. https://reviews.llvm.org/D32

[libcxx] r302095 - CMake: Only add test/ subdirectory when it exists

Author: dexonsmith Date: Wed May 3 18:33:54 2017 New Revision: 302095 URL: http://llvm.org/viewvc/llvm-project?rev=302095&view=rev Log: CMake: Only add test/ subdirectory when it exists r296685 started adding the test/ subdirectory even when LIBCXX_INCLUDE_TESTS=OFF. This is great for testing l

[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

dexonsmith added a comment. Thanks for being flexible; committed in r302095. Maybe longer term we could add a CMake configuration for whether to include the tests, but naming it might be hard ;). https://reviews.llvm.org/D32836 ___ cfe-commits ma

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

dexonsmith added a comment. Breaking the ABI of that configuration SGTM. Comment at: src/memory.cpp:126-130 const void* __shared_weak_count::__get_deleter(const type_info&) const _NOEXCEPT { -return 0; +return nullptr; } If this is the right change,

Buildbot numbers for the week of 04/16/2017 - 04/22/2017

Hello everyone, Below are some buildbot numbers for the week of 04/16/2017 - 04/22/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the last week of 04/23/2017 - 04/29/2017

Hello everyone, Below are some buildbot numbers for the last week of 04/23/2017 - 04/29/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk created this revision. Sanitizer blacklists currently apply to all enabled sanitizers. E.g if multiple sanitizers are enabled, it isn't possible to specify a blacklist for one sanitizer and not another. This makes it impossible to load default blacklists for more than one sanitizer, because d

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

vsk abandoned this revision. vsk added a comment. Obsoleted by: https://reviews.llvm.org/D32842 https://reviews.llvm.org/D32043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r302097 - Test commit for Appveyor - Remove incorrect caching logic

Author: ericwf Date: Wed May 3 19:16:35 2017 New Revision: 302097 URL: http://llvm.org/viewvc/llvm-project?rev=302097&view=rev Log: Test commit for Appveyor - Remove incorrect caching logic Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL: http://llvm.org/viewvc/

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

STL_MSFT added inline comments. Comment at: test/support/msvc_stdlib_force_include.hpp:76 +#include + EricWF wrote: > Is the `stdlib.h` include above not enough? It isn't enough. In MSVC there's a distinction between CRT headers like `stdlib.h` and STL header

r302098 - Add #pragma clang module begin/end pragmas and generate them when preprocessing a module.

Author: rsmith Date: Wed May 3 19:29:54 2017 New Revision: 302098 URL: http://llvm.org/viewvc/llvm-project?rev=302098&view=rev Log: Add #pragma clang module begin/end pragmas and generate them when preprocessing a module. These pragmas are intended to simulate the effect of entering or leaving

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

EricWF added inline comments. Comment at: src/memory.cpp:126-130 const void* __shared_weak_count::__get_deleter(const type_info&) const _NOEXCEPT { -return 0; +return nullptr; } dexonsmith wrote: > If this is the right change, seems like the 0/nullptr

[libcxx] r302099 - Fix macro redefinition warnings for _LIBCPP_NO_RTTI

Author: ericwf Date: Wed May 3 20:06:54 2017 New Revision: 302099 URL: http://llvm.org/viewvc/llvm-project?rev=302099&view=rev Log: Fix macro redefinition warnings for _LIBCPP_NO_RTTI Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewv

[libcxx] r302100 - Use nullptr instead of the literal 0

Author: ericwf Date: Wed May 3 20:06:56 2017 New Revision: 302100 URL: http://llvm.org/viewvc/llvm-project?rev=302100&view=rev Log: Use nullptr instead of the literal 0 Modified: libcxx/trunk/include/memory libcxx/trunk/src/memory.cpp Modified: libcxx/trunk/include/memory URL: http://l

[libcxx] r302102 - Attempt to escape paths correctly

Author: ericwf Date: Wed May 3 20:17:22 2017 New Revision: 302102 URL: http://llvm.org/viewvc/llvm-project?rev=302102&view=rev Log: Attempt to escape paths correctly Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL: http://llvm.org/viewvc/llvm-project/libcxx/trun

[libcxx] r302101 - Attempt to setup MSVC 2017

Author: ericwf Date: Wed May 3 20:17:21 2017 New Revision: 302101 URL: http://llvm.org/viewvc/llvm-project?rev=302101&view=rev Log: Attempt to setup MSVC 2017 Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/appve

[libcxx] r302104 - [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

Author: stl_msft Date: Wed May 3 20:35:11 2017 New Revision: 302104 URL: http://llvm.org/viewvc/llvm-project?rev=302104&view=rev Log: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER. _HAS_CXX17 indicates whether MSVC's STL is in C++17 mode. In MSVC there's

[libcxx] r302105 - [libcxx] [test] Strip trailing whitespace. NFC.

Author: stl_msft Date: Wed May 3 20:43:58 2017 New Revision: 302105 URL: http://llvm.org/viewvc/llvm-project?rev=302105&view=rev Log: [libcxx] [test] Strip trailing whitespace. NFC. Modified: libcxx/trunk/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1

  1   2   >