EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM after addressing inline comments. ================ Comment at: test/support/msvc_stdlib_force_include.hpp:76 +#include <ciso646> + ---------------- Is the `stdlib.h` include above not enough? ================ Comment at: test/support/msvc_stdlib_force_include.hpp:78 + +#if _HAS_CXX17 + #define TEST_STD_VER 17 ---------------- Should this be `#if defined(_HAS_CXX17) && _HAS_CXX17` since Clang doesn't define it to the best of my knowledge? (Or maybe Clang/C2 does, IDK) https://reviews.llvm.org/D32726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
