aaron.ballman added inline comments.

================
Comment at: 
test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:60
+
+  sys_fn_decay_str(SYS_STRING);          // Not Ok - should it be ok?
+  // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: do not implicitly decay an 
array into a pointer; consider using gsl::array_view or an explicit cast 
instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
----------------
I think it's reasonable to diagnose on this due to the decay.


================
Comment at: 
test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:86
+
+  user_fn_decay_str(SYS_STRING); // Not Ok - should it be ok?
+  // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: do not implicitly decay an 
array into a pointer; consider using gsl::array_view or an explicit cast 
instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
----------------
Likewise here.


https://reviews.llvm.org/D31130



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D31130: ... Breno Rodrigues Guimaraes via Phabricator via cfe-commits
    • [PATCH] D31... Aaron Ballman via Phabricator via cfe-commits

Reply via email to