sammccall updated this revision to Diff 89982.
sammccall marked an inline comment as done.
sammccall added a comment.
Review comments
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
include-f
Author: sammccall
Date: Tue Feb 28 02:13:15 2017
New Revision: 296446
URL: http://llvm.org/viewvc/llvm-project?rev=296446&view=rev
Log:
[include-fixer] Add usage count to find-all-symbols.
Summary:
Add usage count to find-all-symbols.
FindAllSymbols now finds (most!) main-file usages of the disc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296446: [include-fixer] Add usage count to find-all-symbols.
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D30210?vs=89982&id=89983#toc
Repository:
rL LLVM
https://revie
Author: hokein
Date: Tue Feb 28 03:03:07 2017
New Revision: 296453
URL: http://llvm.org/viewvc/llvm-project?rev=296453&view=rev
Log:
[clang-format] Fix test failure caused by "rm" on some buildbots.
The begining command "rm" will return 1 when there is not such file to
delete.
This patch is to r
Author: christof
Date: Tue Feb 28 03:09:53 2017
New Revision: 296454
URL: http://llvm.org/viewvc/llvm-project?rev=296454&view=rev
Log:
[ARM] Don't pass -arm-execute-only to cc1as
The option -mexecute-only is translated into the backend option
-arm-execute-only. But this option only makes sense fo
malcolm.parsons added a comment.
I found this FIXME comment in `Expr::HasSideEffects()`:
case LambdaExprClass: {
const LambdaExpr *LE = cast(this);
for (LambdaExpr::capture_iterator I = LE->capture_begin(),
E = LE->capture_end(); I != E; ++I)
Sorry for losing track of this.
I thought I fixed it with r296113. Not sure why windows builds are still
failing. I'll look into this.
Thanks,
Eric
On Tue, Feb 28, 2017 at 2:19 AM Galina Kistanova
wrote:
> Hello Eric,
>
> This commit broke test on one of our builders:
>
> Clang Tools :: ch
kfunk added a comment.
@erikjv Ready for review? Does this reliably fix
https://bugreports.qt.io/browse/QTCREATORBUG-15449?
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
malcolm.parsons updated this revision to Diff 89988.
malcolm.parsons marked an inline comment as done.
malcolm.parsons added a comment.
Handle captures of volatile variables.
https://reviews.llvm.org/D30327
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaLambda.cpp
test/SemaCXX/warn-unused-
rogfer01 updated this revision to Diff 89989.
rogfer01 added a comment.
Avoid altering results of TypeInfo due to the __unaligned qualifier. Instead
override the natural alignment to 1 if the type is __unaligned-qualified.
https://reviews.llvm.org/D30166
Files:
lib/AST/ASTContext.cpp
lib/A
Author: ioeric
Date: Tue Feb 28 04:00:15 2017
New Revision: 296458
URL: http://llvm.org/viewvc/llvm-project?rev=296458&view=rev
Log:
[change-namespace] trying to fix windows buildbot failure.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-too
I suspect it was caused by the new line splitting ("\r\n" vs "\n"?) on
Windows. In the test, I write some strings (expected to be new line
delimited) to a temp file (
https://github.com/llvm-mirror/clang-tools-extra/blob/master/test/change-namespace/white-list.cpp#L1),
read the content, and then sp
Author: chapuni
Date: Tue Feb 28 04:05:56 2017
New Revision: 296460
URL: http://llvm.org/viewvc/llvm-project?rev=296460&view=rev
Log:
clang/test/Format/inplace.cpp: Avoid using wildcard.
MSYS' tools don't do globbing.
Modified:
cfe/trunk/test/Format/inplace.cpp
Modified: cfe/trunk/test/Form
rogfer01 added a comment.
Thanks @javed.absar
This LGTM now.
https://reviews.llvm.org/D30326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
In https://reviews.llvm.org/D30345#688144, @rjmccall wrote:
> You're doing this refactor to... support doing another refactor of the same
> code? Why are these patches separate?
Not quite, by "merging block copy/destroy routines" I meant that my next patch
will try
Author: hokein
Date: Tue Feb 28 04:13:26 2017
New Revision: 296461
URL: http://llvm.org/viewvc/llvm-project?rev=296461&view=rev
Log:
[find-all-symbols] Implement operator== for SymbolAndSignals and
SymbolInfo::Signals.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/SymbolIn
mprobst created this revision.
Herald added a subscriber: klimek.
Limit the blacklisting to only apply when the tag is actually followed by a
parameter in curly braces.
/** @mods {long.type.must.not.wrap} */
vs
/** @const this is a long description that may wrap. */
JSDoc tag reference he
djasper added inline comments.
Comment at: lib/Format/Format.cpp:627
+"(@("
+"const|"
+"define|"
I'd vote for making this "@\w*\ *{". We have seen incorrectly spelled version
and such of this in the past.
https://reviews.llvm.org/D30452
mprobst updated this revision to Diff 8.
mprobst added a comment.
- Match \\w* for all JSDoc param tags.
https://reviews.llvm.org/D30452
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks for tracking this down!
https://reviews.llvm.org/D30412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/Format.cpp:624
+// taze:, and @tag followed by { for a lot of JSDoc tags.
+GoogleStyle.CommentPragmas = "(taze:|(@[A-Za-z_0-9-]*[ \\t]*{)
mprobst marked an inline comment as done.
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:624
+// taze:, and @tag followed by { for a lot of JSDoc tags.
+GoogleStyle.CommentPragmas = "(taze:|(@[A-Za-z_0-9-]*[ \\t]*{))";
GoogleStyle.MaxEmptyLinesToKee
Tweaked in r296460.
On Tue, Feb 28, 2017 at 10:28 AM Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Nico,
>
> This commit broke test on one of our builders:
>
> Clang :: Format/inplace.cpp
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-wi
Author: mprobst
Date: Tue Feb 28 05:08:24 2017
New Revision: 296467
URL: http://llvm.org/viewvc/llvm-project?rev=296467&view=rev
Log:
Blacklist arbitrary @\\w+ JSDoc tags from wrapping.
Summary:
Also limits the blacklisting to only apply when the tag is actually
followed by a parameter in curly b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296467: Blacklist arbitrary @\\w+ JSDoc tags from wrapping.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30452?vs=8&id=90001#toc
Repository:
rL LLVM
https://reviews.
jhenderson abandoned this revision.
jhenderson added a comment.
Abandoning. Due to changes made in https://reviews.llvm.org/D29023, there is no
more need for this patch. The new method followed in that patch means that
clang gets support for the new remarks via -Rpass=stack-protector.
https://
sylvestre.ledru added a comment.
@krasimir is that ok with you?
https://reviews.llvm.org/D30111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gamesh411 added a comment.
Hello,
This checker was developed indeed with internal usage in mind. It should not
necessary be added as a default checker. However I have run it on the
boost-1.63.0 codebase, and there some some mildly interesting findings in
examples and tests. There is also a true
ioeric updated this revision to Diff 90011.
ioeric added a comment.
- Addressed review comments.
- Make key customize-able.
- Added replace() and insert() to replace current replacement interfaces.
- s/EditList/AtomicChange/
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refacto
alexshap added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
i assume i might be missing smth -
alexshap added inline comments.
Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:35
+RemovedHeaders(E.getRemovedHeaders()) {
+std::copy(E.getReplacements().begin(), E.getReplacements().end(),
+ std::back_inserter(Replaces));
if i am n
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
-
ioeric updated this revision to Diff 90012.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/AtomicChange.cpp
Thanks! That's a good technique, I'll remember it for next time. I wonder
if %T should work like that...
On Feb 28, 2017 5:17 AM, "NAKAMURA Takumi via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Tue Feb 28 04:05:56 2017
> New Revision: 296460
>
> URL: http://llvm.o
alexshap added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
ioeric wrote:
> alexshap wrote:
> >
It's needed: when clang-format does leave temp files behind, they will
accumulate over builds and even if that's then fixed, the test would still
fail because of the temp files from prior builds. Thankfully, takuni fixed
this better in r296460.
On Feb 28, 2017 4:14 AM, "Haojian Wu via cfe-commits"
gerazo marked an inline comment as done.
gerazo added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DirtyScalarChecker.cpp:184
+Ty = Ctx.IntTy;
+ if (!Ty->isIntegerType() || Ctx.getIntWidth(Ty) <= TooNarrowForBoundCheck)
+return false;
a.sidor
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
alexshap wrote:
> ioeric wrote:
> > a
ioeric updated this revision to Diff 90018.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Return const refs in getXXX.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/AtomicChan
Author: alexfh
Date: Tue Feb 28 08:13:26 2017
New Revision: 296472
URL: http://llvm.org/viewvc/llvm-project?rev=296472&view=rev
Log:
Misspelled checker description (argument comment)
Reviewers: alexfh
Reviewed By: alexfh
Subscribers: Eugene.Zelenko
Tags: #clang-tools-extra
Patch by Peter Szec
rmaprath updated this revision to Diff 90025.
rmaprath added a comment.
Fixed minor omission.
https://reviews.llvm.org/D29818
Files:
src/chrono.cpp
Index: src/chrono.cpp
===
--- src/chrono.cpp
+++ src/chrono.cpp
@@ -11,6 +11,7
rs created this revision.
Herald added a subscriber: mgorny.
Convention in libcxxabi is to use !defined(FOO) not !FOO.
https://reviews.llvm.org/D30459
Files:
CMakeLists.txt
include/__cxxabi_config.h
include/cxxabi.h
src/abort_message.cpp
src/config.h
src/cxa_default_handlers.cpp
s
Author: danielmarjamaki
Date: Tue Feb 28 08:53:50 2017
New Revision: 296477
URL: http://llvm.org/viewvc/llvm-project?rev=296477&view=rev
Log:
[Sema] Detect more array index out of bounds when C++ overloaded operators are
used
Differential Revision: https://reviews.llvm.org/D30192
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296477: [Sema] Detect more array index out of bounds when
C++ overloaded operators are… (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D30192?vs=89183&id=90027#toc
Rep
Oops, I should have read the patch more thoroughly, sorry for it. Thanks
for the explanation.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki updated this revision to Diff 90030.
danielmarjamaki added a comment.
minor updates. Use llvm::getOrdinalNumber(). Use llvm::Twine.
Repository:
rL LLVM
https://reviews.llvm.org/D30341
Files:
lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
test/Analysis/NewDelete-che
krasimir added a comment.
In https://reviews.llvm.org/D30111#688379, @sylvestre.ledru wrote:
> @krasimir is that ok with you?
Thank you for addressing my comments! The descriptions help to see what's
supposed to happen.
Now another point with this test is that it tests that already Mozilla-va
danielmarjamaki marked an inline comment as done.
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211
// Generate a report for this bug.
- StringRef Desc =
- describeUninitializedArgumentInCall(Call, Is
Author: hokein
Date: Tue Feb 28 09:29:52 2017
New Revision: 296479
URL: http://llvm.org/viewvc/llvm-project?rev=296479&view=rev
Log:
[clang-tidy] Fix a false positive on modernize-use-nullptr check.
Summary:
The false positive happens on two neighbour CXXDefaultArgExpr AST nodes.
like below:
```
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296479: [clang-tidy] Fix a false positive on
modernize-use-nullptr check. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D30412?vs=89894&id=90032#toc
Repository:
rL LLVM
htt
arphaman updated this revision to Diff 90033.
arphaman marked 3 inline comments as done.
arphaman added a comment.
The updated patch uses just one enum and simplifies the capture search loops.
Repository:
rL LLVM
https://reviews.llvm.org/D30345
Files:
lib/CodeGen/CGBlocks.cpp
Index: lib/C
arphaman added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1414
+
+} // end anonymous namespace
+
vsk wrote:
> I don't see the need for two GenericInfo types (although it's plausible it'll
> make sense with your upcoming changes!). I had in mind a sing
hiraditya added a comment.
Ping
https://reviews.llvm.org/D30268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
I'm surprised this is behind a flag. This pragma attempts to be compatible with
cl.exe. Does cl.exe do this by default? If so, we should do it by default. If
not, why add this as an incompatible thing to an MS extension instead of keying
it off some attribute that works
arphaman updated this revision to Diff 90042.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Use `ParseClangAttributeArgs` and add a string to an assert.
Repository:
rL LLVM
https://reviews.llvm.org/D29819
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrD
arphaman added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3818-3819
+ if (ScopeName && (ScopeName->getName() == "gnu" ||
+(ScopeName->getName() == "clang" &&
+ AttrName->isStr("external_source_symbol"
// GNU-scoped at
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
dschuff added a comment.
Hello,
I work on WebAssembly toolchains (including emscripten, which is more or less
the "cross-compiler SDK" use case). There's a lot of history in this review and
I haven't looked at the details yet, but does the current summary text reflect
the current proposal and/o
brad created this revision.
Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64
Repository:
rL LLVM
https://reviews.llvm.org/D30465
Files:
lib/Basic/Targets.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
==
NoQ added subscribers: a.sidorin, NoQ.
NoQ added a comment.
I think this is great. We've been hearing a lot of complaints on the mailing
lists recently about that problem.
Did you check that scan-build properly de-duplicates cross-file reports that
originate from different clang runs but point
hans added a subscriber: djasper.
hans added a comment.
>>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat".
>>>
>>> Manuel: the menu options under Tools currently say "Clang Format
>>> {Selection,Document}". What do you think about using "clang-format" here
>>> instead?
Author: echristo
Date: Tue Feb 28 11:22:05 2017
New Revision: 296490
URL: http://llvm.org/viewvc/llvm-project?rev=296490&view=rev
Log:
Migrate all of aarch64-linux-gnu to \01_mcount instead of just when passing
along gnueabi as this matches both gcc and what the kernel expects.
More of PR27311
Author: tstellar
Date: Tue Feb 28 10:46:19 2017
New Revision: 296485
URL: http://llvm.org/viewvc/llvm-project?rev=296485&view=rev
Log:
Driver: Update devtoolset usage for RHEL
- remove path to dts-1.x (corresponds to gcc 4.7)
- add path to dts-6 (corresponds to 6.x)
Patch By: Maria Gottschalk
D
sylvestre.ledru updated this revision to Diff 90053.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D30111
Files:
test/Format/check-coding-style-mozilla.cpp
unittests/Format/CMakeLists.txt
Index: unittests/Format/CMakeLists.txt
===
sylvestre.ledru added a comment.
I will rename it before the upload if that is fine with you.
Comment at: unittests/Format/check-coding-style-mozilla.cpp:77
+return mVar;
+ } // Tiny functions can be written in a single line.
+
krasimir wrote:
> Note that
erichkeane updated this revision to Diff 90056.
erichkeane added a comment.
Response to Aaron's comments
https://reviews.llvm.org/D28266
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/transparent-union.c
test/
erichkeane marked 6 inline comments as done.
erichkeane added a comment.
Thanks! Changes incoming.
https://reviews.llvm.org/D28266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Feb 28 12:28:15 2017
New Revision: 296499
URL: http://llvm.org/viewvc/llvm-project?rev=296499&view=rev
Log:
clang-format: [Java] Fix bug in enum formatting.
Before:
public enum VeryLongEnum {
ENUM_WITH_MANY_PARAMETERS("aa",
rjmccall added a comment.
In https://reviews.llvm.org/D30345#688298, @arphaman wrote:
> In https://reviews.llvm.org/D30345#688144, @rjmccall wrote:
>
> > You're doing this refactor to... support doing another refactor of the same
> > code? Why are these patches separate?
>
>
> Not quite, by "me
On Fri, Feb 24, 2017 at 8:24 AM, Marcwell Helpdesk wrote:
>
> As interesting the subject of pluggable attributes may be could we please
> drop that discussion and focus on the intention of and what the patch
> actually does? Two revisions of the patch have been supplied and both should
> reason
hans added a subscriber: mehdi_amini.
hans added a comment.
To unblock 4.0, I'm leaning towards merging Bruno's patch as a stop-gap fix.
I realize it probably only fixes the problem for PCH, and not modules. But PCH
is used more widely than modules, so maybe it's good enough for now?
We've run
bruno added a comment.
> It seems to me that the problem here is that `DeclMustBeEmitted` is not safe
> to call in the middle of deserialization if anything partially-deserialized
> might be reachable from the declaration we're querying, and yet we're
> currently calling it in that case.
`De
bruno added a comment.
> What do folks think?
IMO we should do it.
https://reviews.llvm.org/D29753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, despite a long-ish comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3830-3837
+ unsigned NumArgs;
+ // Some Clang-scoped attributes have some special par
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one formatting nit.
Comment at: lib/Sema/SemaDeclAttr.cpp:6201
+void Sema::ProcessDeclAttributeDelayed(Decl *D, const AttributeList *AttrList)
{
+
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this LGTM, but you should wait for confirmation from one of the other
reviewers before committing.
https://reviews.llvm.org/D30166
___
Author: erichkeane
Date: Tue Feb 28 14:44:39 2017
New Revision: 296518
URL: http://llvm.org/viewvc/llvm-project?rev=296518&view=rev
Log:
Allow attributes before union definition
permits typedef union __attribute__((transparent_union)) {...}
Differential Revision: https://reviews.llvm.org/D28266
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296518: Allow attributes before union definition (authored
by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D28266?vs=90056&id=90075#toc
Repository:
rL LLVM
https://reviews.llvm.org
dlj added a comment.
In https://reviews.llvm.org/D30372#688154, @mehdi_amini wrote:
> In https://reviews.llvm.org/D30372#687060, @ahatanak wrote:
>
> > In https://reviews.llvm.org/D30372#687054, @dlj wrote:
> >
> > > In https://reviews.llvm.org/D30372#686871, @ahatanak wrote:
> > >
> > > > Have y
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
In https://reviews.llvm.org/D30327#688254, @malcolm.parsons wrote:
> I found this FIXME comment in `Expr::HasSideEffects()`:
>
> case LambdaExprClass: {
> const Lambd
tigerleapgorge updated this revision to Diff 90078.
tigerleapgorge added a comment.
Updated patch.
Test only runs in C++11.
Added comments to explain CHECK-DAG and CHECK2-NOT.
https://reviews.llvm.org/D30430
Files:
test/CodeGenCXX/template-instantiation.cpp
Index: test/CodeGenCXX/template-
Author: rtrieu
Date: Tue Feb 28 15:24:38 2017
New Revision: 296521
URL: http://llvm.org/viewvc/llvm-project?rev=296521&view=rev
Log:
[ODRHash] Add basic support for CXXRecordDecl
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/
tigerleapgorge added a comment.
In https://reviews.llvm.org/D30430#688146, @rjmccall wrote:
> The C++98 behavior here is not really vital to test precisely; it's just
> minor differences in what gets instantiated and when.
Hi John, my main concern with CHECK-NOT appearing between CHECK lines i
There's no functional change. This was a mistake I made when splitting the
original patch into pieces and I wanted to correct before proceeding with
additional changes.
On Mon, Feb 27, 2017 at 8:27 AM, David Blaikie wrote:
> An explanation as to why the code was moved (& possibly test cases, or
watsond marked 2 inline comments as done.
watsond added a comment.
In https://reviews.llvm.org/D29858#675055, @etienneb wrote:
> Could you add some tests with enums (like the one in your description)?
> This is missing and it's a nice to have.
Added
Comment at: clang-tidy/m
watsond updated this revision to Diff 90087.
watsond marked an inline comment as done.
watsond added a comment.
Fixed logic error, added enum test case
https://reviews.llvm.org/D29858
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
test/clang-tidy/misc-redundant-expression.cpp
Index:
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D29753#688845, @bruno wrote:
> > What do folks think?
>
> IMO we should do it.
Go ahead and commit this, but keep the bug open so we can work on fixing it
properly ev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296549: [Test] Make Lit tests C++11 compatible - IR ordering
(authored by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D30430?vs=90078&id=90101#toc
Repository:
rL LLVM
https://review
Author: lcharles
Date: Tue Feb 28 18:10:00 2017
New Revision: 296549
URL: http://llvm.org/viewvc/llvm-project?rev=296549&view=rev
Log:
[Test] Make Lit tests C++11 compatible - IR ordering
Differential Revision: https://reviews.llvm.org/D30430
Modified:
cfe/trunk/test/CodeGenCXX/template-inst
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM, but with a macro other than `_LIBCPP_HIDDEN`.
Also could you please add doc explaining the rational for this new macro in
depth. I think the summary for this revision would be sufficient
EricWF added inline comments.
Comment at: include/string:1100
template
+inline _LIBCPP_INLINE_VISIBILITY
typename enable_if
smeenai wrote:
> EricWF wrote:
> > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere
> > e
Author: probinson
Date: Tue Feb 28 19:01:10 2017
New Revision: 296554
URL: http://llvm.org/viewvc/llvm-project?rev=296554&view=rev
Log:
[PS4] Set our default dialect to C++11. NFC for other targets.
Reapplies r296209 now that r296549 has fixed what really seems to be
the last problematic test.
Mo
Author: mpark
Date: Tue Feb 28 19:07:56 2017
New Revision: 296558
URL: http://llvm.org/viewvc/llvm-project?rev=296558&view=rev
Log:
Updated the XFAIL comment in variant tests.
Summary:
`ConstexprTestTypes::NoCtors` is an aggregate type (and consequently a literal
type) in C++17,
but not in C++14
Author: ericwf
Date: Tue Feb 28 19:27:14 2017
New Revision: 296561
URL: http://llvm.org/viewvc/llvm-project?rev=296561&view=rev
Log:
Fix PR32097 - is_abstract doesn't work on class templates.
This patch fixes llvm.org/PR32097 by using the __is_abstract
builtin type-trait instead of the previous l
smeenai added inline comments.
Comment at: include/string:1100
template
+inline _LIBCPP_INLINE_VISIBILITY
typename enable_if
EricWF wrote:
> smeenai wrote:
> > EricWF wrote:
> > > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDD
smeenai updated this revision to Diff 90108.
smeenai edited the summary of this revision.
smeenai added a comment.
Addressing comments
https://reviews.llvm.org/D29157
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
include/locale
include/string
Index: include/string
==
smeenai updated this revision to Diff 90109.
smeenai added a comment.
Rebase atop https://reviews.llvm.org/D29157 and switch to
_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
include/__locale
Author: dcoughlin
Date: Tue Feb 28 19:47:37 2017
New Revision: 296562
URL: http://llvm.org/viewvc/llvm-project?rev=296562&view=rev
Log:
[Analyzer] Fix crash in ObjCPropertyChecker on protocol property
Fix a crash in the ObjCPropertyChecker when analyzing a 'copy' property of an
NSMutable* type in
Author: ericwf
Date: Tue Feb 28 20:02:28 2017
New Revision: 296565
URL: http://llvm.org/viewvc/llvm-project?rev=296565&view=rev
Log:
Improve diagnostics when an invalid hash is used in an unordered container.
This patch adds a static assertion that the specified hash meets
the requirements of an
Author: ericwf
Date: Tue Feb 28 20:23:54 2017
New Revision: 296567
URL: http://llvm.org/viewvc/llvm-project?rev=296567&view=rev
Log:
Fix non-reserved macro names LIBCXXABI_NORETURN and LIBCXXABI_ARM_EHABI.
This patch adds the required leading underscore to those macros.
Modified:
libcxxabi/t
1 - 100 of 122 matches
Mail list logo
