smeenai added inline comments.
================
Comment at: include/string:1100
template<class _InputIterator>
+ inline _LIBCPP_INLINE_VISIBILITY
typename enable_if
----------------
EricWF wrote:
> smeenai wrote:
> > EricWF wrote:
> > > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN`
> > > everywhere else?
> > This function is really small, so I figured marking it for inlining was
> > more appropriate.
> This should probably have _LIBCPP_INLINE_VISIBILITY on it then.
I was assuming any client that cares about what they're exporting would build
with `-fvisibility-inlines-hidden`, in which case just `inline` should be
enough.
https://reviews.llvm.org/D29157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
