jbangert created this revision.
Herald added a subscriber: mgorny.
This requires https://reviews.llvm.org/D29613. It adds a new tool,
clang-query-replace that replaces and AST node with the result of evaluating a
simple template language.
https://reviews.llvm.org/D29622
Files:
clang-query/C
jbangert created this revision.
This is the first change as part of developing a clang-query based search and
replace tool.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.
klimek added inline comments.
Comment at: clang-query/QueryReplace.cpp:50
+
+void QueryReplaceTool::addOperation(clang::query::QueryReplaceSpec &Spec) {
+ ast_matchers::dynamic::Diagnostics Diag;
Shouldn't that also just return the error?
Comm
erikjv updated this revision to Diff 87376.
erikjv added a comment.
Fixed all failing tests on Windows.
https://reviews.llvm.org/D27810
Files:
lib/Basic/FileManager.cpp
lib/Basic/VirtualFileSystem.cpp
lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
test/CodeGen/debug-prefix-map.c
test
klimek added a reviewer: hans.
klimek added a comment.
+hans
+1 to "format only current document but save all" not making much sense :)
Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7
+{
+public sealed class TypeConverterUtils
+{
Author: d0k
Date: Tue Feb 7 04:28:20 2017
New Revision: 294291
URL: http://llvm.org/viewvc/llvm-project?rev=294291&view=rev
Log:
Add a prototype for clangd
clangd is a language server protocol implementation based on clang. It's
supposed to provide editor integration while not suffering from the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294291: Add a prototype for clangd (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D29451?vs=87226&id=87383#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29451
Files:
clan
GGanesh updated this revision to Diff 87386.
GGanesh added a comment.
Updated for review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D29386
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Headers/CMakeLists.txt
lib/Hea
ioeric added inline comments.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:42
+ void HandleTranslationUnit(ASTContext &Context) override {
+for (const auto &Callback : Refactoring.Callbacks) {
+ Callback->getReplacements().clear();
Could you add a c
krasimir added a comment.
I feel that this is a bit too rough now; any suggestions on improving the
architecture/design of this patch are welcome!
Comment at: lib/Format/UnwrappedLineParser.cpp:2206
+const SmallVectorImpl &Comments,
+const FormatToken* NextTok) {
bo
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207
+const FormatToken* NextTok) {
bool CommentsInCurrentLine = true;
+ int StartOfSectionAlignedWithNextToken = -1;
Need to add comments about this if we decide we may go wit
Author: d0k
Date: Tue Feb 7 04:47:40 2017
New Revision: 294292
URL: http://llvm.org/viewvc/llvm-project?rev=294292&view=rev
Log:
[clangd] Add missing include.
Modified:
clang-tools-extra/trunk/clangd/Protocol.h
Modified: clang-tools-extra/trunk/clangd/Protocol.h
URL:
http://llvm.org/viewvc
ioeric added inline comments.
Comment at: clang-query/QueryReplace.cpp:1
+#include "QueryReplace.h"
+#include "QueryParser.h"
Please add license header.
Comment at: clang-query/QueryReplace.cpp:37
+
+llvm::ErrorOr QueryReplaceSpec::parseFromJSO
krasimir added inline comments.
Comment at: test/clangd/formatting.txt:9
+# CHECK: {"jsonrpc":"2.0","id":0,"result":{"capabilities":{
+# CHECK: "textDocumentSync": 1,
+# CHECK: "documentFormattingProvider": true,
bkramer wrote:
> djasper wrote:
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2206
+const SmallVectorImpl &Comments,
+const FormatToken* NextTok) {
bool CommentsInCurrentLine = true;
krasimir wrote:
> Any suggestions on how to improve the code quality
djasper accepted this revision.
djasper added a comment.
This looks very nice now :-D. Thanks for working on this!!
Comment at: lib/Format/WhitespaceManager.cpp:196
+
+ // ScopeStack keeps track of the current scope depth.
+ // We only run the "Matches" function on tokens fro
klimek added a comment.
I think this looks pretty good. More comments would help :) Also, organize is
spelled with a 'z' in American.
https://reviews.llvm.org/D29626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: alexfh
Date: Tue Feb 7 05:39:56 2017
New Revision: 294293
URL: http://llvm.org/viewvc/llvm-project?rev=294293&view=rev
Log:
[clang-tidy] misc-argument-comment - extended gmock support
It looks like direct calls to mocked methods happen in the wild. This patch
add support for these as wel
Author: d0k
Date: Tue Feb 7 05:49:03 2017
New Revision: 294294
URL: http://llvm.org/viewvc/llvm-project?rev=294294&view=rev
Log:
[clangd] Harden test against sed implementations that strip \r.
Also clean up logging and don't print \0.
Modified:
clang-tools-extra/trunk/clangd/ClangDMain.cpp
mgorny created this revision.
Herald added a subscriber: dberris.
Check whether strace is to be found in PATH, and control the strace_test
appropriately. This fixes a test failure when strace is not installed.
Repository:
rL LLVM
https://reviews.llvm.org/D29628
Files:
test/lsan/TestCases/
rmaprath created this revision.
Different platforms implement the wait/sleep behaviour in very different ways.
It makes sense to hoist this functionality into the threading API.
I also feel similarly about `hardware_concurrecy()` implementation. Any
thoughts on that?
https://reviews.llvm.org/
Author: dylanmckay
Date: Tue Feb 7 00:04:18 2017
New Revision: 294282
URL: http://llvm.org/viewvc/llvm-project?rev=294282&view=rev
Log:
Revert "Revert "[AVR] Allow specifying the CPU on the command line""
This reverts commit 7ac30e0f839fdab6d723ce2ef6a5b7a4cf03d150.
Added:
cfe/trunk/test/Co
Author: d0k
Date: Tue Feb 7 06:40:59 2017
New Revision: 294297
URL: http://llvm.org/viewvc/llvm-project?rev=294297&view=rev
Log:
[clangd] Set stdin to binary to fix tests on windows.
Modified:
clang-tools-extra/trunk/clangd/ClangDMain.cpp
Modified: clang-tools-extra/trunk/clangd/ClangDMain.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D28451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: rksimon
Date: Tue Feb 7 07:08:22 2017
New Revision: 294299
URL: http://llvm.org/viewvc/llvm-project?rev=294299&view=rev
Log:
Disable test on windows buildbots without shell support
Modified:
clang-tools-extra/trunk/test/clangd/formatting.test
Modified: clang-tools-extra/trunk/test/c
mprobst created this revision.
Herald added a subscriber: klimek.
Regex detection would incorrectly classify a trailing `!` operator
(nullability cast) followed by a `/` as the start of a regular
expression literal. This fixes code such as:
var foo = x()! / 10;
Which would previously parse a r
When adding more tests, an issue with this approach was found using scopes:
switch (x) {
case 1:
break;
case (2):
break;
case 3: {
break;
} // <-- Seems we should offset this by 2
}
I'll look into getting this behavior and update the patch.
~Ryan
mprobst created this revision.
Herald added a subscriber: klimek.
In JavaScript, classes are expressions, so they can appear e.g. in
argument lists.
var C = foo(class {
bar() {
return 1;
}
};
https://reviews.llvm.org/D29635
Files:
lib/Format/UnwrappedLineParser.cpp
unitte
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D29634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Thanks
https://reviews.llvm.org/D29635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Anastasia closed this revision.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Committed in r 293286
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
aaboud updated this revision to Diff 87408.
aaboud marked 2 inline comments as done.
aaboud added a comment.
Addressed Adrian last comments.
Added a LIT tests that covers all the macro kinds:
1. built-in (define)
2. command-line (define, include, undef)
3. main source (define, include, undef)
Ch
Anastasia added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
arsenm wrote:
> Anastasia
joerg added inline comments.
Comment at: include/__threading_support:367
+ ts.tv_sec = ts_sec_max;
+ ts.tv_nsec = giga::num - 1;
+ }
I don't think giga::num makes things any clear compared to just spelling it out.
Comment at: include/
krasimir updated this revision to Diff 87410.
krasimir marked 6 inline comments as done.
krasimir added a comment.
- Address review comments.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index:
mprobst updated this revision to Diff 87412.
mprobst added a comment.
- Parse nested classes as child expressions.
https://reviews.llvm.org/D29635
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatT
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294302: clang-format: [JS] handle parenthesized class
expressions. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D29635?vs=87412&id=87416#toc
Repository:
rL LLVM
https://r
Author: mprobst
Date: Tue Feb 7 08:05:30 2017
New Revision: 294302
URL: http://llvm.org/viewvc/llvm-project?rev=294302&view=rev
Log:
clang-format: [JS] handle parenthesized class expressions.
Summary:
In JavaScript, classes are expressions, so they can appear e.g. in
argument lists.
var C =
djasper added a comment.
Sorry.. Should have caught this in the initial review. Still looks good.
https://reviews.llvm.org/D29635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mprobst
Date: Tue Feb 7 08:08:03 2017
New Revision: 294304
URL: http://llvm.org/viewvc/llvm-project?rev=294304&view=rev
Log:
clang-format: [JS] exclaim preceding regex literals.
Summary:
Regex detection would incorrectly classify a trailing `!` operator
(nullability cast) followed by a `
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294304: clang-format: [JS] exclaim preceding regex literals.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D29634?vs=87402&id=87417#toc
Repository:
rL LLVM
https://reviews
rmaprath added inline comments.
Comment at: include/__threading_support:593
+ using namespace chrono;
+ milliseconds ms = duration_cast(ns);
+ if (ms.count() == 0 || ns > duration_cast(ms))
joerg wrote:
> Use (ns + 99) so that the cast rounds up.
So, this
klimek added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208
+const FormatToken *NextTok) {
+ // Decides which comment tokens should be added to the current line and which
+ // should be added as comments before the next token.
+ //
--
Author: d0k
Date: Tue Feb 7 08:35:09 2017
New Revision: 294309
URL: http://llvm.org/viewvc/llvm-project?rev=294309&view=rev
Log:
[clangd] Fix subtle use after return.
I didn't find this because my main development machine still happens to
use libstdc++ with the broken C++11 ABI, which has a glob
RKSimon added a comment.
Still missing a test in llvm\tools\clang\test\CodeGen\builtins-x86.c
Repository:
rL LLVM
https://reviews.llvm.org/D29386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
krasimir updated this revision to Diff 87424.
krasimir added a comment.
- Moved method summary from the implementation to the declaration.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: uni
klimek added inline comments.
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+ // Comments specifies the sequence of comment tokens to analyze. They get
+ // either pushed to the current line or added to the comments before the next
+ // token.
Given thi
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208
+const FormatToken *NextTok) {
+ // Decides which comment tokens should be added to the current line and which
+ // should be added as comment
sbenza added inline comments.
Comment at: clang-query/QueryReplace.h:35-36
+
+ /// \brief Replacement text. %"identifier" will be substituted by the text of
+ /// an identifier.
+ std::string ToTemplate;
klimek wrote:
> This doesn't seem to come up in the test
I don't understand why we need this extra step in testing now? Did anything
fail?
Thanks,
Anastasia
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
NAKAMURA Takumi via cfe-commits
Sent: 01 November 2016 20:08
To: cfe-commits@lists.llvm.org
S
Author: d0k
Date: Tue Feb 7 09:37:17 2017
New Revision: 294312
URL: http://llvm.org/viewvc/llvm-project?rev=294312&view=rev
Log:
[clangd] Ignore comments in clangd input, so we can write tests without sed.
Another attempt on making this work on windows.
Modified:
clang-tools-extra/trunk/cla
IvanSidorenko created this revision.
Fix in call graph construction: don't build call graph node for callee function
twice for functions with forward declarations.
Maybe the same fix should be done and for VisitObjCMethodDecl. Unfortunately, I
have not enough expertise in ObjC, so I did not tou
The test depends on named labels. It failed with -Asserts.
On Wed, Feb 8, 2017 at 12:45 AM Anastasia Stulova
wrote:
> I don't understand why we need this extra step in testing now? Did
> anything fail?
>
> Thanks,
> Anastasia
>
> -Original Message-
> From: cfe-commits [mailto:cfe-commits
Author: marshall
Date: Tue Feb 7 09:34:20 2017
New Revision: 294311
URL: http://llvm.org/viewvc/llvm-project?rev=294311&view=rev
Log:
Mark LWG2784 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
sbenza added inline comments.
Comment at: include/clang/Tooling/RefactoringCallbacks.h:61
+MatchFinder.addMatcher(Matcher, Callback);
+Callbacks.emplace_back(Callback);
+ }
Why emplace_back instead of push_back?
Comment at: lib/Tooling
GGanesh updated this revision to Diff 87437.
GGanesh added a comment.
Updated the builtins test for "__builtin_ia32_clzero"
Repository:
rL LLVM
https://reviews.llvm.org/D29386
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Headers
Author: stulova
Date: Tue Feb 7 10:09:41 2017
New Revision: 294313
URL: http://llvm.org/viewvc/llvm-project?rev=294313&view=rev
Log:
[OpenCL] Accept logical NOT for pointer types in CL1.1
Fix for bug 30217 - incorrect error given for logical
NOT operation with a pointer type: corrected sema chec
jhenderson added a comment.
Ping!
https://reviews.llvm.org/D29027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Tue Feb 7 10:10:17 2017
New Revision: 294314
URL: http://llvm.org/viewvc/llvm-project?rev=294314&view=rev
Log:
[clangd] Strip file:// from the URI when calling formatting.
It confuses FileManager on windows.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
Mo
Anastasia closed this revision.
Anastasia added a comment.
Committed in r294313
https://reviews.llvm.org/D29038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mlemay-intel updated this revision to Diff 87453.
mlemay-intel added a comment.
Removed the portions that are specific to 32-bit segmentation. I plan to
resubmit those later as a separate patch.
https://reviews.llvm.org/D17092
Files:
include/clang/Driver/Options.td
Index: include/clang/Dr
Unfortunatelly I wont have time now to work on this check... Thank you for
understanding!
On Mon, Feb 6, 2017 at 3:44 PM, Gábor Horváth via Phabricator <
revi...@reviews.llvm.org> wrote:
> xazax.hun added a comment.
>
> Benedek, do you have time to address the review comments or do you want me
>
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/UnwrappedLineParser.cpp:1306
+// Could be a method inside of a braced list `{a() { return 1; }}`.
+if (tryToParseBracedList()) {
mprobst created this revision.
Herald added a subscriber: klimek.
In JavaScript, object literals can contain methods:
var x = {
a() { return 1; },
};
Previously, clang-format always parsed nested {} inside a braced list as
further braced lists. Special case this logic for JavaScript to t
sanwou01 updated this revision to Diff 87461.
sanwou01 added a comment.
Update the tests. Note that the diagnostics for backend errors are missing the
"instantiated into assembly here" messages. This is unfortunate but expected:
the origin information is no longer available at this stage.
http
Author: mprobst
Date: Tue Feb 7 10:33:13 2017
New Revision: 294315
URL: http://llvm.org/viewvc/llvm-project?rev=294315&view=rev
Log:
clang-format: [JS] correcly format object literal methods.
Summary:
In JavaScript, object literals can contain methods:
var x = {
a() { return 1; },
};
gtbercea created this revision.
Previously we have added the "-c" flag which gets passed to PTXAS by default to
generate relocatable OpenMP target code by default. This set of flags exposes
control over this behaviour.
Repository:
rL LLVM
https://reviews.llvm.org/D29659
Files:
include/cl
falho added a comment.
Unfortunately I wont have time to work on this check anymore... thank you for
understanding!
Repository:
rL LLVM
https://reviews.llvm.org/D23421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294315: clang-format: [JS] correcly format object literal
methods. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D29656?vs=87456&id=87462#toc
Repository:
rL LLVM
https://r
gtbercea updated this revision to Diff 87463.
gtbercea added a comment.
Additional test added to check "-c" is passed in appropriately.
Repository:
rL LLVM
https://reviews.llvm.org/D29659
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index:
a.sidorin added a comment.
Hi Artem,
Thank you for adding me, I missed this patch. I have few comments below. If you
(and Vlad) can wait for two or three days, I will re-check the place I'm
worrying about and post the results.
Comment at: lib/StaticAnalyzer/Checkers/GenericT
aprantl added a comment.
In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
> Addressed Adrian last comments.
> Added a LIT tests that covers all the macro kinds:
>
> 1. built-in (define)
> 2. command-line (define, include, undef)
> 3. main source (define, include, undef) Checked the abov
ehsan created this revision.
Herald added a subscriber: JDevlieghere.
This new flag instructs clang-tidy to not output anything
except for errors and warnings. This makes it easier to
script clang-tidy to run as part of external build systems.
https://reviews.llvm.org/D29661
Files:
clang-tid
gtbercea created this revision.
This flag "--fopenmp-ptx=" enables the overwriting of the default PTX version
used for GPU offloaded OpenMP target regions: "+ptx42".
Repository:
rL LLVM
https://reviews.llvm.org/D29660
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains.cpp
te
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
I'm fine with this.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
amaiorano added a comment.
In https://reviews.llvm.org/D29221#668867, @klimek wrote:
> +hans
>
> +1 to "format only current document but save all" not making much sense :)
Yes, I've been using this version for a little while now, and it's not useful
to have the current document version. I'll r
bmharper updated this revision to Diff 87478.
bmharper added a comment.
small comment tweak
https://reviews.llvm.org/D21279
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
==
bmharper added a comment.
Thanks for all the code review work! I'm impressed by the quality standard
maintained here.
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: marshall
Date: Tue Feb 7 12:41:25 2017
New Revision: 294328
URL: http://llvm.org/viewvc/llvm-project?rev=294328&view=rev
Log:
Stop using random_shuffle in the libc++ test suite. It's going to be removed in
c++17. Use shuffle() instead. No change to libc++, just the tests.
Modified:
Hi Richard, Saleem
I cleaned up the patch by removing some unrelated unit tests. Also Saleem can
help me with the commit.
Thanks!
James
From: James Sun
Date: Saturday, February 4, 2017 at 11:35 PM
To: Richard Smith
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subje
aaboud added a comment.
In https://reviews.llvm.org/D16135#669416, @aprantl wrote:
> In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
>
> > Addressed Adrian last comments.
> > Added a LIT tests that covers all the macro kinds:
> >
> > 1. built-in (define)
> > 2. command-line (define, in
ABataev added a comment.
The patch is too big and quite hard to review? Could you split it into several
smaller parts?
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4280-4282
+ // We don't need debug information in this function as nothing here refers to
+ // user source code.
Author: compnerd
Date: Tue Feb 7 13:00:06 2017
New Revision: 294332
URL: http://llvm.org/viewvc/llvm-project?rev=294332&view=rev
Log:
Revert "Basic: match GCC behaviour for SuS macro"
This reverts commit SVN r294148. Seems that it was mistaken, and GCC
does still define `__unix` and `unix` when
On Tue, Feb 7, 2017 at 11:01 AM Amjad Aboud via Phabricator <
revi...@reviews.llvm.org> wrote:
> aaboud added a comment.
>
> In https://reviews.llvm.org/D16135#669416, @aprantl wrote:
>
> > In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
> >
> > > Addressed Adrian last comments.
> > > A
lethalantidote updated this revision to Diff 87484.
lethalantidote marked an inline comment as done.
lethalantidote added a comment.
- Addresses alexfh's comments.
https://reviews.llvm.org/D28973
Files:
clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tools-extra/test/cl
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
nkakuev added a comment.
Thanks for the response, Alex!
The problem I tried to address in this patch was that notes in source files
were "unsuppressing" warnings from third-party headers (this is what we were
discussing in https://reviews.llvm.org/D26418#590417). But at this point, I no
longe
v.g.vassilev created this revision.
Enable the useful -dump-deserialized-decls and -error-on-deserialized-decl
flags for modules builds, too.
Repository:
rL LLVM
https://reviews.llvm.org/D29676
Files:
lib/Frontend/FrontendAction.cpp
Index: lib/Frontend/FrontendAction.cpp
==
Great, thanks!
On 7 February 2017 at 10:54, James Sun wrote:
> Hi Richard, Saleem
>
>
>
> I cleaned up the patch by removing some unrelated unit tests. Also Saleem
> can help me with the commit.
>
>
>
> Thanks!
>
>
>
> James
>
>
>
> *From: *James Sun
> *Date: *Saturday, February 4, 2017 at 11:3
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since you use the
value later, it is probably better to write this as:
if (const auto *RD = cast(CurContext))
CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD
Prazek added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExceptRan
Author: danalbert
Date: Tue Feb 7 15:04:19 2017
New Revision: 294350
URL: http://llvm.org/viewvc/llvm-project?rev=294350&view=rev
Log:
Use copy.deepcopy instead of doing it manually.
Reviewers: EricWF
Reviewed By: EricWF
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294350: Use copy.deepcopy instead of doing it manually.
(authored by danalbert).
Changed prior to commit:
https://reviews.llvm.org/D29209?vs=85999&id=87507#toc
Repository:
rL LLVM
https://reviews.ll
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
Author: ericwf
Date: Tue Feb 7 15:20:31 2017
New Revision: 294353
URL: http://llvm.org/viewvc/llvm-project?rev=294353&view=rev
Log:
Fix test failures when using modules.
Modified:
libcxx/trunk/test/libcxx/debug/containers/db_associative_container_tests.pass.cpp
libcxx/trunk/test/libcxx
Author: ericwf
Date: Tue Feb 7 15:21:17 2017
New Revision: 294355
URL: http://llvm.org/viewvc/llvm-project?rev=294355&view=rev
Log:
fix python3 syntax error
Modified:
libcxx/trunk/test/support/filesystem_dynamic_test_helper.py
Modified: libcxx/trunk/test/support/filesystem_dynamic_test_help
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM,
but please manually verify that the test runs if strace *is* available.
Repository:
rL LLVM
https://reviews.llvm.org/D29628
___
cfe-commits m
Author: djasper
Date: Tue Feb 7 15:38:16 2017
New Revision: 294358
URL: http://llvm.org/viewvc/llvm-project?rev=294358&view=rev
Log:
clang-format: Fix bad variable declaration detection.
Before:
LongType
variable(nullptr, [](A *a) {});
After:
LongType
Author: vvassilev
Date: Tue Feb 7 15:49:41 2017
New Revision: 294359
URL: http://llvm.org/viewvc/llvm-project?rev=294359&view=rev
Log:
Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules.
Modified:
cfe/trunk/lib/Frontend/FrontendAction.cpp
Modified: cfe/trunk/lib/Fro
Author: ericwf
Date: Tue Feb 7 15:51:58 2017
New Revision: 294360
URL: http://llvm.org/viewvc/llvm-project?rev=294360&view=rev
Log:
Fix bugs in filesystem detected by _LIBCPP_ASSERT.
Recently I turned on libc++'s debug mode assertions when
CMake is configured with -DLIBCXX_ENABLE_ASSERTIONS=ON.
1 - 100 of 143 matches
Mail list logo
