Author: rsmith
Date: Mon Jan 9 02:01:21 2017
New Revision: 291427
URL: http://llvm.org/viewvc/llvm-project?rev=291427&view=rev
Log:
Implement C++ DR1391 (wg21.link/cwg1391)
Check for implicit conversion sequences for non-dependent function
template parameters between deduction and substitution.
rsmith added a comment.
This makes sense to me in principle, but I'd like @chandlerc to weigh in.
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Testing phab parsing...
On Wed, Jan 4, 2017 at 4:01 PM Haojian Wu via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL290967: [clang-move] Support moving type alias
> declarations. (a
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:63
+/// Common pre(post)-action for different OpenMP constructs.
+class CommonActionTy final : public PrePostActionTy {
+ llvm::Value *EnterCallee;
I don't think it is good to name it Commo
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/Sema/SemaOpenMP.cpp:6444
+
+ CapturedStmt *CS = cast(AStmt);
+ // 1.2.2 OpenMP Language Terminology
auto *
https://review
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric added a comment.
I'm not entirely sure about this change... looping in Manuel.
https://reviews.llvm.org/D28419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
mprobst added a reviewer: klimek.
mprobst added a subscriber: cfe-commits.
Automatic semicolon insertion should break import and export statements:
Before, this would format on one line:
// Note: no semi after 'x' below!
import {x} from 'x'
export function fo
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: mprobst
Date: Mon Jan 9 02:56:36 2017
New Revision: 291428
URL: http://llvm.org/viewvc/llvm-project?rev=291428&view=rev
Log:
clang-format: [JS] ASI after imports
Summary:
Automatic semicolon insertion should break import and export statements:
Before, this would format on one line:
/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291428: clang-format: [JS] ASI after imports (authored by
mprobst).
Changed prior to commit:
https://reviews.llvm.org/D28465?vs=83593&id=83594#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28465
Author: mprobst
Date: Mon Jan 9 03:00:58 2017
New Revision: 291429
URL: http://llvm.org/viewvc/llvm-project?rev=291429&view=rev
Log:
clang-format: [JS] fix broken test.
Modified:
cfe/trunk/unittests/Format/FormatTestJS.cpp
Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp
URL:
http://l
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper closed this revision.
djasper added a comment.
Landed as r290842.
https://reviews.llvm.org/D28208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
I ran `ninja check-all` with https://reviews.llvm.org/D28081 and
https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely:
Clang :: Format/style-on-command-line.cpp
Clang Tools :: clang-apply-replacements/basic.cpp
Clang Tools :: clang-apply-rep
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:100
+ StringRef ReplacementStr =
+ IsNoThrow ? NoexceptMacro.empty() ? "noexcept" : NoexceptMacro
+
Author: xazax
Date: Mon Jan 9 03:52:32 2017
New Revision: 291430
URL: http://llvm.org/viewvc/llvm-project?rev=291430&view=rev
Log:
[analyzer] Add checker for iterators dereferenced beyond their range.
Patch by: Adam Balogh!
Differential Revision: https://reviews.llvm.org/D25660
Added:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291430: [analyzer] Add checker for iterators dereferenced
beyond their range. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D25660?vs=81224&id=83596#toc
Repository:
rL LLVM
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin
https://reviews.llvm.org/D28260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a reviewer: NoQ.
NoQ added a comment.
In https://reviews.llvm.org/D28330#637075, @zaks.anna wrote:
> I did not think of solution #1! It's definitely better than the pattern
> matching I've added here. However, this checker fires so infrequently, that I
> do
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:100
+ StringRef ReplacementStr =
+ IsNoThrow ? NoexceptMacro.empty() ? "noexcept" : NoexceptMacro
+: DtorOrOperatorDel ? "noexcept(false)" : "";
ale
Author: asiri
Date: Mon Jan 9 04:38:56 2017
New Revision: 291433
URL: http://llvm.org/viewvc/llvm-project?rev=291433&view=rev
Log:
[libcxx] Fix externally-threaded shared library builds after r291275.
Need to allow unresolved symbols in the dylib. This was previously done for
LIBCXX_HAS_EXTERNAL
Author: djasper
Date: Mon Jan 9 05:04:07 2017
New Revision: 291434
URL: http://llvm.org/viewvc/llvm-project?rev=291434&view=rev
Log:
clang-format: Improve support for override/final as variable names.
Before:
bool a = f() &&override.f();
bool a = f() &&final.f();
void f(const MyOverride &
Author: joerg
Date: Mon Jan 9 05:22:14 2017
New Revision: 291436
URL: http://llvm.org/viewvc/llvm-project?rev=291436&view=rev
Log:
Extend NetBSD/AArch64 to cover Big Endian as well.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/net
On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith wrote:
> On 8 January 2017 at 19:02, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: Sun Jan 8 21:02:53 2017
>> New Revision: 291416
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=291416&view=rev
>> Log:
>> [cxx1z-constexpr-l
Author: joerg
Date: Mon Jan 9 05:40:41 2017
New Revision: 291437
URL: http://llvm.org/viewvc/llvm-project?rev=291437&view=rev
Log:
Use the same ABI logic for AArch64 Big Endian as in other places
covering polys.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/Sema
malcolm.parsons resigned from this revision.
malcolm.parsons removed a reviewer: malcolm.parsons.
malcolm.parsons added a comment.
Which tests?
How does this interact with svn's eol-style property?
Resigning as not something I know about.
https://reviews.llvm.org/D28419
_
ther background, see Richard's comments:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170109/181998.html
A patch to fix this is being worked on.
Thanks!
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-pr
arpith-jacob updated this revision to Diff 83609.
arpith-jacob added a comment.
Moved CommonActionTy to CGOpenMPRuntimeNVPTX.cpp and renamed it to
NVPTXActionTy, allowing us to customize the class in the future, if necessary.
https://reviews.llvm.org/D28145
Files:
lib/CodeGen/CGOpenMPRuntime
RKSimon added inline comments.
Comment at: lib/Basic/Targets.cpp:3189
break;
+ case CK_ZNVER1:
+setFeatureEnabledImpl(Features, "adx", true);
GGanesh wrote:
> RKSimon wrote:
> > Same as what I asked on D28017 - is there an accepted order that we should
Author: asiri
Date: Mon Jan 9 05:57:21 2017
New Revision: 291440
URL: http://llvm.org/viewvc/llvm-project?rev=291440&view=rev
Log:
[libcxxabi] Cleanup and adapt for r291275. NFC.
+ Now that libcxxabi shares the same threading API as libcxx, a whole
chunk of code in src/config.h is made redunda
arpith-jacob marked 2 inline comments as done.
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:365
+llvm::FunctionType *FnTy =
+llvm::FunctionType::get(llvm::Type::getInt1Ty(CGM.getLLVMContext()),
+T
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, rsmith.
malcolm.parsons added a subscriber: cfe-commits.
Warn when a lambda explicitly captures something that is not used in its body.
The warning is part of -Wunused and can be enabled with -Wunused-lambda-ca
Arpith, I'm afraid that bool type is translated to i8 or even to i32 type
rather than to i1. I believe you'd better to use
CGF.ConvertTypeForMem(Context.getBoolType())to get the correct return type for
bool rather than simply i1. You'd better to check how bool(...) function type
is converted to
KP added a comment.
ping
https://reviews.llvm.org/D27651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
Did you experience any problems with the array out of bounds check lately? In
case it was stable on large code-bases and did not give too many false
positives, I think it might be worth to move that check out of alpha at the
same time, so users who do not turn on alph
berenm added a comment.
I'm trying to think of a scenario where *, && or & before tokens to be aligned
would not indicate pointers or references, but as the alignment is only done
for now on declarations and assignments, I can't find one.
Maybe you could add one more test case to check Left poi
arphaman added inline comments.
Comment at: test/SemaCXX/uninitialized.cpp:1437
} else {
-[fname]{};
+[fname] { (void)fname; }; // expected-warning {{lambda capture 'fname' is
not used}}
}
I think that expected-warning shouldn't be used here as you
Author: d0k
Date: Mon Jan 9 09:18:28 2017
New Revision: 291446
URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev
Log:
[include-fixer] Load symbol index asynchronously.
We don't actually need the index until parse time, so fetch it in the
background and start parsing. By the time it is
malcolm.parsons updated this revision to Diff 83624.
malcolm.parsons added a comment.
Don't warn in a dependent context.
Remove spurious expected-warning.
https://reviews.llvm.org/D28467
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clan
nemanjai added inline comments.
Comment at: test/CodeGen/builtins-ppc-extractword-error.c:2
+// REQUIRES: powerpc-registered-target
+// XFAIL: powerpc
+
I think this will fail on all the powerpc targets, such as powerpc64le, etc.
Which isn't what you want I imag
amaiorano added a comment.
Hello, sorry for the lack of details here. I will re-run the tests later and
report here the tests that are failing along with output.
The main issue is that when using Git on Windows, by default the installer will
set core.autocrlf to true, which is a Git config vari
arpith-jacob updated this revision to Diff 83631.
arpith-jacob marked an inline comment as done.
arpith-jacob added a comment.
Using CGF.ConvertTypeForMem(Context.getBoolType()) to get the right type for
'bool' rather than using i1.
https://reviews.llvm.org/D28145
Files:
lib/CodeGen/CGOpenMP
GGanesh updated this revision to Diff 83626.
GGanesh added a comment.
Fallback to CK_BTVER1 is ok but not to CK_BTVER2. This is not possible because
of the partial YMM writes. They have different behavior for znver1 with AVX and
their legacy SIMD counterparts. So, as of now leaving them to alpha
Alexey,
Thanks for the pointer. I've updated the patch using
CGF.ConvertTypeForMem(CGM.getContext().BoolTy);
to get the type for 'bool'.
On my machine it returns i8. The compiler produces code for a simple
OpenMP program that links and seems to run fine on the GPU with my runtime.
I also compi
Alternatively could make the bool ctor a template with some SFINAE to
restrict it to only parameters of type bool - thus blocking all conversions
there, if they're particularly problematic.
On Wed, Jan 4, 2017 at 5:32 PM George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Aut
amaiorano added a comment.
In https://reviews.llvm.org/D28315#639559, @ioeric wrote:
> I ran `ninja check-all` with https://reviews.llvm.org/D28081 and
> https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely:
>
> Clang :: Format/style-on-command-line.cpp
> Clang Tools
mclow.lists abandoned this revision.
mclow.lists added a comment.
This was resolved by https://reviews.llvm.org/D26829
https://reviews.llvm.org/D26667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
RKSimon added a comment.
In https://reviews.llvm.org/D28018#639765, @GGanesh wrote:
> Fallback to CK_BTVER1 is ok but not to CK_BTVER2. This is not possible
> because of the partial YMM writes. They have different behavior for znver1
> with AVX and their legacy SIMD counterparts. So, as of now
Author: alexshap
Date: Mon Jan 9 11:06:24 2017
New Revision: 291449
URL: http://llvm.org/viewvc/llvm-project?rev=291449&view=rev
Log:
[clang] Enable using --section-ordering-file option of ld.gold
This diffs enables using --section-ordering-file option of ld.gold
via the variable CLANG_ORDER_FI
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291449: [clang] Enable using --section-ordering-file option
of ld.gold (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D28461?vs=83582&id=83637#toc
Repository:
rL LLVM
http
Author: rnk
Date: Mon Jan 9 11:09:59 2017
New Revision: 291450
URL: http://llvm.org/viewvc/llvm-project?rev=291450&view=rev
Log:
Follow up to r291448: use isStructorDecl in one more place
This pointer comparison has shown to be error-prone, so use the standard
helper for it. NFC
Modified:
c
Author: rnk
Date: Mon Jan 9 11:04:37 2017
New Revision: 291448
URL: http://llvm.org/viewvc/llvm-project?rev=291448&view=rev
Log:
[MS] Fix function type mangling of default ctor closures
Use the canonical decl in pointer comparisons with the default
constructor closure decl. Otherwise we don't pr
KP updated this revision to Diff 83639.
KP added a comment.
Thanks Beren.
No problem for me to rebase once https://reviews.llvm.org/D21279 is merged.
I've added test cases for PAS_Middle and PAS_Left, I'm a bit surprised with
some of the results (although it is not impacted by my changes).
Wi
arpith-jacob updated this revision to Diff 83641.
arpith-jacob added a comment.
Use i1 type for bool after all. But this time use the api ConvertType().
https://reviews.llvm.org/D28145
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.c
Author: rnk
Date: Mon Jan 9 11:25:30 2017
New Revision: 291452
URL: http://llvm.org/viewvc/llvm-project?rev=291452&view=rev
Log:
Split dllexport default constructor closure tests out into a separate file
test/CodeGenCXX/dllexport.cpp has grown quite large at this point. NFC
Added:
cfe/trunk
benlangmuir added a comment.
LGTM
https://reviews.llvm.org/D28415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Mon Jan 9 11:27:17 2017
New Revision: 291453
URL: http://llvm.org/viewvc/llvm-project?rev=291453&view=rev
Log:
[MS] Mark default args of exported default constructors as used
Fixes a regression introduced in r291045, which would lead to link
errors. While we should no longer en
berenm added a comment.
Yes you are right,
I believe it's happening for comma-separated declaration list. I think the
algorithm tries to keep it clear that the pointer / reference marks are for
each declared identifier and not part of the common type.
I think that splitting the declarations fo
probinson added a comment.
Over the weekend I had a thought: Why is -O0 so special here? That is, after
going to all this trouble to propagate -O0 to LTO, how does this generalize to
propagating -O1 or any other specific -O option? (Maybe this question would be
better dealt with on the dev l
hans added a comment.
In https://reviews.llvm.org/D21113#627413, @francisco.lopes wrote:
> I'm waiting for this to land as well, it's crucial for coding windows code
> with libclang assistance on a linux machine.
I'm not actively working on this, so it might take a while.
In the meantime, I r
Author: marshall
Date: Mon Jan 9 12:07:34 2017
New Revision: 291457
URL: http://llvm.org/viewvc/llvm-project?rev=291457&view=rev
Log:
Implement P0403R1 - 'Literal suffixes for basic_string_view'. Requires clang
4.0 (specifically, r290744)
Added:
libcxx/trunk/test/std/strings/string.view/str
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#639874, @probinson wrote:
> Over the weekend I had a thought: Why is -O0 so special here? That is,
> after going to all this trouble to propagate -O0 to LTO, how does this
> generalize to propagating -O1 or any other specific -O
dlj updated this revision to Diff 83647.
dlj added a comment.
- Add a test, and fix codegen test (the array init is now constant, even though
there is a dtor).
https://reviews.llvm.org/D28427
Files:
lib/AST/ExprConstant.cpp
test/CXX/basic/basic.start/basic.start.init/p2.cpp
test/CodeGenC
dlj updated this revision to Diff 83650.
dlj added a comment.
- Fix lit checks.
https://reviews.llvm.org/D28427
Files:
lib/AST/ExprConstant.cpp
test/CXX/basic/basic.start/basic.start.init/p2.cpp
test/CodeGenCXX/global-array-destruction.cpp
Index: test/CodeGenCXX/global-array-destruction
dlj added a comment.
Test added, and fixed another one that I missed before.
https://reviews.llvm.org/D28427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291458: [Lit Test] Make tests C++11 compatible - nothrow
destructors (authored by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D28425?vs=83470&id=83651#toc
Repository:
rL LLVM
https:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:409
+llvm::FunctionType *FnTy =
+llvm::FunctionType::get(CGM.VoidTy, {}, /*isVarArg*/ false);
+
dim created this revision.
dim added reviewers: EricWF, mclow.lists.
dim added subscribers: emaste, cfe-commits.
Some parts of the FreeBSD tree are still compiled with C++98, and until
https://reviews.llvm.org/rL288554 this has always worked fine. After that, a
complaint about the
newly introduc
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, rsmith.
mclow.lists added a subscriber: cfe-commits.
Make `assign`/`length`/`find`/`compare` for `std::char_traits` constexpr.
This makes using `string_view`s at compile time easier.
Use the compiler intrinsics when availabl
mclow.lists added inline comments.
Comment at: include/__string:261
+
+// inline _LIBCPP_CONSTEXPR_AFTER_CXX14
+// int
I will remove this block before committing.
https://reviews.llvm.org/D28473
___
cfe-commits ma
danielcdh added a comment.
Thanks David for the reivew.
Could you also help take a look at https://reviews.llvm.org/D25434, as it
depends on the TargetOptions.h change in that patch.
Thanks,
Dehao
https://reviews.llvm.org/D25435
___
cfe-commits m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291465: PCH: fix a regression that reports a module is
defined in both pch and pcm. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D28415?vs=83431&id=83660#toc
Repository:
rL L
Author: mren
Date: Mon Jan 9 13:20:18 2017
New Revision: 291465
URL: http://llvm.org/viewvc/llvm-project?rev=291465&view=rev
Log:
PCH: fix a regression that reports a module is defined in both pch and pcm.
In r276159, we started to say that a module X is defined in a pch if we specify
-fmodule-n
Author: bruno
Date: Mon Jan 9 13:21:48 2017
New Revision: 291466
URL: http://llvm.org/viewvc/llvm-project?rev=291466&view=rev
Log:
[Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW
Use CLOCK_UPTIME_RAW in case clock_gettime is available on Darwin.
On Apple platforms only CLOCK_UPTIME_RAW
That's a good point, but I don't think they're a big issue: this code has
apparently been this way since 2010, and I only hit this problem because I
was blindly adding `const` to things and looking for what broke. :)
If someone feels differently, I'm happy to swap this to use SFINAE magic.
On Mon
probinson added a comment.
In https://reviews.llvm.org/D28404#639887, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28404#639874, @probinson wrote:
>
> > Over the weekend I had a thought: Why is -O0 so special here? That is,
> > after going to all this trouble to propagate -O0 to LTO, how
echristo added a comment.
I don't think this ever was hashed out in the llvm-dev thread?
https://reviews.llvm.org/D25435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: include/__string:248
+#if _LIBCPP_STD_VER <= 14
+return (const char_type*) memchr(__s, to_int_type(__a), __n);
+#else
We can add another builtin to Clang to support this case if you'd like.
(There's also a way to ge
I started the llvm-dev thread for the instruction location tradeoffs
(removing the location from instructions to improve profiling support -
possibly at the cost of other debug info consumers).
The motivation for this flag is different - for added functionality that's
generally (imho/based on conv
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#640046, @probinson wrote:
> In https://reviews.llvm.org/D28404#639887, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D28404#639874, @probinson wrote:
> >
> > > Over the weekend I had a thought: Why is -O0 so special here? T
Hi,This is my first commit, please feel free to critique any of the code/new test since I'm not quite sure if this is in the correct format.The patch is for the bug https://llvm.org/bugs/show_bug.cgi?id=22877 regarding cleaning up default arguments in constructors while initializing an array.It doe
Author: lcharles
Date: Mon Jan 9 12:24:16 2017
New Revision: 291458
URL: http://llvm.org/viewvc/llvm-project?rev=291458&view=rev
Log:
[Lit Test] Make tests C++11 compatible - nothrow destructors
In C++11, a destructor's implicit exception-spec is nothrow.
The IR for the destructor's invocation c
GGanesh added a comment.
Yes. True I mentioned that for the grouping or the order of the features
enabled. These initFeatureMap are done based on the intrinsics and the CodeGen
part.
https://reviews.llvm.org/D28018
___
cfe-commits mailing list
cfe
GGanesh added a comment.
If Okay, can you please commit these on my behalf. I don't have write access.
https://reviews.llvm.org/D28018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Thanks for working on this!
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:443
+ if (auto LCV = Val.getAs())
+return C.getSymbolManager().getRegionValueSymbol(LCV->getRegion());
+
This might create a new symbol.
Author: marshall
Date: Mon Jan 9 14:29:28 2017
New Revision: 291475
URL: http://llvm.org/viewvc/llvm-project?rev=291475&view=rev
Log:
Added XFAIL for the apple versions of clang as well
Modified:
libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp
libcxx/tru
Author: dim
Date: Mon Jan 9 14:29:35 2017
New Revision: 291476
URL: http://llvm.org/viewvc/llvm-project?rev=291476&view=rev
Log:
Move _PairT declaration out of __hash_combine to avoid warning under C++98
Summary:
Some parts of the FreeBSD tree are still compiled with C++98, and until
rL288554 th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291476: Move _PairT declaration out of __hash_combine to
avoid warning under C++98 (authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D28472?vs=83654&id=83672#toc
Repository:
rL LLV
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a subscriber: cfe-commits.
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fo
efriedma requested changes to this revision.
efriedma added a comment.
This revision now requires changes to proceed.
Missing regression test in test/SemaCXX/.
https://reviews.llvm.org/D27800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
probinson added a comment.
In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28404#640046, @probinson wrote:
>
> > "I don't care" doesn't seem like much of a principle.
>
>
> Long version is: "There is no use-case, no users, so I don't have much
> moti
probinson added a comment.
In https://reviews.llvm.org/D28404#640170, @probinson wrote:
> In my experience, modifying source
Note that the source modification consists of adding `#pragma clang optimize
off` to the top of the file. It is not a complicated thing.
https://reviews.llvm.org/D284
KP updated this revision to Diff 83676.
KP added a comment.
Thanks for the review!
Split declarations in test cases with PAS_Middle/PAS_Left.
Add tests with references and rvalue references.
https://reviews.llvm.org/D27651
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#640170, @probinson wrote:
> In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D28404#640046, @probinson wrote:
> >
> > > "I don't care" doesn't seem like much of a principle.
> >
> >
> >
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote:
> Also, that's not practicable: what if I have an LTO static library for which
> I don't have the source, now if I build my own file with -O0 -flto I can't
> link anymore.
Also: LTO is required for som
On 9 January 2017 at 03:44, Faisal Vali wrote:
> On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith
> wrote:
> > On 8 January 2017 at 19:02, Faisal Vali via cfe-commits
> > wrote:
> >>
> >> Author: faisalv
> >> Date: Sun Jan 8 21:02:53 2017
> >> New Revision: 291416
> >>
> >> URL: http://llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291477: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to
match builtin (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28213?vs=82791&id=83677#toc
Repository:
rL LLVM
http
Author: mgorny
Date: Mon Jan 9 14:54:20 2017
New Revision: 291477
URL: http://llvm.org/viewvc/llvm-project?rev=291477&view=rev
Log:
[Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin
Correct the logic used to set ATOMIC_*_LOCK_FREE preprocessor macros not
to rely on the ABI alignme
1 - 100 of 186 matches
Mail list logo
