nemanjai added inline comments.

================
Comment at: test/CodeGen/builtins-ppc-extractword-error.c:2
+// REQUIRES: powerpc-registered-target
+// XFAIL: powerpc
+
----------------
I think this will fail on all the powerpc targets, such as powerpc64le, etc. 
Which isn't what you want I imagine.
Also, I think this isn't really the idea with XFAIL. The semantics we'd 
probably want are better served by using the `not` tool and checking for the 
error messages. You should be able to find some example of how the `not` tool 
is used in some of the other test cases (for example 
`test/CodeGen/builtins-ppc-p7-disabled.c`).


Repository:
  rL LLVM

https://reviews.llvm.org/D26546



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D26546: [PPC] Add... Nemanja Ivanovic via Phabricator via cfe-commits

Reply via email to