[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

cpplearner updated this revision to Diff 82653. cpplearner added a comment. backed out the changes to `` https://reviews.llvm.org/D27850 Files: include/optional test/std/utilities/optional/optional.object/optional.object.observe/value_or.pass.cpp Index: test/std/utilities/optional/optio

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1984 +// If so, can't return this error here... +return make_string_error("Configuration file(s) do(es) not support " + + getLanguageName(Language) + ": " + amaior

Re: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

On Mon, Dec 26, 2016 at 4:34 AM Marina Yatsina via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: myatsina > Date: Mon Dec 26 06:23:42 2016 > New Revision: 290539 > > URL: http://llvm.org/viewvc/llvm-project?rev=290539&view=rev > Log: > [inline-asm]No error for conflict between inputs\

[PATCH] D21298: [Clang-tidy] delete null check

xazax.hun added a comment. Small ping, is this ready to be committed? https://reviews.llvm.org/D21298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

Adding Ziv, the author of this patch. From: Chandler Carruth [mailto:chandl...@google.com] Sent: Thursday, December 29, 2016 11:57 To: Yatsina, Marina ; cfe-commits@lists.llvm.org Subject: Re: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list On Mon, Dec 26, 201

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Please also accept `SOURCE_DATE_EPOCH` set in the environment -- see https://reproducible-builds.org/specs/source-date-epoch/ Also although I'm generally leery of options auto-detecting the argument format, I think we should be able to pass an epoch timestamp to -ffixed

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

hfinkel added a comment. In https://reviews.llvm.org/D23934#632216, @emaste wrote: > Please also accept `SOURCE_DATE_EPOCH` set in the environment -- see > https://reproducible-builds.org/specs/source-date-epoch/ It looks like there's reasonable adoption of this: https://wiki.debian.org/Repro

[PATCH] D27810: Normalize all filenames before searching FileManager caches

besc added a comment. I found a crash when applying this patch to 3.9.1 final (source archives from http://llvm.org/releases/download.html#3.9.1) and compiling LLVM/Clang with MinGW-w64 GCC 6.2.0 or MSVC 2015. Clang-format sometimes crashes with input from stdin, output to stdout and a command

[PATCH] D27810: Normalize all filenames before searching FileManager caches

yaron.keren added inline comments. Comment at: lib/Basic/FileManager.cpp:218 +#ifdef LLVM_ON_WIN32 + SmallString<128> NormalizedPath(Filename.str()); + llvm::sys::path::native(NormalizedPath); I'd use a larger SmallString<256>, with large projects 128 bytes are

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > firolino wro

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

rmaprath added inline comments. Comment at: src/fallback_malloc.cpp:37 class mutexor { public: EricWF wrote: > rmaprath wrote: > > EricWF wrote: > > > Can't we replace this class with `std::mutex` directly? > > Again, I should've included more context to the pa

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > firolino wro

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > firolin

[PATCH] D21298: [Clang-tidy] delete null check

aaron.ballman added a comment. In https://reviews.llvm.org/D21298#632154, @xazax.hun wrote: > Small ping, is this ready to be committed? If @alexfh doesn't sign off by tomorrow, I think it's fine to commit. We can deal with any last minute comments post-commit. https://reviews.llvm.org/D2129

[PATCH] D21298: [Clang-tidy] delete null check

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:29 + const auto BinaryPointerCheckCondition = binaryOperator( + allOf(hasEitherOperand(castE

[PATCH] D21298: [Clang-tidy] delete null check

alexfh added a comment. In https://reviews.llvm.org/D21298#632235, @aaron.ballman wrote: > In https://reviews.llvm.org/D21298#632154, @xazax.hun wrote: > > > Small ping, is this ready to be committed? > > > If @alexfh doesn't sign off by tomorrow, I think it's fine to commit. We can > deal with

[PATCH] D21298: [Clang-tidy] delete null check

alexfh added a comment. In https://reviews.llvm.org/D21298#632265, @alexfh wrote: > In https://reviews.llvm.org/D21298#632235, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D21298#632154, @xazax.hun wrote: > > > > > Small ping, is this ready to be committed? > > > > > > If @alexfh doesn

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny added a comment. Second ping. https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. Ping. @eugenis, do you consider it good to go then? Or do you want me to change something specifically? https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D28160: [OpenMP] Sema and parsing for 'target teams distribute parallel for' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

EricWF added a comment. Why don't we commit this as is and we can deal with the mutex later? https://reviews.llvm.org/D27575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28162: [ADT] Delete RefCountedBaseVPTR.

jlebar created this revision. jlebar added reviewers: compnerd, dblaikie. jlebar added subscribers: llvm-commits, cfe-commits. Herald added subscribers: mgorny, klimek. This class is unnecessary. Its comment indicated that it was a compile error to allocate an instance of a class that inherits fr

[PATCH] D28162: [ADT] Delete RefCountedBaseVPTR.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks for the cleanup! Comment at: llvm/unittests/ADT/IntrusiveRefCntPtrTest.cpp:14-37 +struct VirtualRefCounted : public llvm::RefCountedBase { + VirtualR

[PATCH] D28162: [ADT] Delete RefCountedBaseVPTR.

jlebar marked an inline comment as done. jlebar added inline comments. Comment at: llvm/unittests/ADT/IntrusiveRefCntPtrTest.cpp:14-37 +struct VirtualRefCounted : public llvm::RefCountedBase { + VirtualRefCounted() { ++NumInstances; } + VirtualRefCounted(const VirtualRefCounted

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r290717 - [ADT] Delete RefCountedBaseVPTR.

Author: jlebar Date: Thu Dec 29 13:59:26 2016 New Revision: 290717 URL: http://llvm.org/viewvc/llvm-project?rev=290717&view=rev Log: [ADT] Delete RefCountedBaseVPTR. Summary: This class is unnecessary. Its comment indicated that it was a compile error to allocate an instance of a class that inhe

[PATCH] D28162: [ADT] Delete RefCountedBaseVPTR.

This revision was automatically updated to reflect the committed changes. jlebar marked 2 inline comments as done. Closed by commit rL290717: [ADT] Delete RefCountedBaseVPTR. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28162?vs=82681&id=82685#toc Repository: rL L

[libcxx] r290721 - Fix PR31489 - std::function self-swap segfaults

Author: ericwf Date: Thu Dec 29 14:03:55 2016 New Revision: 290721 URL: http://llvm.org/viewvc/llvm-project?rev=290721&view=rev Log: Fix PR31489 - std::function self-swap segfaults Modified: libcxx/trunk/include/__functional_03 libcxx/trunk/include/functional libcxx/trunk/test/std/ut

[PATCH] D28165: Change clang-format's Chromium JavaScript defaults

danbeam created this revision. danbeam added a reviewer: thakis. danbeam added a subscriber: cfe-commits. Herald added a subscriber: klimek. Chromium is starting to use clang-format on more JavaScript. In doing this, we discovered that our defaults were not doing a good job differentiating betwe

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:884 +bool MissingBracesOkay = false; + +if (!SemaRef.getLangOpts().CPlusPlus && Remove empty line. Comment at: lib/Sema/SemaInit.cpp:885-892 +if (!SemaRef.getLangOpts()

[PATCH] D28166: Properly merge K&R functions that have attributes

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: cfe-commits. When determining whether a function was written with a prototype, we would look at the type to see if it was something other than a FunctionType while the canonical type wa

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D28166: Properly merge K&R functions that have attributes

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7464-7470 +const Type *NonAttributedFTy = R.getTypePtr(); +while (const auto *AttrTy = NonAttributedFTy->getAs()) { + NonAttributedFTy = AttrTy->getModifiedType().getTypePtr(); +} bool HasProtot

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 82696. aaboud added a comment. Herald added subscribers: mgorny, nemanjai. Improved code based on Richard's comments. Removed the change to ASTConsumer, now it does not need to know anything about PP consumer. However, I still needed to change the CodeGenerato

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

fhahn updated this revision to Diff 82626. https://reviews.llvm.org/D28148 Files: include/clang/Basic/LangOptions.def include/clang/Frontend/LangStandard.h include/clang/Frontend/LangStandards.def lib/Frontend/CompilerInvocation.cpp lib/Sema/SemaInit.cpp test/Sema/zero-initializer.c

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:114 /// \brief Get the name of the capture helper. - StringRef getHelperName() const override { return ".omp_outlined."; } + StringRef getHelperName() const override { return "__omp_outlined__";

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

fhahn added a comment. Ops, it looks like I accidentally switched the diff back to the initial version and I have no idea how to switch it back :( I am very sorry about that, would you mind uploading the latest version again? https://reviews.llvm.org/D28148 _

[libcxx] r290727 - Fix build using the buildit script

Author: ericwf Date: Thu Dec 29 16:42:45 2016 New Revision: 290727 URL: http://llvm.org/viewvc/llvm-project?rev=290727&view=rev Log: Fix build using the buildit script Modified: libcxx/trunk/lib/buildit Modified: libcxx/trunk/lib/buildit URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk

[PATCH] D28166: Properly merge K&R functions that have attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7464-7470 +const Type *NonAttributedFTy = R.getTypePtr(); +while (const auto *AttrTy = NonAttributedFTy->getAs()) { + NonAttributedFTy = AttrTy->getModifiedType().getTypePtr(); +} bool Ha

[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

vsk added a comment. LGTM. I'm not sure what to do for a test. Have you tried checking the IR for the affected object file in tablegen at '-O2 -fsanitize=undefined'? If there's an unconditional call to the ubsan handler, maybe the tablegen source could be used to find a small reproducer? http

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap updated this revision to Diff 82703. alexshap added a comment. minor changes Repository: rL LLVM https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt =

[PATCH] Add missing Decl::Kind for -print-decl-contexts

--- lib/Frontend/ASTConsumers.cpp | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/lib/Frontend/ASTConsumers.cpp b/lib/Frontend/ASTConsumers.cpp index bd2ee06d16..987b8ca398 100644 --- a/lib/Frontend/ASTConsumers.cpp +++ b/lib/Frontend/ASTC

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

Quuxplusone added subscribers: rjmccall, Quuxplusone. Quuxplusone added a comment. Re the language option: In https://reviews.llvm.org/D27163, @rsmith wrote: > Perhaps some catch-all "I want defined behavior for things that C defines > even though I'm compiling in C++" flag would make sense here

[PATCH] D21675: New ODR checker for modules

rtrieu updated this revision to Diff 82702. rtrieu added a comment. Herald added a subscriber: mgorny. This is a redesign of the ODR checker which was discovered to have several shortcomings when run over test cases. The old version mainly used depth-first processing of AST nodes to gather the

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

amaiorano updated this revision to Diff 82708. amaiorano added a comment. Updated with the changes @ioeric suggested. https://reviews.llvm.org/D28081 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Tooling/Refactoring.cpp tools/clang-format/ClangFormat.cpp unittests/For

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

compnerd added a comment. This would need an upgrade path, since the output name can actually be different from the `AchTypeName` (e.g. i386 vs i686). https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D28153: [clang] Fix clean build of generate-order-file

mehdi_amini added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + I'm missing something: the code in the main CMakeLists seems to allows to have an empty value for the

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

rjmccall added a comment. In https://reviews.llvm.org/D28148#632541, @Quuxplusone wrote: > Re the language option: In https://reviews.llvm.org/D27163, @rsmith wrote: > > > Perhaps some catch-all "I want defined behavior for things that C defines > > even though I'm compiling in C++" flag would m

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + mehdi_amini wrote: > I'm missing something: the code in the main CMakeLists seems to allows to > have an

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles added a comment. Thank you for the comments, rsmith. I'm addressing them now, and I'll make sure to add your examples to the test case. I don't think `isSyntactic()` exists, so I'm using `!getSyntactic()` instead, which should have the desired effect. In https://reviews.llvm.org/D281

[PATCH] D28153: [clang] Fix clean build of generate-order-file

mehdi_amini added inline comments. Comment at: CMakeLists.txt:436 + + if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE}) +string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START) So why `if(CLANG_ORDER_FILE ` here? Repository: rL

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: CMakeLists.txt:436 + + if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE}) +string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START) mehdi_amini wrote: > So why `if(CLANG_ORDER_FILE ` here?

[PATCH] D28153: [clang] Fix clean build of generate-order-file

mehdi_amini added a comment. I mean the two checks being out-of-sync is weird, so I rather have them reconciled. Repository: rL LLVM https://reviews.llvm.org/D28153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 82715. alexshap added a comment. upd https://reviews.llvm.org/D28153 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt

[PATCH] D28153: [clang] Fix clean build of generate-order-file

alexshap added inline comments. Comment at: utils/perf-training/CMakeLists.txt:61 +message(FATAL_ERROR "Output clang order file is not set") + endif() + alexshap wrote: > mehdi_amini wrote: > > I'm missing something: the code in the main CMakeLists seems to

[PATCH] D28153: [clang] Fix clean build of generate-order-file

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D28153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[libcxx] r290742 - Update "Making Optional Greater Equal Again" paper status

Author: ericwf Date: Thu Dec 29 22:16:30 2016 New Revision: 290742 URL: http://llvm.org/viewvc/llvm-project?rev=290742&view=rev Log: Update "Making Optional Greater Equal Again" paper status Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http:

r290743 - Remove bogus assertion and add testcase that triggers it.

Author: rsmith Date: Thu Dec 29 22:32:02 2016 New Revision: 290743 URL: http://llvm.org/viewvc/llvm-project?rev=290743&view=rev Log: Remove bogus assertion and add testcase that triggers it. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp cfe/trunk/test/SemaTemplate/temp_arg_nontyp

[PATCH] D28172: [libcxx] Remove unexpected handlers in C++17

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added subscribers: cfe-commits, mclow.lists. This patch implements P0003R5 which removes exception specifications from C++17. The only changes to the

r290744 - Allow lexer to handle string_view literals. Patch from Anton Bikineev.

Author: ericwf Date: Thu Dec 29 22:51:10 2016 New Revision: 290744 URL: http://llvm.org/viewvc/llvm-project?rev=290744&view=rev Log: Allow lexer to handle string_view literals. Patch from Anton Bikineev. This implements the compiler side of p0403r0. This patch was reviewed as https://reviews.llvm

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

EricWF closed this revision. EricWF added a comment. Committed on behalf of @AntonBikineev in r290744. https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added a comment. Alright. I committed the Clang changes. Just re-building now so I can test this. Comment at: include/string_view:780 +} // namespace literals +#endif + `// _LIBCPP_STD_VER > 14` comment please. Comment at: test/std/st

[PATCH] D26949: [libc++abi] Clean up visibility

EricWF added inline comments. Comment at: src/abort_message.cpp:25 -#pragma GCC visibility push(hidden) - Is this really redundant? There is an `#include ` after it. Is this not going to affect those symbols? Comment at: src/cxa_handlers.hpp

[PATCH] D27430: [libc++] Annotate template methods with visibility

EricWF added a comment. Please put these attributes to the first declaration instead of the definition. Comment at: include/thread:392 template +_LIBCPP_HIDDEN thread::thread(_Fp __f) We really should hide this using `inline _LIBCPP_INLINE_VISIBILITY` becaus

[PATCH] D28174: [libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.

smeenai added a comment. As you're aware, I have plans to change `_LIBCPP_TYPE_VIS` to expand to `visibility` instead of `type_visibility`, but I still think this rename makes sense. https://reviews.llvm.org/D28174 ___ cfe-commits mailing list cfe

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles updated this revision to Diff 82720. sgilles added a comment. Address rsmith's comments, in particular: factor out testing zero initializers to a method of `InitListExpr`; use `ParentIList` instead of `StructuredSubobjectInitList`. The warning is (still) not relaxed for C++ code. I hav

[PATCH] D28174: [libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.

EricWF added a comment. In https://reviews.llvm.org/D28174#632662, @smeenai wrote: > As you're aware, I have plans to change `_LIBCPP_TYPE_VIS` to expand to > `visibility` instead of `type_visibility`. I had forgotten. Thanks for the reminder. > but I still think this rename makes sense. Awe