arpith-jacob added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:114
/// \brief Get the name of the capture helper.
- StringRef getHelperName() const override { return ".omp_outlined."; }
+ StringRef getHelperName() const override { return "__omp_outlined__"; }
----------------
ABataev wrote:
> arpith-jacob wrote:
> > On the nvptx device, it is illegal for an identifier to contain a dot ('.')
> > so I've modified it here. If there is a better way to do this, please let
> > me know.
> Could you just override this function in CGOpenMPRuntimeNVPTX?
Alexey, thank you for your review of this patch.
To override getHelperName() in CGOpenMPRuntime.cpp, I will have to move the two
classes CGOpenMPRegionInfo and CGOpenMPOutlinedRegionInfo from the anonymous
namespace to the header file in CGOpenMPRuntime.h (under protected mode). I
would prefer to do this since I will need to use these classes for implementing
codegen of other directives in the future.
Is that okay with you?
https://reviews.llvm.org/D28145
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
