EricWF added inline comments.
================
Comment at: src/abort_message.cpp:25
-#pragma GCC visibility push(hidden)
-
----------------
Is this really redundant? There is an `#include <CrashReporterClient.h>` after
it. Is this not going to affect those symbols?
================
Comment at: src/cxa_handlers.hpp:23
-__attribute__((visibility("hidden"), noreturn))
+_LIBCXXABI_HIDDEN __attribute__((noreturn))
void
----------------
`_LIBCXXABI_HIDDEN LIBCXXABI_NORETURN`?
================
Comment at: src/cxa_handlers.hpp:27
-__attribute__((visibility("hidden"), noreturn))
+_LIBCXXABI_HIDDEN __attribute__((noreturn))
void
----------------
`_LIBCXXABI_HIDDEN LIBCXXABI_NORETURN`?
================
Comment at: src/cxa_new_delete.cpp:34
*/
-__attribute__((__weak__, __visibility__("default")))
+__attribute__((__weak__))
void *
----------------
Can we abstract this away to a `_LIBCXXABI_NEW_DELETE_VIS` macro?
https://reviews.llvm.org/D26949
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
