bruno marked 3 inline comments as done.
bruno added a comment.
> Do we need to perfectly preserve the functionality of `#pragma once` /
> `#import`? That is, would it be acceptable to
> you if we spuriously enter files that have been imported in that way, while
> building a module?
Unfortun
bruno updated this revision to Diff 82067.
bruno marked 3 inline comments as done.
bruno added a comment.
Uploaded new patch with another approach to fix the issue.
https://reviews.llvm.org/D26267
Files:
include/clang/Lex/HeaderSearch.h
include/clang/Lex/ModuleMap.h
lib/Lex/HeaderSearch.c
Author: chandlerc
Date: Tue Dec 20 02:28:19 2016
New Revision: 290169
URL: http://llvm.org/viewvc/llvm-project?rev=290169&view=rev
Log:
Revert r290149: Add the alloc_size attribute to clang.
This commit fails MSan when running test/CodeGen/object-size.c in
a confusing way. After some discussion w
klimek added a comment.
Why isn't the right solution to make getStyle() use vfs::FileSystem? Generally,
everything in clang-format (well, in clang) should use vfs::FileSystem for file
access.
https://reviews.llvm.org/D27971
___
cfe-commits mailing
Author: echuraev
Date: Tue Dec 20 03:15:21 2016
New Revision: 290171
URL: http://llvm.org/viewvc/llvm-project?rev=290171&view=rev
Log:
[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand.
Summary: Enabling the compression of CLK_NULL_QUEUE to variable of type queue_t.
Reviewers: Ana
This triggers a bunch of warnings:
lib/AST/Expr.cpp:1519:11: error: enumeration value 'CK_ZeroToOCLQueue'
not handled in switch [-Werror,-Wswitch]
lib/CodeGen/CGExprConstant.cpp:654:13: error: enumeration value
'CK_ZeroToOCLQueue' not handled in switch [-Werror,-Wswitch]
lib/Edit/RewriteObjC
Author: kfunk
Date: Tue Dec 20 03:56:56 2016
New Revision: 290172
URL: http://llvm.org/viewvc/llvm-project?rev=290172&view=rev
Log:
Fix for clang_Cursor_getSpellingNameRange()
Summary:
Fixes spelling name ranges for user-defined string literal operators.
Example:
constexpr int operator""_toint
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290172: Fix for clang_Cursor_getSpellingNameRange()
(authored by kfunk).
Changed prior to commit:
https://reviews.llvm.org/D18462?vs=51608&id=82071#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
malcolm.parsons updated this revision to Diff 82072.
malcolm.parsons marked 10 inline comments as done.
malcolm.parsons added a comment.
Use IgnoreParenImpCasts().
Elide braces.
Handle character and string literals.
Require C++11.
Improve doc.
https://reviews.llvm.org/D26750
Files:
clang-tidy
Author: djasper
Date: Tue Dec 20 04:05:04 2016
New Revision: 290173
URL: http://llvm.org/viewvc/llvm-project?rev=290173&view=rev
Log:
Revert "[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand."
This reverts commit r290171. It triggers a bunch of warnings, because
the new enumerator
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:33-34
+ case Type::STK_Floating:
+ case Type::STK_IntegralComplex:
+ case Type::STK_FloatingComplex:
+return "0.0";
aaron.ballman wrote:
> Do these requir
malcolm.parsons updated this revision to Diff 82073.
malcolm.parsons marked an inline comment as done.
malcolm.parsons added a comment.
Use 0 for IntegralComplex.
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-
Reverted in rL290173.
On Tue, Dec 20, 2016 at 11:02 AM, Daniel Jasper wrote:
> This triggers a bunch of warnings:
>
> lib/AST/Expr.cpp:1519:11: error: enumeration value 'CK_ZeroToOCLQueue'
> not handled in switch [-Werror,-Wswitch]
> lib/CodeGen/CGExprConstant.cpp:654:13: error: enumeration
krasimir updated this revision to Diff 82081.
krasimir added a comment.
- Put LastLineNeedsDecoration and Decoration and Prefix to the appropriate
subclasses
- Fixed a double indentation bug caused by the WhitespaceManager.
https://reviews.llvm.org/D27754
Files:
lib/Format/BreakableToken.cpp
krasimir added a comment.
Next 2 steps: will implement a simple heuristic about some sorts of ascii-art
types of things; next will branch and produce a version that takes the reflow
state out of the BreakableComment classes and puts it in the
breakProtrudingToken implementation.
https://revie
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:662
+ bool EdgeExists = false;
+ for (auto I = N->pred_begin(), E = N->pred_end(); I != E; ++I)
+if (*I == FromN) {
I prefer having the braces written in this case, but it i
krasimir updated this revision to Diff 82089.
krasimir added a comment.
Ready for review.
- Split BreakableComment back into a BreakableBlockComment and
BreakableLineCommentSection
- Extract common reflow computation functionality
- Put LastLineNeedsDecoration and Decoration and Prefix to the ap
echuraev created this revision.
echuraev added reviewers: djasper, Anastasia.
echuraev added subscribers: bader, cfe-commits, yaxunl.
Fixed warnings in commit: https://reviews.llvm.org/rL290171
https://reviews.llvm.org/D27981
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/In
Author: abataev
Date: Tue Dec 20 06:10:05 2016
New Revision: 290175
URL: http://llvm.org/viewvc/llvm-project?rev=290175&view=rev
Log:
[OPENMP] Fix for PR31428: variable named like directive name modifier
Directive name modifiers in 'if' clause are allowed only for OpenMP 4.5
and higher + in OpenM
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
Also make sure one function reference is only processed once.
https://reviews.llvm.org/D27982
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/cha
echuraev updated this revision to Diff 82094.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D27917
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/unknown_type.cl
Index: test/SemaOpenCL/unknown_type.cl
ioeric updated this revision to Diff 82098.
ioeric added a comment.
- minor fix.
https://reviews.llvm.org/D27982
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNam
I did not see that it was reapplied later, sorry.
With clang version 3.9.0 (tags/RELEASE_390/final) I get the warning in both
c11 and c++11 mode.
With clang version 4.0.0 (trunk 290146) (llvm/trunk 290118) it's gone in
c11 mode, but still there in c++11.
The piece of code I tested it on:
https://g
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld updated this revision to Diff 82102.
Hahnfeld added a comment.
Version that works for me
https://reviews.llvm.org/D22452
Files:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
Index: test/std/experimental/filesystem/fs.op.funcs/fs.op.last
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:34
+ case Type::STK_IntegralComplex:
+return InitType->isCharType() ? "'\\0'" : "0";
+ case Type::STK_Floating:
This is incorrect if the char type is not a n
davidb created this revision.
davidb added reviewers: howard.hinnant, mclow.lists.
davidb added a subscriber: cfe-commits.
davidb set the repository for this revision to rL LLVM.
Add support for demangling C++11 thread_local variables. In clang, the grammar
for mangling for these names are " ::
On Tue, Dec 20, 2016 at 7:58 AM, Attila Török wrote:
> I did not see that it was reapplied later, sorry.
>
> With clang version 3.9.0 (tags/RELEASE_390/final) I get the warning in both
> c11 and c++11 mode.
> With clang version 4.0.0 (trunk 290146) (llvm/trunk 290118) it's gone in c11
> mode, but
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:34
+ case Type::STK_IntegralComplex:
+return InitType->isCharType() ? "'\\0'" : "0";
+ case Type::STK_Floating:
aaron.ballman wrote:
> This is incorrect if
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:34
+ case Type::STK_IntegralComplex:
+return InitType->isCharType() ? "'\\0'" : "0";
+ case Type::STK_Floating:
malcolm.parsons wrote:
> aaron.ballman wrote:
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:34
+ case Type::STK_IntegralComplex:
+return InitType->isCharType() ? "'\\0'" : "0";
+ case Type::STK_Floating:
aaron.ballman wrote:
> malcolm.parsons wrot
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:578
+// FIXME: function calls to overloaded operators are not fixed now even if they
+// are reference
ioeric updated this revision to Diff 82104.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address comments
https://reviews.llvm.org/D27982
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cp
Author: ioeric
Date: Tue Dec 20 08:39:04 2016
New Revision: 290176
URL: http://llvm.org/viewvc/llvm-project?rev=290176&view=rev
Log:
[change-namespace] do not fix calls to overloaded operator functions.
Summary: Also make sure one function reference is only processed once.
Reviewers: hokein
Sub
amaiorano added a comment.
In https://reviews.llvm.org/D27971#627543, @klimek wrote:
> Why isn't the right solution to make getStyle() use vfs::FileSystem?
> Generally, everything in clang-format (well, in clang) should use
> vfs::FileSystem for file access.
You're absolutely right, this is t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290176: [change-namespace] do not fix calls to overloaded
operator functions. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27982?vs=82104&id=82105#toc
Repository:
rL LLVM
Author: djasper
Date: Tue Dec 20 09:27:46 2016
New Revision: 290177
URL: http://llvm.org/viewvc/llvm-project?rev=290177&view=rev
Log:
clang-format: Fix bug in understanding string-label&value analysis.
While for <<-operators often used in log statments, a single key value
pair is always on the se
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:34
+ case Type::STK_IntegralComplex:
+return InitType->isCharType() ? "'\\0'" : "0";
+ case Type::STK_Floating:
malcolm.parsons wrote:
> aaron.ballman wrote:
FlameTop abandoned this revision.
FlameTop added a comment.
I must apologise to you all. The problem was reported in our out-of-tree
version of the compiler and I must have hit finger problems when I confirmed it
in tree. Repeating the test I can no longer reproduce the fault with the 3.9.0
pub
a.sidorin added a comment.
Looks good now, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D27180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons updated this revision to Diff 82113.
malcolm.parsons added a comment.
Use character literal prefixes.
Use float literal suffix.
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseD
Author: abataev
Date: Tue Dec 20 10:51:02 2016
New Revision: 290181
URL: http://llvm.org/viewvc/llvm-project?rev=290181&view=rev
Log:
[OPENMP] Fix for PR31416: Clang crashes on OMPCapturedExpr during source
based coverage compilation
Added source location info to captured expression declaration +
rogfer01 updated this revision to Diff 82114.
rogfer01 added a comment.
Minor issues addressed
https://reviews.llvm.org/D23325
Files:
include/clang/AST/Decl.h
include/clang/AST/Expr.h
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/Specifiers.h
Thank you for your detailed explanation!
It would seem perfectly reasonable to define the behavior in this case, at
least (and I suppose not only) to me.
Attila
2016-12-20 14:50 GMT+01:00 Aaron Ballman :
> On Tue, Dec 20, 2016 at 7:58 AM, Attila Török
> wrote:
> > I did not see that it was reapp
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
Thanks,
Manman
https://reviews.llvm.org/D27852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
bruno added a comment.
Hi,
Thanks for working on this.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:647
+ "top-level module '%0' in private module map, expected a submodule of '%1'">,
+ InGroup>;
It would be nice if we could also emit a FixIt to t
Thank you for looking into this :)!
I noticed that your test case doesn't hit the code coverage path, however.
Perhaps it would be better to remove the PROF-INSTR-PATH check and instead
introduce something like `test/CoverageMapping/openmp.cpp`:
// RUN: %clang_cc1 -fopenmp -x c++ -triple x86_6
ahatanak updated this revision to Diff 82120.
ahatanak added a comment.
Call TransformDeclarationNameInfo unconditionally to transform NameInfo rather
than doing so only for destructors. I think this is a cleaner fix.
https://reviews.llvm.org/D24969
Files:
lib/Sema/SemaTemplateInstantiateDec
rsmith added a comment.
Looks good, other than error recovery.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:4851
+ DeclarationNameInfo NameInfo(Name, D->getLocation());
+ Name = SubstDeclarationNameInfo(NameInfo, TemplateArgs).getName();
+ DeclContext::lo
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D24639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a reviewer: rjmccall.
probinson added a comment.
+rjmccall as IR Gen owner.
https://reviews.llvm.org/D27936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, any chance I can tempt you to lowerCamelCase all the other
ASTRecordReader members to match the new ones as a follow-up change?
https://reviews.llvm.org/D27836
__
probinson created this revision.
probinson added a reviewer: rjmccall.
probinson added a subscriber: cfe-commits.
In C++11, we don't emit vtables as eagerly as we do for C++03, so fiddle the
tests to emit them when the test expects them.
In the C++11 test cleanup project, we're commonly making t
zaks.anna added a comment.
Are there any negative effects from having the duplicates in edges?
When does this occur? It's a bit suspicious since we have a FromN, and a path
is split at that node, resulting in successors that are the same. Is it
possible that whoever split the state did not enco
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D26750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ahatanak updated this revision to Diff 82134.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Add code for error recovery.
https://reviews.llvm.org/D24969
Files:
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/destructor.cpp
Index: tes
ahatanak added inline comments.
Comment at: lib/Sema/TreeTransform.h:8766-8767
NamedDecl *FirstQualifierInScope = nullptr;
+ DeclarationNameInfo MemberNameInfo =
+ getDerived().TransformDeclarationNameInfo(E->getMemberNameInfo());
rsmith wrote:
> Likew
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, but fix what @bruno spotted before committing.
https://reviews.llvm.org/D27832
___
cfe-commits mailing list
cfe-commits@lists.llv
ahatanak updated this revision to Diff 82142.
ahatanak added a comment.
Rebase and improve test cases.
- Add "-mllvm -disable-llvm-optzns" to the RUN line.
- Add a test case that shows lifetime.start of a variable isn't moved to the
beginning of its scope when the goto leaves the scope.
https:
Author: malcolm.parsons
Date: Tue Dec 20 15:26:07 2016
New Revision: 290202
URL: http://llvm.org/viewvc/llvm-project?rev=290202&view=rev
Log:
[clang-tidy] Add modernize-use-default-member-init check
Summary: Fixes PR18858
Reviewers: alexfh, hokein, aaron.ballman
Subscribers: JDevlieghere, Eugen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290202: [clang-tidy] Add modernize-use-default-member-init
check (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26750?vs=82113&id=82144#toc
Repository:
rL LLVM
htt
timshen updated this revision to Diff 82148.
timshen added a comment.
Consistently use early return style.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/test/CodeGen/PowerPC/fp128-bitcast
timshen added a comment.
I changed type style to early return.
For constructors and destructors, I use:
if (...) {
// statement;
return;
}
For normal functions that returns void, I chose:
if (...)
return Foo();
llvm_unreachable(...);
since it's more compact. If returning v
Author: rsmith
Date: Tue Dec 20 15:35:28 2016
New Revision: 290203
URL: http://llvm.org/viewvc/llvm-project?rev=290203&view=rev
Log:
[c++1z] P0195R2: Support pack-expansion of using-declarations.
This change introduces UsingPackDecl as a marker for the set of UsingDecls
produced by pack expansion
On 19 December 2016 at 04:26, Renato Golin wrote:
> On 19 December 2016 at 11:28, Daniel Jasper via cfe-commits
> wrote:
> > I have reverted this in r290092 as it was leading to Clang crashes on the
> > bots and elsewhere, e.g.:
> > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/bui
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
No, seems fine to me.
https://reviews.llvm.org/D27994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Nicely done.
https://reviews.llvm.org/D27936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rjmccall added a comment.
Wouldn't it be simpler to just record an insertion point for the beginning of
the current lexical scope and insert the lifetime.begin there instead of at the
current IP?
Comment at: lib/CodeGen/CodeGenFunction.h:351
llvm::Value *Size;
+llvm:
lenykholodov added a comment.
LGTM
https://reviews.llvm.org/D27956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Dec 20, 2016 at 4:26 PM, Malcolm Parsons via cfe-commits
wrote:
> Author: malcolm.parsons
> Date: Tue Dec 20 15:26:07 2016
> New Revision: 290202
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290202&view=rev
> Log:
> [clang-tidy] Add modernize-use-default-member-init check
>
> Summary:
Author: probinson
Date: Tue Dec 20 16:22:24 2016
New Revision: 290205
URL: http://llvm.org/viewvc/llvm-project?rev=290205&view=rev
Log:
Make two vtable tests tolerate C++11.
In C++11 we don't emit vtables as eagerly as we do for C++03, so
fiddle the tests to emit them when the test expects them.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290205: Make two vtable tests tolerate C++11. (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D27994?vs=82126&id=82156#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27
Author: probinson
Date: Tue Dec 20 16:26:11 2016
New Revision: 290207
URL: http://llvm.org/viewvc/llvm-project?rev=290207&view=rev
Log:
C++11 test cleanup: nonthrowing destructors
If a dtor has no interesting members, then it ends up being nothrow,
which affects the generated IR. Modify some test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290207: C++11 test cleanup: nonthrowing destructors
(authored by probinson).
Changed prior to commit:
https://reviews.llvm.org/D27936?vs=81982&id=82157#toc
Repository:
rL LLVM
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290208: Make a test use a specific C++ dialect (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D27956?vs=82020&id=82160#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: probinson
Date: Tue Dec 20 16:30:44 2016
New Revision: 290208
URL: http://llvm.org/viewvc/llvm-project?rev=290208&view=rev
Log:
Make a test use a specific C++ dialect
In stack-reuse-miscompile.cpp, the allocas for the temps come out in
a different order depending on whether the dialect is
graydon marked 5 inline comments as done.
graydon added a comment.
Addressed review comments
https://reviews.llvm.org/D27852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
graydon updated this revision to Diff 82161.
graydon added a comment.
Updates to address review comments
https://reviews.llvm.org/D27852
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/HeaderSearch.h
lib/Lex/HeaderSearch.cpp
l
bruno added a comment.
Ping!
https://reviews.llvm.org/D27604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 20 December 2016 at 22:32, Aaron Ballman wrote:
> On Tue, Dec 20, 2016 at 4:26 PM, Malcolm Parsons via cfe-commits
> wrote:
>> Author: malcolm.parsons
>> Date: Tue Dec 20 15:26:07 2016
>> New Revision: 290202
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=290202&view=rev
>> Log:
>> [clang-
puetzk added a comment.
I see that you added a FIXME mentioning that it should be C++-only, but I don't
see where you actually did anything that would make it so. What am I missing?
Also, did you mean to drop the changes to utils/TableGen/ClangAttrEmitter.cpp
and bring back the WarnDiag, "Expec
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: test/Modules/implicit-private-with-different-name.m:13
+//
expected-warning@Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap:1{{top-level
module 'APrivate' in private
graydon added inline comments.
Comment at: test/Modules/implicit-private-with-different-name.m:13
+//
expected-warning@Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap:1{{top-level
module 'APrivate' in private module map, expected a submo
Author: malcolm.parsons
Date: Tue Dec 20 16:57:21 2016
New Revision: 290210
URL: http://llvm.org/viewvc/llvm-project?rev=290210&view=rev
Log:
Comment out char16_t and char32_t tests
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-default-member-init-assignment.cpp
clang-
bruno accepted this revision.
bruno added a comment.
Right, I missed it, LGTM
https://reviews.llvm.org/D27852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dlj added a comment.
In https://reviews.llvm.org/D27836#628029, @rsmith wrote:
> LGTM, any chance I can tempt you to lowerCamelCase all the other
> ASTRecordReader members to match the new ones as a follow-up change?
Yup, will do.
https://reviews.llvm.org/D27836
__
nwilson added a comment.
Ping
https://reviews.llvm.org/D26882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290219: [modules] Handle modules with nonstandard names in
module.private.modulemaps (authored by graydon).
Changed prior to commit:
https://reviews.llvm.org/D27852?vs=82161&id=82177#toc
Repository:
Author: graydon
Date: Tue Dec 20 18:24:39 2016
New Revision: 290219
URL: http://llvm.org/viewvc/llvm-project?rev=290219&view=rev
Log:
[modules] Handle modules with nonstandard names in module.private.modulemaps
Summary:
The module system supports accompanying a primary module (say Foo) with
an au
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1923
+IsConstexpr = IC;
+setImplicitlyInline();
+ }
nwilson wrote:
> hubert.reinterpretcast wrote:
> > I am quite sure this is not the right thing to do when `IC` is `false`.
> Good point
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a subscriber: cfe-commits.
This patch changes TableGen-generated code in AttrPCHRead to call functions on
ASTRecordReader, instead of passing separate parameters to ASTReader. This is a
follow-up to r290217.
https://reviews.llvm.
Author: graydon
Date: Tue Dec 20 18:48:14 2016
New Revision: 290221
URL: http://llvm.org/viewvc/llvm-project?rev=290221&view=rev
Log:
Fix build breakage in r290219. Notes should not be in diagnostic groups.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
Modified: cfe/trunk/inc
Author: rsmith
Date: Tue Dec 20 19:10:31 2016
New Revision: 290225
URL: http://llvm.org/viewvc/llvm-project?rev=290225&view=rev
Log:
Factor out checking of template arguments after deduction into a separate
function. (This change would also allow us to handle default template arguments
in partial
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a subscriber: cfe-commits.
This follows up to r290217, and makes functions on ASTRecordReader consistent
and valid style.
https://reviews.llvm.org/D28008
Files:
include/clang/Serialization/ASTReader.h
lib/Serialization/ASTRe
Author: rsmith
Date: Tue Dec 20 19:31:56 2016
New Revision: 290227
URL: http://llvm.org/viewvc/llvm-project?rev=290227&view=rev
Log:
[c++1z] When initializing a const-qualified class type, don't forget to add on
the requested cv-qualifiers after construction. This usually doesn't matter,
but it do
amaiorano updated this revision to Diff 82185.
amaiorano added a comment.
As agreed, modified getStyle to make use of vfs::FileSystem::makeAbsolute. I
would modify the body of the commit as follows:
Modify getStyle to use vfs::FileSystem::makeAbsolute just like FS.addFile does,
rather than sys::
Author: rsmith
Date: Tue Dec 20 19:57:02 2016
New Revision: 290229
URL: http://llvm.org/viewvc/llvm-project?rev=290229&view=rev
Log:
Fix defaulted-functions-in-C++98 extension to give the functions the same
effect they would have in C++11. In particular, they do not prevent
value-initialization fr
On 19 December 2016 at 17:00, Friedman, Eli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 12/19/2016 3:59 PM, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Mon Dec 19 17:59:34 2016
>> New Revision: 290146
>>
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test
On 20 December 2016 at 18:14, Richard Smith wrote:
> On 19 December 2016 at 17:00, Friedman, Eli via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On 12/19/2016 3:59 PM, Richard Smith via cfe-commits wrote:
>>
>>> Author: rsmith
>>> Date: Mon Dec 19 17:59:34 2016
>>> New Revision: 29014
Author: graydon
Date: Tue Dec 20 21:00:11 2016
New Revision: 290233
URL: http://llvm.org/viewvc/llvm-project?rev=290233&view=rev
Log:
Fix windows build breakage in r290219. Unix path separators in testcase.
Modified:
cfe/trunk/test/Modules/implicit-private-with-different-name.m
Modified: cfe
1 - 100 of 104 matches
Mail list logo
