rsmith added inline comments.
================ Comment at: include/clang/AST/Decl.h:1923 + IsConstexpr = IC; + setImplicitlyInline(); + } ---------------- nwilson wrote: > hubert.reinterpretcast wrote: > > I am quite sure this is not the right thing to do when `IC` is `false`. > Good point. I //could// do `if (IC) setImplicitlyInline();`, but that doesn't > seem great with these smaller functions. Any suggestions by you or @rsmith > would be great! Doing something automatic here with the inline specifier is turning out to be too complex. Instead, let's just remove the `setImplicitlyInline()` call from here and call it explicitly when handling a concept. https://reviews.llvm.org/D26882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits