Hi Joerg,
thanks for your comments. I agree that these false positives are annoying.
I submitted a while ago a patch to address those false positives in
https://reviews.llvm.org/D23657 but it is pending approval.
Kind regards,
Roger
> -Original Message-
> From: Joerg Sonnenberger [mail
arphaman added a comment.
In https://reviews.llvm.org/D25131#558004, @rsmith wrote:
> Minor comment, otherwise LGTM.
This makes sense, thanks for pointing it out!
I'll update the comment when I commit.
Repository:
rL LLVM
https://reviews.llvm.org/D25131
_
Author: dergachev
Date: Mon Oct 3 02:58:26 2016
New Revision: 283092
URL: http://llvm.org/viewvc/llvm-project?rev=283092&view=rev
Log:
[analyzer] Extend bug reports with extra notes
These diagnostics are separate from the path-sensitive engine's path notes,
and can be added manually on top of pa
mgorny closed this revision.
mgorny added a comment.
I'm going to close this manually since it seems that Phabricator commit
processing is stuck somehow.
https://reviews.llvm.org/D25161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: dergachev
Date: Mon Oct 3 03:03:51 2016
New Revision: 283093
URL: http://llvm.org/viewvc/llvm-project?rev=283093&view=rev
Log:
[analyzer] Add extra notes to ObjCDeallocChecker
The report is now highlighting instance variables and properties
referenced by the warning message with the help
Author: dergachev
Date: Mon Oct 3 03:11:50 2016
New Revision: 283094
URL: http://llvm.org/viewvc/llvm-project?rev=283094&view=rev
Log:
[analyzer] Improve CloneChecker diagnostics
Highlight code clones referenced by the warning message with the help of
the extra notes feature recently introduced
Author: danielmarjamaki
Date: Mon Oct 3 03:28:51 2016
New Revision: 283095
URL: http://llvm.org/viewvc/llvm-project?rev=283095&view=rev
Log:
[StaticAnalyzer] Fix UnreachableCode false positives.
When there is 'do { } while (0);' in the code the ExplodedGraph and
UnoptimizedCFG did not match.
D
danielmarjamaki closed this revision.
danielmarjamaki added a comment.
r283095
https://reviews.llvm.org/D24759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff updated this revision to Diff 73245.
sepavloff added a comment.
Updated path
The patch is aligned with corresponding changes in llvm repository
(https://reviews.llvm.org/D24926).
Also support of configuration selection for executables line foo-clang is
added.
https://reviews.llvm.org
sepavloff added inline comments.
> mgorny wrote in driver.cpp:334
> 1. I'm not sure if others would agree with me but I think it would be better
> to move those default paths straight to LLVM. If others tools are to adopt
> those configuration files, it would only be reasonable to use the same
SjoerdMeijer added a comment.
Ping
https://reviews.llvm.org/D24909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: danielmarjamaki
Date: Mon Oct 3 04:45:35 2016
New Revision: 283096
URL: http://llvm.org/viewvc/llvm-project?rev=283096&view=rev
Log:
[StaticAnalyser] Add test case to ensure that unreachable code is found.
https://reviews.llvm.org/D24905
Modified:
cfe/trunk/test/Analysis/unreachabl
danielmarjamaki added a comment.
In https://reviews.llvm.org/D24905#557573, @dcoughlin wrote:
> Sorry, missed this patch.
>
> I think it would good to add a test to make sure we do warn when the var decl
> has an initializer, since that will not be executed.
>
> void varDecl(int X) {
> swi
Hello!
Moving it to a subgroup such as -Wparentheses is fine for me. I will look at
that when I have time. Do you think this warning has an acceptable output then?
Best regards,
Daniel Marjamäki
xazax.hun added a comment.
The referenced patch was commited. Could you close/abandon this one?
https://reviews.llvm.org/D24878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: logan
Date: Mon Oct 3 06:08:17 2016
New Revision: 283100
URL: http://llvm.org/viewvc/llvm-project?rev=283100&view=rev
Log:
[CMake] Fix libc++abi standalone cmake build.
The cmake files install directory has been changed to
${prefix}/lib/cmake/llvm since r259821. Searching cmake modules
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as rL283100.
https://reviews.llvm.org/D24081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny abandoned this revision.
mgorny added a comment.
Independently fixed in rL283100.
https://reviews.llvm.org/D25003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
logan added a comment.
Ping. Any further comments? Or, should we duplicate `` in multiple
repositories?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: arphaman
Date: Mon Oct 3 07:12:03 2016
New Revision: 283102
URL: http://llvm.org/viewvc/llvm-project?rev=283102&view=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
usi
On 3 October 2016 at 13:12, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Mon Oct 3 07:12:03 2016
> New Revision: 283102
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283102&view=rev
> Log:
> Fix PR 28885: Fix AST Printer output for the inherited c
malcolm.parsons updated this revision to Diff 73260.
malcolm.parsons added a comment.
Herald added a subscriber: modocache.
Don't warn for trivially default constructable members
https://reviews.llvm.org/D24339
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityT
Author: arphaman
Date: Mon Oct 3 07:17:56 2016
New Revision: 283104
URL: http://llvm.org/viewvc/llvm-project?rev=283104&view=rev
Log:
Revert r283102 (Typo in the phabricator link)
Modified:
cfe/trunk/lib/AST/DeclPrinter.cpp
cfe/trunk/test/SemaCXX/cxx11-ast-print.cpp
Modified: cfe/trunk/
Author: arphaman
Date: Mon Oct 3 07:22:17 2016
New Revision: 283105
URL: http://llvm.org/viewvc/llvm-project?rev=283105&view=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
usi
a.sidorin abandoned this revision.
a.sidorin added a comment.
Merged into https://reviews.llvm.org/D14326 and committed.
https://reviews.llvm.org/D24807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
On 3 October 2016 at 13:23, Alex L wrote:
>
>
> On 3 October 2016 at 13:12, Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: arphaman
>> Date: Mon Oct 3 07:12:03 2016
>> New Revision: 283102
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=283102&view=rev
>> Log:
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.
This LGTM, although I find "fast-math.c" much easier to read than
"denormalfpmode.c". How about naming it "denormal-fp-math.c" to match the
option name?
Author: rksimon
Date: Mon Oct 3 07:37:08 2016
New Revision: 283106
URL: http://llvm.org/viewvc/llvm-project?rev=283106&view=rev
Log:
Wdocumentation fix
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp
URL:
http://llvm.org/viewvc/llvm-p
SjoerdMeijer added a comment.
Yes, excellent, I will rename it to denormal-fp-math.c and commit. Thanks for
reviewing!
https://reviews.llvm.org/D24907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rSerge added a comment.
@dberris , could you deliver this patch to mainline? Or do we need approval
from more reviewers?
https://reviews.llvm.org/D24799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
mshockwave removed a reviewer: bader.
mshockwave updated this revision to Diff 73254.
mshockwave added a comment.
@Anastasia
Sorry for late responding, I'd just attach a new version of patch that fixes
block function use cases as normal lambda functions. But testing code is not
included in this
hfinkel added a comment.
I'm fine with setting these for consistency, but I don't understand why our
failure to do this would cause problems. If you look in lib/CodeGen/CGCall.cpp
and you'll see:
if (!CodeGenOpts.FPDenormalMode.empty())
FuncAttrs.addAttribute("denormal-fp-math",
Author: sjoerdmeijer
Date: Mon Oct 3 08:12:20 2016
New Revision: 283109
URL: http://llvm.org/viewvc/llvm-project?rev=283109&view=rev
Log:
This adds a separate file for the fp denormal regression tests. NFC.
Differential Revision: https://reviews.llvm.org/D24907
Modified:
cfe/trunk/test/Driv
Author: sjoerdmeijer
Date: Mon Oct 3 08:13:50 2016
New Revision: 283110
URL: http://llvm.org/viewvc/llvm-project?rev=283110&view=rev
Log:
This adds a separate file for the fp denormal regression tests. NFC.
I forgot to svn add the new file in my previous commit.
Added:
cfe/trunk/test/Driver
Hi,
I just committed to Clang and noticed that the corresponding Phabricator ticket
does not get automatically closed (I have "Differential Revision:" in my commit
message and believe I didn't make a typo).
Is it just me, or is this is broken after the upgrade? For committing to LLVM
this still
On Mon, 3 Oct 2016 13:47:08 +
Sjoerd Meijer via cfe-commits wrote:
> I just committed to Clang and noticed that the corresponding Phabricator
> ticket does not get automatically closed (I have "Differential Revision:" in
> my commit message and believe I didn't make a typo).
> Is it just me
Author: marshall
Date: Mon Oct 3 09:23:04 2016
New Revision: 283112
URL: http://llvm.org/viewvc/llvm-project?rev=283112&view=rev
Log:
List tentatively ready issues for Issaquah
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llv
Author: marshall
Date: Mon Oct 3 09:24:21 2016
New Revision: 283113
URL: http://llvm.org/viewvc/llvm-project?rev=283113&view=rev
Log:
Change titie of page from Oulu to Issaquah
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llv
Author: yaxunl
Date: Mon Oct 3 09:41:50 2016
New Revision: 283114
URL: http://llvm.org/viewvc/llvm-project?rev=283114&view=rev
Log:
[OpenCL] Fix bug in __builtin_astype causing invalid LLVM cast instructions
__builtin_astype is used to cast OpenCL opaque types to other types, as such,
it needs
edward-jones added a comment.
Ping.
https://reviews.llvm.org/D24461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks for poining that out. I have updated the test case, please see if that
works.
http://llvm.org/viewvc/llvm-project?view=revision&revision=283085
-Aditya
From: Yaron Keren
Sent: Sunday, October 2, 2016 11:32 AM
To: Aditya Kumar
Cc: cfe-commits
Subject:
davide created this revision.
davide added reviewers: mehdi_amini, tejohnson.
davide added a subscriber: cfe-commits.
This looks like an obvious typo to me, but I don't know the whole ThinLTO
story, so.
https://reviews.llvm.org/D25190
Files:
clang/docs/ThinLTO.rst
Index: clang/docs/ThinLTO
Author: vedantk
Date: Mon Oct 3 10:29:22 2016
New Revision: 283116
URL: http://llvm.org/viewvc/llvm-project?rev=283116&view=rev
Log:
[ARC] Ignore qualifiers in copy-restore expressions
When ARC is enabled, an ObjCIndirectCopyRestoreExpr models the passing
of a function argument s.t:
* The arg
rnk added inline comments.
> CGDebugInfo.cpp:47
>
> +namespace {
> +template
LLVM prefers `static` to anonymous namespaces
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
> CGDebugInfo.cpp:48
> +namespace {
> +template
> +uint64_t GetTypeAlignIfRequired(Type Ty, const ASTCon
SjoerdMeijer added a comment.
Hi Hal,
Thanks for reviewing and you're right: this should work. We actually have
actually some downstream (aarch64) build attribute selection code that would
work better with this change. Are you okay with committing this change?
Cheers,
Sjoerd.
https://reviews.
hfinkel added a comment.
In https://reviews.llvm.org/D24909#559110, @SjoerdMeijer wrote:
> Hi Hal,
> Thanks for reviewing and you're right: this should work. We actually have
> actually some downstream (aarch64) build attribute selection code that would
> work better with this change. Are you
rnk added a comment.
It feels like the right thing is to disable EH in device side compilation, but
obviously that won't work because it would reject try/throw in host code. I
think instead of doing that, we should make sure that CUDA diagnoses try /
catch / throw in device functions, and then
Author: logan
Date: Mon Oct 3 11:00:22 2016
New Revision: 283118
URL: http://llvm.org/viewvc/llvm-project?rev=283118&view=rev
Log:
[lit] Allow more file extensions for test cases.
This commit splits the file extensions before determining the test
format. This allows libc++abi to add assembly-ba
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
Good catch indeed!
https://reviews.llvm.org/D25190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as rL283118 with the suggested change
regarding to `is_sh_test` assertion.
https://reviews.llvm.org/D24087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
logan added a comment.
Ping? Any other comments?
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In https://reviews.llvm.org/D25166#559117, @rnk wrote:
> It feels like the right thing is to disable EH in device side compilation,
> but obviously that won't work because it would reject try/throw in host code.
Exactly.
> I think instead of doing that, we should make
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaOverload.cpp:1131
>
>if (getLangOpts().CUDA && ConsiderCudaAttrs) {
> CUDAFunctionTarget NewTarget = IdentifyCUDATarget(New),
I feel like we should
hxy9243 updated this revision to Diff 73293.
hxy9243 added a comment.
Addresses comments from @halyavin, rename "atomic_support.h" to
"__atomic_support" to avoid collisions with application headers.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/__atomic_support
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov requested changes to this revision.
GorNishanov added a comment.
This revision now requires changes to proceed.
> coroutines.cpp:1
> // RUN: %clang_cc1 -std=c++14 -fcoroutines -verify %s
>
Change to -fcoroutines-ts
https://reviews.llvm.org/D25068
___
jlebar added inline comments.
> rnk wrote in SemaOverload.cpp:1131
> I feel like we should exit early on destructors here, before we do any target
> checks. The assert also feels kind of trivial because we only come into this
> overload machinery if looking up New's DeclarationName found Old.
Author: jlebar
Date: Mon Oct 3 11:48:23 2016
New Revision: 283120
URL: http://llvm.org/viewvc/llvm-project?rev=283120&view=rev
Log:
[CUDA] Disallow overloading destructors.
Summary:
We'd attempted to allow this, but turns out we were doing a very bad
job. :)
Making this work properly would be
Author: jlebar
Date: Mon Oct 3 11:48:27 2016
New Revision: 283121
URL: http://llvm.org/viewvc/llvm-project?rev=283121&view=rev
Log:
[CUDA] Clean up some comments in Sema::IsOverload. NFC
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http:
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Oct 3 12:35:08 2016
New Revision: 283124
URL: http://llvm.org/viewvc/llvm-project?rev=283124&view=rev
Log:
Mark a couple issues as done (2742 and 2760)
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://l
gingell created this revision.
gingell added reviewers: cfe-commits, kcc.
This patch adds a "value-after-delete" sanitizer, which will
invalidate the value of a pointer passed in a delete expression.
For instance, when -fsanitize=value-after-delete is passed:
int *foo = new int;
delete foo;
// f
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
> Are you suggesting having them enabled unconditionally in both gold-plugin
> and gold? That will require changes to both llvm and binutils, and the latter
> will have effects for other compilers.
I mean in the gold plugin only. There would not need to be any changes to go
rnk added inline comments.
> Sema.h:9210
> + /// Emit no diagnostics.
> + NOP,
> + /// Emit the diagnostic immediately (i.e., behave like Sema::Diag()).
LLVM has a different enum naming convention:
http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enume
rnk added a comment.
In https://reviews.llvm.org/D25166#559168, @jlebar wrote:
> > Also, take a look at CodeGenFunction::getInvokeDestImpl(). I think you
> > should add some checks in there to return nullptr if we're doing a
> > device-side CUDA compilation. That's a much more direct way to ens
vsk added a comment.
It looks like programs which trip -fsanitize-value-after-delete will just crash
without further reporting, which isn't in keeping with the way other ubsan
checks are implemented.
IMO, address sanitizer is better-equipped to diagnose this issue.
https://reviews.llvm.org/D2
Ping.
Thanks,
--Serge
2016-09-16 23:17 GMT+07:00 Serge Pavlov :
> Ping.
>
> Thanks,
> --Serge
>
> 2016-09-08 20:43 GMT+07:00 Serge Pavlov :
>
>> Any feedback?
>>
>> Thanks,
>> --Serge
>>
>> 2016-09-02 13:11 GMT+07:00 Serge Pavlov :
>>
>>> sepavloff updated this revision to Diff 70134.
>>> sepavl
erichkeane created this revision.
erichkeane added reviewers: oren_ben_simhon, cfe-commits.
erichkeane set the repository for this revision to rL LLVM.
The Register Calling Convention (RegCall) was introduced by Intel to optimize
parameter transfer on function call.
This calling convention ensure
yes, it works, thanks!
2016-10-03 18:19 GMT+03:00 Aditya K :
> Thanks for poining that out. I have updated the test case, please see if
> that works.
>
>
> http://llvm.org/viewvc/llvm-project?view=revision&revision=283085
>
>
>
> -Aditya
>
>
> --
> *From:* Yaron Keren
rsmith accepted this revision.
rsmith added inline comments.
> Sema.h:720-723
> + /// \brief The C++ "std::experimental" namespace, where the experimental
> parts
> + /// of the standard library resides.
> + NamespaceDecl *StdExperimentalNamespace;
> +
This is in the middle of a block of imp
rsmith added inline comments.
> LanguageExtensions.rst:1886
> + bool __builtin_coro_done(void *addr);
> + void __builtin_coro_promise(void *addr, int alignment, bool from_promise)
> +
Return type here is `void*`, not `void`.
> LanguageExtensions.rst:1916
> +
> +Other coroutine builtins are ei
Author: rnk
Date: Mon Oct 3 13:34:23 2016
New Revision: 283131
URL: http://llvm.org/viewvc/llvm-project?rev=283131&view=rev
Log:
Factor out a diagnostic kind enum for use in two %select expressions
NFC
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe
Sunil_Srivastava added a comment.
Ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This patch breaks Windows:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/29769/
On Mon, Oct 3, 2016 at 1:07 AM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Date: Mon Oct 3 02:58:26 2016
> New Revision: 283092
>
> URL: http://llvm.org/vie
jlebar updated this revision to Diff 73315.
jlebar marked an inline comment as done.
jlebar added a comment.
Address review comments, and rebase atop https://reviews.llvm.org/D24573.
https://reviews.llvm.org/D25139
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/
jlebar added inline comments.
> rnk wrote in Sema.h:9238
> I'm concerned that this usage pattern isn't going to be efficient because you
> build the complete diagnostic before calling the bool conversion operator to
> determine that it doesn't need to be emitted. I think you want to construct
vleschuk updated this revision to Diff 73318.
vleschuk added a comment.
Fix code style:
- Two overloaded methods instead of 1 template
- lower-case-headed method names
- static methods instead of anon namespace
- extra new line between methods
https://reviews.llvm.org/D24426
Files:
lib/CodeG
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> CGDebugInfo.cpp:54-56
> + auto TI = Ctx.getTypeInfo(Ty);
> + return TI.AlignIsRequired ? Ctx.toCharUnitsFromBits(TI.Align).getQuantity()
> +
ahatanak created this revision.
ahatanak added a reviewer: rsmith.
ahatanak added a subscriber: cfe-commits.
This fixes PR30566.
The assertion is triggered when RecordLayoutBuilder tries to compute the size
of a field (for capture "name" in the test case) whose type hasn't been
deduced. This fi
> fatal error C1001: An internal error has occurred in the compiler.
Ouch. So i managed to *crash* the microsoft compiler with my code?
Could you please somehow have a look if this is reproducible? If it's
reproducible or hard-to-check-if-reproducible then i'd revert.
I don't think i can debu
ioeric created this revision.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Also test phabricator commit processing.
https://reviews.llvm.org/D25207
Files:
include/clang/Tooling/Core/Replacement.h
Index: include/clang/Tooling/Core/Replacement.h
=
ioeric accepted this revision.
ioeric added a reviewer: ioeric.
ioeric added a comment.
This revision is now accepted and ready to land.
Since this patch only introduces new comments, I'll commit it for now to also
test phabricator's commit processing.
https://reviews.llvm.org/D25207
___
Author: ioeric
Date: Mon Oct 3 14:14:30 2016
New Revision: 283135
URL: http://llvm.org/viewvc/llvm-project?rev=283135&view=rev
Log:
Added more comments to tooling::Replacements.
Summary: Also test phabricator commit processing.
Subscribers: klimek, cfe-commits
Differential Revision: https://re
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some
of their members exported, otherwise we have a lot of link errors when
linking against a libc++ bu
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D4687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
Just want to give you a heads up that I was going to abandon the patch that
adds support for attribute "flexible_array" (https://reviews.llvm.org/D21453)
after r281277, but I'll probably need the attribute after all if we are going
to make the changes in this patch.
rsmith added a comment.
I'm concerned about the complexity of this approach; it's hard for me to be
confident that `BuildScopeInformation` is correct and will remain correct in
the presence of future changes to the AST, and if it's not, we'll potentially
silently miscompile.
A simpler but less
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL213987.
https://reviews.llvm.org/D4362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rnk added inline comments.
> jlebar wrote in Sema.h:9258
> These diagnostics live until the end of codegen, and so are destroyed after
> the ASTContext.
>
> I am becoming increasingly displeased with emitting these errors during
> codegen. In particular, it makes it annoying to write tests.
aaron.ballman added inline comments.
> vbyakovlcl wrote in DiagnosticGroups.td:522
> Gcc prints error messages
>
> t.c:21:13: error: invalid operands to binary << (have vector_int8 and
> vector_short8)
>
> vi8 = vi8 << vs8;
>
> I could not find a flag controlling this error.
I would not ad
aaron.ballman added a comment.
This patch is missing tests for the new functionality.
> aaron.ballman wrote in ExprCXX.h:109
> Missing the full stop at the end of the sentence.
It looks like this comment has not been handled yet.
> ExprCXX.h:120
> + // Check to see if a given overloaded oper
Author: dergachev
Date: Mon Oct 3 15:12:12 2016
New Revision: 283141
URL: http://llvm.org/viewvc/llvm-project?rev=283141&view=rev
Log:
[analyzer] A blind attempt to fix a buildbot after r283092.
The msvc compiler seems to crash compiling the BugReport class.
Modified:
cfe/trunk/include/clan
aaron.ballman added inline comments.
> ProTypeMemberInitCheck.cpp:307
> + Result.Nodes.getNodeAs("record")) {
> +assert(Record->hasDefaultConstructor());
> +checkMissingMemberInitializer(*Result.Context, Record, nullptr);
Please add an explanatory string literal to the as
I will look into this and get back to you.
On Mon, Oct 3, 2016 at 12:12 PM Artem Dergachev wrote:
> > fatal error C1001: An internal error has occurred in the compiler.
>
> Ouch. So i managed to *crash* the microsoft compiler with my code?
>
> Could you please somehow have a look if this is repr
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL209924.
https://reviews.llvm.org/D3922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
- Original Message -
> From: "Artem Dergachev via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Monday, October 3, 2016 3:12:13 PM
> Subject: r283141 - [analyzer] A blind attempt to fix a buildbot after r283092.
>
> Author: dergachev
> Date: Mon Oct 3 15:12:12 2016
> New Revision
I also made a quick blind guess at r283141
(http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161003/172390.html)
Thanks a lot for trying to help, sorry for causing problems.
03/10/2016 23:26, Vitaly Buka пишет:
I will look into this and get back to you.
On Mon, Oct 3, 2016 at 12:12
aaron.ballman added inline comments.
> CppCoreGuidelinesTidyModule.cpp:40
> +CheckFactories.registerCheck(
> +"cppcoreguidelines-one-name-per-declaration");
> CheckFactories.registerCheck(
Can you also register this check under the name `cert-dcl04-c` as well? It fits
the behav
1 - 100 of 180 matches
Mail list logo
