sepavloff added inline comments.
> mgorny wrote in driver.cpp:334 > 1. I'm not sure if others would agree with me but I think it would be better > to move those default paths straight to LLVM. If others tools are to adopt > those configuration files, it would only be reasonable to use the same search > paths consistently and not repeat them in every tool. > > 2. I think the `/etc` prefix should be made configurable via CMake options. > One case that would benefit from this is Gentoo Prefix where the Gentoo > system root is located in a subdirectory of /. It make sense, as it would establish uniform paths. However CommandLine is positioned as general purpose library, which can be used by any tool, not only llvm ones, so forcing particular paths seems to be too rigid. Besides, discussion in mail list demonstrated very diverse opinions, so I would prefer flexible solution. Notion about configurable paths is definitely worth implementing. > mgorny wrote in driver.cpp:336 > 1. You need to update this, following your update on > https://reviews.llvm.org/D24926. > 2. I think you need to use `clang.cfg` here. Updated, thank you. https://reviews.llvm.org/D24933 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
