aaron.ballman added a comment.
This patch is missing tests for the new functionality.
> aaron.ballman wrote in ExprCXX.h:109
> Missing the full stop at the end of the sentence.
It looks like this comment has not been handled yet.
> ExprCXX.h:120
> + // Check to see if a given overloaded operator is of increment kind
> + static bool isIncrementOp(OverloadedOperatorKind Opc) {
> + return Opc == OO_PlusPlus;
I'm not certain that `isIncrementOp` or `isDecrementOp` are useful predicate
functions. I would test these conditions inside of Expr.cpp directly.
https://reviews.llvm.org/D22910
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
