r282056 - clang-format: [JS] do not wrapp @returns tags.

Author: mprobst Date: Wed Sep 21 01:56:38 2016 New Revision: 282056 URL: http://llvm.org/viewvc/llvm-project?rev=282056&view=rev Log: clang-format: [JS] do not wrapp @returns tags. Summary: @returns is incorrect code, the standard is @return. However wrapping it can still confuse users. Reviewe

Re: [PATCH] D24767: clang-format: [JS] do not wrapp @returns tags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282056: clang-format: [JS] do not wrapp @returns tags. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24767?vs=71938&id=72010#toc Repository: rL LLVM https://reviews.llvm.

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

alexshap added a comment. Without the changes: F2438373: Screen Shot 2016-09-21 at 12.38.22 AM.png With the patch the tests are green. Repository: rL LLVM https://reviews.llvm.org/D24792 ___ cfe-commits mailin

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

ioeric added inline comments. Comment at: clang-refactor/driver/Driver.cpp:36 @@ +35,3 @@ +argv[1] = (llvm::Twine(argv[0]) + " " + llvm::Twine(argv[1])).str().c_str(); +Manager.dispatch(Command, argc - 1, argv + 1); + } else { arphaman wrote: > Is there

r282059 - PR30401: Fix substitutions for functions with abi_tag

Author: dpolukhin Date: Wed Sep 21 03:27:03 2016 New Revision: 282059 URL: http://llvm.org/viewvc/llvm-project?rev=282059&view=rev Log: PR30401: Fix substitutions for functions with abi_tag Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp Modifie

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin closed this revision. DmitryPolukhin added a comment. Committed as https://reviews.llvm.org/rL282059 https://reviews.llvm.org/D24704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[libcxxabi] r282062 - [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)

Author: asiri Date: Wed Sep 21 04:09:32 2016 New Revision: 282062 URL: http://llvm.org/viewvc/llvm-project?rev=282062&view=rev Log: [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC) Align the naming / use of the macro LIBCXXABI_HAS_NO_THREADS to follow what we have in libcxx. NF

Re: [PATCH] D24784: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

hokein added a comment. Looks almost good. A few comments. Comment at: change-namespace/ChangeNamespace.cpp:467 @@ +466,3 @@ + const NamedDecl *TargetDecl = + UsingDeclaration->shadow_begin()->getTargetDecl(); + std::string TargetDeclName = TargetDecl->getQualifiedNameAsS

Re: [PATCH] D24784: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

ioeric updated this revision to Diff 72018. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24784 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h unittests/change-namespace/ChangeNamespa

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:3866 @@ -3865,3 +3865,3 @@ if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) { -assert(LCtx->getParent()); +assert(LCtx->inTopFrame() || LCtx->getParent()); return

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 72026. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2863,8 +2863,20 @@

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo updated the summary for this revision. mstorsjo updated this revision to Diff 72025. mstorsjo added a comment. Rebased on top of the latest master https://reviews.llvm.org/D24609 Files: lib/Headers/intrin.h Index: lib/Headers/intrin.h

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 72027. hokein added a comment. Update dependency. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.cpp u

[PATCH] D24791: Use checktime when reloading vim buffer after applying clang-rename

NewProggie created this revision. NewProggie added a subscriber: cfe-commits. After applying `clang-rename` to a vim buffer (using `clang-rename.py` as part of the vim integration) the buffer gets reloaded using `bufdo`. This solution is suboptimal, since syntax highlighting is turned off for pe

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lodato added a comment. Could you add a note to the commit description to say that there is a backwards incompatibility: if a filename matches a branch name or other commit-ish, then `git clang-format ` will no longer work as expected; use `git clang-format -- ` instead. Co

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis added a comment. Checking the generated IR for the incorrect uses of v8f16 shows that clang is silently generating bitcasts from <8 x i16> to <4 x float>. There are some other cases where the type of the operands is incorrect w.r.t. the builtin used. I'm not familiar with the type check

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 72031. hokein added a comment. Improve the way of detecting whether #include in old_header. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.t

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

aaron.ballman added a comment. The other thing this patch is missing are tests, btw. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +// assignment operator is intended to have a side-effect and other overloaded +// operators are not. Otherwise fall through the logic of

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D24513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[clang-tools-extra] r282070 - [clang-move] A prototype tool for moving class definition to new file.

Author: hokein Date: Wed Sep 21 08:18:19 2016 New Revision: 282070 URL: http://llvm.org/viewvc/llvm-project?rev=282070&view=rev Log: [clang-move] A prototype tool for moving class definition to new file. Summary: This patch introduces a new tool which moves a specific class definition from files

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282070: [clang-move] A prototype tool for moving class definition to new file. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D24243?vs=72031&id=72033#toc Repository: rL LLVM

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

aaron.ballman added a comment. In clang 3.8, your test code already produces a diagnostic for me: http://coliru.stacked-crooked.com/a/752a4ea34123bdae Repository: rL LLVM https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D24798: [mips] Fix msa builtins test

sdardis created this revision. sdardis added reviewers: vkalintiris, zoran.jovanovic. sdardis added a subscriber: cfe-commits. Herald added a subscriber: sdardis. This test was using the wrong types in several places. https://reviews.llvm.org/D24798 Files: test/CodeGen/builtins-mips-msa.c Ind

Re: [PATCH] D24784: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

dcoughlin added a comment. I suspect I introduced this regression in r264687. Repository: rL LLVM https://reviews.llvm.org/D24792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

yaxunl added inline comments. Comment at: clang/test/CodeGen/fp-contract-pragma___on-by-default___-O1...3___aarch64-backend.c:8 @@ +7,3 @@ +// CHECK: fmadd d0, d{{[0-7]}}, d{{[0-7]}}, d{{[0-7]}} +// CHECK-NEXT: ret +double fmadd_double(double a, double b, double c) {

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

ahatanak added a comment. Thanks Bruno. I have a couple more questions. Comment at: lib/Sema/SemaExpr.cpp:8090 @@ +8089,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return VecType; +} Sorry I wasn't clear, but I was a

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric updated this revision to Diff 72045. ioeric added a comment. - Provide order-independent replacements examples in comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index:

[clang-tools-extra] r282073 - [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

Author: ioeric Date: Wed Sep 21 10:06:12 2016 New Revision: 282073 URL: http://llvm.org/viewvc/llvm-project?rev=282073&view=rev Log: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier. Reviewers: hokein Subscribers: cfe-commits Differential Revision: https://revi

Re: [PATCH] D24784: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282073: [change-namespace] fix name qualifiers in UsingShadowDecl and… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24784?vs=72018&id=72046#toc Repository: rL LLVM https:

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge created this revision. rSerge added reviewers: rsmith, dberris. rSerge added subscribers: cfe-commits, iid_iunknown. Herald added a subscriber: dberris. Added the code which explicitly emits an error in Clang in case `-fxray-instrument` is passed, but XRay is not supported for the selected

[clang-tools-extra] r282074 - Fix compiler warnings.

Author: hokein Date: Wed Sep 21 10:19:04 2016 New Revision: 282074 URL: http://llvm.org/viewvc/llvm-project?rev=282074&view=rev Log: Fix compiler warnings. Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMo

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. Do we want to remove lifetime intrinsics when we aren't doing the asan-use-after-scope check? Since this isn't a mis-compile caused by inaccurate lifetime intrinsics, I was wondering whether we should do this only when asan-use-after-scope is on to minimize the impact

[PATCH] D24804: clang-format: [JS] reserved words in method names.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Before: class X { delete () { ... } } After: class X { delete() { ... } } https://reviews.llvm.org

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

On 21 Sep 2016 6:10 am, "Aaron Ballman" wrote: aaron.ballman added a comment. The other thing this patch is missing are tests, btw. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +// assignment operator is intended to have a side-effect and other overloaded +// operat

[PATCH] D24803: [change-namespace] fix qualifier of function references.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D24803 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp ==

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez updated this revision to Diff 72064. lhchavez added a comment. Addressed lovato's comments https://reviews.llvm.org/D24319 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format === --- to

Re: [PATCH] D24804: clang-format: [JS] reserved words in method names.

mprobst updated this revision to Diff 72061. mprobst added a comment. - move up to support let in methods. https://reviews.llvm.org/D24804 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ===

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez marked 9 inline comments as done. lhchavez added a comment. Addressed all comments. PTAAL. https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24770: [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)

rmaprath closed this revision. rmaprath added a comment. In https://reviews.llvm.org/D24770#547701, @jroelofs wrote: > LGTM Thanks! Committed as r282062. / Asiri https://reviews.llvm.org/D24770 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D24806: [docs] Add ThinLTO user documentation

tejohnson created this revision. tejohnson added a reviewer: mehdi_amini. tejohnson added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Add some user facing documentation on ThinLTO and how to use it. https://reviews.llvm.org/D24806 Files: docs/CommandGuide/clang.rst doc

[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

a.sidorin created this revision. a.sidorin added reviewers: aaron.ballman, doug.gregor. a.sidorin added a subscriber: cfe-commits. I have encountered a segfault when I tried to get sub-expression of serialized ArrayTypeTraitExpr. The fix is simple but I have no idea about nice test. Maybe you ha

Re: [PATCH] D24806: [docs] Add ThinLTO user documentation

tejohnson updated this revision to Diff 72078. tejohnson added a comment. Add some troubleshooting info for gold plugin misconfigurations https://reviews.llvm.org/D24806 Files: docs/CommandGuide/clang.rst docs/ThinLTO.rst docs/index.rst Index: docs/index.rst =

[PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

mgorny created this revision. mgorny added a reviewer: EricWF. mgorny added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Stop stripping -m32 from the user-supplied flags. There is no valid reason to do that, stripping it silently is thoroughly confusing and makes it impossi

Re: [PATCH] D24806: [docs] Add ThinLTO user documentation

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Great! Thanks for writing it :) Comment at: docs/CommandGuide/clang.rst:339 @@ +338,3 @@ + The default for :option:`-flto` is :option:`-flto=full`, in which the +

Re: [PATCH] D24806: [docs] Add ThinLTO user documentation

tejohnson updated this revision to Diff 72081. tejohnson added a comment. Replace 'regular LTO' with 'monolithic LTO' to be more descriptive. https://reviews.llvm.org/D24806 Files: docs/CommandGuide/clang.rst docs/ThinLTO.rst docs/index.rst Index: docs/index.rst =

r282089 - [docs] Add ThinLTO user documentation

Author: tejohnson Date: Wed Sep 21 11:57:03 2016 New Revision: 282089 URL: http://llvm.org/viewvc/llvm-project?rev=282089&view=rev Log: [docs] Add ThinLTO user documentation Summary: Add some user facing documentation on ThinLTO and how to use it. Reviewers: mehdi_amini Subscribers: mehdi_amini

Re: [PATCH] D24806: [docs] Add ThinLTO user documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL282089: [docs] Add ThinLTO user documentation (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D24806?vs=72081&id=72082#toc Repository: rL LLVM https://reviews.llvm.org/D24

Re: r282089 - [docs] Add ThinLTO user documentation

Anyone know how to get these changes on http://clang.llvm.org/docs/? Is that site periodically refreshed or do I need to do something explicit? Thanks, Teresa On Wed, Sep 21, 2016 at 9:57 AM, Teresa Johnson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tejohnson > Date: Wed Sep

Re: r282089 - [docs] Add ThinLTO user documentation

It is automatically refreshed frequently I believe. If it is not there tomorrow, we should start being worried :) — Mehdi > On Sep 21, 2016, at 10:57 AM, Teresa Johnson wrote: > > Anyone know how to get these changes on http://clang.llvm.org/docs/ > ? Is that site

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added a comment. Clang 3.8 balances vector shift operand erroneous using CheckVectorOperands which converts one of operand to the type of another. In https://reviews.llvm.org/D21678 it was fixed by using checkVectorShift instead. As result clang does not emit error if shift operands

r282082 - [AVX512] Fix return types on __builtin_ia32_gather3XivXdi builtins

Author: mcinally Date: Wed Sep 21 11:07:40 2016 New Revision: 282082 URL: http://llvm.org/viewvc/llvm-project?rev=282082&view=rev Log: [AVX512] Fix return types on __builtin_ia32_gather3XivXdi builtins The return types on the AVX512 __builtin_ia32_gather3XivXdi builtins are incorrect. The return

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

Intrinsics are invalid there, code is generated in such way that variable is being accessed after lifetime.end. I suspect that optimizer can make invalid code because of this, but I can't reproduce. So I think it's safer to remove them at all and don't wait for miscompile reports. Still if perform

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka added a comment. Intrinsics are invalid there, code is generated in such way that variable is being accessed after lifetime.end. I suspect that optimizer can make invalid code because of this, but I can't reproduce. So I think it's safer to remove them at all and don't wait for miscom

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge created this revision. tigerleapgorge added a reviewer: rsmith. tigerleapgorge added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Hi Everyone, Here is the 11th Lit C++11 compatibility patch. This will most likely be my final Lit patch. I have updated 16 tests th

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. In https://reviews.llvm.org/D21698#546733, @yaxunl wrote: > In https://reviews.llvm.org/D21698#540237, @Anastasia wrote: > > > I have made an experiment with a simple kernel: > > > > void foo1(void); > > void foo2(void); > > void foo3(void); > > void foo4(void);

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

zaks.anna added a comment. > However, the assert here has a reason: we clearly shouldn't be trying to > analyze synthesized bodies as top-level functions. Yes, seems like we should update r264687 so that we use the available body when analyzing as top level. Another possible issue is that we

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl added a comment. Thanks for the review Aaron! Tom, would you be able to do a final glance over? https://reviews.llvm.org/D24513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

majnemer added a subscriber: majnemer. majnemer added a comment. In https://reviews.llvm.org/D24693#548739, @ahatanak wrote: > Do we want to remove lifetime intrinsics when we aren't doing the > asan-use-after-scope check? Since this isn't a mis-compile caused by > inaccurate lifetime intrinsic

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

alexshap added a comment. > is that a problem for your codebase? @zaks.anna - yes it is. > Another possible issue is that we will use the synthesized body if the > function name starts with "OSAtomicCompareAndSwap" since ?>we do not match > the full function name. If the function body is ava

[PATCH] D24813: Driver: Add a test for triple with opencl environment

tstellarAMD created this revision. tstellarAMD added a reviewer: Anastasia. tstellarAMD added a subscriber: cfe-commits. Herald added subscribers: yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D24813 Files: test/Driver/amdgpu-toolchain.c Index: test/Driver/amdgpu-toolchain.c ===

[libclc] r282106 - Provide vstore_half helper to workaround clc restrictions

Author: jvesely Date: Wed Sep 21 15:15:55 2016 New Revision: 282106 URL: http://llvm.org/viewvc/llvm-project?rev=282106&view=rev Log: Provide vstore_half helper to workaround clc restrictions clang won't accept half precision loads and stores without cl_khr_fp16 since r281904 Added: libclc/

r282108 - Add -Wignored-pragma-intrinsic flag

Author: agutowski Date: Wed Sep 21 15:19:21 2016 New Revision: 282108 URL: http://llvm.org/viewvc/llvm-project?rev=282108&view=rev Log: Add -Wignored-pragma-intrinsic flag Summary: People might want to receive warnings about pragmas but not about intrinsics that are implemented in intrin.h. Rev

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL282108: Add -Wignored-pragma-intrinsic flag (authored by agutowski). Changed prior to commit: https://reviews.llvm.org/D24775?vs=71960&id=72102#toc Repository: rL LLVM https://reviews.llvm.org/D2477

Re: [PATCH] D24688: Introduce "hosted" module flag.

tstellarAMD added a comment. What does "hosted mode" mean? https://reviews.llvm.org/D24688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

On Tue, Sep 20, 2016 at 4:21 PM, Albert Gutowski wrote: > OK, thanks for the note about referring to Chromium, I fixed that. > As to -Wunknown-pragma, I feel that it would be inconsistent with other > pragmas unless I moved whole pragma to lexer instead of parser - I've just > discovered that I c

Re: [PATCH] D24688: Introduce "hosted" module flag.

pcc added a comment. The word "hosted" takes its meaning from the C/C++ standards. It refers to a build environment where the standard library is guaranteed to be available. Note that we've been rethinking this approach on the mailing list, see http://lists.llvm.org/pipermail/llvm-dev/2016-Sept

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

zaks.anna added a comment. Can you give a bit more context? Do you see the crash on a redefinition of the OSAtomicCompareAndSwapPtr or one of the other standard functions or do you have another similarly named function that should not be modeled? Repository: rL LLVM https://reviews.llvm.org

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

Thanks for clarification! You are right that it doesn't really fit in -Wignored-pragma, but I also don't like the idea of getting warning about ignored "#pragma intrinsic" after setting -Wno-ignored-pragma, so I think I'll leave it as it is. On Wed, Sep 21, 2016 at 1:35 PM, Nico Weber wrote: > On

r282109 - [CMake] Pass CLANG_VERSION_* variables into later stages

Author: cbieneman Date: Wed Sep 21 15:43:43 2016 New Revision: 282109 URL: http://llvm.org/viewvc/llvm-project?rev=282109&view=rev Log: [CMake] Pass CLANG_VERSION_* variables into later stages When supporting overriding clang versions we also need to pass those through to the next stage so they

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

alexshap added a comment. @zaks.anna: it happens on one of the ports of libdispatch, but probably i also can reproduce this crash with OSAtomicCompareAndSwap. Repository: rL LLVM https://reviews.llvm.org/D24792 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Abe updated this revision to Diff 72103. Abe added a comment. Combined "fp-contract-pragma___on-by-default___-O0___aarch64-backend.c" and "fp-contract-pragma___on-by-default___-O1...3___aarch64-backend.c" into a single file ["fp-contract-pragma___on-by-default.c"]. https://reviews.llvm.org/D24

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

yaxunl added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2441 @@ +2440,3 @@ + + if ((LangOpts.C11 || LangOpts.C99 || LangOpts.CPlusPlus) + && ( CodeGenOptions::FPC_On == Res.getCodeGenOpts().getFPContractMode() ) The format o

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lodato accepted this revision. lodato added a reviewer: lodato. lodato added a comment. This revision is now accepted and ready to land. Nice feature. Thanks for the patch! https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

zaks.anna added a comment. One approach would be to skip analyzing the functions which we model as top level. - a/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp +++ b/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp @@ -688,6 +688,9 @@ void AnalysisConsumer::ActionExprEngine(Decl *D, bool Ob

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

spatel created this revision. spatel added reviewers: echristo, evandro, hfinkel. spatel added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, mcrosier. Technically, I suppose this patch is independent of the upcoming llvm sibling patch because we can still pass 'check-all' with

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. In https://reviews.llvm.org/D24693#549095, @majnemer wrote: > This doesn't sound right. Given the example in the description, we are > accessing the memory location after end has been called: this seems like a > real miscompile. It would appear unsafe to only do this

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 72117. sfantao added a comment. - Rebase. https://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp lib/Driver/Types.cpp test/Driver/cuda-bindings.cu test/Driver/cuda-phases.cu Index: test/Driver/cuda-phases.

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao updated this revision to Diff 72118. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao updated this revision to Diff 72120. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c === --- test/Driver/

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 72119. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 72121. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ===

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

sfantao updated this revision to Diff 72122. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp lib/Driver/MSVCToolChain.cpp lib/Driver/ToolCha

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 72124. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/Types.cpp test/Driver/o

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

sfantao updated this revision to Diff 72123. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c =

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 72125. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h test/Driver/

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao updated this revision to Diff 72126. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp lib/Driver

r282122 - [CMake] Check if passthrough variables are defined

Author: cbieneman Date: Wed Sep 21 18:24:15 2016 New Revision: 282122 URL: http://llvm.org/viewvc/llvm-project?rev=282122&view=rev Log: [CMake] Check if passthrough variables are defined Checking if they evaluate to true cases prevents passing values that evaluate to false cases. Instead we shou

Re: [PATCH] D10857: Update documentation for unroll pragmas on loops with runtime trip counts

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r242048. https://reviews.llvm.org/D10857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

alexshap updated the summary for this revision. alexshap updated this revision to Diff 72132. alexshap added a comment. Address the comments Repository: rL LLVM https://reviews.llvm.org/D24792 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp lib/StaticAnalyzer/Frontend/AnalysisC

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

vsk added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} + Rede

r282124 - [Sema] Fix PR30481: crash on checking printf args.

Author: gbiv Date: Wed Sep 21 19:00:26 2016 New Revision: 282124 URL: http://llvm.org/viewvc/llvm-project?rev=282124&view=rev Log: [Sema] Fix PR30481: crash on checking printf args. We were falling through from one case to another in a switch statement. Oops. Modified: cfe/trunk/lib/Sema/Sem

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka added a comment. Miscompile. Here assert fails without the patch. int* p1; int* p2; int use2() { assert(p1 != p2 || !"reuse"); return p1 == p2; } void f3(int cond) { { int tmp[1024]; p1 = tmp; goto l2; l1: int tmp2[1024]; p2 = tmp2; exit(use2());

r282125 - [CMake] More robust handling for bootstrap variables

Author: cbieneman Date: Wed Sep 21 19:18:12 2016 New Revision: 282125 URL: http://llvm.org/viewvc/llvm-project?rev=282125&view=rev Log: [CMake] More robust handling for bootstrap variables Checking defined isn't good enough we also need to handle defined to empty string. Modified: cfe/trunk

[libcxx] r282126 - Add missing _v traits. is_bind_expression_v, is_placeholder_v and uses_allocator_v

Author: marshall Date: Wed Sep 21 19:23:15 2016 New Revision: 282126 URL: http://llvm.org/viewvc/llvm-project?rev=282126&view=rev Log: Add missing _v traits. is_bind_expression_v, is_placeholder_v and uses_allocator_v Modified: libcxx/trunk/include/__functional_base libcxx/trunk/include/

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. What does the error actually look like? Can you add a test for it? It's unclear to me how this would read... for example does it say "XRay for arm is unsupported"? https://reviews.llvm.org/D24799 ___ cfe-commits mailing li

Re: [PATCH] D24373: [Coroutines] Adding builtins for coroutine intrinsics and backendutil support.

rsmith added inline comments. Comment at: include/clang/Basic/Builtins.def:1293 @@ +1292,3 @@ + +BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n") +BUILTIN(__builtin_coro_alloc, "bv*", "n") I don't really like having builtins which will result in errors from the midd

[PATCH] D24820: Add -stats-file option

MatzeB created this revision. MatzeB added reviewers: bruno, rsmith, aprantl. MatzeB added a subscriber: cfe-commits. MatzeB set the repository for this revision to rL LLVM. Herald added a subscriber: mcrosier. This option behaves in a similar spirit as -save-temps and writes out llvm statistics i

[libcxx] r282134 - Fix failure on 03 bot

Author: marshall Date: Wed Sep 21 22:25:22 2016 New Revision: 282134 URL: http://llvm.org/viewvc/llvm-project?rev=282134&view=rev Log: Fix failure on 03 bot Modified: libcxx/trunk/test/std/utilities/memory/allocator.uses/allocator.uses.trait/uses_allocator.pass.cpp Modified: libcxx/trunk/t

  1   2   >