NewProggie created this revision.
NewProggie added a subscriber: cfe-commits.

After applying `clang-rename` to a vim buffer (using `clang-rename.py` as part 
of the vim integration) the buffer gets reloaded using `bufdo`. This solution 
is suboptimal, since syntax highlighting is turned off for performance reasons 
and never turned on, after all changes to the source file have been applied. 

A better solution to this is using `checktime`. It is exactly designed for this 
kind of task and doesn't have the syntax highlighting issue.

https://reviews.llvm.org/D24791

Files:
  clang-rename/tool/clang-rename.py

Index: clang-rename/tool/clang-rename.py
===================================================================
--- clang-rename/tool/clang-rename.py
+++ clang-rename/tool/clang-rename.py
@@ -54,7 +54,7 @@
         print stderr
 
     # Reload all buffers in Vim.
-    vim.command("bufdo edit")
+    vim.command("checktime")
 
 
 if __name__ == '__main__':


Index: clang-rename/tool/clang-rename.py
===================================================================
--- clang-rename/tool/clang-rename.py
+++ clang-rename/tool/clang-rename.py
@@ -54,7 +54,7 @@
         print stderr
 
     # Reload all buffers in Vim.
-    vim.command("bufdo edit")
+    vim.command("checktime")
 
 
 if __name__ == '__main__':
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to