On 21 Sep 2016 6:10 am, "Aaron Ballman" <aaron.ball...@gmail.com> wrote:
aaron.ballman added a comment. The other thing this patch is missing are tests, btw. ================ Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ + // assignment operator is intended to have a side-effect and other overloaded + // operators are not. Otherwise fall through the logic of call expression. + OverloadedOperatorKind Op = cast<CXXOperatorCallExpr>( this)->getOperator(); ---------------- I think that `operator++()` and `operator--()` should be handled as well as the assignment operators. @rsmith, thoughts? I agree; if we're going to assume that overloaded operators are intended to mutate the object in the cases where the builtin form does, that should apply to all such operators -- assignment, compound assignment, increment and decrement. https://reviews.llvm.org/D22910
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
