Author: nikola
Date: Tue Sep 13 02:02:02 2016
New Revision: 281298
URL: http://llvm.org/viewvc/llvm-project?rev=281298&view=rev
Log:
Allow register variables in naked functions.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/Sema/attr-naked.c
Modified: cfe/trunk/lib/Sema/SemaDe
nikola closed this revision.
nikola added a comment.
r281298
https://reviews.llvm.org/D24193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In https://reviews.llvm.org/D24005#540200, @mgorny wrote:
> And done.
I think @beanz meant to actually do the renames for consistency... Sorry for
the confusion!
https://reviews.llvm.org/D24005
___
cfe-commits mailing l
Hahnfeld added a comment.
@zlei will you commit the patch or do you want me to do that on your behalf?
https://reviews.llvm.org/D24069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 71116.
ioeric marked 13 inline comments as done.
ioeric added a comment.
Herald added a subscriber: mgorny.
- Addressed review comments.
- Separate getAffectedFiles into its own interface.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-too
ioeric added inline comments.
Comment at: migrate-tool/HeaderBuild.h:29
@@ +28,3 @@
+
+ std::string generateContent() const;
+
klimek wrote:
> This all needs more comments :)
> I assume we'll also need to somehow give this a "style" at some point? Or
> alternati
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:35
@@ +34,3 @@
+ hasName("size"), returns(isInteger()),
+
mgorny added a comment.
In https://reviews.llvm.org/D24005#540803, @Hahnfeld wrote:
> In https://reviews.llvm.org/D24005#540200, @mgorny wrote:
>
> > And done.
>
>
> I think @beanz meant to actually do the renames for consistency... Sorry for
> the confusion!
I know but I feel like it's a topi
omtcyfz updated this revision to Diff 71119.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Combine two `returns` matchers.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
docs/clang-tidy/checks/readability-container-size-empty.r
Author: omtcyfz
Date: Tue Sep 13 03:58:11 2016
New Revision: 281307
URL: http://llvm.org/viewvc/llvm-project?rev=281307&view=rev
Log:
[clang-tidy] Extend readability-container-size-empty to arbitrary class with
size() and empty()
This patch extends readability-container-size-empty check allowing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281307: [clang-tidy] Extend readability-container-size-empty
to arbitrary class with… (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24349?vs=71119&id=71120#toc
Repository:
ioeric updated this revision to Diff 71126.
ioeric marked 13 inline comments as done.
ioeric added a comment.
Herald added a subscriber: mgorny.
- Minor cleanup.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamespace.cpp
ch
Author: asiri
Date: Tue Sep 13 04:32:32 2016
New Revision: 281310
URL: http://llvm.org/viewvc/llvm-project?rev=281310&view=rev
Log:
[libcxx] Fix gcc builds.
Step around a gcc pre-processor defect which causes it to fail to
parse the __has_include macro check.
Modified:
libcxx/trunk/include/_
omtcyfz updated this revision to Diff 71130.
omtcyfz added a comment.
Remove redundant arguments passed to diagnostic.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/
Author: omtcyfz
Date: Tue Sep 13 05:19:13 2016
New Revision: 281313
URL: http://llvm.org/viewvc/llvm-project?rev=281313&view=rev
Log:
[clang-tidy] Fix naming in container-size-empty.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
Modified:
clang-tools-e
ioeric added a comment.
In https://reviews.llvm.org/D24383#540296, @djasper wrote:
> The problem is that it is implicit behavior, that's not easy to understand.
> What's worse is that the behavior of add and merge would fundamentally be
> reverse. If you add two inserts at the same location, th
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:359
@@ +358,3 @@
+ End, tok::semi, *Result.SourceManager, Result.Context->getLangOpts(),
+ /*SkipTrailingWhitespaceAndNewLine=*/true);
+ if (AfterSemi.isValid())
The indenta
Author: vvassilev
Date: Tue Sep 13 05:36:12 2016
New Revision: 281315
URL: http://llvm.org/viewvc/llvm-project?rev=281315&view=rev
Log:
Simplify. NFC.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cp
Author: vvassilev
Date: Tue Sep 13 05:38:26 2016
New Revision: 281316
URL: http://llvm.org/viewvc/llvm-project?rev=281316&view=rev
Log:
Revert accidentally checked in change in r281315.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:359
@@ +358,3 @@
+ End, tok::semi, *Result.SourceManager, Result.Context->getLangOpts(),
+ /*SkipTrailingWhitespaceAndNewLine=*/true);
+ if (AfterSemi.isValid())
omtcyfz wrot
malcolm.parsons created this revision.
malcolm.parsons added reviewers: sbenza, aaron.ballman, alexfh.
malcolm.parsons added subscribers: Eugene.Zelenko, cfe-commits, beanz.
This check did not create FixItHints when the statement before the redundant
control flow was not followed by a semicolon.
rizsotto.mailinglist accepted this revision.
rizsotto.mailinglist added a comment.
This revision is now accepted and ready to land.
thanks Devin, i like smaller code, have no problem with this change. :)
about the file/directory paths: i agree that the situation is not ideal. but
there are/were
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D24501
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
===
djasper added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:147
@@ +146,3 @@
+ // Trailing comma in braces is not removed.
+ std::string Code = "void f() { std::vector v = {1,2,,,3,{4,5,}}; }";
+ std::string Expected = "void f() { std::vector v = {1,2,3,{4,5,}};
alexshap added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D23901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 71158.
ioeric marked an inline comment as done.
ioeric added a comment.
- Refactored cleanup unittest; added more test cases for trailing commas.
https://reviews.llvm.org/D24501
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unitte
ioeric added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:147
@@ +146,3 @@
+ // Trailing comma in braces is not removed.
+ std::string Code = "void f() { std::vector v = {1,2,,,3,{4,5,}}; }";
+ std::string Expected = "void f() { std::vector v = {1,2,3,{4,5,}};
urusant created this revision.
urusant added reviewers: zaks.anna, dcoughlin, jordan_rose, NoQ.
urusant added subscribers: cfe-commits, daviddrysdale.
urusant set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz.
Hi,
I am interested in feedback on a patch I was
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D24508
Files:
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateI
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Some remarks, but looks good.
Comment at: unittests/Format/CleanupTest.cpp:38
@@ +37,3 @@
+ // Returns code after cleanup around \p Offsets.
+ std::string cleanupAroundOff
ioeric updated this revision to Diff 71174.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Minor cleanup.
https://reviews.llvm.org/D24501
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
ioeric added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:125
@@ -123,7 +124,3 @@
std::string Expected = "class A {\nA() {} };";
- std::vector Ranges;
- Ranges.push_back(tooling::Range(17, 0));
- Ranges.push_back(tooling::Range(19, 0));
- std::string Resul
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281344: Remove redundant comma around parenthesis in
parameter list. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24501?vs=71174&id=71175#toc
Repository:
rL LLVM
https://
Author: ioeric
Date: Tue Sep 13 10:02:43 2016
New Revision: 281344
URL: http://llvm.org/viewvc/llvm-project?rev=281344&view=rev
Log:
Remove redundant comma around parenthesis in parameter list.
Reviewers: djasper
Subscribers: cfe-commits, klimek
Differential Revision: https://reviews.llvm.org/D
Author: nico
Date: Tue Sep 13 10:05:04 2016
New Revision: 281345
URL: http://llvm.org/viewvc/llvm-project?rev=281345&view=rev
Log:
Traversing template paramter lists of DeclaratorDecls and/or TagDecls.
The unit tests in this patch demonstrate the need to traverse template
parameter lists of Decla
thakis added a subscriber: thakis.
thakis added a comment.
landed in r281345.
https://reviews.llvm.org/D24268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D23901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
vbyakovlcl removed rL LLVM as the repository for this revision.
vbyakovlcl changed the visibility of this Differential Revision from "All
Users" to "Public (No Login Required)".
vbyakovlcl updated this revision to Diff 71135.
https://reviews.llvm.org/D24467
Files:
llvm/tools/clang/lib/Sema/Sem
Author: rengolin
Date: Tue Sep 13 10:40:36 2016
New Revision: 281346
URL: http://llvm.org/viewvc/llvm-project?rev=281346&view=rev
Log:
[3.9.1] Merge r279871 - [ARM] Adding .arch directives around WMMX unwind code
Modified:
libunwind/branches/release_39/src/UnwindRegistersRestore.S
libunwi
srhines added a comment.
My comment is mostly naming considerations to improve clarity. I do have
concerns though about the unhandled else path.
Comment at: lib/Sema/SemaChecking.cpp:3842
@@ -3841,2 +3841,3 @@
-static void CheckFormatString(Sema &S, const StringLiteral *FExpr
thakis marked 2 inline comments as done.
thakis added a comment.
In https://reviews.llvm.org/D24469#540400, @majnemer wrote:
> Does __uuidof walk bases to find [uuid] in cl.exe? They walk bases for the
> __declspec spelling.
As far as I can tell, they don't for either:
C:\src\chrome\src>type
compnerd added inline comments.
Comment at: test/Analysis/array-struct.c:147
@@ +146,3 @@
+ bar(((gets3().a)));
+}
+
Perhaps Im missing something, but theres no change to actually verify the
output?
Repository:
rL LLVM
https://reviews.llvm.org/D24484
_
thakis updated this revision to Diff 71181.
thakis added a comment.
comments
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDecl
falho marked 5 inline comments as done.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23
@@ +21,4 @@
+ Finder->addMatcher(
+ declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")),
+ parameterCountIs(0)))
alexshap added inline comments.
Comment at: test/Analysis/array-struct.c:147
@@ +146,3 @@
+ bar(((gets3().a)));
+}
+
compnerd wrote:
> Perhaps Im missing something, but theres no change to actually verify the
> output?
without the changes the analyzer is crash
yaxunl created this revision.
yaxunl added reviewers: tstellarAMD, nhaustov, arsenm.
yaxunl added subscribers: cfe-commits, AMDGPU.
Herald added a subscriber: wdng.
Fix target options for fp32/64-denormals so that
+fp64-denormals is set if fp64 is supported
-fp32-denormals if fp32 denormals i
kzhuravl created this revision.
kzhuravl added reviewers: arsenm, aaron.ballman.
kzhuravl added subscribers: yaxunl, kanarayan, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: nhaehnle, wdng.
__attribute__((amdgpu_flat_work_group_size(, ))) - request minimum
and maxim
mprobst updated this revision to Diff 71189.
mprobst added a comment.
- update commit msg
- make test case a bit more generic
https://reviews.llvm.org/D24477
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Generally looks good.
Comment at: unittests/Format/FormatTestJS.cpp:1433
@@ +1432,3 @@
+TEST_F(FormatTestJS, ImportComments) {
+ verifyFormat("import {x} from 'x'; // from
Author: mren
Date: Tue Sep 13 11:45:29 2016
New Revision: 281351
URL: http://llvm.org/viewvc/llvm-project?rev=281351&view=rev
Log:
Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.
Now ObjCObjectType extends from ObjCProtocolQualifiers. We save number of
protocols in ObjCPro
mprobst marked an inline comment as done.
mprobst added a comment.
https://reviews.llvm.org/D24477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
Once small comment otherwise. LGTM.
Comment at: lib/Basic/Targets.cpp:1962
@@ -1961,3 +1961,3 @@
bool hasLDEXPF:1;
- bool hasDenormSupport:1;
+ bool hasFP32Deno
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:1962
@@ -1961,3 +1961,3 @@
bool hasLDEXPF:1;
- bool hasDenormSupport:1;
+ bool hasFP32DenormSupport:1;
tstellarAMD wrote:
> I think this name is a little confusing, because the hardware does su
beanz added a comment.
You cannot rename the variables that start with `LLVM_*`, but the variables
without the leading `LLVM` can be renamed to whatever makes sense, or left
as-is. I'm fine with either way.
The variables starting with `LLVM_*` are effectively public interface to the
build syst
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Extend `tooling::Replacements::add()` to support adding order-independent
replacements.
Two replacements are considered order-independent if one of th
Author: mren
Date: Tue Sep 13 12:03:12 2016
New Revision: 281353
URL: http://llvm.org/viewvc/llvm-project?rev=281353&view=rev
Log:
ObjectiveC: Refactor applyObjCProtocolQualifiers.
To construct the canonical type of ObjCTypeParamType, we need to apply
qualifiers on ObjCObjectPointerType. The upda
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281353: ObjectiveC: Refactor applyObjCProtocolQualifiers.
(authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D24059?vs=69766&id=71194#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: mren
Date: Tue Sep 13 12:25:08 2016
New Revision: 281355
URL: http://llvm.org/viewvc/llvm-project?rev=281355&view=rev
Log:
ObjectiveC generics: Add ObjCTypeParamType in the type system.
We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
representation of "T " where T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281355: ObjectiveC generics: Add ObjCTypeParamType in the
type system. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23079?vs=69764&id=71197#toc
Repository:
rL LLVM
https://
joerg added a subscriber: joerg.
joerg added a comment.
While I agree with the general sentiment, the check doesn't work at all. For
example, ARMv4 always has to use libcalls. It's not even true that libcalls are
slow, i.e. on true non-parallel architectures, the libcall can be as simple as
a r
joerg added a comment.
More precisely, this should re-use the logic from __atomic_is_lock_free and not
reinvent it.
https://reviews.llvm.org/D24448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
meikeb updated this revision to Diff 71199.
meikeb marked 7 inline comments as done.
meikeb added a comment.
Fix typos and add assert to sum up offset helper.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
=
On Mon, Sep 12, 2016 at 11:50:36PM -, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Mon Sep 12 18:50:35 2016
> New Revision: 281277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281277&view=rev
> Log:
> [Sema] Fix PR30346: relax __builtin_object_size checks.
>
> This pat
meikeb added a comment.
I explained why I chose the names that you commented on. Feel free to add your
thoughts if you still think another name would be more fitting.
Comment at: lib/Sema/SemaChecking.cpp:3842
@@ -3841,2 +3841,3 @@
-static void CheckFormatString(Sema &S, cons
Author: yaxunl
Date: Tue Sep 13 12:37:09 2016
New Revision: 281357
URL: http://llvm.org/viewvc/llvm-project?rev=281357&view=rev
Log:
AMDGPU: Fix target options fp32/64-denormals
Fix target options for fp32/64-denormals so that
+fp64-denormals is set if fp64 is supported
-fp32-denormals if fp32 d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281357: AMDGPU: Fix target options fp32/64-denormals
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D24512?vs=71183&id=71201#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: mren
Date: Tue Sep 13 12:41:05 2016
New Revision: 281358
URL: http://llvm.org/viewvc/llvm-project?rev=281358&view=rev
Log:
ObjectiveC Generics: Start using ObjCTypeParamType.
For ObjC type parameter, we used to have TypedefType that is canonicalized to
id or the bound type. We can't repre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281358: ObjectiveC Generics: Start using ObjCTypeParamType.
(authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23080?vs=69765&id=71205#toc
Repository:
rL LLVM
https://reviews.llv
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks!
Do you have commit access?
Repository:
rL LLVM
https://reviews.llvm.org/D24484
___
cfe-commits mailing list
cfe-commits@lists.l
alexshap added a comment.
Thx,
I do.
Repository:
rL LLVM
https://reviews.llvm.org/D24484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Currently, driver level warnings do not show option names (e.g. warning:
complain about foo [-Woption-name]) in a diagnostic unless
-fdiagnostics-show-option is explictly specified. OTOH, the driv
I hadn't thought Clang wanted to be *quite* so knowledgeable about targets, and
similarly not so tightly tied to byte-addressable targets. But if both of
those things are actually okay, then it's fine to set the alignment value here
to what would be passed through to DWARF.
--paulr
From: David
Saleem Abdulrasool via cfe-commits writes:
> Author: compnerd
> Date: Mon Sep 12 16:15:23 2016
> New Revision: 281261
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
> Log:
> CodeGen: use some range-based for loops
>
> Use range-based for loops to simplify the logic. Add an expli
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
LGTM!
Comment at: lib/Sema/SemaDeclAttr.cpp:4609
@@ +4608,3 @@
+ unsigned AttrSpellingListIndex, StringRef Uuid) {
+ if (const auto *
rnk added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
declaration
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Sorry, I lost track of this.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
agutowski added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
decla
Author: rsmith
Date: Tue Sep 13 13:35:34 2016
New Revision: 281363
URL: http://llvm.org/viewvc/llvm-project?rev=281363&view=rev
Log:
Work around a GCC 4.7-specific issue: due to implementing older rules for
implicit declarations of move operations, GCC 4.7 would find that SelectPiece
has neither a
loladiro added a comment.
Small bump here. Is it possible to rewrite these without std::forward, so we
can have the const-initialization behavior on C++11 (or is there are different
solution?).
Repository:
rL LLVM
https://reviews.llvm.org/D24372
__
agutowski updated this revision to Diff 71212.
agutowski added a comment.
Add test for implicitly declared intel intrinsic diagnostic in C++
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Bas
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm after merging the test back.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring libra
agutowski updated this revision to Diff 71213.
agutowski added a comment.
Merge C and C++ tests
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
brtaylor92 created this revision.
brtaylor92 added reviewers: alexfh, craig.topper.
brtaylor92 added a subscriber: cfe-commits.
Assert text for getSingleDecl() is inaccurate. Appears to have been copy pasted
from getDeclGroup()
https://reviews.llvm.org/D24518
Files:
include/clang/AST/DeclGrou
Author: nico
Date: Tue Sep 13 13:55:26 2016
New Revision: 281367
URL: http://llvm.org/viewvc/llvm-project?rev=281367&view=rev
Log:
[clang-cl] Diagnose duplicate uuids.
This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the
thakis closed this revision.
thakis added a comment.
r281367, thanks!
https://reviews.llvm.org/D24469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: alexshap
Date: Tue Sep 13 14:17:20 2016
New Revision: 281373
URL: http://llvm.org/viewvc/llvm-project?rev=281373&view=rev
Log:
[analyzer] Fix ExprEngine::VisitMemberExpr
AST may contain intermediate ParenExpr nodes
between MemberExpr and ArrayToPointerDecay.
This diff adjusts the check in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281373: [analyzer] Fix ExprEngine::VisitMemberExpr (authored
by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D24484?vs=71082&id=71218#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: agutowski
Date: Tue Sep 13 14:26:42 2016
New Revision: 281375
URL: http://llvm.org/viewvc/llvm-project?rev=281375&view=rev
Log:
Add some MS aliases for existing intrinsics
Reviewers: thakis, compnerd, majnemer, rsmith, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281375: Add some MS aliases for existing intrinsics
(authored by agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24330?vs=71213&id=71220#toc
Repository:
rL LLVM
https://reviews.llvm.o
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3691
@@ -3635,1 +3690,3 @@
+ if (D->hasAttr())
+AlignInBits = D->getMaxAlignment();
StringRef DeclName, LinkageName;
probinson wrote:
> dblaikie wrote:
> > is max alignment the right t
On Tue, Sep 13, 2016 at 10:44 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Sep 12, 2016 at 11:50:36PM -, George Burgess IV via
> cfe-commits wrote:
> > Author: gbiv
> > Date: Mon Sep 12 18:50:35 2016
> > New Revision: 281277
> >
> > URL: http://llvm.org
Author: agutowski
Date: Tue Sep 13 14:43:33 2016
New Revision: 281378
URL: http://llvm.org/viewvc/llvm-project?rev=281378&view=rev
Log:
Add bunch of _Interlocked builtins
Reviewers: compnerd, thakis, Prazek, majnemer, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281378: Add bunch of _Interlocked builtins (authored by
agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24153?vs=70572&id=71223#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24153
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:608
@@ -608,2 +607,3 @@
uint64_t Size = CGM.getContext().getTypeSize(Ty);
+ uint64_t Align = 0;
rnk wrote:
> IMO this is what we should be doing everywhere, rather than manually checking
I think it's better to pass amount in bytes here, as specified by user
(alignas takes bytes, not bits).
On 09/13/2016 09:00 PM, Robinson, Paul wrote:
I hadn't thought Clang wanted to be *quite* so knowledgeable about
targets, and similarly not so tightly tied to byte-addressable
targets. But
Author: rsmith
Date: Tue Sep 13 15:00:02 2016
New Revision: 281382
URL: http://llvm.org/viewvc/llvm-project?rev=281382&view=rev
Log:
Work around MSVC 2013's inability to default move special members.
Modified:
cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
Modified: cfe/trunk/utils/Tab
Author: bruno
Date: Tue Sep 13 15:04:35 2016
New Revision: 281383
URL: http://llvm.org/viewvc/llvm-project?rev=281383&view=rev
Log:
[SemaObjC] Be more strict while parsing type arguments and protocols
Fix a crash-on-invalid.
When parsing type arguments and protocols,
parseObjCTypeArgsOrProtocolQ
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r281383
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexshap
Date: Tue Sep 13 15:17:57 2016
New Revision: 281385
URL: http://llvm.org/viewvc/llvm-project?rev=281385&view=rev
Log:
Remove excessive padding from PTHWriter
The class PTHWriter is in lib/Frontend/CacheTokens.cpp
inside the anonymous namespace.
This diff changes the order of fie
1 - 100 of 152 matches
Mail list logo
