rizsotto.mailinglist accepted this revision.
rizsotto.mailinglist added a comment.
This revision is now accepted and ready to land.

thanks Devin, i like smaller code, have no problem with this change. :)

about the file/directory paths: i agree that the situation is not ideal. but 
there are/were strict constrains on how a compilation database shall look like. 
once a year i ask the question 
<http://lists.llvm.org/pipermail/cfe-dev/2016-February/047181.html> on the 
mailing list about it. the situation might have been improved since... besides, 
using absolute path is actually the safest bet we can make. (other tools doing 
the same (CMake is a good example)) would not invest time into this until i see 
it got broken.


https://reviews.llvm.org/D24470



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to