djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land.
Generally looks good. ================ Comment at: unittests/Format/FormatTestJS.cpp:1433 @@ +1432,3 @@ +TEST_F(FormatTestJS, ImportComments) { + verifyFormat("import {x} from 'x'; // from //x:x", getGoogleJSStyleWithColumns(25)); + verifyFormat("// taze: x from 'location'", getGoogleJSStyleWithColumns(10)); ---------------- Maybe here, too? I don't think many people are familiar with bazel target syntax ;). https://reviews.llvm.org/D24477 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits