r279419 - Test commit (Removing trailing whitespace).

Author: eladcohen Date: Mon Aug 22 02:34:21 2016 New Revision: 279419 URL: http://llvm.org/viewvc/llvm-project?rev=279419&view=rev Log: Test commit (Removing trailing whitespace). Modified: cfe/trunk/include/clang/Driver/Driver.h Modified: cfe/trunk/include/clang/Driver/Driver.h URL: http:/

[PATCH] D23765: Fix for clang PR 29087

twoh created this revision. twoh added a reviewer: rsmith. twoh added a subscriber: cfe-commits. Since rL274049, for an inheriting constructor declaration, the name of the using declaration (and using shadow declaration comes from the using declaration) is the name of a derived class, not the ba

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68833. v.g.vassilev added a comment. Adapt to the new APIs. Now it builds. https://reviews.llvm.org/D23400 Files: lib/Sema/SemaExceptionSpec.cpp test/Modules/Inputs/PR28423/Allocator

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev updated this revision to Diff 68834. v.g.vassilev added a comment. Add the right diff. https://reviews.llvm.org/D23400 Files: include/clang/Analysis/DefUse.h lib/Analysis/CMakeLists.txt lib/Analysis/DefUse.cpp Index: lib/Analysis/DefUse.cpp ==

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. The reason one has to precompute ScopeLevel is because IndentLevel is not actually meaningful on each token. It's only meaningful for the first token on the line (the remaining tokens on the line have IndentLevel = 0). So if you look at the implementation of calculateS

r279425 - [analyzer] Correctly add assumptions based on array bounds.

Author: xazax Date: Mon Aug 22 05:07:32 2016 New Revision: 279425 URL: http://llvm.org/viewvc/llvm-project?rev=279425&view=rev Log: [analyzer] Correctly add assumptions based on array bounds. Also simplify the constraints generated by the checker. Differential Revision: https://reviews.llvm.org

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279425: [analyzer] Correctly add assumptions based on array bounds. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23112?vs=68023&id=68840#toc Repository: rL LLVM https://re

Re: [PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

mprobst updated this revision to Diff 68844. mprobst added a comment. - drop accidentally included template string patch from this diff. https://reviews.llvm.org/D23761 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp =

Re: [PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

mprobst marked an inline comment as done. Comment at: lib/Format/FormatTokenLexer.cpp:245 @@ -241,1 +244,3 @@ ++Offset; // Skip the escaped character. +if (Offset + 1 < Lex->getBuffer().end() && *Offset == '$' && +*(Offset + 1) == '{') { ygao wr

r279427 - Reapply "[analyzer] Added valist related checkers."

Author: xazax Date: Mon Aug 22 06:21:30 2016 New Revision: 279427 URL: http://llvm.org/viewvc/llvm-project?rev=279427&view=rev Log: Reapply "[analyzer] Added valist related checkers." Differential Revision: https://reviews.llvm.org/D15227 Added: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistCh

Re: [PATCH] D15227: [analyzer] Valist checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279427: Reapply "[analyzer] Added valist related checkers." (authored by xazax). Repository: rL LLVM https://reviews.llvm.org/D15227 Files: cfe/trunk/include/clang/StaticAnalyzer/Checkers/Checkers.t

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. removing the MSC_VER check will not be enough, the feature guards from the intrinsic and the builtin need to be removed to make it work. not sure if this is the right way to go, any thoughts on this? Repository: rL LLVM https://reviews.llvm.org/D21959 __

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Ping (x2). https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun added a comment. In https://reviews.llvm.org/D15227#521781, @NoQ wrote: > In https://reviews.llvm.org/D15227#519239, @xazax.hun wrote: > > > I suspect that slightly different AST is generated for those architectures > > that cause the different behavior. I will further investigate thos

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst updated this revision to Diff 68851. mprobst added a comment. - Test escaped dollar sign. https://reviews.llvm.org/D22431 Files: lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:259 @@ -241,1 +258,3 @@ ++Offset; // Skip the escaped character. +if (Offset + 1 < Lex->getBuffer().end() && Offset[0] == '$' && +Offset[1] == '{') { Question by @ygao in

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst updated this revision to Diff 68853. mprobst added a comment. - Fix escaping issue. https://reviews.llvm.org/D22431 Files: lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/Forma

[PATCH] D23767: DebugInfo: use llvm::di_flags_t for debug info flags

vleschuk created this revision. vleschuk added reviewers: echristo, aprantl. vleschuk added subscribers: llvm-commits, cfe-commits. Herald added a subscriber: mehdi_amini. Use llvm::di_flags_t type for debug flags instead of unsigned int to avoid problems on platforms with sizeof(int) < 4: we alr

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D23492: Make function local tags visible.

akuegel added a subscriber: akuegel. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. -

Re: [PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Please add a "before" and "after" to the patch description before submitting. Otherwise looks good. https://reviews.llvm.org/D23761 ___ cfe-co

r279436 - clang-format: [JS] supports casts to types starting with punctuation ("{[(").

Author: mprobst Date: Mon Aug 22 09:23:30 2016 New Revision: 279436 URL: http://llvm.org/viewvc/llvm-project?rev=279436&view=rev Log: clang-format: [JS] supports casts to types starting with punctuation ("{[("). Before: x as{x: number} After: x as {x: number} Reviewers: djasper Subsc

Re: [PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rL279436: clang-format: [JS] supports casts to types starting with punctuation ("{[("). (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D

Re: [PATCH] D23279: clang-reorder-fields

bcraig added a comment. I will note that I'm only really looking at the tests, mostly from the perspective of a potential user. Thanks for getting C++ initializer lists in. The tests in general look fine. The omission of cross visibility reordering is fine as an initial step. Once multi-TU s

Re: [PATCH] D23279: clang-reorder-fields

On Mon, Aug 22, 2016 at 10:34 AM, Ben Craig wrote: > bcraig added a comment. > > I will note that I'm only really looking at the tests, mostly from the > perspective of a potential user. > > Thanks for getting C++ initializer lists in. > > The tests in general look fine. The omission of cross vi

Re: [PATCH] D23279: clang-reorder-fields

compnerd added inline comments. Comment at: test/clang-reorder-fields/ClassMixedInitialization.cpp:1-3 @@ +1,4 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-reorder-fields -record-name Foo -fields-order e,x,pi,v,s %t.cpp -i -- -std=c++11 +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

mclow.lists added inline comments. Comment at: include/__external_threading:26 @@ +25,3 @@ + +#if !defined(_LIBCPP_MUTEX_T) || \ +!defined(_LIBCPP_MUTEX_INITIALIZER) || \ bcraig wrote: > So users of external pthreading (or their compiler driver) would need to

Re: [PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

NoQ added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:243 @@ +242,3 @@ +/// clone groups from the given hash group. +virtual bool acceptsHashGroup(const CloneGroup &HashGroup); + I might be wishing a lot, but i've a feeling

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

djasper added a comment. I think the IndentLevel in WhitespaceManager (and the nested Change) is a horrible mess and should be cleaned up. It gets set either to 0 or to the "Level" of the AnnotatedLine. To me only the latter makes sense as the line defines the indent level. Everything else, inc

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath added inline comments. Comment at: include/__external_threading:26 @@ +25,3 @@ + +#if !defined(_LIBCPP_MUTEX_T) || \ +!defined(_LIBCPP_MUTEX_INITIALIZER) || \ mclow.lists wrote: > bcraig wrote: > > So users of external pthreading (or their compiler dr

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Thanks for the comments. @bcraig, multi-TU support is in - in the sense that it's in at the same level, as it's in for clang-rename and the other tools (take a look my comments above, please). Also: @omtcyf0: > Well, multi-TU support is needed for many tools and it is

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. --

Re: r278483 - This patch implements PR#22821.

I don't see any approval after Aaron's "Please wait until someone has had the chance to review before committing" on https://reviews.llvm.org/D20561 -- was this reviewed on IRC? On Fri, Aug 12, 2016 at 4:04 AM, Roger Ferrer Ibanez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rog

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath added a comment. Comments from @mclow.lists on the latest revision (received offline): - Need instructions on how to build and test the patch... - Need to be able to build+test on Mac (looks like there is a small problem in the patch w.r.t pthreads that makes the build fail on Mac) - Ne

Re: [PATCH] D23492: Make function local tags visible.

akuegel added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. ---

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh added a comment. Please rebase your patch, I've made some changes to some of these files. Comment at: docs/clang-tidy/checks/misc-misplaced-widening-cast.rst:39 @@ -34,3 +38,3 @@ Forgetting to place the cast at all is at least as dangerous and at least as -common as misp

[clang-tools-extra] r279442 - [clang-tidy docs] Further cleanup of options

Author: alexfh Date: Mon Aug 22 12:19:23 2016 New Revision: 279442 URL: http://llvm.org/viewvc/llvm-project?rev=279442&view=rev Log: [clang-tidy docs] Further cleanup of options Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.rst clang-tool

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh accepted this revision. alexfh added a comment. LG. Thank you! https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r278984 - Add test missed from r278983.

Hi Richard, This test has been failing since it was committed. http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2277/ > On Aug 17, 2016, at 2:42 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Wed Aug 17 16:42:10 2016 > New Revision: 278984 > > URL: htt

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. --

r279444 - Remove redundant test

Author: dblaikie Date: Mon Aug 22 12:49:50 2016 New Revision: 279444 URL: http://llvm.org/viewvc/llvm-project?rev=279444&view=rev Log: Remove redundant test test/CodeGenCXX/debug-info-zero-length-arrays.cpp tests this functionality more comprehensively Removed: cfe/trunk/test/CodeGenCXX/debu

r279445 - PR29086: DebugInfo: Improve support for fixed array dimensions in variable length arrays

Author: dblaikie Date: Mon Aug 22 12:49:56 2016 New Revision: 279445 URL: http://llvm.org/viewvc/llvm-project?rev=279445&view=rev Log: PR29086: DebugInfo: Improve support for fixed array dimensions in variable length arrays Added: cfe/trunk/test/CodeGenCXX/debug-info-vla.cpp Modified: cf

[PATCH] D23780: [analyzer] Fixed crash in StmtDataCollector when analyzing methods of template classes.

teemperor created this revision. teemperor added reviewers: v.g.vassilev, NoQ. teemperor added a subscriber: cfe-commits. The current check with `isTemplateInstantiation()` is also returning true when calling a member method of a template class. In this case getTemplateSpecializationArgs() retur

Re: [PATCH] D23719: [libc++] Use C11 for atomics check

smeenai abandoned this revision. smeenai added a comment. Will create a different change with the other config change, since it's completely different conceptually. https://reviews.llvm.org/D23719 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D22766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

dblaikie added a comment. Not all of these already had NodeRef implemented - that implies that some algorithms weren't using NodeRef before this change, or that these traits are unused? I thought the plan was to migrate each algorithm then just do a strict cleanup. Did that not pan out/some oth

[libcxx] r279453 - Add missing include that caused a test failure on Windows. Thanks to STL for the patch. No functional change.

Author: marshall Date: Mon Aug 22 13:45:31 2016 New Revision: 279453 URL: http://llvm.org/viewvc/llvm-project?rev=279453&view=rev Log: Add missing include that caused a test failure on Windows. Thanks to STL for the patch. No functional change. Modified: libcxx/trunk/test/std/containers/ass

Re: [PATCH] D23685: [libcxx] [test] Include the iterator header for back_inserter.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as revision 279453 https://reviews.llvm.org/D23685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r279455 - [CUDA] Collapsed offload actions should not be top-level jobs.

Author: tra Date: Mon Aug 22 13:50:34 2016 New Revision: 279455 URL: http://llvm.org/viewvc/llvm-project?rev=279455&view=rev Log: [CUDA] Collapsed offload actions should not be top-level jobs. If they are, we end up with the last intermediary output preserved in the current directory after compil

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279455: [CUDA] Collapsed offload actions should not be top-level jobs. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D23526?vs=68100&id=68896#toc Repository: rL LLVM https://r

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

mclow.lists added a comment. Eric - did you want to see a benchmark as part of this commit? https://reviews.llvm.org/D22834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279457 - ADT: Remove uses of ilist_*sentinel_traits, NFC

Author: dexonsmith Date: Mon Aug 22 13:57:44 2016 New Revision: 279457 URL: http://llvm.org/viewvc/llvm-project?rev=279457&view=rev Log: ADT: Remove uses of ilist_*sentinel_traits, NFC Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h Modified: cfe/trunk/include

r279463 - AMDGPU: Handle structs directly in AMDGPUABIInfo

Author: arsenm Date: Mon Aug 22 14:25:59 2016 New Revision: 279463 URL: http://llvm.org/viewvc/llvm-project?rev=279463&view=rev Log: AMDGPU: Handle structs directly in AMDGPUABIInfo Structs are currently handled as pointer + byval, which makes AMDGPU LLVM backend generate incorrect code when stru

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm closed this revision. arsenm added a comment. r279463 https://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

EricWF added a comment. No benchmark needed but one would be appreciated if possible. https://reviews.llvm.org/D22834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

timshen added a comment. In https://reviews.llvm.org/D23730#522396, @dblaikie wrote: > Not all of these already had NodeRef implemented - that implies that some > algorithms weren't using NodeRef before this change, or that these traits are > unused? I thought the plan was to migrate each algor

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

timshen added inline comments. Comment at: llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h:684-688 @@ -684,7 +683,7 @@ typedef SUnitIterator ChildIteratorType; -static inline NodeType *getEntryNode(SUnit *N) { return N; } -static inline ChildIteratorType child_begin(Nod

Re: [PATCH] D23279: clang-reorder-fields

djasper added a subscriber: djasper. djasper added a comment. Sorry for the long silence. Manuel is currently out on vacation. I am not entirely sure how we want to make progress at this point. There seems to be consensus that in the mid-term, this should go into the clang-refactor tool. Howeve

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > My only high-level comment so far (will try to review in more detail later) > is: I find it strange to mix ASTMatchers and a >RecursiveASTVisitor in the > same tool. It seem that if you are using ASTMatchers internally for other > things, you should also >use ASTMatc

Re: [PATCH] D23279: clang-reorder-fields

bcraig added a comment. In https://reviews.llvm.org/D23279#522504, @djasper wrote: > In the meantime, I don't know whether we should check this in as a > standalone-tool and then merge into clang-refactor once ready. Ben, what do > you think? Well, I don't know how much you should count my op

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

hiraditya added a comment. In https://reviews.llvm.org/D22834#522499, @EricWF wrote: > No benchmark needed but one would be appreciated if possible. I guess @laxmansole sent you a synthetic benchmark because we were having trouble integrating it to the libcxx testsuite. I can send you that aga

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

dblaikie added a comment. In https://reviews.llvm.org/D23730#522501, @timshen wrote: > In https://reviews.llvm.org/D23730#522396, @dblaikie wrote: > > > Not all of these already had NodeRef implemented - that implies that some > > algorithms weren't using NodeRef before this change, or that thes

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Or it isn't approved (was mixing up reviews) - but now it is... https://reviews.llvm.org/D23730 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko updated this revision to Diff 68908. Eugene.Zelenko added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-

libclang: binary/unary operator spelling

Hello, this is my first patch proposal so please for give me if i made some mistakes. This patch changes the result of clang_getCursorSpelling in the way that it returns the operator for CXCursor_BinaryOperator/CXCursor_UnaryOperator instead of an empty string. So e.g. for a + b it returns:

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

timshen added a comment. In https://reviews.llvm.org/D23730#522537, @dblaikie wrote: > I'd sort of be inclined to remove them, then - but I leave that up to you. It looks like people create some class, and add GraphTraits specialization for it, in the hope that others can use it, but didn't wr

[PATCH] D23783: [Sema][Comments] Support @param with c++ 'using' keyword

bruno created this revision. bruno added a reviewer: rsmith. bruno added a subscriber: cfe-commits. Give appropriate warnings with -Wdocumentation for @param comments that refer to function aliases defined with 'using'. Very similar to typedef's behavior. Support for TypeAliasTemplateDecl comes ne

r279475 - [GraphTraits] Replace all NodeType usage with NodeRef

Author: timshen Date: Mon Aug 22 16:09:30 2016 New Revision: 279475 URL: http://llvm.org/viewvc/llvm-project?rev=279475&view=rev Log: [GraphTraits] Replace all NodeType usage with NodeRef This should finish the GraphTraits migration. Differential Revision: http://reviews.llvm.org/D23730 Modifie

Re: [PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL279475: [GraphTraits] Replace all NodeType usage with NodeRef (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D23730?vs=68748&id=68912#toc Repository: rL LLVM https://review

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. Ben: I am happy to have this as a separate tool until then. But if we go that route, let's add very explicit comments about this so that people don't start depending on it and we can actually remove it as easily as possible. Alex: I don't think there will be a significa

[PATCH] D23784: Remove trailing WS [NFC]

hiraditya created this revision. hiraditya added reviewers: mclow.lists, EricWF. hiraditya added a subscriber: cfe-commits. https://reviews.llvm.org/D23784 Files: libcxx/include/algorithm Index: libcxx/include/algorithm === --- li

r279479 - [AST] Remove unused function, to silence a GCC7 warning.

Author: davide Date: Mon Aug 22 16:33:12 2016 New Revision: 279479 URL: http://llvm.org/viewvc/llvm-project?rev=279479&view=rev Log: [AST] Remove unused function, to silence a GCC7 warning. Modified: cfe/trunk/lib/AST/StmtProfile.cpp Modified: cfe/trunk/lib/AST/StmtProfile.cpp URL: http://l

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: test/clang-reorder-fields/CStructAmbiguousName.cpp:6 @@ +5,3 @@ +struct Foo { + int x;// CHECK: int x; + double y; // CHECK: double y; djasper wrote: > Have you thought about how to handle comments that surround th

r279481 - [SemaObjC] Do not RebuildObjCMessageExpr without valid method decl

Author: bruno Date: Mon Aug 22 16:50:22 2016 New Revision: 279481 URL: http://llvm.org/viewvc/llvm-project?rev=279481&view=rev Log: [SemaObjC] Do not RebuildObjCMessageExpr without valid method decl Fix crash-on-invalid in ObjC Sema by avoiding to rebuild a message expression to a 'super' class i

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @djasper - regarding the visitor - thank you, i understand ur concerns - i will add a version which uses a matcher (will update this diff). Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing lis

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For ou

r279485 - Module debug info: Don't assert when encountering an incomplete definition

Author: adrian Date: Mon Aug 22 17:23:58 2016 New Revision: 279485 URL: http://llvm.org/viewvc/llvm-project?rev=279485&view=rev Log: Module debug info: Don't assert when encountering an incomplete definition in isDefinedInClangModule() and assume that the incomplete definition is not defined in th

r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Author: rsmith Date: Mon Aug 22 17:25:03 2016 New Revision: 279486 URL: http://llvm.org/viewvc/llvm-project?rev=279486&view=rev Log: Fix regression introduced by r279164: only pass definitions as the PatternDef to DiagnoseUninstantiableTemplate, teach hasVisibleDefinition to correctly determine wh

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > > wrote: >> >> On Mon, Apr 25, 2016 at 1:52 PM, A

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko updated this revision to Diff 68921. Eugene.Zelenko added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For out-of-bounds checking of static -arrays, see the clang-diagnostic-array-bounds check. +ar

Re: [PATCH] D23492: Make function local tags visible.

rsmith added a comment. Should be fixed in r279486, which also incorporates the updates to this change since it landed (sinking diagnostics into `DiagnoseUninstantiableTemplate`). Comment at: lib/Sema/SemaTemplate.cpp:494-495 @@ +493,4 @@ +// Say nothing + } + else if (Fu

r279489 - Add the second half of the testcase I should have added in 279485.

Author: adrian Date: Mon Aug 22 17:30:34 2016 New Revision: 279489 URL: http://llvm.org/viewvc/llvm-project?rev=279489&view=rev Log: Add the second half of the testcase I should have added in 279485. Added: cfe/trunk/test/Modules/ModuleModuleDebugInfo.cpp Added: cfe/trunk/test/Modules/Module

r279491 - Typo.

Author: adrian Date: Mon Aug 22 17:38:18 2016 New Revision: 279491 URL: http://llvm.org/viewvc/llvm-project?rev=279491&view=rev Log: Typo. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

r279490 - Add comments. NFC

Author: adrian Date: Mon Aug 22 17:38:16 2016 New Revision: 279490 URL: http://llvm.org/viewvc/llvm-project?rev=279490&view=rev Log: Add comments. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For out-of-bounds checking of static -arrays, see the clang-diagnostic-array-bounds check. +arrays, se

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther updated this revision to Diff 68930. ksuther added a comment. This was accepted a few months ago but it got buried and was never committed. The diff has been updated so that it can be committed cleanly. https://reviews.llvm.org/D15643 Files: lib/Format/TokenAnnotator.cpp Index: lib/

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko updated this revision to Diff 68933. Eugene.Zelenko added a comment. Address review comment. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-i

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: test/SemaCXX/constant-expression-cxx11.cpp:2091 @@ +2090,3 @@ + }; + static_assert(X::f() == c + d,""); +} I would use `'c' + 'd'`

[PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh created this revision. alexfh added a reviewer: gribozavr. alexfh added a subscriber: cfe-commits. Cargo-culted from clang docs builder. Should work, but I haven't tried. https://reviews.llvm.org/D23787 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocs

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 68939. alexshap added a comment. 1. Get rid of the visitor. 2. Get rid of the dependency on libc++ in tests (ran and checked the tests under the minimal checkout: llvm + clang + extra tools) Repository: rL LLVM https://reviews.llvm.org/D23279 Files:

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh added a comment. In https://reviews.llvm.org/D23728#522710, @Eugene.Zelenko wrote: > Address review comment. Thanks! Still LG. Repository: rL LLVM https://reviews.llvm.org/D23728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang-tools-extra] r279494 - Fix style in some Clang-tidy checks documentation.

Author: eugenezelenko Date: Mon Aug 22 19:19:43 2016 New Revision: 279494 URL: http://llvm.org/viewvc/llvm-project?rev=279494&view=rev Log: Fix style in some Clang-tidy checks documentation. Differential revision: https://reviews.llvm.org/D23728 Modified: clang-tools-extra/trunk/docs/clang-

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL279494: Fix style in some Clang-tidy checks documentation. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23728?vs=68933&id=68941#toc Repository: rL LLVM https://rev

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

compnerd added a subscriber: compnerd. Comment at: include/clang/Driver/Options.td:1380 @@ +1379,3 @@ +def mlong_calls : Flag<["-"], "mlong-calls">, Group, + HelpText<"ARM: Generate an indirect jump to enable jumps further than 64M, Hexagon: Generate constant-extended branches."

Re: [PATCH] D23279: clang-reorder-fields

alexshap removed rL LLVM as the repository for this revision. alexshap changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". alexshap updated this revision to Diff 68943. alexshap added a comment. Fix typo https://reviews.llvm.org/D23279 Files:

Re: [PATCH] D23279: clang-reorder-fields

aaron.ballman added a comment. None of your tests will run on Windows, which makes me worried if that's intended to be a supported target. https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @aaron.ballman Thanks, yeah, there is an issue. Also there are inline-comments by @bcraig and @compnerd about the tests. I used clang-rename, include-fixer, clang-tidy as examples. alexshap-mbp:extra alexshap$ grep -r -n "sed -e " ./* | head -n 5 ./test/clang-tidy/mode

Re: [PATCH] D23279: clang-reorder-fields

aaron.ballman added a comment. In https://reviews.llvm.org/D23279#522779, @alexshap wrote: > @aaron.ballman > Thanks, yeah, there is an issue. Also there are inline-comments by @bcraig > and @compnerd about the tests. > I used clang-rename, include-fixer, clang-tidy as examples. Correct, but

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. I think quite a bit of the complexity in this patch stems from the two different ways to format the input (defining the field order or alternatively defining the new index of specific fields). Do we really need both? If not, I'd remove one of them for now (likely the in

  1   2   >