dblaikie added a comment. In https://reviews.llvm.org/D23730#522501, @timshen wrote:
> In https://reviews.llvm.org/D23730#522396, @dblaikie wrote: > > > Not all of these already had NodeRef implemented - that implies that some > > algorithms weren't using NodeRef before this change, or that these traits > > are unused? I thought the plan was to migrate each algorithm then just do a > > strict cleanup. Did that not pan out/some other aspects I'm forgetting? > > > I think those traits are unused. Notice that by merely removing "NodeType *" > declarations, the build/tests doesn't break, so at least they are not covered > by the tests. I'd sort of be inclined to remove them, then - but I leave that up to you. Otherwise this review is already approved, so commit as you see fit. https://reviews.llvm.org/D23730 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
